76637 2012-01-19 08:13:04 -0800 Update FloatRect::uniteIfNonZero to use isZero() 2012-01-23 14:38:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pdr webkit-unassigned ap darin leviw webkit.review.bot oldest_to_newest 538719 0 pdr 2012-01-19 08:13:04 -0800 We should update uniteIfNonZero() to use isZero() instead of a !width() && !height(). See: https://bugs.webkit.org/show_bug.cgi?id=76177#c3 538724 1 123133 pdr 2012-01-19 08:15:47 -0800 Created attachment 123133 Update uniteIfNonZero to use isZero 538735 2 123135 pdr 2012-01-19 08:36:07 -0800 Created attachment 123135 Update uniteIfNonZero to use isZero A note on why I added no tests: I did a little research on what this change will affect and I came up empty handed. I instrumented the code and ran all our tests and visited various popular/complex pages, neither of which registered a difference between the old behavior and the new. The primary use of uniteIfNonZero in regular code is in RenderInline.cpp which, as far as I can tell in my testing, only passes integer values through to this method and should not be affected by this change. I still think this is change will be clearly useful in preventing future bugs. 538906 3 123135 ap 2012-01-19 12:09:01 -0800 Comment on attachment 123135 Update uniteIfNonZero to use isZero View in context: https://bugs.webkit.org/attachment.cgi?id=123135&action=review > Source/WebCore/ChangeLog:15 > + * rendering/svg/SVGRenderSupport.cpp: > + (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): It would be helpful to explain this change in ChangeLog. Readers needn't spend effort trying to figure out how it's related to bug title when it's not! 538918 4 123171 pdr 2012-01-19 12:22:01 -0800 Created attachment 123171 Update uniteIfNonZero to use isZero Adding a comment in the ChangeLog so that readers are not confused by the unrelated change in SVGRenderSupport.cpp. 540655 5 123171 darin 2012-01-23 10:43:48 -0800 Comment on attachment 123171 Update uniteIfNonZero to use isZero OK 540847 6 123171 webkit.review.bot 2012-01-23 14:38:09 -0800 Comment on attachment 123171 Update uniteIfNonZero to use isZero Clearing flags on attachment: 123171 Committed r105643: <http://trac.webkit.org/changeset/105643> 540849 7 webkit.review.bot 2012-01-23 14:38:13 -0800 All reviewed patches have been landed. Closing bug. 123133 2012-01-19 08:15:47 -0800 2012-01-19 08:36:07 -0800 Update uniteIfNonZero to use isZero 76637.1.patch text/plain 1930 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTQxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTE5ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIHVuaXRlSWZOb25aZXJv IHRvIHVzZSBpc1plcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc2NjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9GbG9hdFJlY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRSZWN0Ojp1bml0ZUlmTm9u WmVybyk6CisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9TVkdSZW5kZXJTdXBwb3J0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVDb250YWluZXJCb3VuZGlu Z0JveGVzKToKKwogMjAxMi0wMS0xOCAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290 dGVAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gSGFuZGxlIHRoZSBsYXllcnMgdmlzaWJsZSBy ZWN0IGNhbGN1bGF0aW9uIG9uIHRoZSB3ZWIgcHJvY2Vzcy4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcAkocmV2aXNpb24gMTA1Mjc4KQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTE5LDkgKzExOSw5IEBAIHZvaWQgRmxvYXRSZWN0Ojp1bml0ZUV2ZW5JZkVt cHR5KGNvbnN0IEYKIHZvaWQgRmxvYXRSZWN0Ojp1bml0ZUlmTm9uWmVybyhjb25zdCBGbG9hdFJl Y3QmIG90aGVyKQogewogICAgIC8vIEhhbmRsZSBlbXB0eSBzcGVjaWFsIGNhc2VzIGZpcnN0Lgot ICAgIGlmICghb3RoZXIud2lkdGgoKSAmJiAhb3RoZXIuaGVpZ2h0KCkpCisgICAgaWYgKG90aGVy LmlzWmVybygpKQogICAgICAgICByZXR1cm47Ci0gICAgaWYgKCF3aWR0aCgpICYmICFoZWlnaHQo KSkgeworICAgIGlmIChpc1plcm8oKSkgewogICAgICAgICAqdGhpcyA9IG90aGVyOwogICAgICAg ICByZXR1cm47CiAgICAgfQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdS ZW5kZXJTdXBwb3J0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3ZnL1NWR1JlbmRlclN1cHBvcnQuY3BwCShyZXZpc2lvbiAxMDUyNzgpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3ZnL1NWR1JlbmRlclN1cHBvcnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTAsOCArMTkwLDcgQEAgdm9pZCBTVkdSZW5kZXJTdXBwb3J0Ojpjb21wdXRlQ29udGFpbmVy QgogICAgICAgICAgICAgcmVwYWludEJvdW5kaW5nQm94LnVuaXRlKHRyYW5zZm9ybS5tYXBSZWN0 KGN1cnJlbnQtPnJlcGFpbnRSZWN0SW5Mb2NhbENvb3JkaW5hdGVzKCkpKTsKICAgICAgICAgfQog Ci0gICAgICAgIGlmIChpc0ZpcnN0Q2hpbGQpCi0gICAgICAgICAgICBpc0ZpcnN0Q2hpbGQgPSBm YWxzZTsKKyAgICAgICAgaXNGaXJzdENoaWxkID0gZmFsc2U7CiAgICAgfQogfQogCg== 123135 2012-01-19 08:36:07 -0800 2012-01-19 12:22:01 -0800 Update uniteIfNonZero to use isZero 76637.2.patch text/plain 2078 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTQxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE5ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIHVuaXRlSWZOb25aZXJv IHRvIHVzZSBpc1plcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc2NjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiAoSSBmb3VuZCBubyBleGlzdGluZyBjb2RlcGF0aCB0aGF0IHdv dWxkIGJlIGFmZmVjdGVkIGJ5CisgICAgICAgIHRoaXMgY2hhbmdlIGJ1dCBJIHRoaW5rIHRoaXMg Y2hhbmdlIGlzIHN0aWxsIHZhbHVhYmxlIGluIHByZXZlbnRpbmcKKyAgICAgICAgZnV0dXJlIGJ1 Z3MuKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkZsb2F0UmVjdDo6dW5pdGVJZk5vblplcm8pOgorICAgICAgICAqIHJlbmRl cmluZy9zdmcvU1ZHUmVuZGVyU3VwcG9ydC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdSZW5k ZXJTdXBwb3J0Ojpjb21wdXRlQ29udGFpbmVyQm91bmRpbmdCb3hlcyk6CisKIDIwMTItMDEtMTgg IEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAg ICBbUXRdIEhhbmRsZSB0aGUgbGF5ZXJzIHZpc2libGUgcmVjdCBjYWxjdWxhdGlvbiBvbiB0aGUg d2ViIHByb2Nlc3MuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9h dFJlY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0Zsb2F0UmVjdC5jcHAJKHJldmlzaW9uIDEwNTI3OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOSw5ICsxMTks OSBAQCB2b2lkIEZsb2F0UmVjdDo6dW5pdGVFdmVuSWZFbXB0eShjb25zdCBGCiB2b2lkIEZsb2F0 UmVjdDo6dW5pdGVJZk5vblplcm8oY29uc3QgRmxvYXRSZWN0JiBvdGhlcikKIHsKICAgICAvLyBI YW5kbGUgZW1wdHkgc3BlY2lhbCBjYXNlcyBmaXJzdC4KLSAgICBpZiAoIW90aGVyLndpZHRoKCkg JiYgIW90aGVyLmhlaWdodCgpKQorICAgIGlmIChvdGhlci5pc1plcm8oKSkKICAgICAgICAgcmV0 dXJuOwotICAgIGlmICghd2lkdGgoKSAmJiAhaGVpZ2h0KCkpIHsKKyAgICBpZiAoaXNaZXJvKCkp IHsKICAgICAgICAgKnRoaXMgPSBvdGhlcjsKICAgICAgICAgcmV0dXJuOwogICAgIH0KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUmVuZGVyU3VwcG9ydC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdSZW5kZXJTdXBwb3J0LmNw cAkocmV2aXNpb24gMTA1Mjc4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdS ZW5kZXJTdXBwb3J0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTkwLDggKzE5MCw3IEBAIHZvaWQg U1ZHUmVuZGVyU3VwcG9ydDo6Y29tcHV0ZUNvbnRhaW5lckIKICAgICAgICAgICAgIHJlcGFpbnRC b3VuZGluZ0JveC51bml0ZSh0cmFuc2Zvcm0ubWFwUmVjdChjdXJyZW50LT5yZXBhaW50UmVjdElu TG9jYWxDb29yZGluYXRlcygpKSk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoaXNGaXJzdENo aWxkKQotICAgICAgICAgICAgaXNGaXJzdENoaWxkID0gZmFsc2U7CisgICAgICAgIGlzRmlyc3RD aGlsZCA9IGZhbHNlOwogICAgIH0KIH0KIAo= 123171 2012-01-19 12:22:01 -0800 2012-01-23 14:38:08 -0800 Update uniteIfNonZero to use isZero 76637.3.patch text/plain 2208 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTQzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAxLTE5ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIHVuaXRlSWZOb25aZXJv IHRvIHVzZSBpc1plcm8uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NjYzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gKEkgZm91bmQgbm8gZXhpc3RpbmcgY29kZXBhdGggdGhhdCB3 b3VsZCBiZSBhZmZlY3RlZCBieQorICAgICAgICB0aGlzIGNoYW5nZSBidXQgSSB0aGluayB0aGlz IGNoYW5nZSBpcyBzdGlsbCB2YWx1YWJsZSBpbiBwcmV2ZW50aW5nCisgICAgICAgIGZ1dHVyZSBi dWdzLikKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGbG9hdFJlY3Q6OnVuaXRlSWZOb25aZXJvKToKKworICAgICAgICBUaGUg Zm9sbG93aW5nIGNoYW5nZSBpcyBhIG1pbm9yIGZvbGxvd3VwIHRvCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjE3NyNjMTIgYW5kIGlzIG5vdCBkaXJl Y3RseQorICAgICAgICByZWxhdGVkIHRvIHRoZSByZXN0IG9mIHRoaXMgcGF0Y2guCisgICAgICAg ICogcmVuZGVyaW5nL3N2Zy9TVkdSZW5kZXJTdXBwb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVDb250YWluZXJCb3VuZGluZ0JveGVzKToKKwogMjAx Mi0wMS0xOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtl IFdlYkF1ZGlvIEFQSSBjb25zdC1jb3JyZWN0LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuY3BwCShyZXZpc2lvbiAxMDU0MjIpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMTksOSArMTE5LDkgQEAgdm9pZCBGbG9hdFJlY3Q6OnVuaXRlRXZlbklmRW1wdHkoY29u c3QgRgogdm9pZCBGbG9hdFJlY3Q6OnVuaXRlSWZOb25aZXJvKGNvbnN0IEZsb2F0UmVjdCYgb3Ro ZXIpCiB7CiAgICAgLy8gSGFuZGxlIGVtcHR5IHNwZWNpYWwgY2FzZXMgZmlyc3QuCi0gICAgaWYg KCFvdGhlci53aWR0aCgpICYmICFvdGhlci5oZWlnaHQoKSkKKyAgICBpZiAob3RoZXIuaXNaZXJv KCkpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoIXdpZHRoKCkgJiYgIWhlaWdodCgpKSB7Cisg ICAgaWYgKGlzWmVybygpKSB7CiAgICAgICAgICp0aGlzID0gb3RoZXI7CiAgICAgICAgIHJldHVy bjsKICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1JlbmRlclN1 cHBvcnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZH UmVuZGVyU3VwcG9ydC5jcHAJKHJldmlzaW9uIDEwNTQyMikKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdmcvU1ZHUmVuZGVyU3VwcG9ydC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MCw4 ICsxOTAsNyBAQCB2b2lkIFNWR1JlbmRlclN1cHBvcnQ6OmNvbXB1dGVDb250YWluZXJCCiAgICAg ICAgICAgICByZXBhaW50Qm91bmRpbmdCb3gudW5pdGUodHJhbnNmb3JtLm1hcFJlY3QoY3VycmVu dC0+cmVwYWludFJlY3RJbkxvY2FsQ29vcmRpbmF0ZXMoKSkpOwogICAgICAgICB9CiAKLSAgICAg ICAgaWYgKGlzRmlyc3RDaGlsZCkKLSAgICAgICAgICAgIGlzRmlyc3RDaGlsZCA9IGZhbHNlOwor ICAgICAgICBpc0ZpcnN0Q2hpbGQgPSBmYWxzZTsKICAgICB9CiB9CiAK