76630 2012-01-19 07:07:56 -0800 REGRESSION(r100558): NRWT should work without SVN or GIT 2012-06-19 07:20:00 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 72247 1 ossy dpranke abarth alex.bravo dpranke eric lauro.neto ojan ossy webkit.review.bot zarvai oldest_to_newest 538681 0 ossy 2012-01-19 07:07:56 -0800 After http://trac.webkit.org/changeset/100558 NRWT exits before testing if the WebKit isn't is SVN or GIT SCM: For more parallelism, run new-run-webkit-tests directly. Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 426, in <module> sys.exit(main()) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 419, in main host._initialize_scm() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/host.py", line 112, in _initialize_scm self._scm = detector.default_scm(patch_directories) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 60, in default_scm raise Exception("FATAL: Failed to determine the SCM system for either %s or %s" % (cwd, script_directory)) Exception: FATAL: Failed to determine the SCM system for either /home/oszi/WebKit or /home/oszi/WebKit/Tools/Scripts/webkitpy/common/checkout/scm It would be great if we can run NRWT again without copying ~5Gb sized repository for an embedded system. I don't think if NRWT should depends on SCM. 538688 1 123124 ossy 2012-01-19 07:18:26 -0800 Created attachment 123124 workaround It is only a workaround (partial revert of r100558) to make NRWT work without GIT or SVN SCM. Feel free to use it until a proper fix. 538759 2 eric 2012-01-19 09:24:54 -0800 No. I don't think we should support this. 538760 3 eric 2012-01-19 09:25:28 -0800 I think not having a checkout just makes things more complicated. I don't think there is a lot of need to support running the tests w/o a full development environment. 538769 4 ossy 2012-01-19 09:42:57 -0800 I really don't understand why should NRWT depends on SCM if it doesn't use it for running tests ... Copying ~5Gb sized full repository to an embedded system is _impossible_. We really need WebKit lib, DumpRenderTree, Tools/Scripts/webkitpy, LayoutTests/platform/my-favourite-platform and LayoutTests directory without other platform results for testing. It is maximum 2-300Mb, which can be copied simple to a device. But now this crazy dependency is the only blocker. 641874 5 alex.bravo 2012-06-05 14:02:56 -0700 I just run across a problem that when only git is installed and svn is NOT installed. I get a crash like the one supplied below. It's pretty hard to find out from that crash that missing subversion is the problem. alex@alex8540:~/projects/webkit-desk$ python Tools/Scripts/new-run-webkit-tests Traceback (most recent call last): File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 452, in <module> sys.exit(main()) File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 444, in main host._initialize_scm() File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/common/host.py", line 112, in _initialize_scm self._scm = detector.default_scm(patch_directories) File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 53, in default_scm scm_system = self.detect_scm_system(cwd, patch_directories) File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/common/checkout/scm/detection.py", line 69, in detect_scm_system if SVN.in_working_directory(absolute_path): File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 93, in in_working_directory exit_code = Executive().run_command(svn_info_args, cwd=path, return_exit_code=True) File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/common/system/executive.py", line 397, in run_command close_fds=self._should_close_fds()) File "/home/alex/projects/webkit-desk/Tools/Scripts/webkitpy/common/system/executive.py", line 453, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.7/subprocess.py", line 679, in __init__ errread, errwrite) File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child raise child_exception 651923 6 148215 dpranke 2012-06-18 17:48:54 -0700 Created attachment 148215 Patch 651928 7 dpranke 2012-06-18 17:52:02 -0700 I've updated this patch (just merged to head and added a ChangeLog) and am landing it. NRWT is explicitly not supposed to be required to have a checkout, so I agree w/ Ossy here. Note that if we are in an SVN checkout and are configured to upload the build results we will extract the revision number if we can; that code is in json_results_generator, and it should deal with a lack-of-svn fine, though (it will probably raise an error if there is a .svn dir but you don't have an svn binary in your path, but that shouldn't happen in practice). 651936 8 dpranke 2012-06-18 17:58:25 -0700 Committed r120646: <http://trac.webkit.org/changeset/120646> 652424 9 rafael.lobo 2012-06-19 07:20:00 -0700 *** Bug 87020 has been marked as a duplicate of this bug. *** 123124 2012-01-19 07:18:26 -0800 2012-06-18 17:48:40 -0700 workaround 1.patch text/plain 1148 ossy ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfd29ya2VyX2Jyb2tlci5weQppbmRleCA4MmJh OTFmLi43YWY1MzNlIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3dvcmtlcl9icm9rZXIucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl93b3JrZXJfYnJv a2VyLnB5CkBAIC0yNjMsNyArMjYzLDYgQEAgaWYgbXVsdGlwcm9jZXNzaW5nOgogICAgICAgICAg ICAgICAgIGhvc3QgPSBNb2NrSG9zdCgpCiAgICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAg ICAgIGhvc3QgPSBIb3N0KCkKLSAgICAgICAgICAgIGhvc3QuX2luaXRpYWxpemVfc2NtKCkKIAog ICAgICAgICAgICAgb3B0aW9ucyA9IHNlbGYuX29wdGlvbnMKICAgICAgICAgICAgIHBvcnRfb2Jq ID0gaG9zdC5wb3J0X2ZhY3RvcnkuZ2V0KHNlbGYuX3BsYXRmb3JtX25hbWUsIG9wdGlvbnMpCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weQppbmRleCBiNjA2OGI2Li5mNWEwNDFmZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC00 MTYsNyArNDE2LDYgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKIGRlZiBtYWluKCk6CiAg ICAgb3B0aW9ucywgYXJncyA9IHBhcnNlX2FyZ3MoKQogICAgIGhvc3QgPSBIb3N0KCkKLSAgICBo b3N0Ll9pbml0aWFsaXplX3NjbSgpCiAgICAgcG9ydCA9IGhvc3QucG9ydF9mYWN0b3J5LmdldChv cHRpb25zLnBsYXRmb3JtLCBvcHRpb25zKQogICAgIHJldHVybiBydW4ocG9ydCwgb3B0aW9ucywg YXJncykKIAo= 148215 2012-06-18 17:48:54 -0700 2012-06-18 17:50:21 -0700 Patch bug-76630-20120618174853.patch text/plain 1492 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDRjZWQ3OTg1MGQ5ODAyNmE2Njg3OTFhY2VhNTNkYzQ4 MDIwZjA4ZC4uMjJlNTgxOWQ3MDYxNWFhM2RhN2UwYjJlOTVhMjMxNzIyM2RhNDE1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA2LTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMTAwNTU4KTogTlJXVCBzaG91bGQgd29yayB3aXRob3V0IFNW TiBvciBHSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2NjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBQcmFua2UuCisKKyAgICAgICAgTlJX VCBpcyBub3Qgc3VwcG9zZWQgdG8gaGF2ZSBhIHJlcXVpcmVtZW50IHRoYXQgd2UgaGF2ZSBhbgor ICAgICAgICBhY3R1YWwgU1ZOIG9yIEdpdCBjaGVja291dCwgYW5kIHdlIHdlcmUgdW5uZWNlc3Nh cmlseQorICAgICAgICBpbml0aWFsaXppbmcgdGhlIGNoZWNrb3V0LiBUaGlzIHBhdGNoIHJlbW92 ZXMgdGhhdCBsaW5lIDopLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKG1haW4pOgorCiAyMDEyLTA2LTE4ICBa YW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgUkVHUkVTU0lP TihyMTIwNTQ2KTogSXQgbWFkZSAzIHdlYmtpdHB5IHRlc3RzIGZhaWwKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5Cmlu ZGV4IDBlMjdhMmQ1ZGE0OTkzYTgxMDEyZTNhZjQ1M2U1YjFmYzI4YTkxM2MuLmYzNjNkODYxY2Vl YmFlNzQ3MTk4NTlmYTI3OGUzODBmNWVjYzhiNDkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtNDQwLDcg KzQ0MCw2IEBAIGRlZiBtYWluKCk6CiAgICAgICAgIGhvc3QgPSBNb2NrSG9zdCgpCiAgICAgZWxz ZToKICAgICAgICAgaG9zdCA9IEhvc3QoKQotICAgIGhvc3QuX2luaXRpYWxpemVfc2NtKCkKICAg ICBwb3J0ID0gaG9zdC5wb3J0X2ZhY3RvcnkuZ2V0KG9wdGlvbnMucGxhdGZvcm0sIG9wdGlvbnMp CiAgICAgbG9nZ2luZy5nZXRMb2dnZXIoKS5zZXRMZXZlbChsb2dnaW5nLkRFQlVHIGlmIG9wdGlv bnMudmVyYm9zZSBlbHNlIGxvZ2dpbmcuSU5GTykKICAgICByZXR1cm4gcnVuKHBvcnQsIG9wdGlv bnMsIGFyZ3MpCg==