76620 2012-01-19 04:05:55 -0800 [GTK] GTK's DRT not to log events for already defunct objects 2012-01-20 01:57:43 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 76531 1 mario webkit-unassigned pnormand oldest_to_newest 538608 0 mario 2012-01-19 04:05:55 -0800 If an AtkObject has emmitted the 'state-change::defunct' function it means it is not a valid object anymore, so we should not do anything about it, like trying to retrieve its name and role for loggint purposes, which is what printAccessibilityEvent() in Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp does. Filing this bug now since recent changes in the repository (r105253) unveiled that not controlling this situation could lead to DRT segfaulting in some tests (like platform/gtk/accessibility/combo-box-collapsed-selection-changed.html, which is skipped at the time of this writing). 538611 1 mario 2012-01-19 04:10:21 -0800 We can't fix bug 76531 until we fix this other one, as DRT will segfault otherwise. 538619 2 123104 mario 2012-01-19 04:36:37 -0800 Created attachment 123104 Patch proposal 538756 3 123104 mrobinson 2012-01-19 09:20:47 -0800 Comment on attachment 123104 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=123104&action=review > Tools/ChangeLog:8 > + Do not to log 'state-change:defunct' events. Do not to log -> Do not log 539355 4 mario 2012-01-20 01:57:43 -0800 Committed r105496: <http://trac.webkit.org/changeset/105496> 123104 2012-01-19 04:36:37 -0800 2012-01-19 09:20:46 -0800 Patch proposal 0001-GTK-GTK-s-DRT-not-to-log-events-for-already-defunct-.patch text/plain 5362 mario RnJvbSAzMWJkZGM3ZjU1NTZjN2E1NzczZGNhMzFhYjQ3NzBiMDlhM2NhN2JiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBXZWQsIDE4IEphbiAyMDEyIDIwOjAxOjEyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gW0dUS10gR1RLJ3MgRFJUIG5vdCB0byBsb2cgZXZlbnRzIGZvciBhbHJlYWR5IGRlZnVuY3QK IG9iamVjdHMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjIwCgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkRvIG5vdCB0byBsb2cgJ3N0YXRlLWNoYW5nZTpk ZWZ1bmN0JyBldmVudHMuCgoqIER1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5Q2FsbGJh Y2tzLmNwcDoKKHByaW50QWNjZXNzaWJpbGl0eUV2ZW50KTogRWFybHkgcmV0dXJuIGlmIGEKJ3N0 YXRlLWNoYW5nZTpkZWZ1bmN0JyBzaWduYWwgaXMgcGFzc2VkLgooYXhPYmplY3RFdmVudExpc3Rl bmVyKTogUGFzcyB0aGUgc2lnbmFsIG5hbWUgYW5kIHZhbHVlIGluCnNlcGFyYXRlIHBhcmFtZXRl cnMgdG8gcHJpbnRBY2Nlc3NpYmlsaXR5RXZlbnQuCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKwogLi4uL0R1bXBS ZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5Q2FsbGJhY2tzLmNwcCAgfCAgIDM0ICsrKysrKysr KysrLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDE1IGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCAzMjU4OTA5Li42YjE2NjQ4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDEtMTkgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEdUSydzIERS VCBub3QgdG8gbG9nIGV2ZW50cyBmb3IgYWxyZWFkeSBkZWZ1bmN0IG9iamVjdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NjIwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IHRvIGxvZyAnc3Rh dGUtY2hhbmdlOmRlZnVuY3QnIGV2ZW50cy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0 ay9BY2Nlc3NpYmlsaXR5Q2FsbGJhY2tzLmNwcDoKKyAgICAgICAgKHByaW50QWNjZXNzaWJpbGl0 eUV2ZW50KTogRWFybHkgcmV0dXJuIGlmIGEKKyAgICAgICAgJ3N0YXRlLWNoYW5nZTpkZWZ1bmN0 JyBzaWduYWwgaXMgcGFzc2VkLgorICAgICAgICAoYXhPYmplY3RFdmVudExpc3RlbmVyKTogUGFz cyB0aGUgc2lnbmFsIG5hbWUgYW5kIHZhbHVlIGluCisgICAgICAgIHNlcGFyYXRlIHBhcmFtZXRl cnMgdG8gcHJpbnRBY2Nlc3NpYmlsaXR5RXZlbnQuCisKIDIwMTItMDEtMTggIEJhbGF6cyBLZWxl bWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gQ29uc29saWRhdGUgbGF5 b3V0IHRlc3QgY3Jhc2ggbG9nZ2luZwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv Z3RrL0FjY2Vzc2liaWxpdHlDYWxsYmFja3MuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0FjY2Vzc2liaWxpdHlDYWxsYmFja3MuY3BwCmluZGV4IGY1MGIwMzMuLmEyNGQzNjcgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5Q2FsbGJhY2tzLmNw cAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eUNhbGxiYWNrcy5j cHAKQEAgLTQzLDIxICs0MywyNiBAQCBzdGF0aWMgZ3VpbnQgY2hpbGRyZW5DaGFuZ2VkTGlzdGVu ZXJJZCA9IDA7CiBzdGF0aWMgZ3VpbnQgcHJvcGVydHlDaGFuZ2VkTGlzdGVuZXJJZCA9IDA7CiBz dGF0aWMgZ3VpbnQgdmlzaWJsZURhdGFDaGFuZ2VkTGlzdGVuZXJJZCA9IDA7CiAKLXN0YXRpYyB2 b2lkIHByaW50QWNjZXNzaWJpbGl0eUV2ZW50KEF0a09iamVjdCogYWNjZXNzaWJsZSwgY29uc3Qg Z2NoYXIqIHNpZ25hbE5hbWUpCitzdGF0aWMgdm9pZCBwcmludEFjY2Vzc2liaWxpdHlFdmVudChB dGtPYmplY3QqIGFjY2Vzc2libGUsIGNvbnN0IGdjaGFyKiBzaWduYWxOYW1lLCBjb25zdCBnY2hh ciogc2lnbmFsVmFsdWUpCiB7Ci0gICAgLy8gU2FuaXR5IGNoZWNrLgotICAgIGlmICghYWNjZXNz aWJsZSB8fCAhQVRLX0lTX09CSkVDVChhY2Nlc3NpYmxlKSB8fCAhc2lnbmFsTmFtZSkKKyAgICAv LyBEbyBub3QgaGFuZGxlIHN0YXRlLWNoYW5nZTpkZWZ1bmN0IHNpZ25hbHMsIGFzIHRoZSBBdGtP YmplY3QKKyAgICAvLyBhc3NvY2lhdGVkIHRvIHRoZW0gd2lsbCBub3QgYmUgdmFsaWQgYXQgdGhp cyBwb2ludCBhbHJlYWR5LgorICAgIGlmICghc2lnbmFsTmFtZSB8fCAhZ19zdHJjbXAwKHNpZ25h bE5hbWUsICJzdGF0ZS1jaGFuZ2U6ZGVmdW5jdCIpKQorICAgICAgICByZXR1cm47CisKKyAgICBp ZiAoIWFjY2Vzc2libGUgfHwgIUFUS19JU19PQkpFQ1QoYWNjZXNzaWJsZSkpCiAgICAgICAgIHJl dHVybjsKIAogICAgIGNvbnN0IGdjaGFyKiBvYmplY3ROYW1lID0gYXRrX29iamVjdF9nZXRfbmFt ZShhY2Nlc3NpYmxlKTsKLSAgICBndWludCBvYmplY3RSb2xlID0gYXRrX29iamVjdF9nZXRfcm9s ZShhY2Nlc3NpYmxlKTsKKyAgICBBdGtSb2xlIG9iamVjdFJvbGUgPSBhdGtfb2JqZWN0X2dldF9y b2xlKGFjY2Vzc2libGUpOwogCiAgICAgLy8gVHJ5IHRvIGFsd2F5cyBwcm92aWRlIGEgbmFtZSB0 byBiZSBsb2dnZWQgZm9yIHRoZSBvYmplY3QuCiAgICAgaWYgKCFvYmplY3ROYW1lIHx8ICpvYmpl Y3ROYW1lID09ICdcMCcpCiAgICAgICAgIG9iamVjdE5hbWUgPSAiKE5vIG5hbWUpIjsKIAorICAg IEdPd25QdHI8Z2NoYXI+IHNpZ25hbE5hbWVBbmRWYWx1ZShzaWduYWxWYWx1ZSA/IGdfc3RyZHVw X3ByaW50ZigiJXMgPSAlcyIsIHNpZ25hbE5hbWUsIHNpZ25hbFZhbHVlKSA6IGdfc3RyZHVwKHNp Z25hbE5hbWUpKTsKICAgICBwcmludGYoIkFjY2Vzc2liaWxpdHkgb2JqZWN0IGVtaXR0ZWQgXCIl c1wiIC8gTmFtZTogXCIlc1wiIC8gUm9sZTogJWRcbiIsCi0gICAgICAgICAgIHNpZ25hbE5hbWUs IG9iamVjdE5hbWUsIG9iamVjdFJvbGUpOworICAgICAgICAgICBzaWduYWxOYW1lQW5kVmFsdWUu Z2V0KCksIG9iamVjdE5hbWUsIG9iamVjdFJvbGUpOwogfQogCiBzdGF0aWMgZ2Jvb2xlYW4gYXhP YmplY3RFdmVudExpc3RlbmVyKEdTaWduYWxJbnZvY2F0aW9uSGludCAqc2lnbmFsSGludCwKQEAg LTc1LDI2ICs4MCwyNSBAQCBzdGF0aWMgZ2Jvb2xlYW4gYXhPYmplY3RFdmVudExpc3RlbmVyKEdT aWduYWxJbnZvY2F0aW9uSGludCAqc2lnbmFsSGludCwKIAogICAgIEdTaWduYWxRdWVyeSBzaWdu YWxfcXVlcnk7CiAgICAgR093blB0cjxnY2hhcj4gc2lnbmFsTmFtZTsKKyAgICBHT3duUHRyPGdj aGFyPiBzaWduYWxWYWx1ZTsKIAogICAgIGdfc2lnbmFsX3F1ZXJ5KHNpZ25hbEhpbnQtPnNpZ25h bF9pZCwgJnNpZ25hbF9xdWVyeSk7CiAKICAgICBpZiAoIWdfc3RyY21wMChzaWduYWxfcXVlcnku c2lnbmFsX25hbWUsICJzdGF0ZS1jaGFuZ2UiKSkgewotICAgICAgICBzaWduYWxOYW1lLnNldChn X3N0cmR1cF9wcmludGYoInN0YXRlLWNoYW5nZTolcyA9ICVkIiwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGdfdmFsdWVfZ2V0X3N0cmluZygmcGFyYW1WYWx1ZXNbMV0p LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ192YWx1ZV9nZXRfYm9v bGVhbigmcGFyYW1WYWx1ZXNbMl0pKSk7CisgICAgICAgIHNpZ25hbE5hbWUuc2V0KGdfc3RyZHVw X3ByaW50Zigic3RhdGUtY2hhbmdlOiVzIiwgZ192YWx1ZV9nZXRfc3RyaW5nKCZwYXJhbVZhbHVl c1sxXSkpKTsKKyAgICAgICAgc2lnbmFsVmFsdWUuc2V0KGdfc3RyZHVwX3ByaW50ZigiJWQiLCBn X3ZhbHVlX2dldF9ib29sZWFuKCZwYXJhbVZhbHVlc1syXSkpKTsKICAgICB9IGVsc2UgaWYgKCFn X3N0cmNtcDAoc2lnbmFsX3F1ZXJ5LnNpZ25hbF9uYW1lLCAiZm9jdXMtZXZlbnQiKSkgewotICAg ICAgICBzaWduYWxOYW1lLnNldChnX3N0cmR1cF9wcmludGYoImZvY3VzLWV2ZW50ID0gJWQiLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ192YWx1ZV9nZXRfYm9vbGVh bigmcGFyYW1WYWx1ZXNbMV0pKSk7CisgICAgICAgIHNpZ25hbE5hbWUuc2V0KGdfc3RyZHVwKCJm b2N1cy1ldmVudCIpKTsKKyAgICAgICAgc2lnbmFsVmFsdWUuc2V0KGdfc3RyZHVwX3ByaW50Zigi JWQiLCBnX3ZhbHVlX2dldF9ib29sZWFuKCZwYXJhbVZhbHVlc1sxXSkpKTsKICAgICB9IGVsc2Ug aWYgKCFnX3N0cmNtcDAoc2lnbmFsX3F1ZXJ5LnNpZ25hbF9uYW1lLCAiY2hpbGRyZW4tY2hhbmdl ZCIpKSB7Ci0gICAgICAgIHNpZ25hbE5hbWUuc2V0KGdfc3RyZHVwX3ByaW50ZigiY2hpbGRyZW4t Y2hhbmdlZCA9ICVkIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdf dmFsdWVfZ2V0X3VpbnQoJnBhcmFtVmFsdWVzWzFdKSkpOworICAgICAgICBzaWduYWxOYW1lLnNl dChnX3N0cmR1cCgiY2hpbGRyZW4tY2hhbmdlZCIpKTsKKyAgICAgICAgc2lnbmFsVmFsdWUuc2V0 KGdfc3RyZHVwX3ByaW50ZigiJWQiLCBnX3ZhbHVlX2dldF91aW50KCZwYXJhbVZhbHVlc1sxXSkp KTsKICAgICB9IGVsc2UgaWYgKCFnX3N0cmNtcDAoc2lnbmFsX3F1ZXJ5LnNpZ25hbF9uYW1lLCAi cHJvcGVydHktY2hhbmdlIikpIHsKLSAgICAgICAgc2lnbmFsTmFtZS5zZXQoZ19zdHJkdXBfcHJp bnRmKCJwcm9wZXJ0eS1jaGFuZ2U6JXMiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZ19xdWFya190b19zdHJpbmcoc2lnbmFsSGludC0+ZGV0YWlsKSkpOworICAgICAg ICBzaWduYWxOYW1lLnNldChnX3N0cmR1cF9wcmludGYoInByb3BlcnR5LWNoYW5nZTolcyIsIGdf cXVhcmtfdG9fc3RyaW5nKHNpZ25hbEhpbnQtPmRldGFpbCkpKTsKICAgICB9IGVsc2UKICAgICAg ICAgc2lnbmFsTmFtZS5zZXQoZ19zdHJkdXAoc2lnbmFsX3F1ZXJ5LnNpZ25hbF9uYW1lKSk7CiAK LSAgICBwcmludEFjY2Vzc2liaWxpdHlFdmVudChhY2Nlc3NpYmxlLCBzaWduYWxOYW1lLmdldCgp KTsKKyAgICBwcmludEFjY2Vzc2liaWxpdHlFdmVudChhY2Nlc3NpYmxlLCBzaWduYWxOYW1lLmdl dCgpLCBzaWduYWxWYWx1ZS5nZXQoKSk7CiAKICAgICByZXR1cm4gVFJVRTsKIH0KLS0gCjEuNy43 LjUKCg==