76616 2012-01-19 03:14:34 -0800 [GTK] Add print-backgrounds setting to WebKit2 GTK+ API 2012-01-19 09:31:15 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 75544 1 cgarcia webkit-unassigned gustavo webkit.review.bot xan.lopez oldest_to_newest 538582 0 cgarcia 2012-01-19 03:14:34 -0800 To allow disabling print brackgrounds. 538584 1 123093 cgarcia 2012-01-19 03:16:51 -0800 Created attachment 123093 Patch 538585 2 webkit.review.bot 2012-01-19 03:20:05 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 538752 3 123093 mrobinson 2012-01-19 09:05:31 -0800 Comment on attachment 123093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123093&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:761 > + * Whether background images should be printed. Oh, you should probably be more explicit here that this happens only during printing runs. 538763 4 cgarcia 2012-01-19 09:31:15 -0800 Committed r105417: <http://trac.webkit.org/changeset/105417> 123093 2012-01-19 03:16:51 -0800 2012-01-19 09:05:31 -0800 Patch wk2-print-backgrounds.diff text/plain 7425 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5YzBmNWNmLi5hMGZiZTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFkZCBwcmludC1iYWNrZ3JvdW5kcyBzZXR0aW5nIHRvIFdlYktp dDIgR1RLKyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc2NjE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh3ZWJL aXRTZXR0aW5nc1NldFByb3BlcnR5KToKKyAgICAgICAgKHdlYktpdFNldHRpbmdzR2V0UHJvcGVy dHkpOgorICAgICAgICAod2Via2l0X3NldHRpbmdzX2NsYXNzX2luaXQpOgorICAgICAgICAod2Vi a2l0X3NldHRpbmdzX2dldF9wcmludF9iYWNrZ3JvdW5kcyk6CisgICAgICAgICh3ZWJraXRfc2V0 dGluZ3Nfc2V0X3ByaW50X2JhY2tncm91bmRzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRTZXR0aW5ncy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Vi a2l0Mmd0ay1zZWN0aW9ucy50eHQ6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMv VGVzdFdlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHRlc3RXZWJLaXRTZXR0aW5ncyk6CisK IDIwMTItMDEtMTcgIEhhamltZSBNb3JyaXRhICA8bW9ycml0YUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW0ludGVybmFsc10gU2hvdWxkIGJlIGFibGUgdG8gYWNjZXNzIGNvcnJlc3BvbmRpbmcg RG9jdW1lbnQgb2JqZWN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDJkODU4MWUuLmJjZjU0NDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKQEAg LTEwMCw3ICsxMDAsOCBAQCBlbnVtIHsKICAgICBQUk9QX0VOQUJMRV9UQUJTX1RPX0xJTktTLAog ICAgIFBST1BfRU5BQkxFX0ROU19QUkVGRVRDSElORywKICAgICBQUk9QX0VOQUJMRV9DQVJFVF9C Uk9XU0lORywKLSAgICBQUk9QX0VOQUJMRV9GVUxMU0NSRUVOCisgICAgUFJPUF9FTkFCTEVfRlVM TFNDUkVFTiwKKyAgICBQUk9QX1BSSU5UX0JBQ0tHUk9VTkRTCiB9OwogCiBzdGF0aWMgdm9pZCB3 ZWJLaXRTZXR0aW5nc1NldFByb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcElkLCBj b25zdCBHVmFsdWUqIHZhbHVlLCBHUGFyYW1TcGVjKiBwYXJhbVNwZWMpCkBAIC0xOTgsNiArMTk5 LDkgQEAgc3RhdGljIHZvaWQgd2ViS2l0U2V0dGluZ3NTZXRQcm9wZXJ0eShHT2JqZWN0KiBvYmpl Y3QsIGd1aW50IHByb3BJZCwgY29uc3QgR1ZhbHUKICAgICBjYXNlIFBST1BfRU5BQkxFX0ZVTExT Q1JFRU46CiAgICAgICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX2Z1bGxzY3JlZW4oc2V0 dGluZ3MsIGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpKTsKICAgICAgICAgYnJlYWs7CisgICAg Y2FzZSBQUk9QX1BSSU5UX0JBQ0tHUk9VTkRTOgorICAgICAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0 X3ByaW50X2JhY2tncm91bmRzKHNldHRpbmdzLCBnX3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKSk7 CisgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEdfT0JKRUNUX1dBUk5fSU5W QUxJRF9QUk9QRVJUWV9JRChvYmplY3QsIHByb3BJZCwgcGFyYW1TcGVjKTsKICAgICAgICAgYnJl YWs7CkBAIC0yOTksNiArMzAzLDkgQEAgc3RhdGljIHZvaWQgd2ViS2l0U2V0dGluZ3NHZXRQcm9w ZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BJZCwgR1ZhbHVlKiB2YWwKICAgICBjYXNl IFBST1BfRU5BQkxFX0ZVTExTQ1JFRU46CiAgICAgICAgIGdfdmFsdWVfc2V0X2Jvb2xlYW4odmFs dWUsIHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2Z1bGxzY3JlZW4oc2V0dGluZ3MpKTsKICAg ICAgICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX1BSSU5UX0JBQ0tHUk9VTkRTOgorICAgICAgICBn X3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCB3ZWJraXRfc2V0dGluZ3NfZ2V0X3ByaW50X2JhY2tn cm91bmRzKHNldHRpbmdzKSk7CisgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAg IEdfT0JKRUNUX1dBUk5fSU5WQUxJRF9QUk9QRVJUWV9JRChvYmplY3QsIHByb3BJZCwgcGFyYW1T cGVjKTsKICAgICAgICAgYnJlYWs7CkBAIC03NDgsNiArNzU1LDE5IEBAIHN0YXRpYyB2b2lkIHdl YmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFM U0UsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICByZWFkV3JpdGVDb25zdHJ1Y3RQYXJhbUZsYWdzKSk7CiAKKyAgICAvKioKKyAgICAgKiBX ZWJLaXRTZXR0aW5nczpwcmludC1iYWNrZ3JvdW5kczoKKyAgICAgKgorICAgICAqIFdoZXRoZXIg YmFja2dyb3VuZCBpbWFnZXMgc2hvdWxkIGJlIHByaW50ZWQuCisgICAgICovCisgICAgZ19vYmpl Y3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnT2JqZWN0Q2xhc3MsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBQUk9QX1BSSU5UX0JBQ0tHUk9VTkRTLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX2Jvb2xlYW4oInByaW50LWJhY2tn cm91bmRzIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIF8oIlByaW50IEJhY2tncm91bmRzIiksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJXaGV0aGVyIGJhY2tncm91bmQg aW1hZ2VzIHNob3VsZCBiZSBwcmludGVkIiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBUUlVFLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFy YW1GbGFncykpOworCiAgICAgZ190eXBlX2NsYXNzX2FkZF9wcml2YXRlKGtsYXNzLCBzaXplb2Yo V2ViS2l0U2V0dGluZ3NQcml2YXRlKSk7CiB9CiAKQEAgLTE4ODIsNyArMTkwMiw3IEBAIGdib29s ZWFuIHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2Z1bGxzY3JlZW4oV2ViS2l0U2V0dGluZ3Mq IHNldHRpbmdzKQogfQogCiAvKioKLSAqIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX2Z1bGxz Y3JlZW4KKyAqIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX2Z1bGxzY3JlZW46CiAgKiBAc2V0 dGluZ3M6IGEgI1dlYktpdFNldHRpbmdzCiAgKiBAZW5hYmxlZDogVmFsdWUgdG8gYmUgc2V0CiAg KgpAQCAtMTkwMCwzICsxOTIwLDM4IEBAIHZvaWQgd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVf ZnVsbHNjcmVlbihXZWJLaXRTZXR0aW5ncyogc2V0dGluZ3MsIGdib29sZWFuIGVuCiAgICAgV0tQ cmVmZXJlbmNlc1NldEZ1bGxTY3JlZW5FbmFibGVkKHByaXYtPnByZWZlcmVuY2VzLmdldCgpLCBl bmFibGVkKTsKICAgICBnX29iamVjdF9ub3RpZnkoR19PQkpFQ1Qoc2V0dGluZ3MpLCAiZW5hYmxl LWZ1bGxzY3JlZW4iKTsKIH0KKworLyoqCisgKiB3ZWJraXRfc2V0dGluZ3NfZ2V0X3ByaW50X2Jh Y2tncm91bmRzOgorICogQHNldHRpbmdzOiBhICNXZWJLaXRTZXR0aW5ncworICoKKyAqIEdldCB0 aGUgI1dlYktpdFNldHRpbmdzOnByaW50LWJhY2tncm91bmRzIHByb3BlcnR5LgorICoKKyAqIFJl dHVybnM6ICVUUlVFIElmIGJhY2tncm91bmQgaW1hZ2VzIHdob3VsZCBiZSBwcmludGVkIG9yICVG QUxTRSBvdGhlcndpc2UuCisgKi8KK2dib29sZWFuIHdlYmtpdF9zZXR0aW5nc19nZXRfcHJpbnRf YmFja2dyb3VuZHMoV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzKQoreworICAgIGdfcmV0dXJuX3Zh bF9pZl9mYWlsKFdFQktJVF9JU19TRVRUSU5HUyhzZXR0aW5ncyksIEZBTFNFKTsKKworICAgIHJl dHVybiBXS1ByZWZlcmVuY2VzR2V0U2hvdWxkUHJpbnRCYWNrZ3JvdW5kcyhzZXR0aW5ncy0+cHJp di0+cHJlZmVyZW5jZXMuZ2V0KCkpOworfQorCisvKioKKyAqIHdlYmtpdF9zZXR0aW5nc19zZXRf cHJpbnRfYmFja2dyb3VuZHM6CisgKiBAc2V0dGluZ3M6IGEgI1dlYktpdFNldHRpbmdzCisgKiBA cHJpbnRfYmFja2dyb3VuZHM6IFZhbHVlIHRvIGJlIHNldAorICoKKyAqIFNldCB0aGUgI1dlYktp dFNldHRpbmdzOnByaW50LWJhY2tncm91bmRzIHByb3BlcnR5LgorICovCit2b2lkIHdlYmtpdF9z ZXR0aW5nc19zZXRfcHJpbnRfYmFja2dyb3VuZHMoV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzLCBn Ym9vbGVhbiBwcmludEJhY2tncm91bmRzKQoreworICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lU X0lTX1NFVFRJTkdTKHNldHRpbmdzKSk7CisKKyAgICBXZWJLaXRTZXR0aW5nc1ByaXZhdGUqIHBy aXYgPSBzZXR0aW5ncy0+cHJpdjsKKyAgICBib29sIGN1cnJlbnRWYWx1ZSA9IFdLUHJlZmVyZW5j ZXNHZXRTaG91bGRQcmludEJhY2tncm91bmRzKHByaXYtPnByZWZlcmVuY2VzLmdldCgpKTsKKyAg ICBpZiAoY3VycmVudFZhbHVlID09IHByaW50QmFja2dyb3VuZHMpCisgICAgICAgIHJldHVybjsK KworICAgIFdLUHJlZmVyZW5jZXNTZXRTaG91bGRQcmludEJhY2tncm91bmRzKHByaXYtPnByZWZl cmVuY2VzLmdldCgpLCBwcmludEJhY2tncm91bmRzKTsKKyAgICBnX29iamVjdF9ub3RpZnkoR19P QkpFQ1Qoc2V0dGluZ3MpLCAicHJpbnQtYmFja2dyb3VuZHMiKTsKK30KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmggYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5oCmluZGV4IDhiMTlhNDYu LmE2NzY5ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFNldHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0U2V0dGluZ3MuaApAQCAtMjg2LDYgKzI4NiwxMyBAQCBXRUJLSVRfQVBJIHZvaWQKIHdlYmtp dF9zZXR0aW5nc19zZXRfZW5hYmxlX2Z1bGxzY3JlZW4gICAgICAgICAgICAgICAgICAgICAgICAg IChXZWJLaXRTZXR0aW5ncyAqc2V0dGluZ3MsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Jvb2xlYW4gICAgICAgIGVuYWJs ZWQpOwogCitXRUJLSVRfQVBJIGdib29sZWFuCit3ZWJraXRfc2V0dGluZ3NfZ2V0X3ByaW50X2Jh Y2tncm91bmRzICAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0U2V0dGluZ3MgKnNldHRp bmdzKTsKKworV0VCS0lUX0FQSSB2b2lkCit3ZWJraXRfc2V0dGluZ3Nfc2V0X3ByaW50X2JhY2tn cm91bmRzICAgICAgICAgICAgICAgICAgICAgICAgICAoV2ViS2l0U2V0dGluZ3MgKnNldHRpbmdz LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGdib29sZWFuICAgICAgICBwcmludF9iYWNrZ3JvdW5kcyk7CisKIEdfRU5EX0RF Q0xTCiAKICNlbmRpZiAvKiBXZWJLaXRTZXR0aW5nc19oICovCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0IGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvZG9jcy93ZWJraXQyZ3RrLXNlY3Rpb25z LnR4dAppbmRleCBjNzI3YTIzLi44NWQyODk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9kb2NzL3dlYmtpdDJndGstc2VjdGlvbnMudHh0CisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL2RvY3Mvd2Via2l0Mmd0ay1zZWN0aW9ucy50eHQK QEAgLTIwMiw2ICsyMDIsOCBAQCB3ZWJraXRfc2V0dGluZ3NfZ2V0X2VuYWJsZV9jYXJldF9icm93 c2luZwogd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfY2FyZXRfYnJvd3NpbmcKIHdlYmtpdF9z ZXR0aW5nc19nZXRfZW5hYmxlX2Z1bGxzY3JlZW4KIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxl X2Z1bGxzY3JlZW4KK3dlYmtpdF9zZXR0aW5nc19nZXRfcHJpbnRfYmFja2dyb3VuZHMKK3dlYmtp dF9zZXR0aW5nc19zZXRfcHJpbnRfYmFja2dyb3VuZHMKIAogPFNVQlNFQ1RJT04gU3RhbmRhcmQ+ CiBXZWJLaXRTZXR0aW5nc0NsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFNldHRpbmdzLmNwcAppbmRleCA5M2U5 YzljLi5jY2U3ZTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKQEAgLTE4NCw2ICsxODQs MTEgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdFNldHRpbmdzKFRlc3QqLCBnY29uc3Rwb2ludGVy KQogICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfZW5hYmxlX2Z1bGxzY3JlZW4oc2V0dGluZ3MsIFRS VUUpOwogICAgIGdfYXNzZXJ0KHdlYmtpdF9zZXR0aW5nc19nZXRfZW5hYmxlX2Z1bGxzY3JlZW4o c2V0dGluZ3MpKTsKIAorICAgIC8vIFByaW50IGJhY2tncm91bmRzIGlzIGVuYWJsZWQgYnkgZGVm YXVsdAorICAgIGdfYXNzZXJ0KHdlYmtpdF9zZXR0aW5nc19nZXRfcHJpbnRfYmFja2dyb3VuZHMo c2V0dGluZ3MpKTsKKyAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X3ByaW50X2JhY2tncm91bmRzKHNl dHRpbmdzLCBGQUxTRSk7CisgICAgZ19hc3NlcnQoIXdlYmtpdF9zZXR0aW5nc19nZXRfcHJpbnRf YmFja2dyb3VuZHMoc2V0dGluZ3MpKTsKKwogICAgIGdfb2JqZWN0X3VucmVmKEdfT0JKRUNUKHNl dHRpbmdzKSk7CiB9CiAK