76588 2012-01-18 16:59:52 -0800 editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName 2012-01-19 09:09:47 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica ap oldest_to_newest 538332 0 enrica 2012-01-18 16:59:52 -0800 This method is called to convert HTML into an NSAttributedString in several methods of the NSTextInput protocol. The conversion currently fails to handle the underline style, causing problems with the Inspector Bar in Mail on Mac. 538333 1 enrica 2012-01-18 17:00:07 -0800 <rdar://problem/9325183> 538335 2 123040 enrica 2012-01-18 17:06:30 -0800 Created attachment 123040 Patch 538347 3 123040 mitz 2012-01-18 17:17:15 -0800 Comment on attachment 123040 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123040&action=review > Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm:68 > + NSDictionary *attributes = [attrString attributesAtIndex:0 effectiveRange:nil]; I think the effectiveRange parameter is a pointer to an NSRange, so you should write 0, not nil. 538745 4 enrica 2012-01-19 08:50:58 -0800 > I think the effectiveRange parameter is a pointer to an NSRange, so you should write 0, not nil. Thanks for the review! I will fix this. 538748 5 enrica 2012-01-19 08:56:03 -0800 http://trac.webkit.org/changeset/105416 538754 6 ap 2012-01-19 09:09:47 -0800 This could be tested with a regular layout test - we expose attributedSubstringFromRange in DumpRenderTree. 123040 2012-01-18 17:06:30 -0800 2012-01-18 17:17:15 -0800 Patch forgottenunderline.txt text/plain 3973 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTM1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTE4ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgZWRpdGluZ0F0dHJpYnV0ZWRT dHJpbmdGcm9tUmFuZ2UgaW4gV2ViSFRNTENvbnZlcnRlciBkb2VzIG5vdCBoYW5kbGUgTlNVbmRl cmxpbmVTdHlsZUF0dHJpYnV0ZU5hbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NjU4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTMyNTE4Mz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBU ZXN0V2ViS2l0QVBJIHRlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvSFRNTENvbnZlcnRl ci5tbToKKyAgICAgICAgKCtbV2ViSFRNTENvbnZlcnRlciBlZGl0aW5nQXR0cmlidXRlZFN0cmlu Z0Zyb21SYW5nZTpdKToKKwogMjAxMi0wMS0xOCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBQcm92aWRlIGFjY2VzcyB0byB1c2VyJ3MgbGlzdCBvZiBw cmVmZXJyZWQgbGFuZ3VhZ2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvSFRN TENvbnZlcnRlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv SFRNTENvbnZlcnRlci5tbQkocmV2aXNpb24gMTA1MzAzKQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL0hUTUxDb252ZXJ0ZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTE2OTMsNiArMTY5 Myw4IEBAICsgKE5TQXR0cmlidXRlZFN0cmluZyAqKWVkaXRpbmdBdHRyaWJ1dGUKICAgICAgICAg aWYgKCFyZW5kZXJlcikKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBSZW5kZXJTdHls ZSogc3R5bGUgPSByZW5kZXJlci0+c3R5bGUoKTsKKyAgICAgICAgaWYgKHN0eWxlLT50ZXh0RGVj b3JhdGlvbnNJbkVmZmVjdCgpICYgVU5ERVJMSU5FKQorICAgICAgICAgICAgW2F0dHJzLmdldCgp IHNldE9iamVjdDpbTlNOdW1iZXIgbnVtYmVyV2l0aEludGVnZXI6TlNVbmRlcmxpbmVTdHlsZVNp bmdsZV0gZm9yS2V5Ok5TVW5kZXJsaW5lU3R5bGVBdHRyaWJ1dGVOYW1lXTsKICAgICAgICAgTlNG b250ICpmb250ID0gc3R5bGUtPmZvbnQoKS5wcmltYXJ5Rm9udCgpLT5nZXROU0ZvbnQoKTsKICAg ICAgICAgW2F0dHJzLmdldCgpIHNldE9iamVjdDpmb250IGZvcktleTpOU0ZvbnRBdHRyaWJ1dGVO YW1lXTsKICAgICAgICAgaWYgKHN0eWxlLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVy dHlDb2xvcikuYWxwaGEoKSkKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTM1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTE4ICBFbnJpY2EgQ2FzdWNjaSAg PGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgZWRpdGluZ0F0dHJpYnV0ZWRTdHJpbmdGcm9t UmFuZ2UgaW4gV2ViSFRNTENvbnZlcnRlciBkb2VzIG5vdCBoYW5kbGUgTlNVbmRlcmxpbmVTdHls ZUF0dHJpYnV0ZU5hbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NjU4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vOTMyNTE4Mz4KKworICAgICAg ICBBZGRlZCB0ZXN0LgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9JbnNwZWN0b3JCYXIubW06 CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxMi0wMS0xOCAgT2phbiBWYWZh aSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCB0ZXN0cyBmcm9tIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEwNTMzMi4KSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvbWFjL0luc3BlY3RvckJhci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL21hYy9JbnNwZWN0b3JCYXIubW0JKHJldmlzaW9uIDEwNTMwMykKKysrIFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL0luc3BlY3RvckJhci5tbQkod29ya2luZyBjb3B5 KQpAQCAtNTYsMTMgKzU2LDE5IEBAIFRFU1QoV2ViS2l0MSwgSW5zcGVjdG9yQmFyVGVzdCkKICAg ICBSZXRhaW5QdHI8SW5zcGVjdG9yQmFyQ29udHJvbGxlcj4gaW5zcGVjdG9yQmFyQ29udHJvbGxl cihBZG9wdE5TLCBbSW5zcGVjdG9yQmFyQ29udHJvbGxlciBuZXddKTsKIAogICAgIHdlYlZpZXcu Z2V0KCkuZnJhbWVMb2FkRGVsZWdhdGUgPSBpbnNwZWN0b3JCYXJDb250cm9sbGVyLmdldCgpOwot ICAgIFt3ZWJWaWV3LmdldCgpLm1haW5GcmFtZSBsb2FkSFRNTFN0cmluZzpAIjxib2R5IGNvbnRl bnRlZGl0YWJsZSBzdHlsZT1cImNvbG9yOiBncmVlblwiPkxvcmVtIGlwc3VtIHNpdCBhbWV0PC9i b2R5PiIgYmFzZVVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAImFib3V0OmJsYW5rIl1dOworICAg IFt3ZWJWaWV3LmdldCgpLm1haW5GcmFtZSBsb2FkSFRNTFN0cmluZzpAIjxib2R5IGNvbnRlbnRl ZGl0YWJsZSBzdHlsZT1cImNvbG9yOiBncmVlblwiPjx1PkxvcmVtIGlwc3VtIHNpdCBhbWV0PC91 PjwvYm9keT4iIGJhc2VVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJhYm91dDpibGFuayJdXTsK IAogICAgIFV0aWw6OnJ1bigmZGlkRmluaXNoTG9hZCk7CiAKICAgICBET01Eb2N1bWVudCAqZG9j dW1lbnQgPSB3ZWJWaWV3LmdldCgpLm1haW5GcmFtZURvY3VtZW50OwogICAgIFtbZG9jdW1lbnQg Ym9keV0gZm9jdXNdOwogICAgIFt3ZWJWaWV3LmdldCgpIHNlbGVjdEFsbDpuaWxdOworICAgIAor ICAgIE5TQXR0cmlidXRlZFN0cmluZyAqYXR0clN0cmluZyA9IFsoTlNWaWV3IDxOU1RleHRJbnB1 dD4gKilbW1t3ZWJWaWV3LmdldCgpIG1haW5GcmFtZV0gZnJhbWVWaWV3XSBkb2N1bWVudFZpZXdd IGF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2U6TlNNYWtlUmFuZ2UoMCwgNSldOworICAgIE5T RGljdGlvbmFyeSAqYXR0cmlidXRlcyA9IFthdHRyU3RyaW5nIGF0dHJpYnV0ZXNBdEluZGV4OjAg ZWZmZWN0aXZlUmFuZ2U6bmlsXTsKKyAgICAKKyAgICBFWFBFQ1RfVFJVRShbW2F0dHJpYnV0ZXMg b2JqZWN0Rm9yS2V5Ok5TVW5kZXJsaW5lU3R5bGVBdHRyaWJ1dGVOYW1lXSBpbnRWYWx1ZV0gIT0g MCk7CisKICAgICBbd2ViVmlldy5nZXQoKSBjaGFuZ2VBdHRyaWJ1dGVzOmluc3BlY3RvckJhckNv bnRyb2xsZXIuZ2V0KCldOwogICAgIAogICAgIERPTU5vZGUgKmN1cnJlbnROb2RlID0gW2RvY3Vt ZW50IGJvZHldOwpAQCAtNzEsNiArNzcsNyBAQCBURVNUKFdlYktpdDEsIEluc3BlY3RvckJhclRl c3QpCiAKICAgICBET01DU1NTdHlsZURlY2xhcmF0aW9uICpzdHlsZSA9IFtkb2N1bWVudCBnZXRD b21wdXRlZFN0eWxlOihET01FbGVtZW50ICopY3VycmVudE5vZGUgcHNldWRvRWxlbWVudDpuaWxd OwogICAgIEVYUEVDVF9XS19TVFJFUShAInJnYigwLCAwLCAwKSIsIFtzdHlsZSBjb2xvcl0pOwor ICAgIAogfQogCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==