76565 2012-01-18 13:27:47 -0800 Save two ID checks on CSS property validation 2012-01-18 18:02:22 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 tmpsantos webkit-unassigned kling macpherson webkit.review.bot oldest_to_newest 538105 0 tmpsantos 2012-01-18 13:27:47 -0800 The same validation is done again in the next case statement. Check for CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value is a number. 538111 1 122983 tmpsantos 2012-01-18 13:34:49 -0800 Created attachment 122983 Fixes double check on property validation 538242 2 122983 kling 2012-01-18 15:26:17 -0800 Comment on attachment 122983 Fixes double check on property validation r=me 538375 3 122983 webkit.review.bot 2012-01-18 18:02:18 -0800 Comment on attachment 122983 Fixes double check on property validation Clearing flags on attachment: 122983 Committed r105370: <http://trac.webkit.org/changeset/105370> 538376 4 webkit.review.bot 2012-01-18 18:02:22 -0800 All reviewed patches have been landed. Closing bug. 122983 2012-01-18 13:34:49 -0800 2012-01-18 18:02:18 -0800 Fixes double check on property validation double_check_on_property_validation.patch text/plain 1457 tmpsantos ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlNmFmZDgyLi5mZWI3ZWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDEtMTggIFRoaWFnbyBNYXJjb3MgUC4gU2FudG9zICA8dG1wc2FudG9zQGdtYWls LmNvbT4KKworICAgICAgICBTYXZlIHR3byBJRCBjaGVja3Mgb24gQ1NTIE1pbi9XaWR0aCBwcm9w ZXJ0eSB2YWxpZGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NjU2NQorCisgICAgICAgIFRoZSBzYW1lIHZhbGlkYXRpb24gaXMgZG9uZSBhZ2Fp biBpbiB0aGUgbmV4dCBjYXNlIHN0YXRlbWVudC4gQ2hlY2sgZm9yCisgICAgICAgIENTU1ZhbHVl SW50cmluc2ljIGFuZCBDU1NWYWx1ZU1pbkludHJpbnNpYyB3YXMgZG9uZSB0d2ljZSB3aGVuIHRo ZSB2YWx1ZQorICAgICAgICBpcyBhIG51bWJlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q1NTUGFyc2VyOjpwYXJzZVZhbHVlKToKKwogMjAxMi0wMS0xOCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ0ddIFJhc3Rlcml6ZWQgc2Nh bGluZyBvZiB0cmFuc2Zvcm1lZCBTVkcgc2hhcGVzIHdpdGggZ3JhZGllbnQgZmlsbCBhbmQgLXdl YmtpdC1zdmctc2hhZG93IGFwcGxpZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggOGVl MDVmYS4uMWI5MTU5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTEzMTUsNyArMTMx NSw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZVZhbHVlKGludCBwcm9wSWQsIGJvb2wgaW1wb3J0 YW50KQogICAgIGNhc2UgQ1NTUHJvcGVydHlNYXhXaWR0aDogICAgICAgICAgICAvLyA8bGVuZ3Ro PiB8IDxwZXJjZW50YWdlPiB8IG5vbmUgfCBpbmhlcml0CiAgICAgY2FzZSBDU1NQcm9wZXJ0eVdl YmtpdE1heExvZ2ljYWxXaWR0aDoKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0TWF4TG9naWNh bEhlaWdodDoKLSAgICAgICAgaWYgKGlkID09IENTU1ZhbHVlTm9uZSB8fCBpZCA9PSBDU1NWYWx1 ZUludHJpbnNpYyB8fCBpZCA9PSBDU1NWYWx1ZU1pbkludHJpbnNpYykgeworICAgICAgICBpZiAo aWQgPT0gQ1NTVmFsdWVOb25lKSB7CiAgICAgICAgICAgICB2YWxpZFByaW1pdGl2ZSA9IHRydWU7 CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQo=