76547 2012-01-18 09:11:47 -0800 Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer 2012-01-26 12:31:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed dglazkov kbr senorblanco vangelis webkit.review.bot oldest_to_newest 537908 0 reed 2012-01-18 09:11:47 -0800 Signal to skia to force A8 text from LCD output, but only when we have to disable LCD because we're in a layer 537917 1 122943 reed 2012-01-18 09:25:59 -0800 Created attachment 122943 Patch 537918 2 reed 2012-01-18 09:26:34 -0800 will need skia 3061 to land, to access the new API to set the GenA8FromLCD bit 537971 3 reed 2012-01-18 10:25:12 -0800 will address http://code.google.com/p/chromium/issues/detail?id=110066 (among others) 538007 4 122943 senorblanco 2012-01-18 11:09:09 -0800 Comment on attachment 122943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122943&action=review OK. r=me > Source/WebCore/ChangeLog:10 > + Existing tests should confirm nothing is broken. Antialiased text > + is disabled in layouttests, so they should be unaffected by the > + difference in antialiasing quality. Not your fault, but we really should come up with a way to override AA settings for specific layout tests. This could be done by adding to the JS API in testing/Internals (as we do for accelerated drawing, e.g.). This would allow us to test changes like this. 538310 5 122943 kbr 2012-01-18 16:19:55 -0800 Comment on attachment 122943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122943&action=review > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:184 > + SkPaint::kGenA8FromLCD_Flag) I should suggest here to use a constant rather than a #define. 541380 6 123747 reed 2012-01-24 09:19:47 -0800 Created attachment 123747 Patch 541383 7 reed 2012-01-24 09:21:00 -0800 changed #define to a constant. 541386 8 123747 reed 2012-01-24 09:24:03 -0800 Comment on attachment 123747 Patch new API from skia (rev. 3061) has landed. 541417 9 123747 webkit.review.bot 2012-01-24 10:01:53 -0800 Comment on attachment 123747 Patch Attachment 123747 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11334427 New failing tests: media/audio-garbage-collect.html 541513 10 123747 senorblanco 2012-01-24 11:31:17 -0800 Comment on attachment 123747 Patch media/audio-garbage-collect.html looks unrelated (failing intermittently on canaries as well). Looks good. r=me 542303 11 123747 webkit.review.bot 2012-01-25 08:39:56 -0800 Comment on attachment 123747 Patch Rejecting attachment 123747 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11342545 542474 12 senorblanco 2012-01-25 11:17:50 -0800 (In reply to comment #11) > (From update of attachment 123747 [details]) > Rejecting attachment 123747 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 > > ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Full output: http://queues.webkit.org/results/11342545 Looks like the Reviewed by NOBODY line is missing OOPS; perhaps this is confusing the commit bot. 543383 13 vangelis 2012-01-26 12:31:05 -0800 Committed r106029: <http://trac.webkit.org/changeset/106029> 122943 2012-01-18 09:25:59 -0800 2012-01-24 09:19:43 -0800 Patch bug-76547-20120118122558.patch text/plain 2592 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTI4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTE4ICBNaWtlIFJl ZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAgU2lnbmFsIHRvIHNraWEgdG8gZm9yY2Ug QTggdGV4dCBmcm9tIExDRCBvdXRwdXQsIGJ1dCBvbmx5IHdoZW4gd2UgaGF2ZSB0byBkaXNhYmxl IExDRCBiZWNhdXNlIHdlJ3JlIGluIGEgbGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ LgorCisgICAgICAgIEV4aXN0aW5nIHRlc3RzIHNob3VsZCBjb25maXJtIG5vdGhpbmcgaXMgYnJv a2VuLiBBbnRpYWxpYXNlZCB0ZXh0CisgICAgICAgIGlzIGRpc2FibGVkIGluIGxheW91dHRlc3Rz LCBzbyB0aGV5IHNob3VsZCBiZSB1bmFmZmVjdGVkIGJ5IHRoZQorICAgICAgICBkaWZmZXJlbmNl IGluIGFudGlhbGlhc2luZyBxdWFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9Ta2lhRm9udFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzZXR1cFBhaW50Rm9yRm9u dCk6CisKIDIwMTItMDEtMTggIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBvbWl0IGNvbXByZXNzaW9uIGZpZWxkIGluIEhBUiBl bnRyaWVzIGZvciByZXNvdXJjZXMgY29taW5nIGZyb20gY2FjaGUKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCShy ZXZpc2lvbiAxMDUxODEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1NraWFGb250V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc5LDYgKzE3OSwxMCBAQCBzdGF0 aWMgdWludDMyX3QgZ2V0RGVmYXVsdEdESVRleHRGbGFncygpCiAgICAgcmV0dXJuIGdGbGFnczsK IH0KIAorI2RlZmluZSBURVhUX0ZMQUdTX01BU0sgKFNrUGFpbnQ6OmtBbnRpQWxpYXNfRmxhZyB8 ICAgICAgICAgXAorICAgICAgICAgICAgICAgICAgICAgICAgIFNrUGFpbnQ6OmtMQ0RSZW5kZXJU ZXh0X0ZsYWcgfCAgICAgXAorICAgICAgICAgICAgICAgICAgICAgICAgIFNrUGFpbnQ6OmtHZW5B OEZyb21MQ0RfRmxhZykKKwogc3RhdGljIHZvaWQgc2V0dXBQYWludEZvckZvbnQoU2tQYWludCog cGFpbnQsIFBsYXRmb3JtQ29udGV4dFNraWEqIHBjcywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFNrVHlwZWZhY2UqIGZhY2UsIGZsb2F0IHNpemUsIGludCBxdWFsaXR5KQogewpAQCAt MjA1LDEyICsyMDksMjAgQEAgc3RhdGljIHZvaWQgc2V0dXBQYWludEZvckZvbnQoU2tQYWludCog cAogICAgIHRleHRGbGFncyAmPSBnZXREZWZhdWx0R0RJVGV4dEZsYWdzKCk7CiAKICAgICAvLyBk byB0aGlzIGNoZWNrIGFmdGVyIG91ciBzd2l0Y2ggb24gbGZRdWFsaXR5Ci0gICAgaWYgKGRpc2Fi bGVUZXh0TENEKHBjcykpCisgICAgaWYgKGRpc2FibGVUZXh0TENEKHBjcykpIHsKICAgICAgICAg dGV4dEZsYWdzICY9IH5Ta1BhaW50OjprTENEUmVuZGVyVGV4dF9GbGFnOworICAgICAgICAvLyBJ ZiB3ZSAqanVzdCogY2xlYXIgb3VyIHJlcXVlc3QgZm9yIExDRCwgdGhlbiBHREkgc2VlbXMgdG8K KyAgICAgICAgLy8gc29tZXRpbWVzIGdpdmUgdXMgQUEgdGV4dCwgYW5kIHNvbWV0aW1lcyBnaXZl IHVzIEJXIHRleHQuIFNpbmNlIHRoZQorICAgICAgICAvLyBvcmlnaW5hbCBpbnRlbnQgd2FzIExD RCwgd2Ugd2FudCB0byBmb3JjZSBBQSAocmF0aGVyIHRoYW4gQlcpLCBzbyB3ZQorICAgICAgICAv LyBhZGQgYSBzcGVjaWFsIGJpdCB0byB0ZWxsIFNraWEgdG8gZG8gaXRzIGJlc3QgdG8gYXZvaWQg dGhlIEJXOiBieQorICAgICAgICAvLyBkcmF3aW5nIExDRCBvZmZzY3JlZW4gYW5kIGRvd25zYW1w bGluZyB0aGF0IHRvIEFBLgorICAgICAgICB0ZXh0RmxhZ3MgfD0gU2tQYWludDo6a0dlbkE4RnJv bUxDRF9GbGFnOworICAgIH0KIAogICAgIC8vIG5vdyBjb3B5IGluIGp1c3QgdGhlIHRleHQgZmxh Z3MKKyAgICBTa0FTU0VSVCghKHRleHRGbGFncyAmIH5URVhUX0ZMQUdTX01BU0spKTsKICAgICB1 aW50MzJfdCBmbGFncyA9IHBhaW50LT5nZXRGbGFncygpOwotICAgIGZsYWdzICY9IH4oU2tQYWlu dDo6a0FudGlBbGlhc19GbGFnIHwgU2tQYWludDo6a0xDRFJlbmRlclRleHRfRmxhZyk7CisgICAg ZmxhZ3MgJj0gflRFWFRfRkxBR1NfTUFTSzsKICAgICBmbGFncyB8PSB0ZXh0RmxhZ3M7CiAgICAg cGFpbnQtPnNldEZsYWdzKGZsYWdzKTsKIH0K 123747 2012-01-24 09:19:47 -0800 2012-01-25 08:39:56 -0800 Patch bug-76547-20120124121945.patch text/plain 2367 reed SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTc0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTI0ICBNaWtlIFJl ZWQgIDxyZWVkQGdvb2dsZS5jb20+CisKKyAgICAgICAgU2lnbmFsIHRvIHNraWEgdG8gZm9yY2Ug QTggdGV4dCBmcm9tIExDRCBvdXRwdXQsIGJ1dCBvbmx5IHdoZW4gd2UgaGF2ZSB0byBkaXNhYmxl IExDRCBiZWNhdXNlIHdlJ3JlIGluIGEgbGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NTQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ LgorCisgICAgICAgIEV4aXN0aW5nIHRlc3RzIHNob3VsZCBjb25maXJtIG5vdGhpbmcgaXMgYnJv a2VuLiBBbnRpYWxpYXNlZCB0ZXh0CisgICAgICAgIGlzIGRpc2FibGVkIGluIGxheW91dHRlc3Rz LCBzbyB0aGV5IHNob3VsZCBiZSB1bmFmZmVjdGVkIGJ5IHRoZQorICAgICAgICBkaWZmZXJlbmNl IGluIGFudGlhbGlhc2luZyBxdWFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9Ta2lhRm9udFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzZXR1cFBhaW50Rm9yRm9u dCk6CisKIDIwMTItMDEtMjQgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIFJlZmFjdG9yIEdUSydzIGFjY2Vzc2liaWxpdGl0eSBjb2Rl IHRvIGJlIG1vcmUgbW9kdWxhcgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJKHJldmlzaW9uIDEwNTczNykKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMDUsMTIgKzIwNSwyNCBAQCBzdGF0aWMgdm9pZCBzZXR1cFBhaW50 Rm9yRm9udChTa1BhaW50KiBwCiAgICAgdGV4dEZsYWdzICY9IGdldERlZmF1bHRHRElUZXh0Rmxh Z3MoKTsKIAogICAgIC8vIGRvIHRoaXMgY2hlY2sgYWZ0ZXIgb3VyIHN3aXRjaCBvbiBsZlF1YWxp dHkKLSAgICBpZiAoZGlzYWJsZVRleHRMQ0QocGNzKSkKKyAgICBpZiAoZGlzYWJsZVRleHRMQ0Qo cGNzKSkgewogICAgICAgICB0ZXh0RmxhZ3MgJj0gflNrUGFpbnQ6OmtMQ0RSZW5kZXJUZXh0X0Zs YWc7CisgICAgICAgIC8vIElmIHdlICpqdXN0KiBjbGVhciBvdXIgcmVxdWVzdCBmb3IgTENELCB0 aGVuIEdESSBzZWVtcyB0bworICAgICAgICAvLyBzb21ldGltZXMgZ2l2ZSB1cyBBQSB0ZXh0LCBh bmQgc29tZXRpbWVzIGdpdmUgdXMgQlcgdGV4dC4gU2luY2UgdGhlCisgICAgICAgIC8vIG9yaWdp bmFsIGludGVudCB3YXMgTENELCB3ZSB3YW50IHRvIGZvcmNlIEFBIChyYXRoZXIgdGhhbiBCVyks IHNvIHdlCisgICAgICAgIC8vIGFkZCBhIHNwZWNpYWwgYml0IHRvIHRlbGwgU2tpYSB0byBkbyBp dHMgYmVzdCB0byBhdm9pZCB0aGUgQlc6IGJ5CisgICAgICAgIC8vIGRyYXdpbmcgTENEIG9mZnNj cmVlbiBhbmQgZG93bnNhbXBsaW5nIHRoYXQgdG8gQUEuCisgICAgICAgIHRleHRGbGFncyB8PSBT a1BhaW50OjprR2VuQThGcm9tTENEX0ZsYWc7CisgICAgfQorCisgICAgc3RhdGljIGNvbnN0IHVp bnQzMl90IHRleHRGbGFnc01hc2sgPSBTa1BhaW50OjprQW50aUFsaWFzX0ZsYWcgfAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tQYWludDo6a0xDRFJlbmRlclRl eHRfRmxhZyB8CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTa1Bh aW50OjprR2VuQThGcm9tTENEX0ZsYWc7CiAKICAgICAvLyBub3cgY29weSBpbiBqdXN0IHRoZSB0 ZXh0IGZsYWdzCisgICAgU2tBU1NFUlQoISh0ZXh0RmxhZ3MgJiB+dGV4dEZsYWdzTWFzaykpOwog ICAgIHVpbnQzMl90IGZsYWdzID0gcGFpbnQtPmdldEZsYWdzKCk7Ci0gICAgZmxhZ3MgJj0gfihT a1BhaW50OjprQW50aUFsaWFzX0ZsYWcgfCBTa1BhaW50OjprTENEUmVuZGVyVGV4dF9GbGFnKTsK KyAgICBmbGFncyAmPSB+dGV4dEZsYWdzTWFzazsKICAgICBmbGFncyB8PSB0ZXh0RmxhZ3M7CiAg ICAgcGFpbnQtPnNldEZsYWdzKGZsYWdzKTsKIH0K