76543 2012-01-18 07:36:39 -0800 Web Inspector: omit compression field in HAR entries for resources coming from cache 2012-01-18 09:14:40 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 537867 0 caseq 2012-01-18 07:36:39 -0800 As originally reported by Bryan McQuade, we incorrectly set compression for cached resources to original response size (sans re-validation headers for 304 resources): ==== You do set bodySize to 0 when from cache, as spec'd, but then you set compression to the full uncompressed response size as a result. ==== HAR specification suggests that we omit the compression field when no info is available. 537892 1 122938 caseq 2012-01-18 08:44:13 -0800 Created attachment 122938 Patch 537910 2 caseq 2012-01-18 09:14:40 -0800 Committed r105282: <http://trac.webkit.org/changeset/105282> 122938 2012-01-18 08:44:13 -0800 2012-01-18 09:02:09 -0800 Patch bug-76543-20120118204411.patch text/plain 7751 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQ3OWEzYWU0ZGI2NjJm ODA5Y2U3MTAxZTAyNDI0MDFiODlkMWE3Yy4uMDU4MTBjOGUxNGYyNzVkOGZhMWE4ZTM2YzA3M2Zm MzhkNTBiNmQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTAxLTE4ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogb21pdCBjb21wcmVzc2lvbiBmaWVsZCBpbiBIQVIgZW50cmllcyBmb3IgcmVzb3VyY2VzIGNv bWluZyBmcm9tIGNhY2hlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NjU0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9IQVJFbnRyeS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IQVJFbnRyeS5wcm90b3R5 cGUuX2J1aWxkQ29udGVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSEFSRW50cnkucHJvdG90 eXBlLmdldCByZXNwb25zZUNvbXByZXNzaW9uKToKKworMjAxMi0wMS0xOCAgQW5kcmV5IEtvc3lh a292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlc291 cmNlIHRyZWUgbW9kZWwgbGVha3MgZnJhbWVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03NjUzMwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0hBUkVudHJ5LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9IQVJFbnRyeS5qcwppbmRleCA5MzljNDU4Yjk4ZDYxMDE3YTFlYTczYWZhNzdm NWRkNzE0NjNlZDlhLi4wY2IwZjQ4Y2I0ZTJhMTJiMjJkNmZhMjhiNDA0YjYzMDA3ZGRjOWJlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hBUkVudHJ5Lmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSEFSRW50cnkuanMKQEAg LTEwNCwxMiArMTA0LDE1IEBAIFdlYkluc3BlY3Rvci5IQVJFbnRyeS5wcm90b3R5cGUgPSB7CiAg ICAgICovCiAgICAgX2J1aWxkQ29udGVudDogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgcmV0 dXJuIHsKKyAgICAgICAgdmFyIGNvbnRlbnQgPSB7CiAgICAgICAgICAgICBzaXplOiB0aGlzLl9y ZXNvdXJjZS5yZXNvdXJjZVNpemUsCi0gICAgICAgICAgICBjb21wcmVzc2lvbjogdGhpcy5yZXNw b25zZUNvbXByZXNzaW9uLAogICAgICAgICAgICAgbWltZVR5cGU6IHRoaXMuX3Jlc291cmNlLm1p bWVUeXBlLAogICAgICAgICAgICAgLy8gdGV4dDogdGhpcy5fcmVzb3VyY2UuY29udGVudCAvLyBU T0RPOiBwdWxsIG91dCBpbnRvIGEgYm9vbGVhbiBmbGFnLCBhcyBjb250ZW50IGNhbiBiZSBodWdl IChhbmQgbmVlZHMgdG8gYmUgcmVxdWVzdGVkIHdpdGggYW4gYXN5bmMgY2FsbCkKICAgICAgICAg fTsKKyAgICAgICAgdmFyIGNvbXByZXNzaW9uID0gdGhpcy5yZXNwb25zZUNvbXByZXNzaW9uOwor ICAgICAgICBpZiAodHlwZW9mIGNvbXByZXNzaW9uID09PSAibnVtYmVyIikKKyAgICAgICAgICAg IGNvbnRlbnQuY29tcHJlc3Npb24gPSBjb21wcmVzc2lvbjsKKyAgICAgICAgcmV0dXJuIGNvbnRl bnQ7CiAgICAgfSwKIAogICAgIC8qKgpAQCAtMjUyLDYgKzI1NSw4IEBAIFdlYkluc3BlY3Rvci5I QVJFbnRyeS5wcm90b3R5cGUgPSB7CiAgICAgICovCiAgICAgZ2V0IHJlc3BvbnNlQ29tcHJlc3Np b24oKQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlLmNhaGNlZCB8fCB0aGlzLl9y ZXNvdXJjZS5zdGF0dXNDb2RlID09PSAzMDQpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IHJldHVybiB0aGlzLl9yZXNvdXJjZS5yZXNvdXJjZVNpemUgLSAodGhpcy5fcmVzb3VyY2UudHJh bnNmZXJTaXplIC0gdGhpcy5fcmVzb3VyY2UucmVzcG9uc2VIZWFkZXJzU2l6ZSk7CiAgICAgfQog fQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDQ1ZGJiOGUyM2RlZGIzZWRiM2Y1MzEyMjQ5YWZjYWQxZTQ2ZWIzN2UuLjFiOTNl OGNmNDUwYWM2Zjg4MmY5ZmUxNzRmODdjZTc3YmI5ZWIyNDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxMi0wMS0xOCAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFdlYiBJbnNwZWN0b3I6IG9taXQgY29tcHJlc3Npb24gZmllbGQgaW4gSEFSIGVudHJp ZXMgZm9yIHJlc291cmNlcyBjb21pbmcgZnJvbSBjYWNoZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY1NDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNl LWhhci1jb252ZXJzaW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2luc3Bl Y3Rvci9yZXNvdXJjZS1oYXItaGVhZGVycy1leHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90 ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtcGFyYW1ldGVycy1leHBlY3RlZC50eHQ6CisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtaGFyLWNv bnZlcnNpb24tZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorCiAyMDEyLTAxLTE4ICBHYWJvciBSYXBj c2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFVwZGF0ZSBhbm90aGVy IFNWRyBleHBlY3RlZCBhZnRlciByMTA1MjQ3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtaGFyLWNvbnZlcnNpb24tZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtaGFyLWNvbnZlcnNpb24t ZXhwZWN0ZWQudHh0CmluZGV4IDhhOTJhNDM0NjExNjRiYzg0N2RkNGVjM2YzMjg0OTJmY2M1YWU5 NmMuLmVkZDUxNzRkNGI5OGFmZWM1MDdhOGM4MmVmYzJkYjdhNGRiYjAxNTYgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLWhhci1jb252ZXJzaW9u LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNv dXJjZS1oYXItY29udmVyc2lvbi1leHBlY3RlZC50eHQKQEAgLTk4LDcgKzk4LDYgQEAgUGFnZSBy ZWxvYWRlZC4KICAgICAgICAgICAgICAgICBdCiAgICAgICAgICAgICAgICAgY29udGVudCA6IHsK ICAgICAgICAgICAgICAgICAgICAgc2l6ZSA6IDxudW1iZXI+Ci0gICAgICAgICAgICAgICAgICAg IGNvbXByZXNzaW9uIDogPG51bWJlcj4KICAgICAgICAgICAgICAgICAgICAgbWltZVR5cGUgOiAi YXBwbGljYXRpb24veC1qYXZhc2NyaXB0IgogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg ICAgICByZWRpcmVjdFVSTCA6ICIiCkBAIC0xMzQsOCArMTMzLDggQEAgUGFnZSByZWxvYWRlZC4K ICAgICAgICAgICAgICAgICBdCiAgICAgICAgICAgICAgICAgY29udGVudCA6IHsKICAgICAgICAg ICAgICAgICAgICAgc2l6ZSA6IDxudW1iZXI+Ci0gICAgICAgICAgICAgICAgICAgIGNvbXByZXNz aW9uIDogPG51bWJlcj4KICAgICAgICAgICAgICAgICAgICAgbWltZVR5cGUgOiAidGV4dC9odG1s IgorICAgICAgICAgICAgICAgICAgICBjb21wcmVzc2lvbiA6IDxudW1iZXI+CiAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgICAgIHJlZGlyZWN0VVJMIDogIiIKICAgICAgICAgICAgICAg ICBoZWFkZXJzU2l6ZSA6IDxudW1iZXI+CkBAIC0xNzAsNyArMTY5LDYgQEAgUGFnZSByZWxvYWRl ZC4KICAgICAgICAgICAgICAgICBdCiAgICAgICAgICAgICAgICAgY29udGVudCA6IHsKICAgICAg ICAgICAgICAgICAgICAgc2l6ZSA6IDxudW1iZXI+Ci0gICAgICAgICAgICAgICAgICAgIGNvbXBy ZXNzaW9uIDogPG51bWJlcj4KICAgICAgICAgICAgICAgICAgICAgbWltZVR5cGUgOiAiYXBwbGlj YXRpb24veC1qYXZhc2NyaXB0IgogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBy ZWRpcmVjdFVSTCA6ICIiCkBAIC0yMTAsOCArMjA4LDggQEAgUGFnZSByZWxvYWRlZC4KICAgICAg ICAgICAgICAgICBdCiAgICAgICAgICAgICAgICAgY29udGVudCA6IHsKICAgICAgICAgICAgICAg ICAgICAgc2l6ZSA6IDxudW1iZXI+Ci0gICAgICAgICAgICAgICAgICAgIGNvbXByZXNzaW9uIDog PG51bWJlcj4KICAgICAgICAgICAgICAgICAgICAgbWltZVR5cGUgOiAiYXBwbGljYXRpb24veG1s IgorICAgICAgICAgICAgICAgICAgICBjb21wcmVzc2lvbiA6IDxudW1iZXI+CiAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgICAgIHJlZGlyZWN0VVJMIDogIiIKICAgICAgICAgICAgICAg ICBoZWFkZXJzU2l6ZSA6IDxudW1iZXI+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2luc3BlY3Rvci9yZXNvdXJjZS1oYXItaGVhZGVycy1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZS1oYXItaGVhZGVycy1leHBlY3RlZC50 eHQKaW5kZXggMDhkZTBjMjVjYWE0YmRhZjExZmM1Y2VjMzc4OGFkYzQ0MmM1MGRiOC4uMzg1MDEy MTYxMWUyNzRiN2ZjMGQ4NTExMTM1NWQwOGNmMmY5YjJlNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtaGFyLWhlYWRlcnMtZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLWhhci1oZWFk ZXJzLWV4cGVjdGVkLnR4dApAQCAtNTMsOCArNTMsOCBAQCBIQVI6ewogICAgICAgICBdCiAgICAg ICAgIGNvbnRlbnQgOiB7CiAgICAgICAgICAgICBzaXplIDogMTAwMAotICAgICAgICAgICAgY29t cHJlc3Npb24gOiA1MDAKICAgICAgICAgICAgIG1pbWVUeXBlIDogInRleHQvaHRtbCIKKyAgICAg ICAgICAgIGNvbXByZXNzaW9uIDogNTAwCiAgICAgICAgIH0KICAgICAgICAgcmVkaXJlY3RVUkwg OiAiIgogICAgICAgICBoZWFkZXJzU2l6ZSA6IDM5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZS1wYXJhbWV0ZXJzLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLXBhcmFtZXRlcnMtZXhwZWN0 ZWQudHh0CmluZGV4IGQyMzIyN2JlYTI4NmIxMDM3ZGNjNTRkMjUyMTgzNDk3MzE5MGY5ZjkuLmMx ZTA1ZmJmNTAwMWJiY2QwZDA4MjliYjk3MzQ5YmM5OTc5ZGJmODAgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLXBhcmFtZXRlcnMtZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLXBhcmFt ZXRlcnMtZXhwZWN0ZWQudHh0CkBAIC00OSw4ICs0OSw4IEBAIFRlc3RzIHRoYXQgcmVzb3VyY2Vz IHBhbmVsIHNob3dzIGZvcm0gZGF0YSBwYXJhbWV0ZXJzLgogICAgICAgICBdCiAgICAgICAgIGNv bnRlbnQgOiB7CiAgICAgICAgICAgICBzaXplIDogMTQKLSAgICAgICAgICAgIGNvbXByZXNzaW9u IDogPG51bWJlcj4KICAgICAgICAgICAgIG1pbWVUeXBlIDogImFwcGxpY2F0aW9uL3htbCIKKyAg ICAgICAgICAgIGNvbXByZXNzaW9uIDogPG51bWJlcj4KICAgICAgICAgfQogICAgICAgICByZWRp cmVjdFVSTCA6ICIiCiAgICAgICAgIGhlYWRlcnNTaXplIDogPG51bWJlcj4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291 cmNlLWhhci1jb252ZXJzaW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLWhhci1jb252ZXJzaW9uLWV4cGVj dGVkLnR4dAppbmRleCA4YTkyYTQzNDYxMTY0YmM4NDdkZDRlYzNmMzI4NDkyZmNjNWFlOTZjLi5l ZGQ1MTc0ZDRiOThhZmVjNTA3YThjODJlZmMyZGI3YTRkYmIwMTU2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9odHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZS1o YXItY29udmVyc2lvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vaHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtaGFyLWNvbnZlcnNpb24tZXhwZWN0 ZWQudHh0CkBAIC05OCw3ICs5OCw2IEBAIFBhZ2UgcmVsb2FkZWQuCiAgICAgICAgICAgICAgICAg XQogICAgICAgICAgICAgICAgIGNvbnRlbnQgOiB7CiAgICAgICAgICAgICAgICAgICAgIHNpemUg OiA8bnVtYmVyPgotICAgICAgICAgICAgICAgICAgICBjb21wcmVzc2lvbiA6IDxudW1iZXI+CiAg ICAgICAgICAgICAgICAgICAgIG1pbWVUeXBlIDogImFwcGxpY2F0aW9uL3gtamF2YXNjcmlwdCIK ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgcmVkaXJlY3RVUkwgOiAiIgpAQCAt MTM0LDggKzEzMyw4IEBAIFBhZ2UgcmVsb2FkZWQuCiAgICAgICAgICAgICAgICAgXQogICAgICAg ICAgICAgICAgIGNvbnRlbnQgOiB7CiAgICAgICAgICAgICAgICAgICAgIHNpemUgOiA8bnVtYmVy PgotICAgICAgICAgICAgICAgICAgICBjb21wcmVzc2lvbiA6IDxudW1iZXI+CiAgICAgICAgICAg ICAgICAgICAgIG1pbWVUeXBlIDogInRleHQvaHRtbCIKKyAgICAgICAgICAgICAgICAgICAgY29t cHJlc3Npb24gOiA8bnVtYmVyPgogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBy ZWRpcmVjdFVSTCA6ICIiCiAgICAgICAgICAgICAgICAgaGVhZGVyc1NpemUgOiA8bnVtYmVyPgpA QCAtMTcwLDcgKzE2OSw2IEBAIFBhZ2UgcmVsb2FkZWQuCiAgICAgICAgICAgICAgICAgXQogICAg ICAgICAgICAgICAgIGNvbnRlbnQgOiB7CiAgICAgICAgICAgICAgICAgICAgIHNpemUgOiA8bnVt YmVyPgotICAgICAgICAgICAgICAgICAgICBjb21wcmVzc2lvbiA6IDxudW1iZXI+CiAgICAgICAg ICAgICAgICAgICAgIG1pbWVUeXBlIDogImFwcGxpY2F0aW9uL3gtamF2YXNjcmlwdCIKICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgcmVkaXJlY3RVUkwgOiAiIgpAQCAtMjEwLDgg KzIwOCw4IEBAIFBhZ2UgcmVsb2FkZWQuCiAgICAgICAgICAgICAgICAgXQogICAgICAgICAgICAg ICAgIGNvbnRlbnQgOiB7CiAgICAgICAgICAgICAgICAgICAgIHNpemUgOiA8bnVtYmVyPgotICAg ICAgICAgICAgICAgICAgICBjb21wcmVzc2lvbiA6IDxudW1iZXI+CiAgICAgICAgICAgICAgICAg ICAgIG1pbWVUeXBlIDogImFwcGxpY2F0aW9uL3htbCIKKyAgICAgICAgICAgICAgICAgICAgY29t cHJlc3Npb24gOiA8bnVtYmVyPgogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBy ZWRpcmVjdFVSTCA6ICIiCiAgICAgICAgICAgICAgICAgaGVhZGVyc1NpemUgOiA8bnVtYmVyPgo=