76537 2012-01-18 06:31:23 -0800 [CSSRegions] Add region styling test for region css rules specificity/position 2012-03-22 03:46:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 mihnea webkit-unassigned webkit.review.bot oldest_to_newest 537829 0 mihnea 2012-01-18 06:31:23 -0800 Working on https://bugs.webkit.org/show_bug.cgi?id=76453 unveiled an issue with the way region styling rules were applied as they were not taking the specificity into account. There should be a test for this. 584253 1 133064 mibalan 2012-03-21 09:57:59 -0700 Created attachment 133064 Ref test for region styling specificity 585098 2 133064 kling 2012-03-22 03:09:49 -0700 Comment on attachment 133064 Ref test for region styling specificity LGTM. 585109 3 133064 webkit.review.bot 2012-03-22 03:46:07 -0700 Comment on attachment 133064 Ref test for region styling specificity Clearing flags on attachment: 133064 Committed r111667: <http://trac.webkit.org/changeset/111667> 585110 4 webkit.review.bot 2012-03-22 03:46:12 -0700 All reviewed patches have been landed. Closing bug. 133064 2012-03-21 09:57:59 -0700 2012-03-22 03:46:07 -0700 Ref test for region styling specificity 76537.patch text/plain 5576 mibalan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmZmE2NDAxLi43YmVhZTYzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDMt MjEgIE1paGFpIEJhbGFuICA8bWliYWxhbkBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTU1JlZ2lv bnNdIEFkZCByZWdpb24gc3R5bGluZyB0ZXN0IGZvciByZWdpb24gY3NzIHJ1bGVzIHNwZWNpZmlj aXR5L3Bvc2l0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NjUzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogZmFzdC9yZWdpb25zL3JlZ2lvbi1zdHlsZS1ydWxlLXNwZWNpZmljaXR5LWV4cGVjdGVk Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcmVnaW9ucy9yZWdpb24tc3R5bGUtcnVsZS1z cGVjaWZpY2l0eS5odG1sOiBBZGRlZC4KKwogMjAxMi0wMy0xNiAgWW9zaGlmdW1pIElub3VlICA8 eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gbGFiZWwuZm9ybSBhdHRyaWJ1 dGUgZG9lc24ndCB3b3JrCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvcmVn aW9uLXN0eWxlLXJ1bGUtc3BlY2lmaWNpdHktZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvcmVnaW9ucy9yZWdpb24tc3R5bGUtcnVsZS1zcGVjaWZpY2l0eS1leHBlY3RlZC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjQwYWM1OTQKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvcmVnaW9uLXN0eWxlLXJ1bGUtc3BlY2lmaWNp dHktZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDU3IEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1s PgorCTxoZWFkPgorCQk8c3R5bGU+CisJCWJvZHkgeworCQkJZm9udC1mYW1pbHk6IG1vbm9zcGFj ZTsKKwkJCWZvbnQtc2l6ZTogMWVtOworCQl9CisJCXAgeworCQkJbWFyZ2luOiAwOworCQkJbGlu ZS1oZWlnaHQ6IDFlbTsKKwkJfQorCQkuY29udGFpbmVyIHsKKwkJCWJhY2tncm91bmQtY29sb3I6 IGxpZ2h0Z3JheTsKKwkJCXdpZHRoOiAxNWVtOworCQkJaGVpZ2h0OiA1ZW07CisJCX0KKwkJLmxp Z2h0IHsKKwkJCWJhY2tncm91bmQtY29sb3I6IGxpZ2h0Z3JlZW47CisJCX0KKwkJLmxpbWUgewor CQkJYmFja2dyb3VuZC1jb2xvcjogbGltZTsKKwkJfQorCQkuZ3JlZW4geworCQkJYmFja2dyb3Vu ZC1jb2xvcjogZ3JlZW47CisJCX0KKwkJPC9zdHlsZT4KKwk8L2hlYWQ+CisJPGJvZHk+CisJCTxo MT5UZXN0aW5nIENTUyBzZWxlY3RvcnMgc3BlY2lmaWNpdHkvcG9zaXRpb24gaXMgcmVzcGVjdGVk IHdoZW4gdXNpbmcgQHJlZ2lvbiBzdHlsaW5nPC9oMT4KKworCQlTZWxlY3RvciBzcGVjaWZpY2l0 eSBpbiBAcmVnaW9uIHJ1bGUKKwkJPGRpdiBjbGFzcz0nY29udGFpbmVyJyBpZD0ncjEnPgorCQkJ PHAgY2xhc3M9J2xpZ2h0Jz5QbGFpbiBwYXJhZ3JhcGg8L3A+CisJCQk8cCBjbGFzcz0nbGltZSc+ U3R5bGVkIHdpdGggY2xhc3M8L3A+CisJCQk8cCBjbGFzcz0nZ3JlZW4nPlN0eWxlZCB3aXRoIElE PC9wPgorCQk8L2Rpdj4KKwkJU2VsZWN0b3IgcG9zaXRpb24gaW4gQHJlZ2lvbiBydWxlCisJCTxk aXYgY2xhc3M9J2NvbnRhaW5lcicgaWQ9J3IyJz4KKwkJCTxwIGNsYXNzPSdsaWdodCc+UGxhaW4g cGFyYWdyYXBoPC9wPgorCQkJPHAgY2xhc3M9J2xpbWUnPlN0eWxlZCB3aXRoIGNsYXNzPC9wPgor CQkJPHAgY2xhc3M9J2dyZWVuJz5TdHlsZWQgd2l0aCBJRDwvcD4KKwkJPC9kaXY+CisJCU1vcmUg c3BlY2lmaWMgc2VsZWN0b3IgaW4gZmxvd2VkIGNvbnRlbnQKKwkJPGRpdiBjbGFzcz0nY29udGFp bmVyJyBpZD0ncjMnPgorCQkJPHAgY2xhc3M9J2xpbWUnPkNsYXNzIGluIGNvbnRlbnQ8L3A+CisJ CQk8cCBjbGFzcz0nbGltZSc+SUQgaW4gY29udGVudDwvcD4KKwkJCTxwIGNsYXNzPSdsaW1lJz5J RCBpbiBjb250ZW50PC9wPgorCQk8L2Rpdj4KKwkJU3R5bGUgYXR0cmlidXRlIGluIGZsb3dlZCBj b250ZW50CisJCTxkaXYgY2xhc3M9J2NvbnRhaW5lcicgaWQ9J3I0Jz4KKwkJCTxwIGNsYXNzPSds aW1lJz5FbGVtZW50IHN0eWxlIGluIHJlZ2lvbjwvcD4KKwkJCTxwIGNsYXNzPSdsaW1lJz5JRCBz dHlsZSBpbiByZWdpb248L3A+CisJCQk8cCBjbGFzcz0nbGltZSc+Q2xhc3MgaW4gcmVnaW9uPC9w PgorCQk8L2Rpdj4KKwk8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmls ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3JlZ2lvbi1zdHlsZS1ydWxl LXNwZWNpZmljaXR5Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvcmVnaW9uLXN0eWxl LXJ1bGUtc3BlY2lmaWNpdHkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw Li5lOTk2Njc5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3Jl Z2lvbi1zdHlsZS1ydWxlLXNwZWNpZmljaXR5Lmh0bWwKQEAgLTAsMCArMSwxNDMgQEAKKzwhZG9j dHlwZSBodG1sPgorPGh0bWw+CisJPGhlYWQ+CisJCTxzdHlsZT4KKwkJYm9keSB7CisJCQlmb250 LWZhbWlseTogbW9ub3NwYWNlOworCQkJZm9udC1zaXplOiAxZW07CisJCX0KKwkJcCB7CisJCQlt YXJnaW46IDA7CisJCQlsaW5lLWhlaWdodDogMWVtOworCQl9CisJCS5jb250YWluZXIgeworCQkJ YmFja2dyb3VuZC1jb2xvcjogbGlnaHRncmF5OworCQkJd2lkdGg6IDE1ZW07CisJCQloZWlnaHQ6 IDVlbTsKKwkJfQorCQkvKiBzZWxlY3RvciBzcGVjaWZpY2l0eQorCQkjaWQgPT4gMTAwCisJCS5j bGFzcyA9PiAxMAorCQllbGVtZW50ID0+IDEKKwkJKi8KKwkJLyoKKwkJc2VsZWN0b3IgcG9zaXRp b24KKwkJaW4gc3R5bGU9IiIgYXR0cmlidXRlCisJCWluIDxzdHlsZS8+IGVsZW1lbnQgLyBleHRl cm5hbCBmaWxlCisJCSovCisKKwkJLyogVGVzdGluZyBzZWxlY3RvciBzcGVjaWZpY2l0eSBpcyBy ZXNwZWN0ZWQgaW4gQHJlZ2lvbiBzdHlsZSBibG9ja3MgKi8KKwkJI2YxIHsKKwkJCS13ZWJraXQt Zmxvdy1pbnRvOiBmbG93MTsKKwkJfQorCQkjcjEgeworCQkJLXdlYmtpdC1mbG93LWZyb206IGZs b3cxOworCQl9CisJCUAtd2Via2l0LXJlZ2lvbiAjcjEgeworCQkJKiB7CisJCQkJYmFja2dyb3Vu ZC1jb2xvcjogeWVsbG93OworCQkJfQorCQkJcCB7CisJCQkJYmFja2dyb3VuZC1jb2xvcjogbGln aHRncmVlbjsKKwkJCX0KKwkJCS5jcjEgeworCQkJCWJhY2tncm91bmQtY29sb3I6IGxpbWU7CisJ CQl9CisJCQkjcDEgeworCQkJCWJhY2tncm91bmQtY29sb3I6IGdyZWVuOworCQkJfQorCQl9CisK KwkJLyogVGVzdGluZyBzZWxlY3RvciBwb3NpdGlvbiBpcyByZXNwZWN0ZWQgaW4gQHJlZ2lvbiBz dHlsZSBibG9ja3MgKi8KKwkJI2YyIHsKKwkJCS13ZWJraXQtZmxvdy1pbnRvOiBmbG93MjsKKwkJ fQorCQkjcjIgeworCQkJLXdlYmtpdC1mbG93LWZyb206IGZsb3cyOworCQl9CisJCUAtd2Via2l0 LXJlZ2lvbiAjcjIgeworCQkJcCwgLmNyMjEsICNwMiB7CisJCQkJYmFja2dyb3VuZC1jb2xvcjog cmVkOworCQkJfQorCQl9CisJCUAtd2Via2l0LXJlZ2lvbiAjcjIgeworCQkJcCB7CisJCQkJYmFj a2dyb3VuZC1jb2xvcjogbGlnaHRncmVlbjsKKwkJCX0KKwkJCS5jcjIyIHsKKwkJCQliYWNrZ3Jv dW5kLWNvbG9yOiBsaW1lOworCQkJfQorCQkJI3AyIHsKKwkJCQliYWNrZ3JvdW5kLWNvbG9yOiBn cmVlbjsKKwkJCX0KKwkJfQorCisJCS8qIE1vcmUgc3BlY2lmaWMgc2VsZWN0b3IgaW4gZmxvd2Vk IGNvbnRlbnQgdGhhbiBpbiBAcmVnaW9uIHN0eWxlICovCisJCS5jMyB7CisJCQliYWNrZ3JvdW5k LWNvbG9yOiBsaW1lOworCQl9CisJCSNwMzEsICNwMzIgeworCQkJYmFja2dyb3VuZC1jb2xvcjog bGltZTsKKwkJfQorCQkjZjMgeworCQkJLXdlYmtpdC1mbG93LWludG86IGZsb3czOworCQl9CisJ CSNyMyB7CisJCQktd2Via2l0LWZsb3ctZnJvbTogZmxvdzM7CisJCX0KKwkJQC13ZWJraXQtcmVn aW9uICNyMyB7CisJCQlwLCAuY3IzIHsKKwkJCQliYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisJCQl9 CisJCX0KKworCQkvKiBGbG93ZWQgY29udGVudCBoYXMgc3R5bGUgYXR0cmlidXRlICovCisJCSNm NCB7CisJCQktd2Via2l0LWZsb3ctaW50bzogZmxvdzQ7CisJCX0KKwkJI3I0IHsKKwkJCS13ZWJr aXQtZmxvdy1mcm9tOiBmbG93NDsKKwkJfQorCQlALXdlYmtpdC1yZWdpb24gI3I0IHsKKwkJCXAs ICNwNCwgLmNyNCB7CisJCQkJYmFja2dyb3VuZC1jb2xvcjogcmVkOworCQkJfQorCQl9CisJCTwv c3R5bGU+CisJPC9oZWFkPgorCTxib2R5PgorCQk8IS0tIEZsb3dlZCBjb250ZW50IC0tPgorCQk8 ZGl2IGlkPSdmMSc+CisJCQk8cD5QbGFpbiBwYXJhZ3JhcGg8L3A+CisJCQk8cCBjbGFzcz0nY3Ix Jz5TdHlsZWQgd2l0aCBjbGFzczwvcD4KKwkJCTxwIGlkPSdwMSc+U3R5bGVkIHdpdGggSUQ8L3A+ CisJCTwvZGl2PgorCQk8ZGl2IGlkPSdmMic+CisJCQk8cD5QbGFpbiBwYXJhZ3JhcGg8L3A+CisJ CQk8cCBjbGFzcz0nY3IyMSBjcjIyJz5TdHlsZWQgd2l0aCBjbGFzczwvcD4KKwkJCTxwIGlkPSdw Mic+U3R5bGVkIHdpdGggSUQ8L3A+CisJCTwvZGl2PgorCQk8ZGl2IGlkPSdmMyc+CisJCQk8cCBj bGFzcz0nYzMnPkNsYXNzIGluIGNvbnRlbnQ8L3A+CisJCQk8cCBpZD0ncDMxJz5JRCBpbiBjb250 ZW50PC9wPgorCQkJPHAgY2xhc3M9J2NyMycgaWQ9J3AzMic+SUQgaW4gY29udGVudDwvcD4KKwkJ PC9kaXY+CisJCTxkaXYgaWQ9J2Y0Jz4KKwkJCTxwIHN0eWxlPSdiYWNrZ3JvdW5kLWNvbG9yOiBs aW1lOycgPkVsZW1lbnQgc3R5bGUgaW4gcmVnaW9uPC9wPgorCQkJPHAgc3R5bGU9J2JhY2tncm91 bmQtY29sb3I6IGxpbWU7JyBpZD0ncDInPklEIHN0eWxlIGluIHJlZ2lvbjwvcD4KKwkJCTxwIHN0 eWxlPSdiYWNrZ3JvdW5kLWNvbG9yOiBsaW1lOycgY2xhc3M9J2NyMic+Q2xhc3MgaW4gcmVnaW9u PC9wPgorCQk8L2Rpdj4KKworCQk8IS0tIFJlZ2lvbnMgLS0+CisJCTxoMT5UZXN0aW5nIENTUyBz ZWxlY3RvcnMgc3BlY2lmaWNpdHkvcG9zaXRpb24gaXMgcmVzcGVjdGVkIHdoZW4gdXNpbmcgQHJl Z2lvbiBzdHlsaW5nPC9oMT4KKworCQlTZWxlY3RvciBzcGVjaWZpY2l0eSBpbiBAcmVnaW9uIHJ1 bGUKKwkJPGRpdiBjbGFzcz0nY29udGFpbmVyJyBpZD0ncjEnPjwvZGl2PgorCQlTZWxlY3RvciBw b3NpdGlvbiBpbiBAcmVnaW9uIHJ1bGUKKwkJPGRpdiBjbGFzcz0nY29udGFpbmVyJyBpZD0ncjIn PjwvZGl2PgorCQlNb3JlIHNwZWNpZmljIHNlbGVjdG9yIGluIGZsb3dlZCBjb250ZW50CisJCTxk aXYgY2xhc3M9J2NvbnRhaW5lcicgaWQ9J3IzJz48L2Rpdj4KKwkJU3R5bGUgYXR0cmlidXRlIGlu IGZsb3dlZCBjb250ZW50CisJCTxkaXYgY2xhc3M9J2NvbnRhaW5lcicgaWQ9J3I0Jz48L2Rpdj4K Kwk8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=