76534 2012-01-18 05:44:02 -0800 [Qt] fontCache related assertion revealed by svg text layout optimization from r105143 2014-02-03 03:19:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED INVALID Qt, QtTriaged P1 Critical --- 65711 79668 1 rgabor webkit-unassigned hausmann kbalazs ossy rhodovan.u-szeged zherczeg zimmermann oldest_to_newest 537795 0 rgabor 2012-01-18 05:44:02 -0800 ASSERTION FAILED: fontCache()->generation() == m_generation ../../../../Source/WebCore/platform/graphics/FontFallbackList.cpp(104) : const WebCore::FontData* WebCore::FontFallbackList::fontDataAt(const WebCore::Font*, unsigned int) const 537808 1 rgabor 2012-01-18 06:00:38 -0800 Skipped until fix: http://trac.webkit.org/changeset/105269 537881 2 ossy 2012-01-18 08:10:28 -0800 Skipping didn't solve the problem, because the next test started to assert with same error: svg/carto.net/scrollbar.svg 537882 3 ossy 2012-01-18 08:12:41 -0800 I cc-ed SVG and fontcache experts. Have you got any idea? 537929 4 ossy 2012-01-18 09:38:13 -0800 svg/carto.net/combobox.svg is the culprit test. You can easily reproduce the bug with: $ Tools/Scripts/old-run-webkit-tests --debug svg/carto.net/combobox.svg RANDOM-SVG-CARTO_NET-TEST 537937 5 ossy 2012-01-18 09:42:44 -0800 I skipped a test to paint the bot green: http://trac.webkit.org/changeset/105287 But we really need a proper fix for this assertion. 539458 6 123304 zherczeg 2012-01-20 06:18:07 -0800 Created attachment 123304 Draft patch This patch fixes this particular issue, but it may have other side effects, so it is early to call this as a proper fix. 540093 7 123304 zimmermann 2012-01-21 00:35:16 -0800 Comment on attachment 123304 Draft patch So is this safe to land? Or does it need further testing? 540176 8 kbalazs 2012-01-21 14:29:29 -0800 (In reply to comment #7) > (From update of attachment 123304 [details]) > So is this safe to land? Or does it need further testing? I would rather ask, does this really fix the bug, or just hides it? 651427 9 123304 kbalazs 2012-06-18 09:12:42 -0700 Comment on attachment 123304 Draft patch Zoltan said to me that it's about where we call clearMemoryCaches, and this reordering untriggered the bug. However, all of this is public API so it should work in any order. I'm going to check if this is reproducible now. 652369 10 kbalazs 2012-06-19 06:26:23 -0700 I could not reproduce this bug now with Qt 5. Can we close it? Should we check Qt 4.8 as well, given that it's support will be dropped from trunk soon? 652406 11 ossy 2012-06-19 07:05:25 -0700 It is still valid on Qt 4.8, you can easily reproduce the assert: $ Tools/Scripts/old-run-webkit-tests --debug svg/carto.net/combobox.svg svg/carto.net/frameless-svg-parse-error.html Maybe it is valid on Qt 5 too, but I don't have debug Qt 5 build. And unfortunately debug WebKit build isn't possible with release Qt 5. Could you test it with Qt 5? 652410 12 kbalazs 2012-06-19 07:10:34 -0700 (In reply to comment #11) > It is still valid on Qt 4.8, you can easily reproduce the assert: > $ Tools/Scripts/old-run-webkit-tests --debug svg/carto.net/combobox.svg svg/carto.net/frameless-svg-parse-error.html > > Maybe it is valid on Qt 5 too, but I don't have debug Qt 5 build. And unfortunately debug WebKit build isn't possible with release Qt 5. > > Could you test it with Qt 5? I will. The question is: should we care about Qt 4? 652420 13 ossy 2012-06-19 07:17:39 -0700 (In reply to comment #12) > I will. The question is: should we care about Qt 4? Yes, we should till Qt 4 is supported officially. 652431 14 kbalazs 2012-06-19 07:27:52 -0700 (In reply to comment #13) > (In reply to comment #12) > > I will. The question is: should we care about Qt 4? > Yes, we should till Qt 4 is supported officially. Qt 4 + trunk support will be dropped in a few weeks (days?). Do you think about that time, or the lifetime of Qt 4? Qt 4 with trunk will be mantained in a branch, so I think Qt 4 QA work will not be our job anymore. 652438 15 ossy 2012-06-19 07:34:41 -0700 (In reply to comment #14) > (In reply to comment #13) > > (In reply to comment #12) > > > I will. The question is: should we care about Qt 4? > > Yes, we should till Qt 4 is supported officially. > > Qt 4 + trunk support will be dropped in a few weeks (days?). Do you think about that time, or the lifetime of Qt 4? Qt 4 with trunk will be mantained in a branch, so I think Qt 4 QA work will not be our job anymore. You're right. But we should care with Qt 4 till the big boss push the big red button and remove all Qt 4 related code from trunk. But it is absolutely unrelated to this topic. The question is here if the bug is Qt4 related or it is valid on Qt5 too. If it is Qt4 related, we should move the skipped list entry to qt-4.8/Skipped. 652443 16 kbalazs 2012-06-19 07:41:35 -0700 (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #13) > > > (In reply to comment #12) > > > > I will. The question is: should we care about Qt 4? > > > Yes, we should till Qt 4 is supported officially. > > > > Qt 4 + trunk support will be dropped in a few weeks (days?). Do you think about that time, or the lifetime of Qt 4? Qt 4 with trunk will be mantained in a branch, so I think Qt 4 QA work will not be our job anymore. > > You're right. But we should care with Qt 4 till the big boss push > the big red button and remove all Qt 4 related code from trunk. > > But it is absolutely unrelated to this topic. The question > is here if the bug is Qt4 related or it is valid on Qt5 too. > > If it is Qt4 related, we should move the skipped list entry to qt-4.8/Skipped. Ok, I just wanted to make this clear :) Yes, this is still reproducible with Qt 5 WebKit1. 654465 17 kbalazs 2012-06-21 06:51:49 -0700 Filed a new bug for it since I'm planning to change cross-platform code. *** This bug has been marked as a duplicate of bug 89658 *** 662033 18 kbalazs 2012-07-03 01:12:24 -0700 Unduplicating since my assumption that the bug is related to the font system was wrong. In fact it is in the svg code from r105143. 662037 19 kbalazs 2012-07-03 01:16:19 -0700 (In reply to comment #18) > Unduplicating since my assumption that the bug is related to the font system was wrong. In fact it is in the svg code from r105143. See discussion in bug 89658 comment 9. 975382 20 jturcotte 2014-02-03 03:19:39 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 123304 2012-01-20 06:18:07 -0800 2012-06-18 09:12:42 -0700 Draft patch drt-fix.patch text/plain 1166 zherczeg ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3Bw IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggZTdh NDk4MC4uZmQzNWI2ZSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJl bmRlclRyZWVRdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWVRdC5jcHAKQEAgLTYxOSwxMSArNjE5LDYgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZTo6b3Blbihj b25zdCBRVXJsJiB1cmwpCiAgICAgaW50IHdpZHRoID0gaXNXM0NUZXN0ID8gNDgwIDogTGF5b3V0 VGVzdENvbnRyb2xsZXI6Om1heFZpZXdXaWR0aDsKICAgICBpbnQgaGVpZ2h0ID0gaXNXM0NUZXN0 ID8gMzYwIDogTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdIZWlnaHQ7CiAgICAgbV9tYWlu Vmlldy0+cmVzaXplKFFTaXplKHdpZHRoLCBoZWlnaHQpKTsKLSAgICBtX3BhZ2UtPnNldFByZWZl cnJlZENvbnRlbnRzU2l6ZShRU2l6ZSgpKTsKLSAgICBtX3BhZ2UtPnNldFZpZXdwb3J0U2l6ZShR U2l6ZSh3aWR0aCwgaGVpZ2h0KSk7Ci0KLSAgICBRRm9jdXNFdmVudCBldihRRXZlbnQ6OkZvY3Vz SW4pOwotICAgIG1fcGFnZS0+ZXZlbnQoJmV2KTsKIAogICAgIFFXZWJTZXR0aW5nczo6Y2xlYXJN ZW1vcnlDYWNoZXMoKTsKICNpZiAhKFFUX1ZFUlNJT04gPD0gUVRfVkVSU0lPTl9DSEVDSyg0LCA2 LCAyKSkKQEAgLTYzMSw2ICs2MjYsMTIgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZTo6b3Blbihjb25z dCBRVXJsJiB1cmwpCiAjZW5kaWYKICAgICBpbml0aWFsaXplRm9udHMoKTsKIAorICAgIG1fcGFn ZS0+c2V0UHJlZmVycmVkQ29udGVudHNTaXplKFFTaXplKCkpOworICAgIG1fcGFnZS0+c2V0Vmll d3BvcnRTaXplKFFTaXplKHdpZHRoLCBoZWlnaHQpKTsKKworICAgIFFGb2N1c0V2ZW50IGV2KFFF dmVudDo6Rm9jdXNJbik7CisgICAgbV9wYWdlLT5ldmVudCgmZXYpOworCiAgICAgRHVtcFJlbmRl clRyZWVTdXBwb3J0UXQ6OmR1bXBGcmFtZUxvYWRlcih1cmwudG9TdHJpbmcoKS5jb250YWlucygi bG9hZGluZy8iKSk7CiAgICAgc2V0VGV4dE91dHB1dEVuYWJsZWQodHJ1ZSk7CiAgICAgbV9wYWdl LT5tYWluRnJhbWUoKS0+bG9hZCh1cmwpOwo=