76533 2012-01-18 05:31:30 -0800 Web Inspector: resource tree model leaks frames 2012-01-18 07:22:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 537790 0 caseq 2012-01-18 05:31:30 -0800 We never remove frames from ResourceTreeModel._frames. To test for that: - open inspector - navigate to a few sites - open inspector on inspector - check WebInspector.resourceTreeModel._frames -- it contains frames belonging to all sites visited. 537807 1 122910 caseq 2012-01-18 05:57:14 -0800 Created attachment 122910 Patch 537811 2 122910 pfeldman 2012-01-18 06:10:57 -0800 Comment on attachment 122910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122910&action=review > Source/WebCore/inspector/front-end/ResourceTreeModel.js:199 > + _removeFrame: function(frame) This method should be defined in frame. 537827 3 122917 caseq 2012-01-18 06:30:09 -0800 Created attachment 122917 Patch 537840 4 122917 pfeldman 2012-01-18 07:08:56 -0800 Comment on attachment 122917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122917&action=review > Source/WebCore/inspector/front-end/ResourceTreeModel.js:524 > + frame._remove(); I think this should be the last line in the method (after the childFrames.remove) > Source/WebCore/inspector/front-end/ResourceTreeModel.js:538 > + this._model.dispatchEventToListeners(WebInspector.ResourceTreeModel.EventTypes.FrameDetached, this); Also, dispatch as the last line. 537853 5 caseq 2012-01-18 07:22:28 -0800 Committed r105274: <http://trac.webkit.org/changeset/105274> 122910 2012-01-18 05:57:14 -0800 2012-01-18 06:30:00 -0800 Patch bug-76533-20120118175712.patch text/plain 2324 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDFmZGFkNTJmM2Q1YTFm MWE5NDRjMjgyZmE1ZDhjOGM5NWY5MWE4Mi4uYTMxYjBlN2RiYmYzNDQ0MTY3Nzc4Zjg2NGRiNDY1 ZGVlNGFjN2Q0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTAxLTE4ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogcmVzb3VyY2UgdHJlZSBtb2RlbCBsZWFrcyBmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNl VHJlZU1vZGVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVHJlZU1vZGVsLnBy b3RvdHlwZS5fZnJhbWVEZXRhY2hlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VU cmVlTW9kZWwucHJvdG90eXBlLl9yZW1vdmVGcmFtZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu UmVzb3VyY2VUcmVlRnJhbWUucHJvdG90eXBlLl9yZW1vdmVDaGlsZEZyYW1lKToKKworMjAxMi0w MS0xOCAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFBvcG92ZXIgZG9lcyBub3QgZGlzYXBwZWFyLCBjYXVzZXMgZGVidWdnZXIg ZmFpbHVyZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcxMzYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VUcmVlTW9kZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlVHJlZU1vZGVsLmpzCmluZGV4IDg5YzFmODU3NzljNzJlODg3Zjg2MzFkNjJiYWEw NmU4MjY1ZjMyYzUuLjQ1MGMzNDViYzI3YzE0MzFiN2UyNmI0YjY4MzI2NjBlN2QwMTQyZjkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VUcmVl TW9kZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZVRyZWVNb2RlbC5qcwpAQCAtMTg5LDExICsxODksMjAgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNl VHJlZU1vZGVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICAvLyBS ZXBvcnQgdGhhdCByb290IGlzIGRldGFjaGVkCiAgICAgICAgICAgICBmcmFtZS5fcmVtb3ZlQ2hp bGRGcmFtZXMoKTsKLSAgICAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdl Ykluc3BlY3Rvci5SZXNvdXJjZVRyZWVNb2RlbC5FdmVudFR5cGVzLkZyYW1lRGV0YWNoZWQsIGZy YW1lKTsKKyAgICAgICAgICAgIHRoaXMuX3JlbW92ZUZyYW1lKGZyYW1lKTsKICAgICAgICAgfQog ICAgIH0sCiAKICAgICAvKioKKyAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5SZXNvdXJjZVRy ZWVGcmFtZX0gZnJhbWUKKyAgICAgKi8KKyAgICBfcmVtb3ZlRnJhbWU6IGZ1bmN0aW9uKGZyYW1l KQorICAgIHsKKyAgICAgICAgZGVsZXRlIHRoaXMuX2ZyYW1lc1tmcmFtZS5pZF07CisgICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVN b2RlbC5FdmVudFR5cGVzLkZyYW1lRGV0YWNoZWQsIGZyYW1lKTsKKyAgICB9LAorCisgICAgLyoq CiAgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuRXZlbnR9IGV2ZW50CiAgICAgICovCiAgICAg X29uUmVzb3VyY2VVcGRhdGVkOiBmdW5jdGlvbihldmVudCkKQEAgLTUyNiw3ICs1MzUsNyBAQCBX ZWJJbnNwZWN0b3IuUmVzb3VyY2VUcmVlRnJhbWUucHJvdG90eXBlID0gewogICAgIHsKICAgICAg ICAgZnJhbWUuX3JlbW92ZUNoaWxkRnJhbWVzKCk7CiAgICAgICAgIHRoaXMuX2NoaWxkRnJhbWVz LnJlbW92ZShmcmFtZSk7Ci0gICAgICAgIHRoaXMuX21vZGVsLmRpc3BhdGNoRXZlbnRUb0xpc3Rl bmVycyhXZWJJbnNwZWN0b3IuUmVzb3VyY2VUcmVlTW9kZWwuRXZlbnRUeXBlcy5GcmFtZURldGFj aGVkLCBmcmFtZSk7CisgICAgICAgIHRoaXMuX21vZGVsLl9yZW1vdmVGcmFtZShmcmFtZSk7CiAg ICAgfSwKIAogICAgIF9yZW1vdmVDaGlsZEZyYW1lczogZnVuY3Rpb24oKQo= 122917 2012-01-18 06:30:09 -0800 2012-01-18 07:11:15 -0800 Patch bug-76533-20120118183007.patch text/plain 2515 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDFmZGFkNTJmM2Q1YTFm MWE5NDRjMjgyZmE1ZDhjOGM5NWY5MWE4Mi4uYTMxYjBlN2RiYmYzNDQ0MTY3Nzc4Zjg2NGRiNDY1 ZGVlNGFjN2Q0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTAxLTE4ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogcmVzb3VyY2UgdHJlZSBtb2RlbCBsZWFrcyBmcmFtZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NTMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNl VHJlZU1vZGVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVHJlZU1vZGVsLnBy b3RvdHlwZS5fZnJhbWVEZXRhY2hlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VU cmVlTW9kZWwucHJvdG90eXBlLl9yZW1vdmVGcmFtZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu UmVzb3VyY2VUcmVlRnJhbWUucHJvdG90eXBlLl9yZW1vdmVDaGlsZEZyYW1lKToKKworMjAxMi0w MS0xOCAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFBvcG92ZXIgZG9lcyBub3QgZGlzYXBwZWFyLCBjYXVzZXMgZGVidWdnZXIg ZmFpbHVyZS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcxMzYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VUcmVlTW9kZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Jlc291cmNlVHJlZU1vZGVsLmpzCmluZGV4IDg5YzFmODU3NzljNzJlODg3Zjg2MzFkNjJiYWEw NmU4MjY1ZjMyYzUuLmM3ZjVlMjhhMzJlMTFiYWQyNzM0YWViODI0OWE0ZGRmMjQ0ZmFhNGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VUcmVl TW9kZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZVRyZWVNb2RlbC5qcwpAQCAtMTg2LDExICsxODYsOCBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VU cmVlTW9kZWwucHJvdG90eXBlID0gewogCiAgICAgICAgIGlmIChmcmFtZS5wYXJlbnRGcmFtZSkK ICAgICAgICAgICAgIGZyYW1lLnBhcmVudEZyYW1lLl9yZW1vdmVDaGlsZEZyYW1lKGZyYW1lKTsK LSAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAvLyBSZXBvcnQgdGhhdCByb290IGlzIGRldGFj aGVkCi0gICAgICAgICAgICBmcmFtZS5fcmVtb3ZlQ2hpbGRGcmFtZXMoKTsKLSAgICAgICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVN b2RlbC5FdmVudFR5cGVzLkZyYW1lRGV0YWNoZWQsIGZyYW1lKTsKLSAgICAgICAgfQorICAgICAg ICBlbHNlCisgICAgICAgICAgICBmcmFtZS5fcmVtb3ZlKCk7CiAgICAgfSwKIAogICAgIC8qKgpA QCAtNTI0LDkgKzUyMSw4IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVGcmFtZS5wcm90b3R5 cGUgPSB7CiAgICAgICovCiAgICAgX3JlbW92ZUNoaWxkRnJhbWU6IGZ1bmN0aW9uKGZyYW1lKQog ICAgIHsKLSAgICAgICAgZnJhbWUuX3JlbW92ZUNoaWxkRnJhbWVzKCk7CisgICAgICAgIGZyYW1l Ll9yZW1vdmUoKTsKICAgICAgICAgdGhpcy5fY2hpbGRGcmFtZXMucmVtb3ZlKGZyYW1lKTsKLSAg ICAgICAgdGhpcy5fbW9kZWwuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5S ZXNvdXJjZVRyZWVNb2RlbC5FdmVudFR5cGVzLkZyYW1lRGV0YWNoZWQsIGZyYW1lKTsKICAgICB9 LAogCiAgICAgX3JlbW92ZUNoaWxkRnJhbWVzOiBmdW5jdGlvbigpCkBAIC01MzYsNiArNTMyLDEz IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVGcmFtZS5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICB0aGlzLl9yZW1vdmVDaGlsZEZyYW1lKGNvcHlbaV0pOyAKICAgICB9LAogCisgICAgX3Jl bW92ZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdGhpcy5fcmVtb3ZlQ2hpbGRGcmFtZXMo KTsKKyAgICAgICAgdGhpcy5fbW9kZWwuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3Bl Y3Rvci5SZXNvdXJjZVRyZWVNb2RlbC5FdmVudFR5cGVzLkZyYW1lRGV0YWNoZWQsIHRoaXMpOwor ICAgICAgICBkZWxldGUgdGhpcy5fbW9kZWwuX2ZyYW1lc1t0aGlzLmlkXTsKKyAgICB9LAorCiAg ICAgLyoqCiAgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuUmVzb3VyY2V9IHJlc291cmNlCiAg ICAgICovCg==