76529 2012-01-18 03:54:27 -0800 [GTK] Listen to GDK_SCROLL_MASK 2012-01-18 10:07:13 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 carlosg webkit-unassigned cgarcia gustavo webkit.review.bot xan.lopez oldest_to_newest 537763 0 carlosg 2012-01-18 03:54:27 -0800 There's a funny misbehavior in GTK+ where it sends scroll events to widgets listening to GDK_BUTTON_PRESS_MASK (perhaps dates from the old days where apps listened to 4-7 button presses), WebKitWebView seems to rely on this behavior and doesn't set GDK_SCROLL_MASK in the event mask, given it already seems to handle scroll events, adding this bit to the mask should be quite harmless, mostly for correctness 537765 1 cgarcia 2012-01-18 03:59:52 -0800 GtkLayout adds EXPOSURE and SCROLL. It seems that when we switched from GtkLayout to GtkContainer EXPOSURE was added but not SCROLL, I don't know if that was on purpose, though. 537921 2 122944 carlosg 2012-01-18 09:31:21 -0800 Created attachment 122944 Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base] 537927 3 webkit.review.bot 2012-01-18 09:37:43 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 537961 4 122944 webkit.review.bot 2012-01-18 10:07:09 -0800 Comment on attachment 122944 Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base] Clearing flags on attachment: 122944 Committed r105289: <http://trac.webkit.org/changeset/105289> 537962 5 webkit.review.bot 2012-01-18 10:07:13 -0800 All reviewed patches have been landed. Closing bug. 122944 2012-01-18 09:31:21 -0800 2012-01-18 10:07:09 -0800 Patch, adds GDK_SCROLL_MASK to WebKitWebView[Base] add-scroll-mask.diff text/plain 3020 carlosg ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBiYzczZjcyLi5iNDgyYjRiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDEtMTggIENhcmxvcyBHYXJuYWNobyAgPGNhcmxvc2dAZ25v bWUub3JnPgorCisgICAgICAgIFtHVEtdIExpc3RlbiB0byBHREtfU0NST0xMX01BU0sKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NTI5CisKKyAgICAg ICAgU2V0IEdES19TQ1JPTExfTUFTSyBleHBsaWNpdGx5LCBhcyBXZWJLaXRXZWJWaWV3IGRvZXMg aGFuZGxlCisgICAgICAgIHNjcm9sbCBldmVudHMsIHNjcm9sbGluZyBjdXJyZW50bHkgd29ya3Mg YmVjYXVzZSBHVEsrIGhhcHBlbnMgCisgICAgICAgIHRvIHNlbmQgc3VjaCBldmVudHMgdG8gd2lk Z2V0cyBsaXN0ZW5pbmcgdG8gR0RLX0JVVFRPTl9QUkVTU19NQVNLLAorICAgICAgICBidXQgdGhp cyBpc24ndCB0aGUgaW50ZW5kZWQgYmVoYXZpb3IsIHNvIGl0J3Mgc3ViamVjdCB0byBjaGFuZ2Uu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWJr aXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfcmVhbGl6ZSk6 CisKIDIwMTItMDEtMTcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHdGtdIElucHV0IHRleHQgZmllbGQgbm90IHJlcGFpbnRlZCB3aGVuIHZhbHVl IGlzIGNoYW5nZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApp bmRleCAwODY4YTRhLi5hYTQzMmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwCkBAIC05NjEsNiArOTYxLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92 aWV3X3JlYWxpemUoR3RrV2lkZ2V0KiB3aWRnZXQpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCBHREtfRVhQT1NVUkVfTUFTSwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgR0RL X0JVVFRPTl9QUkVTU19NQVNLCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBHREtfQlVU VE9OX1JFTEVBU0VfTUFTSworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgR0RLX1NDUk9M TF9NQVNLCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBHREtfUE9JTlRFUl9NT1RJT05f TUFTSwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgR0RLX0tFWV9QUkVTU19NQVNLCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBHREtfS0VZX1JFTEVBU0VfTUFTSwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CmluZGV4IGFlN2JjZjYuLjM5NGY0YzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx Mi0wMS0xOCAgQ2FybG9zIEdhcm5hY2hvICA8Y2FybG9zZ0Bnbm9tZS5vcmc+CisKKyAgICAgICAg W0dUS10gTGlzdGVuIHRvIEdES19TQ1JPTExfTUFTSworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzY1MjkKKworICAgICAgICBTZXQgR0RLX1NDUk9MTF9N QVNLIGV4cGxpY2l0bHksIGFzIFdlYktpdFdlYlZpZXdCYXNlIGRvZXMgaGFuZGxlCisgICAgICAg IHNjcm9sbCBldmVudHMsIHNjcm9sbGluZyBjdXJyZW50bHkgd29ya3MgYmVjYXVzZSBHVEsrIGhh cHBlbnMgCisgICAgICAgIHRvIHNlbmQgc3VjaCBldmVudHMgdG8gd2lkZ2V0cyBsaXN0ZW5pbmcg dG8gR0RLX0JVVFRPTl9QUkVTU19NQVNLLAorICAgICAgICBidXQgdGhpcyBpc24ndCB0aGUgaW50 ZW5kZWQgYmVoYXZpb3IsIHNvIGl0J3Mgc3ViamVjdCB0byBjaGFuZ2UuCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUp OgorCiAyMDEyLTAxLTE4ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CiAK ICAgICAgICAgTW92ZSBTaGFkb3dDb250ZW50RWxlbWVudCBmcm9tIGRvbS8gdG8gaHRtbC8gYW5k IG1ha2UgU2hhZG93Q29udGVudEVsZW1lbnQgc3ViY2xhc3Mgb2YgSFRNTEVsZW1lbnQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAKaW5kZXggYzAzZjBiYi4uN2FiZjJkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTE4LDYgKzEx OCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlUmVhbGl6ZShHdGtXaWRnZXQqIHdp ZGdldCkKICAgICAgICAgfCBHREtfRVhQT1NVUkVfTUFTSwogICAgICAgICB8IEdES19CVVRUT05f UFJFU1NfTUFTSwogICAgICAgICB8IEdES19CVVRUT05fUkVMRUFTRV9NQVNLCisgICAgICAgIHwg R0RLX1NDUk9MTF9NQVNLCiAgICAgICAgIHwgR0RLX1BPSU5URVJfTU9USU9OX01BU0sKICAgICAg ICAgfCBHREtfS0VZX1BSRVNTX01BU0sKICAgICAgICAgfCBHREtfS0VZX1JFTEVBU0VfTUFTSwo=