76506 2012-01-17 18:17:13 -0800 Remove some unused code in AudioContext 2012-01-18 20:02:46 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rgbbones rgbbones crogers kbr webkit.review.bot oldest_to_newest 537527 0 rgbbones 2012-01-17 18:17:13 -0800 Remove some unused code in AudioContext 537528 1 122855 rgbbones 2012-01-17 18:18:35 -0800 Created attachment 122855 Patch 537532 2 rgbbones 2012-01-17 18:20:26 -0800 Hi It seems to me that some code in AudioContext is not used anymore. So I remove them in this patch. 538080 3 crogers 2012-01-18 12:40:57 -0800 Looks great to me - thanks for the cleanup! 538364 4 122855 kbr 2012-01-18 17:52:25 -0800 Comment on attachment 122855 Patch Looks good. r=me 538414 5 122855 webkit.review.bot 2012-01-18 20:02:41 -0800 Comment on attachment 122855 Patch Clearing flags on attachment: 122855 Committed r105375: <http://trac.webkit.org/changeset/105375> 538415 6 webkit.review.bot 2012-01-18 20:02:46 -0800 All reviewed patches have been landed. Closing bug. 122855 2012-01-17 18:18:35 -0800 2012-01-18 20:02:41 -0800 Patch bug-76506-20120118102252.patch text/plain 4281 rgbbones U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTVkZDk4NWJkMTY3NTE5 YmEyODVjZWNhZmFkNzY0MzI4OGExNWJhYS4uMjI1MjBiNWZkZDAxODNjOTZmYzBmYjcyODU3MGZj Zjg1ODM2MjA1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTE3ICBSYXlt b25kIExpdSAgPHJheW1vbmQubGl1QGludGVsLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSB1 bnVzZWQgY29kZSBpbiBBdWRpb0NvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc2NTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJlcXVpcmVkLgorCisgICAgICAgICogd2Vi YXVkaW8vQXVkaW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6 Y29uc3RydWN0Q29tbW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6dW5pbml0 aWFsaXplKToKKyAgICAgICAgKiB3ZWJhdWRpby9BdWRpb0NvbnRleHQuaDoKKwogMjAxMi0wMS0x NyAgQW5kcmVhcyBLbGluZyAgPGF3ZXNvbWVrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgU3Bh Y2VTcGxpdFN0cmluZzogU2hhcmUgZXF1aXZhbGVudCBzdHJpbmcgcGllY2UgdmVjdG9ycy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCmluZGV4IGRjYTk2MDYzYTI5YTg4 ZjUzZjE0MGIxOTEzMzkxMjlmNjFiZTcxMTQuLjBjMTY2NGZiODQ4OWM3Njg0MzlmZWU4N2NjZjIw Yjk5ZmVlZjMyM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQ29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcApA QCAtMTcyLDggKzE3Miw2IEBAIHZvaWQgQXVkaW9Db250ZXh0Ojpjb25zdHJ1Y3RDb21tb24oKQog ICAgIEZGVEZyYW1lOjppbml0aWFsaXplKCk7CiAgICAgCiAgICAgbV9saXN0ZW5lciA9IEF1ZGlv TGlzdGVuZXI6OmNyZWF0ZSgpOwotICAgIG1fdGVtcG9yYXJ5TW9ub0J1cyA9IGFkb3B0UHRyKG5l dyBBdWRpb0J1cygxLCBBdWRpb05vZGU6OlByb2Nlc3NpbmdTaXplSW5GcmFtZXMpKTsKLSAgICBt X3RlbXBvcmFyeVN0ZXJlb0J1cyA9IGFkb3B0UHRyKG5ldyBBdWRpb0J1cygyLCBBdWRpb05vZGU6 OlByb2Nlc3NpbmdTaXplSW5GcmFtZXMpKTsKIH0KIAogQXVkaW9Db250ZXh0Ojp+QXVkaW9Db250 ZXh0KCkKQEAgLTIzOCwxMyArMjM2LDYgQEAgdm9pZCBBdWRpb0NvbnRleHQ6OnVuaW5pdGlhbGl6 ZSgpCiAKICAgICAgICAgZGVsZXRlTWFya2VkTm9kZXMoKTsKIAotICAgICAgICAvLyBCZWNhdXNl IHRoZSBBdWRpb0J1ZmZlcnMgYXJlIGdhcmJhZ2UgY29sbGVjdGVkLCB3ZSBjYW4ndCBkZWxldGUg dGhlbSBoZXJlLgotICAgICAgICAvLyBJbnN0ZWFkLCBhdCBsZWFzdCByZWxlYXNlIHRoZSBwb3Rl bnRpYWxseSBsYXJnZSBhbW91bnQgb2YgYWxsb2NhdGVkIG1lbW9yeSBmb3IgdGhlIGF1ZGlvIGRh dGEuCi0gICAgICAgIC8vIE5vdGUgdGhhdCB3ZSBkbyB0aGlzICphZnRlciogdGhlIGNvbnRleHQg aXMgdW5pbml0aWFsaXplZCBhbmQgc3RvcHMgcHJvY2Vzc2luZyBhdWRpby4KLSAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fYWxsb2NhdGVkQnVmZmVycy5zaXplKCk7ICsraSkKLSAg ICAgICAgICAgIG1fYWxsb2NhdGVkQnVmZmVyc1tpXS0+cmVsZWFzZU1lbW9yeSgpOwotICAgICAg ICBtX2FsbG9jYXRlZEJ1ZmZlcnMuY2xlYXIoKTsKLSAgICAKICAgICAgICAgbV9pc0luaXRpYWxp emVkID0gZmFsc2U7CiAgICAgfQogfQpAQCAtMjk1LDExICsyODYsNiBAQCBib29sIEF1ZGlvQ29u dGV4dDo6aGFzRG9jdW1lbnQoKQogICAgIHJldHVybiBtX2RvY3VtZW50OwogfQogCi12b2lkIEF1 ZGlvQ29udGV4dDo6cmVmQnVmZmVyKFBhc3NSZWZQdHI8QXVkaW9CdWZmZXI+IGJ1ZmZlcikKLXsK LSAgICBtX2FsbG9jYXRlZEJ1ZmZlcnMuYXBwZW5kKGJ1ZmZlcik7Ci19Ci0KIFBhc3NSZWZQdHI8 QXVkaW9CdWZmZXI+IEF1ZGlvQ29udGV4dDo6Y3JlYXRlQnVmZmVyKHVuc2lnbmVkIG51bWJlck9m Q2hhbm5lbHMsIHNpemVfdCBudW1iZXJPZkZyYW1lcywgZmxvYXQgc2FtcGxlUmF0ZSwgRXhjZXB0 aW9uQ29kZSYgZWMpCiB7CiAgICAgUmVmUHRyPEF1ZGlvQnVmZmVyPiBhdWRpb0J1ZmZlciA9IEF1 ZGlvQnVmZmVyOjpjcmVhdGUobnVtYmVyT2ZDaGFubmVscywgbnVtYmVyT2ZGcmFtZXMsIHNhbXBs ZVJhdGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0 LmggYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0NvbnRleHQuaAppbmRleCBjNGVlYzA4 YzA0ZGE3NmIwM2U1NTAxMmMyODg3Y2RmYTNjMTRhZDRmLi5iYTdjNTM4YTViMjUyNzliYWE2MTMy NmE3NDdhZGJmZWM0YTQyMmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9B dWRpb0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0NvbnRleHQu aApAQCAtMTAyLDkgKzEwMiw2IEBAIHB1YmxpYzoKICAgICAvLyBBc3luY2hyb25vdXMgYXVkaW8g ZmlsZSBkYXRhIGRlY29kaW5nLgogICAgIHZvaWQgZGVjb2RlQXVkaW9EYXRhKEFycmF5QnVmZmVy KiwgUGFzc1JlZlB0cjxBdWRpb0J1ZmZlckNhbGxiYWNrPiwgUGFzc1JlZlB0cjxBdWRpb0J1ZmZl ckNhbGxiYWNrPiwgRXhjZXB0aW9uQ29kZSYgZWMpOwogCi0gICAgLy8gS2VlcCB0cmFjayBvZiB0 aGlzIGJ1ZmZlciBzbyB3ZSBjYW4gcmVsZWFzZSBtZW1vcnkgYWZ0ZXIgdGhlIGNvbnRleHQgaXMg c2h1dCBkb3duLi4uCi0gICAgdm9pZCByZWZCdWZmZXIoUGFzc1JlZlB0cjxBdWRpb0J1ZmZlcj4g YnVmZmVyKTsKLQogICAgIEF1ZGlvTGlzdGVuZXIqIGxpc3RlbmVyKCkgeyByZXR1cm4gbV9saXN0 ZW5lci5nZXQoKTsgfQogCiAgICAgLy8gVGhlIEF1ZGlvTm9kZSBjcmVhdGUgbWV0aG9kcyBhcmUg Y2FsbGVkIG9uIHRoZSBtYWluIHRocmVhZCAoZnJvbSBKYXZhU2NyaXB0KS4KQEAgLTEyNiw5ICsx MjMsNiBAQCBwdWJsaWM6CiAgICAgUGFzc1JlZlB0cjxBdWRpb0NoYW5uZWxTcGxpdHRlcj4gY3Jl YXRlQ2hhbm5lbFNwbGl0dGVyKCk7CiAgICAgUGFzc1JlZlB0cjxBdWRpb0NoYW5uZWxNZXJnZXI+ IGNyZWF0ZUNoYW5uZWxNZXJnZXIoKTsKIAotICAgIEF1ZGlvQnVzKiB0ZW1wb3JhcnlNb25vQnVz KCkgeyByZXR1cm4gbV90ZW1wb3JhcnlNb25vQnVzLmdldCgpOyB9Ci0gICAgQXVkaW9CdXMqIHRl bXBvcmFyeVN0ZXJlb0J1cygpIHsgcmV0dXJuIG1fdGVtcG9yYXJ5U3RlcmVvQnVzLmdldCgpOyB9 Ci0KICAgICAvLyBXaGVuIGEgc291cmNlIG5vZGUgaGFzIG5vIG1vcmUgcHJvY2Vzc2luZyB0byBk byAoaGFzIGZpbmlzaGVkIHBsYXlpbmcpLCB0aGVuIGl0IHRlbGxzIHRoZSBjb250ZXh0IHRvIGRl cmVmZXJlbmNlIGl0LgogICAgIHZvaWQgbm90aWZ5Tm9kZUZpbmlzaGVkUHJvY2Vzc2luZyhBdWRp b05vZGUqKTsKIApAQCAtMjU1LDkgKzI0OSw2IEBAIHByaXZhdGU6CiAgICAgUmVmUHRyPEF1ZGlv RGVzdGluYXRpb25Ob2RlPiBtX2Rlc3RpbmF0aW9uTm9kZTsKICAgICBSZWZQdHI8QXVkaW9MaXN0 ZW5lcj4gbV9saXN0ZW5lcjsKIAotICAgIC8vIE9ubHkgYWNjZXNzZWQgaW4gdGhlIG1haW4gdGhy ZWFkLgotICAgIFZlY3RvcjxSZWZQdHI8QXVkaW9CdWZmZXI+ID4gbV9hbGxvY2F0ZWRCdWZmZXJz OwotCiAgICAgLy8gT25seSBhY2Nlc3NlZCBpbiB0aGUgYXVkaW8gdGhyZWFkLgogICAgIFZlY3Rv cjxBdWRpb05vZGUqPiBtX2ZpbmlzaGVkTm9kZXM7CiAKQEAgLTI3Nyw5ICsyNjgsNiBAQCBwcml2 YXRlOgogICAgIHZvaWQgaGFuZGxlRGlydHlBdWRpb05vZGVJbnB1dHMoKTsKICAgICB2b2lkIGhh bmRsZURpcnR5QXVkaW9Ob2RlT3V0cHV0cygpOwogCi0gICAgT3duUHRyPEF1ZGlvQnVzPiBtX3Rl bXBvcmFyeU1vbm9CdXM7Ci0gICAgT3duUHRyPEF1ZGlvQnVzPiBtX3RlbXBvcmFyeVN0ZXJlb0J1 czsKLQogICAgIHVuc2lnbmVkIG1fY29ubmVjdGlvbkNvdW50OwogCiAgICAgLy8gR3JhcGggbG9j a2luZy4K