76498 2012-01-17 17:03:17 -0800 [chromium] Apply color profiles in more cases 2012-03-28 20:54:04 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75999 82428 1 kbr kbr jbauman noel.gordon senorblanco webkit.review.bot oldest_to_newest 537452 0 kbr 2012-01-17 17:03:17 -0800 The fix for Bug 75999 disabled the application of color profiles whenever WebGL's premultipliedAlpha flag is set. We can do better than this if we check to see whether the image has an alpha channel before deciding not to apply the color profile. 537458 1 122843 kbr 2012-01-17 17:10:45 -0800 Created attachment 122843 Patch 537487 2 122843 senorblanco 2012-01-17 17:30:31 -0800 Comment on attachment 122843 Patch I'm not very familiar with this code, but I'll trust the test results. r=me 537500 3 noel.gordon 2012-01-17 17:43:47 -0800 LGTM. 537561 4 122843 webkit.review.bot 2012-01-17 19:09:33 -0800 Comment on attachment 122843 Patch Clearing flags on attachment: 122843 Committed r105230: <http://trac.webkit.org/changeset/105230> 537562 5 webkit.review.bot 2012-01-17 19:09:37 -0800 All reviewed patches have been landed. Closing bug. 122843 2012-01-17 17:10:45 -0800 2012-01-17 19:09:33 -0800 Patch bug-76498-20120117171044.patch text/plain 1829 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I0NzBiYjQzMmZiMDE5 N2Y3ZDQ5NTQzZDZmYjRlMDQxNDc5Mjk4Mi4uMGMyNTc1ZDExOGZkN2U1MWFhMGZkY2MyYzlkOTYx M2NmYzc1Nzc5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTE3ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEFwcGx5 IGNvbG9yIHByb2ZpbGVzIGluIG1vcmUgY2FzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NDk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm90IGFkZGluZyBuZXcgdGVzdHMsIGFzIGFwcGxpY2F0aW9u IG9mIHRoZSBjb2xvciBwcm9maWxlIGlzIG5vdAorICAgICAgICBndWFyYW50ZWVkIGZvciBpbWFn ZXMgdXNlZCBhcyB0ZXh0dXJlcyBpbiBXZWJHTC4gUmFuIGV4aXN0aW5nCisgICAgICAgIFdlYkdM IGxheW91dCB0ZXN0czsgYWxsIHBhc3MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNv ZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VG cmFtZTo6c2V0U3RhdHVzKToKKwogMjAxMi0wMS0xNyAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIENyYXNoIGluIGluIFdlYkNvcmU6OkV2ZW50SGFuZGxl cjo6bW91c2VNb3ZlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdl LWRlY29kZXJzL3NraWEvSW1hZ2VEZWNvZGVyU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3BwCmluZGV4IDBjMzIw NmU4NjZjNDFmZjJmOTIzNzhiYjEwYmQyYWMyNWJhNmY4YmUuLmYzZmQ3NjljZDNiMmEwY2RmNjBj YjZiYjFhM2Q1OWJkZGY5ZGQ2ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2ltYWdlLWRlY29kZXJzL3NraWEvSW1hZ2VEZWNvZGVyU2tpYS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvc2tpYS9JbWFnZURlY29kZXJTa2lhLmNwcApA QCAtMTYwLDcgKzE2MCw3IEBAIHZvaWQgSW1hZ2VGcmFtZTo6c2V0U3RhdHVzKEZyYW1lU3RhdHVz IHN0YXR1cykKICNpZiBQTEFURk9STShDSFJPTUlVTSkgJiYgT1MoREFSV0lOKQogICAgICAgICAv LyByZXNvbHZlQ29sb3JTcGFjZSgpIGFuZCBjYWxsZWVzIGFzc3VtZSB0aGF0IHRoZSBhbHBoYSBj aGFubmVsIGlzCiAgICAgICAgIC8vIHByZW11bHRpcGxpZWQsIHNvIGRvbid0IGFwcGx5IHRoZSBj b2xvciBwcm9maWxlIGlmIGl0IGlzbid0LgotICAgICAgICBpZiAobV9jb2xvclByb2ZpbGUuaXNF bXB0eSgpIHx8ICFtX3ByZW11bHRpcGx5QWxwaGEpCisgICAgICAgIGlmIChtX2NvbG9yUHJvZmls ZS5pc0VtcHR5KCkgfHwgKCFtX3ByZW11bHRpcGx5QWxwaGEgJiYgaGFzQWxwaGEoKSkpCiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIFJldGFpblB0cjxDR0NvbG9yU3BhY2VSZWY+IGNnQ29s b3JTcGFjZShBZG9wdENGLCBjcmVhdGVDb2xvclNwYWNlKG1fY29sb3JQcm9maWxlKSk7CiAgICAg ICAgIHJlc29sdmVDb2xvclNwYWNlKG1fYml0bWFwLmJpdG1hcCgpLCBjZ0NvbG9yU3BhY2UuZ2V0 KCkpOwo=