76478 2012-01-17 14:19:57 -0800 REGRESSION: iframes with composited contents are not transparent in WK1 2012-05-29 15:25:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser enne adele enne fpizlo jamesr simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 537350 0 simon.fraser 2012-01-17 14:19:57 -0800 The pixel result of compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html from DRT shows that the iframes are showing up as opaque white. This reproduces in a WK1 window in Safari. 537357 1 simon.fraser 2012-01-17 14:35:22 -0800 I think http://trac.webkit.org/changeset/92874 may have broken this. FrameView::useSlowRepaints() returns 'false' for iframes with composited content, but Widget::paint() (in WidgetMac) relies on [[scrollView contentView] copiesOnScroll] to decide when to turn off background drawing. 537361 2 webkit-bug-importer 2012-01-17 14:39:05 -0800 <rdar://problem/10710494> 537362 3 simon.fraser 2012-01-17 14:41:21 -0800 WidgetMac really needs to get at FrameView's m_contentIsOpaque bit, but that would be a layering violation. 614913 4 fpizlo 2012-05-02 18:36:06 -0700 The relevant test appears to pass as of r115915 614916 5 simon.fraser 2012-05-02 18:37:47 -0700 compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html is the iframe source, not the actual test. I probably meant compositing/iframes/repaint-after-losing-scrollbars.html. 614917 6 fpizlo 2012-05-02 18:38:19 -0700 (In reply to comment #5) > compositing/iframes/resources/repaint-after-losing-scrollbars-iframe.html is the iframe source, not the actual test. I probably meant compositing/iframes/repaint-after-losing-scrollbars.html. I figured that's what you meant, and that is indeed what I'm referring to. 614918 7 simon.fraser 2012-05-02 18:38:46 -0700 This still fails. enne, can you look at this? 617739 8 enne 2012-05-07 11:14:00 -0700 (In reply to comment #7) > This still fails. enne, can you look at this? Sure, I can take a look. 618169 9 140636 enne 2012-05-07 17:42:04 -0700 Created attachment 140636 Patch 618171 10 enne 2012-05-07 17:43:27 -0700 (In reply to comment #9) > Created an attachment (id=140636) [details] > Patch I am not happy with this, but am unsure about how else to handle this. I don't think it's correct to assume that !ScrollView::canBlitOnScroll() implies !FrameView::m_contentIsOpaque. It's also very strange to me that drawsBackground is true for something that shouldn't draw a background. That paint function is a pile of assumptions. 629620 11 enne 2012-05-21 15:40:26 -0700 smfr: ping 636442 12 enne 2012-05-29 14:31:24 -0700 (In reply to comment #11) > smfr: ping smfr: re-ping? You asked me to fix this three weeks ago, so I uploaded a patch. Was this something you wanted landed? Otherwise, maybe this issue should just be WONTFIXed. 636465 13 140636 simon.fraser 2012-05-29 14:47:20 -0700 Comment on attachment 140636 Patch Sorry for the delay. 636494 14 140636 webkit.review.bot 2012-05-29 15:25:03 -0700 Comment on attachment 140636 Patch Clearing flags on attachment: 140636 Committed r118840: <http://trac.webkit.org/changeset/118840> 636495 15 webkit.review.bot 2012-05-29 15:25:08 -0700 All reviewed patches have been landed. Closing bug. 140636 2012-05-07 17:42:04 -0700 2012-05-29 15:25:03 -0700 Patch bug-76478-20120507174203.patch text/plain 1627 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTRmNTRmMDU1YTU4OTU0 YWM2MTg4ZDNkYWJhNmIzYzliMzdlZTc4Ny4uMjY0MzQ0N2VhMTc2ZjFhYjI3ZDQwNjdlOGFhY2Mx YzM3MmRjNWE1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTA3ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4IHRyYW5zcGFyZW50 IGlmcmFtZXMgd2l0aCBjb21wb3NpdGVkIGNvbnRlbnRzIGluIFdLMSBvbiBNYWMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NDc4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcv aWZyYW1lcy9yZXBhaW50LWFmdGVyLWxvc2luZy1zY3JvbGxiYXJzLmh0bWwKKworICAgICAgICAq IHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6dXNlU2xv d1JlcGFpbnRzKToKKwogMjAxMi0wNS0wNCAgSmVmZnJleSBQZmF1ICA8anBmYXVAYXBwbGUuY29t PgogCiAgICAgICAgIFByZXZlbnQgZWFybHkgRXZlbnRMaXN0ZW5lciBkZWxldGlvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGJiZTJlODU3NzhhMjI2ZjU0MGI0YzIxYWZlMTE3OTk3 MDViYWI5NzYuLjIzMDU5ZTMxOGI4YmZmNDM2N2I5NDA3NDkwMDRjZjMyYjM4OTZhODQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTEyNjksNyArMTI2OSwxMSBAQCBib29sIEZyYW1l Vmlldzo6dXNlU2xvd1JlcGFpbnRzKGJvb2wgY29uc2lkZXJPdmVybGFwKSBjb25zdAogewogICAg IGJvb2wgbXVzdEJlU2xvdyA9IG1fc2xvd1JlcGFpbnRPYmplY3RDb3VudCA+IDAgfHwgKHBsYXRm b3JtV2lkZ2V0KCkgJiYgbV9maXhlZE9iamVjdENvdW50ID4gMCk7CiAKLSAgICBpZiAoY29udGVu dHNJbkNvbXBvc2l0ZWRMYXllcigpKQorICAgIC8vIEZJWE1FOiBXaWRnZXRNYWMubW0gbWFrZXMg dGhlIGFzc3VtcHRpb24gdGhhdCB1c2VTbG93UmVwYWludHMgPT0KKyAgICAvLyBtX2NvbnRlbnRJ c09wYXF1ZSwgc28gZG9uJ3QgdGFrZSB0aGUgZmFzdCBwYXRoIGZvciBjb21wb3NpdGVkIGxheWVy cworICAgIC8vIGlmIHRoZXkgYXJlIGEgcGxhdGZvcm0gd2lkZ2V0IGluIG9yZGVyIHRvIGdldCBw YWludGluZyBjb3JyZWN0bmVzcworICAgIC8vIGZvciB0cmFuc3BhcmVudCBsYXllcnMuIFNlZSB0 aGUgY29tbWVudCBpbiBXaWRnZXRNYWM6OnBhaW50LgorICAgIGlmIChjb250ZW50c0luQ29tcG9z aXRlZExheWVyKCkgJiYgIXBsYXRmb3JtV2lkZ2V0KCkpCiAgICAgICAgIHJldHVybiBtdXN0QmVT bG93OwogCiAjaWYgUExBVEZPUk0oQ0hST01JVU0pCg==