76477 2012-01-17 13:20:39 -0800 add test expections ahead of skia DEPS roll 2012-01-18 12:00:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 reed reed epoger senorblanco webkit.review.bot oldest_to_newest 537322 0 reed 2012-01-17 13:20:39 -0800 add test expections ahead of skia DEPS roll 537323 1 122804 reed 2012-01-17 13:23:33 -0800 Created attachment 122804 Patch 537349 2 122804 senorblanco 2012-01-17 14:16:58 -0800 Comment on attachment 122804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122804&action=review r=me, but a comment would be nice. > LayoutTests/platform/chromium/test_expectations.txt:1111 > +//BUGCR105305 MAC : fast/borders/border-image-rotate-transform.html = IMAGE Probably should add a comment here explaining why it's commented out. Is it still expected to be wrong after the skia roll? Or just wrong in a new way? If neither, it should just be removed. 537784 3 122804 webkit.review.bot 2012-01-18 05:01:33 -0800 Comment on attachment 122804 Patch Rejecting attachment 122804 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 NOBODY just expectations changes found in /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11282176 537835 4 122919 reed 2012-01-18 06:52:52 -0800 Created attachment 122919 Patch 537837 5 reed 2012-01-18 06:56:44 -0800 addressed comment in #2, added "Unreviewed" to ChangeLog 537931 6 122919 senorblanco 2012-01-18 09:38:50 -0800 Comment on attachment 122919 Patch Looks good. r=me 538047 7 122919 webkit.review.bot 2012-01-18 11:59:56 -0800 Comment on attachment 122919 Patch Clearing flags on attachment: 122919 Committed r105304: <http://trac.webkit.org/changeset/105304> 538048 8 webkit.review.bot 2012-01-18 12:00:00 -0800 All reviewed patches have been landed. Closing bug. 122804 2012-01-17 13:23:33 -0800 2012-01-18 06:52:49 -0800 Patch bug-76477-20120117162332.patch text/plain 3298 reed SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwNTE4NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTE3ICBNaWtlIFJlZWQgIDxyZWVk QGdvb2dsZS5jb20+CisKKyAgICAgICAgYWRkIHRlc3QgZXhwZWN0aW9ucyBhaGVhZCBvZiBza2lh IERFUFMgcm9sbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzY0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkganVzdCBleHBlY3RhdGlvbnMg Y2hhbmdlcworICAgICAgICBodHRwOi8vY29kZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVz L2RldGFpbD9pZD0xMTA0OTMKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dDoKKwogMjAxMi0wMS0xMiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5j b20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2 MTk3CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiAxMDUxMjcpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTExMDgs NyArMTEwOCw3IEBAIEJVR0NSMTA1MzA1IENQVSA6IHN2Zy9jdXN0b20vcGF0dGVybi13aXQKIEJV R0NSMTA1MzA1IExJTlVYIE1BQyBDUFUgOiBzdmcvdGV4dC90ZXh0LWdyYWRpZW50LXBvc2l0aW9u aW5nLnN2ZyA9IElNQUdFCiBCVUdDUjEwNTMwNSA6IHN2Zy90ZXh0L3NlbGVjdGlvbi1iYWNrZ3Jv dW5kLWNvbG9yLnhodG1sID0gUEFTUyBDUkFTSCBJTUFHRQogQlVHQ1IxMDUzMDUgOiBzdmcvdGV4 dC9zZWxlY3Rpb24tc3R5bGVzLnhodG1sID0gUEFTUyBDUkFTSCBJTUFHRQotQlVHQ1IxMDUzMDUg TUFDIDogZmFzdC9ib3JkZXJzL2JvcmRlci1pbWFnZS1yb3RhdGUtdHJhbnNmb3JtLmh0bWwgPSBJ TUFHRQorLy9CVUdDUjEwNTMwNSBNQUMgOiBmYXN0L2JvcmRlcnMvYm9yZGVyLWltYWdlLXJvdGF0 ZS10cmFuc2Zvcm0uaHRtbCA9IElNQUdFCiBCVUdDUjEwNTMwNSBNQUMgTElOVVggOiBzdmcvdHJh bnNmb3Jtcy90ZXh0LXdpdGgtcGF0dGVybi13aXRoLXN2Zy10cmFuc2Zvcm0uc3ZnID0gSU1BR0Ug UEFTUwogCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAtMTMxNiw3ICsxMzE2LDYgQEAgQlVHQ1IyMzQ4OCBNQUMg OiBmYXN0L2xheWVycy9sYXllci1jb250ZQogQlVHQ1IyMzQ4OCBNQUMgOiBmYXN0L2xheWVycy9y ZW1vdmUtbGF5ZXItd2l0aC1uZXN0ZWQtc3RhY2tpbmcuaHRtbCA9IElNQUdFCiBCVUdDUjIzNDg4 IExFT1BBUkQgOiBmYXN0L2xpc3RzL29sLXN0YXJ0LXBhcnNpbmcuaHRtbCA9IElNQUdFCiBCVUdD UjIzNDg4IExFT1BBUkQgOiBmYXN0L211bHRpY29sL3Bvc2l0aW9uZWQtd2l0aC1jb25zdHJhaW5l ZC1oZWlnaHQuaHRtbCA9IElNQUdFCi1CVUdDUjIzNDg4IE1BQyA6IHN2Zy90cmFuc2Zvcm1zL2Fu aW1hdGVkLXBhdGgtaW5zaWRlLXRyYW5zZm9ybWVkLWh0bWwueGh0bWwgPSBJTUFHRQogQlVHQ1Iy MzQ4OCBNQUMgOiB0YWJsZXMvbW96aWxsYV9leHBlY3RlZF9mYWlsdXJlcy9idWdzL2J1ZzE3ODg1 NS54bWwgPSBJTUFHRQogCiAvLyBMb29rcyB0aGUgc2FtZSB0byBtZS4uLiBodWguIFZhcmlhdGlv biBvZiBhYm92ZT8KQEAgLTE0NDEsNiArMTQ0MCwxMiBAQCBCVUdDUjIzNDczIE1BQyA6IGZhc3Qv cmVwYWludC90cmFuc2Zvcm0tCiAvLyBUaGlja2VyIHNoYWRvdyB0aGFuIGV4cGVjdGVkCiBCVUdD UjIzNDcxIExFT1BBUkQgOiBmYXN0L3RleHQvc3Ryb2tpbmcuaHRtbCA9IElNQUdFCiAKKy8vIFRv IGJlIHJlYmFzZWxpbmVkIGFmdGVyIHNraWEgcmV2LiAzMDM5IGxhbmRzCitCVUdDUjExMDQ5MyBD UFUgOiBmYXN0L2JhY2tncm91bmRzL3JlcGVhdC9uZWdhdGl2ZS1vZmZzZXQtcmVwZWF0LXRyYW5z Zm9ybWVkLmh0bWwgPSBJTUFHRQorQlVHQ1IxMTA0OTMgQ1BVIDogc3ZnL3RyYW5zZm9ybXMvYW5p bWF0ZWQtcGF0aC1pbnNpZGUtdHJhbnNmb3JtZWQtaHRtbC54aHRtbCA9IElNQUdFCitCVUdDUjEx MDQ5MyBDUFUgOiBmYXN0L2JvcmRlcnMvYm9yZGVyLWltYWdlLXJvdGF0ZS10cmFuc2Zvcm0uaHRt bCA9IElNQUdFCitCVUdDUjExMDQ5MyBDUFUgOiBzdmcvY3VzdG9tL2ZvY3VzLXJpbmcuc3ZnID0g SU1BR0UKKwogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KIC8vIEVORCBNQUMgUE9SVCBURVNUUwogLy8gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K QEAgLTI0NDEsMTAgKzI0NDYsNiBAQCBCVUdfWVVUQUsgTEVPUEFSRCA6IGZhc3QvaW1hZ2VzL2lt YWdlbWFwCiBCVUdfWVVUQUsgTElOVVggV0lOIDogZmFzdC9pbWFnZXMvaW1hZ2VtYXAtcG9seWdv bi1mb2N1cy1yaW5nLmh0bWwgPSBJTUFHRStURVhUCiBCVUdfWVVUQUsgTEVPUEFSRCA6IGZhc3Qv aW1hZ2VzL2ltYWdlbWFwLXBvbHlnb24tZm9jdXMtcmluZy5odG1sID0gSU1BR0UKIAotLy8gTmVl ZCB0byByZWJhc2VsaW5lIG5vdyB0aGF0IHdlIGFudGlhbGlhcyByb3RhdGVkIGltYWdlcwotQlVH Q1IzNjkwMiBMSU5VWCBXSU4gOiBmYXN0L2JvcmRlcnMvYm9yZGVyLWltYWdlLXJvdGF0ZS10cmFu c2Zvcm0uaHRtbCA9IElNQUdFCi1CVUdDUjM2OTAyIExJTlVYIFdJTiA6IHN2Zy9jdXN0b20vZm9j dXMtcmluZy5zdmcgPSBJTUFHRQotCiAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KIC8vIFJlZ3Jlc3Npb25z IGNhdXNlZCBieSBzd2l0Y2hpbmcgdG8gRFJULgogLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg== 122919 2012-01-18 06:52:52 -0800 2012-01-18 11:59:56 -0800 Patch bug-76477-20120118095251.patch text/plain 3219 reed SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwNTI3MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTE4ICBNaWtlIFJlZWQgIDxyZWVk QGdvb2dsZS5jb20+CisKKyAgICAgICAgYWRkIHRlc3QgZXhwZWN0aW9ucyBhaGVhZCBvZiBza2lh IERFUFMgcm9sbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzY0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFk6IFVucmV2aWV3ZWQKKyAgICAg ICAgc2VlIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lk PTExMDQ5MworCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0OgorCiAyMDEyLTAxLTE4ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4K IAogICAgICAgICBbUXRdIFVwZGF0ZSBhbm90aGVyIFNWRyBleHBlY3RlZCBhZnRlciByMTA1MjQ3 LgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dAkocmV2aXNpb24gMTA1MjI5KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xMTA4LDcg KzExMDgsNiBAQCBCVUdDUjEwNTMwNSBDUFUgOiBzdmcvY3VzdG9tL3BhdHRlcm4td2l0CiBCVUdD UjEwNTMwNSBMSU5VWCBNQUMgQ1BVIDogc3ZnL3RleHQvdGV4dC1ncmFkaWVudC1wb3NpdGlvbmlu Zy5zdmcgPSBJTUFHRQogQlVHQ1IxMDUzMDUgOiBzdmcvdGV4dC9zZWxlY3Rpb24tYmFja2dyb3Vu ZC1jb2xvci54aHRtbCA9IFBBU1MgQ1JBU0ggSU1BR0UKIEJVR0NSMTA1MzA1IDogc3ZnL3RleHQv c2VsZWN0aW9uLXN0eWxlcy54aHRtbCA9IFBBU1MgQ1JBU0ggSU1BR0UKLUJVR0NSMTA1MzA1IE1B QyA6IGZhc3QvYm9yZGVycy9ib3JkZXItaW1hZ2Utcm90YXRlLXRyYW5zZm9ybS5odG1sID0gSU1B R0UKIEJVR0NSMTA1MzA1IE1BQyBMSU5VWCA6IHN2Zy90cmFuc2Zvcm1zL3RleHQtd2l0aC1wYXR0 ZXJuLXdpdGgtc3ZnLXRyYW5zZm9ybS5zdmcgPSBJTUFHRSBQQVNTCiAKIC8vIC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBA IC0xMzE2LDcgKzEzMTUsNiBAQCBCVUdDUjIzNDg4IE1BQyA6IGZhc3QvbGF5ZXJzL2xheWVyLWNv bnRlCiBCVUdDUjIzNDg4IE1BQyA6IGZhc3QvbGF5ZXJzL3JlbW92ZS1sYXllci13aXRoLW5lc3Rl ZC1zdGFja2luZy5odG1sID0gSU1BR0UKIEJVR0NSMjM0ODggTEVPUEFSRCA6IGZhc3QvbGlzdHMv b2wtc3RhcnQtcGFyc2luZy5odG1sID0gSU1BR0UKIEJVR0NSMjM0ODggTEVPUEFSRCA6IGZhc3Qv bXVsdGljb2wvcG9zaXRpb25lZC13aXRoLWNvbnN0cmFpbmVkLWhlaWdodC5odG1sID0gSU1BR0UK LUJVR0NSMjM0ODggTUFDIDogc3ZnL3RyYW5zZm9ybXMvYW5pbWF0ZWQtcGF0aC1pbnNpZGUtdHJh bnNmb3JtZWQtaHRtbC54aHRtbCA9IElNQUdFCiBCVUdDUjIzNDg4IE1BQyA6IHRhYmxlcy9tb3pp bGxhX2V4cGVjdGVkX2ZhaWx1cmVzL2J1Z3MvYnVnMTc4ODU1LnhtbCA9IElNQUdFCiAKIC8vIExv b2tzIHRoZSBzYW1lIHRvIG1lLi4uIGh1aC4gVmFyaWF0aW9uIG9mIGFib3ZlPwpAQCAtMTQ0MSw2 ICsxNDM5LDEyIEBAIEJVR0NSMjM0NzMgTUFDIDogZmFzdC9yZXBhaW50L3RyYW5zZm9ybS0KIC8v IFRoaWNrZXIgc2hhZG93IHRoYW4gZXhwZWN0ZWQKIEJVR0NSMjM0NzEgTEVPUEFSRCA6IGZhc3Qv dGV4dC9zdHJva2luZy5odG1sID0gSU1BR0UKIAorLy8gVG8gYmUgcmViYXNlbGluZWQgYWZ0ZXIg c2tpYSByZXYuIDMwMzkgbGFuZHMKK0JVR0NSMTEwNDkzIENQVSA6IGZhc3QvYmFja2dyb3VuZHMv cmVwZWF0L25lZ2F0aXZlLW9mZnNldC1yZXBlYXQtdHJhbnNmb3JtZWQuaHRtbCA9IElNQUdFCitC VUdDUjExMDQ5MyBDUFUgOiBzdmcvdHJhbnNmb3Jtcy9hbmltYXRlZC1wYXRoLWluc2lkZS10cmFu c2Zvcm1lZC1odG1sLnhodG1sID0gSU1BR0UKK0JVR0NSMTEwNDkzIENQVSA6IGZhc3QvYm9yZGVy cy9ib3JkZXItaW1hZ2Utcm90YXRlLXRyYW5zZm9ybS5odG1sID0gSU1BR0UKK0JVR0NSMTEwNDkz IENQVSA6IHN2Zy9jdXN0b20vZm9jdXMtcmluZy5zdmcgPSBJTUFHRQorCiAvLyAtLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog Ly8gRU5EIE1BQyBQT1JUIFRFU1RTCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpAQCAtMjQ0MSwxMCArMjQ0NSw2IEBA IEJVR19ZVVRBSyBMRU9QQVJEIDogZmFzdC9pbWFnZXMvaW1hZ2VtYXAKIEJVR19ZVVRBSyBMSU5V WCBXSU4gOiBmYXN0L2ltYWdlcy9pbWFnZW1hcC1wb2x5Z29uLWZvY3VzLXJpbmcuaHRtbCA9IElN QUdFK1RFWFQKIEJVR19ZVVRBSyBMRU9QQVJEIDogZmFzdC9pbWFnZXMvaW1hZ2VtYXAtcG9seWdv bi1mb2N1cy1yaW5nLmh0bWwgPSBJTUFHRQogCi0vLyBOZWVkIHRvIHJlYmFzZWxpbmUgbm93IHRo YXQgd2UgYW50aWFsaWFzIHJvdGF0ZWQgaW1hZ2VzCi1CVUdDUjM2OTAyIExJTlVYIFdJTiA6IGZh c3QvYm9yZGVycy9ib3JkZXItaW1hZ2Utcm90YXRlLXRyYW5zZm9ybS5odG1sID0gSU1BR0UKLUJV R0NSMzY5MDIgTElOVVggV0lOIDogc3ZnL2N1c3RvbS9mb2N1cy1yaW5nLnN2ZyA9IElNQUdFCi0K IC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLwogLy8gUmVncmVzc2lvbnMgY2F1c2VkIGJ5IHN3aXRjaGluZyB0 byBEUlQuCiAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8K