76467 2012-01-17 11:38:12 -0800 [Mac] Add a flag telling plug-in if it can enter sandbox 2012-03-07 16:13:54 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca mjs oldest_to_newest 537234 0 ap 2012-01-17 11:38:12 -0800 A plug-in cannot know if it's running in a process that would tolerate entering sandbox. Let's tell it (a Mac only experiment for now). 537237 1 122789 ap 2012-01-17 11:39:40 -0800 Created attachment 122789 proposed patch 537270 2 122789 andersca 2012-01-17 12:10:16 -0800 Comment on attachment 122789 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=122789&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:503 > + case WKNVAllowedToEnterSandbox: > + *(NPBool*)value = true; > + break; Shouldn't this be true only when running in the plug-in process? (Not that it really matters since we don't support in-process plug-ins with WebKit2). 537278 3 ap 2012-01-17 12:17:02 -0800 > we don't support in-process plug-ins with WebKit2 Yes, this is why I made it always return true. Was there a better way to write this? 573340 4 ap 2012-03-07 16:13:54 -0800 This has been landed long ago in <http://trac.webkit.org/changeset/105323>. 122789 2012-01-17 11:39:40 -0800 2012-01-17 12:10:16 -0800 proposed patch PluginSandboxFlag.txt text/plain 1755 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTE3OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAxLTE3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIEFkZCBhIGZsYWcg dGVsbGluZyBwbHVnLWluIGlmIGl0IGNhbiBlbnRlciBzYW5kYm94CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjQ2NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL05ldHNjYXBlQnJvd3NlckZ1bmNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TlBOX0dldFZh bHVlKTogQWRkZWQgYSBwcml2YXRlIGZsYWcuCisKIDIwMTItMDEtMTcgIE1hcnRpbiBSb2JpbnNv biAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFtXSzJdIFdlYktpdFBy aXZhdGUgc2hvdWxkIGluY2x1ZGUgdGhlIGVudGlyZSBXZWJLaXQyIEMgQVBJCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVu Y3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAJKHJldmlzaW9uIDEwNTA3NCkKKysrIFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJG dW5jcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwOCw2ICs0MDgsOSBAQCBzdGF0aWMgY29uc3Qg dW5zaWduZWQgV0tOVlN1cHBvcnRzQ29tcG9zCiAvLyBXaGV0aGVyIHRoZSBicm93c2VyIGV4cGVj dHMgYSBub24tcmV0YWluZWQgQ29yZSBBbmltYXRpb24gbGF5ZXIuCiBzdGF0aWMgY29uc3QgdW5z aWduZWQgV0tOVkV4cGVjdHNOb25yZXRhaW5lZExheWVyID0gNzQ2NTc7CiAKKy8vIFdoZXRoZXIg cGx1Zy1pbiBjb2RlIGlzIGFsbG93ZWQgdG8gZW50ZXIgKGFyYml0cmFyeSkgc2FuZGJveCBmb3Ig dGhlIHByb2Nlc3MuCitzdGF0aWMgY29uc3QgdW5zaWduZWQgV0tOVkFsbG93ZWRUb0VudGVyU2Fu ZGJveCA9IDc0NjU4OworCiAvLyBUaGUgQ29yZSBBbmltYXRpb24gcmVuZGVyIHNlcnZlciBwb3J0 Lgogc3RhdGljIGNvbnN0IHVuc2lnbmVkIFdLTlZDQUxheWVyUmVuZGVyU2VydmVyUG9ydCA9IDcx ODc5OwogCkBAIC00OTUsNiArNDk4LDEwIEBAIHN0YXRpYyBOUEVycm9yIE5QTl9HZXRWYWx1ZShO UFAgbnBwLCBOUE4KICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKKyAgICAgICAgY2Fz ZSBXS05WQWxsb3dlZFRvRW50ZXJTYW5kYm94OgorICAgICAgICAgICAgKihOUEJvb2wqKXZhbHVl ID0gdHJ1ZTsKKyAgICAgICAgICAgIGJyZWFrOworCiAjaWZuZGVmIE5QX05PX1FVSUNLRFJBVwog ICAgICAgICBjYXNlIE5QTlZzdXBwb3J0c1F1aWNrRHJhd0Jvb2w6CiAgICAgICAgICAgICAvLyBX ZSBkb24ndCBzdXBwb3J0IHRoZSBRdWlja0RyYXcgZHJhd2luZyBtb2RlbC4K