76463 2012-01-17 09:25:47 -0800 [Qt] Debug build fails with debug qt5 2012-01-17 16:11:14 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned webkit.review.bot oldest_to_newest 537155 0 ostap73 2012-01-17 09:25:47 -0800 After this commit https://qt.gitorious.org/qt/qtbase/commit/14b929e9c448f2cc74fa047aaf8af283b81fbaf9 debug build of qt webkit fails if built with debug version of qt5. In file included from ../../../../qt5trunk/qtbase/include/QtCore/qglobal.h:1:0, from ../../../Source/WebCore/platform/graphics/IntSize.h:44, from ../../../Source/WebCore/platform/DragImage.h:29, from ../../../Source/WebCore/page/Frame.h:33, from ../../../Source/WebCore/loader/FrameNetworkingContext.h:23, from ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.h:23, from ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:22: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/global/qglobal.h: In instantiation of ‘QTypeInfo<QNetworkCookie>’: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:413:5: instantiated from ‘void QList<T>::node_destruct(QList<T>::Node*, QList<T>::Node*) [with T = QNetworkCookie]’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:739:5: instantiated from ‘void QList<T>::dealloc(QListData::Data*) [with T = QNetworkCookie]’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:715:9: instantiated from ‘QList<T>::~QList() [with T = QNetworkCookie]’ ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:68:95: instantiated from here ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/global/qglobal.h:2049:5: error: invalid application of ‘sizeof’ to incomplete type ‘QNetworkCookie’ cc1plus: warnings being treated as errors In file included from ../../../../qt5trunk/qtbase/include/QtCore/qlist.h:1:0, from ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/kernel/qobject.h:50, from ../../../../qt5trunk/qtbase/include/QtCore/qobject.h:1, from ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/io/qiodevice.h:46, from ../../../../qt5trunk/qtbase/include/QtCore/qiodevice.h:1, from ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/io/qdatastream.h:46, from ../../../../qt5trunk/qtbase/include/QtCore/qdatastream.h:1, from ../../../../qt5trunk/qtbase/include/QtCore/QDataStream:1, from ../../../Source/WebCore/platform/graphics/IntPoint.h:33, from ../../../Source/WebCore/platform/graphics/FloatSize.h:31, from ../../../Source/WebCore/platform/DragImage.h:30, from ../../../Source/WebCore/page/Frame.h:33, from ../../../Source/WebCore/loader/FrameNetworkingContext.h:23, from ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.h:23, from ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:22: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h: In member function ‘void QList<T>::node_destruct(QList<T>::Node*, QList<T>::Node*) [with T = QNetworkCookie]’: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:739:5: instantiated from ‘void QList<T>::dealloc(QListData::Data*) [with T = QNetworkCookie]’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:715:9: instantiated from ‘QList<T>::~QList() [with T = QNetworkCookie]’ ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:68:95: instantiated from here ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:414:27: error: possible problem detected in invocation of delete operator: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:414:27: error: invalid use of incomplete type ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtNetwork/../../src/network/access/qnetworkaccessmanager.h:58:7: error: forward declaration of ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:414:27: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined. ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:416:28: error: invalid use of incomplete type ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtNetwork/../../src/network/access/qnetworkaccessmanager.h:58:7: error: forward declaration of ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h: In member function ‘void QList<T>::node_copy(QList<T>::Node*, QList<T>::Node*, QList<T>::Node*) [with T = QNetworkCookie]’: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:694:9: instantiated from ‘void QList<T>::detach_helper(int) [with T = QNetworkCookie]’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:708:5: instantiated from ‘void QList<T>::detach_helper() [with T = QNetworkCookie]’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:118:80: instantiated from ‘QList<T>::QList(const QList<T>&) [with T = QNetworkCookie]’ ../../../Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:68:95: instantiated from here ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:382:17: error: invalid use of incomplete type ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtNetwork/../../src/network/access/qnetworkaccessmanager.h:58:7: error: forward declaration of ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:388:17: error: possible problem detected in invocation of delete operator: ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:388:17: error: invalid use of incomplete type ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtNetwork/../../src/network/access/qnetworkaccessmanager.h:58:7: error: forward declaration of ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:388:17: note: neither the destructor nor the class-specific operator delete will be called, even if they are declared when the class is defined. ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:395:17: error: invalid use of incomplete type ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtNetwork/../../src/network/access/qnetworkaccessmanager.h:58:7: error: forward declaration of ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtCore/../../src/corelib/tools/qlist.h:401:17: error: invalid use of incomplete type ‘struct QNetworkCookie’ ../../../../qt5trunk/qtbase/include/QtNetwork/../../src/network/access/qnetworkaccessmanager.h:58:7: error: forward declaration of ‘struct QNetworkCookie’ make[2]: *** [obj/debug/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.o] Error 1 make[2]: Leaving directory `/home/sl/work/webkit2/WebKitBuild/Debug/Source' make[1]: *** [sub-api-pri-make_default-ordered] Error 2 make[1]: Leaving directory `/home/sl/work/webkit2/WebKitBuild/Debug/Source' make: *** [sub-Source-QtWebKit-pro-make_default-ordered] Error 2 537162 1 122778 ostap73 2012-01-17 09:36:35 -0800 Created attachment 122778 Add missing include to satisfy sizeof in QTypeInfo. 537423 2 122778 webkit.review.bot 2012-01-17 16:11:10 -0800 Comment on attachment 122778 Add missing include to satisfy sizeof in QTypeInfo. Clearing flags on attachment: 122778 Committed r105206: <http://trac.webkit.org/changeset/105206> 537424 3 webkit.review.bot 2012-01-17 16:11:14 -0800 All reviewed patches have been landed. Closing bug. 122778 2012-01-17 09:36:35 -0800 2012-01-17 16:11:10 -0800 Add missing include to satisfy sizeof in QTypeInfo. missing_QNetworkCookie_fix_01.diff text/plain 2108 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cKaW5kZXggNjMzNTY5NC4uMzVkN2Q4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMi0wMS0xNyAgVmlhdGNoZXNsYXYgT3N0YXBlbmtvICA8b3N0YXBlbmtv LnZpYXRjaGVzbGF2QG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIERlYnVnIGJ1aWxkIGZhaWxz IHdpdGggZGVidWcgcXQ1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NjQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBRTmV0d29ya0Nvb2tpZSBpbmNsdWRlIGluIG9yZGVyIHRvIHNhdGlzZnkgc2l6 ZW9mIGluIFFUeXBlSW5mbyBpbiBkZWJ1ZyBidWlsZHMuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0UXQuY3BwOgorCiAyMDEyLTAxLTEzICBNYXJjZWxv IExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdIEZpeCBt aXNzaW5nIHNpZ25hbCBpbiBxd2ViZnJhbWUgQVBJIHRlc3QgZm9yIFF0NQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250ZXh0UXQu Y3BwIGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZU5ldHdvcmtpbmdDb250 ZXh0UXQuY3BwCmluZGV4IDAyYjY0YTQuLjdlOTk2MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVOZXR3b3JraW5nQ29udGV4dFF0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTmV0d29ya2luZ0NvbnRleHRRdC5j cHAKQEAgLTI1LDYgKzI1LDcgQEAKICNpbmNsdWRlICJxd2ViZnJhbWVfcC5oIgogI2luY2x1ZGUg InF3ZWJwYWdlLmgiCiAjaW5jbHVkZSA8UU5ldHdvcmtBY2Nlc3NNYW5hZ2VyPgorI2luY2x1ZGUg PFFOZXR3b3JrQ29va2llPgogI2luY2x1ZGUgPFFOZXR3b3JrQ29va2llSmFyPgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggMDA1MzYzYi4uNGFlMzFlMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAxLTE3ICBWaWF0Y2hl c2xhdiBPc3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAg ICAgIFtRdF0gRGVidWcgYnVpbGQgZmFpbHMgd2l0aCBkZWJ1ZyBxdDUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2NDYzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFFOZXR3b3JrQ29va2llIGluY2x1 ZGUgaW4gb3JkZXIgdG8gc2F0aXNmeSBzaXplb2YgaW4gUVR5cGVJbmZvIGluIGRlYnVnIGJ1aWxk cy4KKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvY29va2llamFyLmg6CisKIDIwMTItMDEtMTcg IFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAgICAg IFtRdF0gRG9uJ3Qgc2V0IHRoZSAncHJpbWFyeScgZmxhZyB3aGVuIG1vY2tpbmcgdG91Y2gtcG9p bnRzIGluIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL2Nvb2tp ZWphci5oIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9jb29raWVqYXIuaAppbmRleCBhZDZiZDNjLi42 ZTVlNzNiIDEwMDY0NAotLS0gYS9Ub29scy9RdFRlc3RCcm93c2VyL2Nvb2tpZWphci5oCisrKyBi L1Rvb2xzL1F0VGVzdEJyb3dzZXIvY29va2llamFyLmgKQEAgLTI5LDYgKzI5LDcgQEAKICNkZWZp bmUgY29va2llamFyX2gKIAogI2luY2x1ZGUgPFFGaWxlPgorI2luY2x1ZGUgPFFOZXR3b3JrQ29v a2llPgogI2luY2x1ZGUgPFFOZXR3b3JrQ29va2llSmFyPgogI2luY2x1ZGUgPFFUaW1lcj4KIAo=