76445 2012-01-17 05:11:15 -0800 [Qt] build-webkit does not detect the number of CPUs 2012-02-28 08:27:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 sh4.seo webkit-unassigned allan.jensen hausmann ossy vestbo webkit.review.bot oldest_to_newest 537031 0 sh4.seo 2012-01-17 05:11:15 -0800 https://bugs.webkit.org/show_bug.cgi?id=41469 for Qt. 537042 1 allan.jensen 2012-01-17 06:07:55 -0800 Is it really necessary, and how would it work with icecc? I personally just build with MAKEFLAGS=-j24 Tools/Scripts/build-webkit --qt 537044 2 sh4.seo 2012-01-17 06:12:37 -0800 1. It is a better default. 2. The patch will set -jN only if --makeargs is absent. This is what other ports do, and I think icecc will work fine. 537597 3 122866 sh4.seo 2012-01-17 20:33:53 -0800 Created attachment 122866 Patch 537695 4 hausmann 2012-01-18 01:08:06 -0800 Nice idea. Tor Arne, Ossy, what do you think? 537705 5 122866 ossy 2012-01-18 01:21:31 -0800 Comment on attachment 122866 Patch The idea is absolutely good, but now it would overload out buildbot servers. We run 3-4 bots on all machine with -jXXX set with MAKEFLAGS environment. It think we should move forward to GTK way. You can set -jXXX manually to add it to WebKitMakeArguments environment variable. If you don't do it, numberOfCPUs() is the default value. Please don't land the fix before we fix our bots. 537706 6 ossy 2012-01-18 01:25:08 -0800 (In reply to comment #1) > Is it really necessary, and how would it work with icecc? > > I personally just build with MAKEFLAGS=-j24 Tools/Scripts/build-webkit --qt I'm not sure what happens after this patch when MAKEFLAGS is set ... for example: MAKEFLAGS=-j24 make -j8 Which one is stronger? It would be great if build-webkit will respect MAKEFLAGS too. 537707 7 vestbo 2012-01-18 01:30:45 -0800 (In reply to comment #6) > (In reply to comment #1) > > Is it really necessary, and how would it work with icecc? > > > > I personally just build with MAKEFLAGS=-j24 Tools/Scripts/build-webkit --qt > > I'm not sure what happens after this patch when MAKEFLAGS is set ... > for example: MAKEFLAGS=-j24 make -j8 > > Which one is stronger? It would be great if build-webkit will respect MAKEFLAGS too. It has to. I'm fine with adding logic pass -j if it's not set anywhere else, but it shouldn't break the setup of people who set MAKEFLAGS and friends in their bash/zshrc, eg. 547094 8 124954 jbadics 2012-02-01 08:27:22 -0800 Created attachment 124954 proposed patch Automatically determine the number of CPUs for make only if this -j argument haven't already been specified. 547136 9 124954 vestbo 2012-02-01 09:45:01 -0800 Comment on attachment 124954 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=124954&action=review good stuff, a few comments: > Tools/Scripts/webkitdirs.pm:2089 > + if ($makeargs !~ /-j/i && (!defined $ENV{"MAKEFLAGS"} || ($ENV{"MAKEFLAGS"} !~ /-j/i ))){ Slight style (missing space before {), and the regex will trigger on stuff like --just-print as well. build-webkit uses -j\s*\d+ 549873 10 125608 jbadics 2012-02-06 03:08:54 -0800 Created attachment 125608 proposed patch Added whitespace character before '{' and modified the regex to match only the desired keywords. 549883 11 125611 jbadics 2012-02-06 03:49:24 -0800 Created attachment 125611 proposed patch fixed the second regex too 554179 12 125611 eric 2012-02-10 10:31:24 -0800 Comment on attachment 125611 proposed patch Entertaining. There is also code for this in webkitpy/common/ports.py 566676 13 125611 ossy 2012-02-28 07:53:33 -0800 Comment on attachment 125611 proposed patch LGTM, r=me. >(From update of attachment 125611 [details]) >Entertaining. There is also code for this in webkitpy/common/ports.py I don't think if it is entartaining, but a necessary change, because Tools/Scripts/build-webkit doesn't use webkitpy/common/ports.py , but many developers and bots use build-webkit script. 566703 14 125611 webkit.review.bot 2012-02-28 08:27:24 -0800 Comment on attachment 125611 proposed patch Clearing flags on attachment: 125611 Committed r109108: <http://trac.webkit.org/changeset/109108> 566704 15 webkit.review.bot 2012-02-28 08:27:30 -0800 All reviewed patches have been landed. Closing bug. 122866 2012-01-17 20:33:53 -0800 2012-01-18 01:21:31 -0800 Patch bug-76445-20120118133306.patch text/plain 1082 sh4.seo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNTI0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAxLTE3ICBTZW8gU2FuZ2h5ZW9uICA8c2g0LnNlb0BzYW1zdW5nLmNv bT4KKworICAgICAgICBbUXRdIGJ1aWxkLXdlYmtpdCBkb2VzIG5vdCBkZXRlY3QgdGhlIG51bWJl ciBvZiBDUFVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NjQ0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRRTWFrZVByb2plY3QpOiBV c2UgbnVtYmVyT2ZDUFVzIHRvIGRldGVybWluZSB0aGUgYXJndW1lbnQKKyAgICAgICAgdG8gcGFz cyB0byBtYWtlIGZvciBkb2luZyBwYXJhbGxlbCBidWlsZC4KKwogMjAxMi0wMS0xNyAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEVuYWJsZSB0ZXN0cyBvbiB0aGUg bWFjLWV3cwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTA1MjM5KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yMDM4LDYgKzIwMzgsOCBA QCBzdWIgYnVpbGRRTWFrZVByb2plY3QoJEApCiAgICAgICAgIH0KICAgICB9CiAKKyAgICAkbWFr ZWFyZ3MgPSAiLWoiIC4gbnVtYmVyT2ZDUFVzKCkgaWYgbm90ICRtYWtlYXJnczsKKwogICAgIG15 ICRxbWFrZXBhdGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKHNvdXJjZURpcigpLCAiVG9vbHMiLCAi cW1ha2UiKTsKICAgICBteSAkcW1ha2Vjb21tYW5kOwogICAgIGlmIChpc1dpbmRvd3MoKSkgewo= 124954 2012-02-01 08:27:22 -0800 2012-02-06 03:08:54 -0800 proposed patch webkitdirspm_20120201.patch text/plain 1363 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZjg0 MTVjLi5iMDc4ZmY5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMDEgIErDoW5vcyBCYWRpY3MgIDxkaWNz a2FAZ21haWwuY29tPgorCisgICAgICAgIFtRdF0gYnVpbGQtd2Via2l0IGRvZXMgbm90IGRldGVj dCB0aGUgbnVtYmVyIG9mIENQVXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc2NDQ1CisKKyAgICAgICAgQmFzZWQgb24gU2VvIFNhbmdoeWVvbidzIHdv cmsgKG1vZGlmaWNhdGlvbjoKKyAgICAgICAgQXV0b21hdGljYWxseSBkZXRlcm1pbmUgdGhlIG51 bWJlciBvZiBDUFVzIGZvciBtYWtlCisgICAgICAgIG9ubHkgaWYgLWogbWFrZSBhcmd1bWVudCBo YXZlbid0IGFscmVhZHkgYmVlbiBzcGVjaWZpZWQuKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAg ICAoYnVpbGRRTWFrZVByb2plY3RzKToKKwogMjAxMi0wMS0yNiAgSGFucyBXZW5uYm9yZyAgPGhh bnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNwZWVjaCBJbnB1dDogbW92ZSBNb2NrU3BlZWNo SW5wdXRDbGllbnQgaW50byBDaHJvbWl1bSBEdW1wUmVuZGVyVHJlZSBpbXBsZW1lbnRhdGlvbgpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCmluZGV4IGU4ZmUzZDIuLjEyNGNlM2UgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAg LTIwODUsNiArMjA4NSwxMSBAQCBzdWIgYnVpbGRRTWFrZVByb2plY3RzCiAgICAgICAgIH0KICAg ICB9CiAKKyAgICAjIEF1dG9tYXRpY2FsbHkgZGV0ZXJtaW5lIHRoZSBudW1iZXIgb2YgQ1BVcyBm b3IgbWFrZSBvbmx5IGlmIHRoaXMgbWFrZSBhcmd1bWVudCBoYXZlbid0IGFscmVhZHkgYmVlbiBz cGVjaWZpZWQuCisgICAgaWYgKCRtYWtlYXJncyAhfiAvLWovaSAmJiAoIWRlZmluZWQgJEVOVnsi TUFLRUZMQUdTIn0gfHwgKCRFTlZ7Ik1BS0VGTEFHUyJ9ICF+IC8tai9pICkpKXsKKyAgICAgICAg JG1ha2VhcmdzIC49ICIgLWoiIC4gbnVtYmVyT2ZDUFVzKCk7CisgICAgfQorCiAgICAgbXkgJHFt YWtlcGF0aCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoc291cmNlRGlyKCksICJUb29scyIsICJxbWFr ZSIpOwogICAgIG15ICRxbWFrZWNvbW1hbmQ7CiAgICAgaWYgKGlzV2luZG93cygpKSB7Cg== 125608 2012-02-06 03:08:54 -0800 2012-02-06 03:49:24 -0800 proposed patch webkitdirspm_20120206.patch text/plain 1352 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMmY4 YzE3Li40NGMyNjkyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMDYgIErDoW5vcyBCYWRpY3MgIDxkaWNz a2FAZ21haWwuY29tPgorCisgICAgICAgIFtRdF0gYnVpbGQtd2Via2l0IGRvZXMgbm90IGRldGVj dCB0aGUgbnVtYmVyIG9mIENQVXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc2NDQ1CisKKyAgICAgICAgQmFzZWQgb24gU2VvIFNhbmdoeWVvbidzIHdv cmsgKG1vZGlmaWNhdGlvbjoKKyAgICAgICAgQXV0b21hdGljYWxseSBkZXRlcm1pbmUgdGhlIG51 bWJlciBvZiBDUFVzIGZvciBtYWtlCisgICAgICAgIG9ubHkgaWYgLWogbWFrZSBhcmd1bWVudCBo YXZlbid0IGFscmVhZHkgYmVlbiBzcGVjaWZpZWQuKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAg ICAoYnVpbGRRTWFrZVByb2plY3RzKToKKwogMjAxMi0wMi0wMiAgSm9jaGVuIEVpc2luZ2VyICA8 am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIGFkZCBzdXBwb3J0IGZv ciAtLW1ha2VhcmdzIHRvIHRoZSBuaW5qYS1iYXNlZCBidWlsZApkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IGViMjI1MjMuLmM2ZTc0NGUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIwODUsNiArMjA4NSwxMSBA QCBzdWIgYnVpbGRRTWFrZVByb2plY3RzCiAgICAgICAgIH0KICAgICB9CiAKKyAgICAjIEF1dG9t YXRpY2FsbHkgZGV0ZXJtaW5lIHRoZSBudW1iZXIgb2YgQ1BVcyBmb3IgbWFrZSBvbmx5IGlmIHRo aXMgbWFrZSBhcmd1bWVudCBoYXZlbid0IGFscmVhZHkgYmVlbiBzcGVjaWZpZWQuCisgICAgaWYg KCRtYWtlYXJncyAhfiAvLWpccypcZCsvaSAmJiAoIWRlZmluZWQgJEVOVnsiTUFLRUZMQUdTIn0g fHwgKCRFTlZ7Ik1BS0VGTEFHUyJ9ICF+IC8tai9pICkpKSB7CisgICAgICAgICRtYWtlYXJncyAu PSAiIC1qIiAuIG51bWJlck9mQ1BVcygpOworICAgIH0KKwogICAgIG15ICRxbWFrZXBhdGggPSBG aWxlOjpTcGVjLT5jYXRmaWxlKHNvdXJjZURpcigpLCAiVG9vbHMiLCAicW1ha2UiKTsKICAgICBt eSAkcW1ha2Vjb21tYW5kOwogICAgIGlmIChpc1dpbmRvd3MoKSkgewo= 125611 2012-02-06 03:49:24 -0800 2012-02-28 08:27:24 -0800 proposed patch webkitdirspm_20120206.patch text/plain 1358 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMmY4 YzE3Li40NGMyNjkyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDItMDYgIErDoW5vcyBCYWRpY3MgIDxkaWNz a2FAZ21haWwuY29tPgorCisgICAgICAgIFtRdF0gYnVpbGQtd2Via2l0IGRvZXMgbm90IGRldGVj dCB0aGUgbnVtYmVyIG9mIENQVXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTc2NDQ1CisKKyAgICAgICAgQmFzZWQgb24gU2VvIFNhbmdoeWVvbidzIHdv cmsgKG1vZGlmaWNhdGlvbjoKKyAgICAgICAgQXV0b21hdGljYWxseSBkZXRlcm1pbmUgdGhlIG51 bWJlciBvZiBDUFVzIGZvciBtYWtlCisgICAgICAgIG9ubHkgaWYgLWogbWFrZSBhcmd1bWVudCBo YXZlbid0IGFscmVhZHkgYmVlbiBzcGVjaWZpZWQuKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAg ICAoYnVpbGRRTWFrZVByb2plY3RzKToKKwogMjAxMi0wMi0wMiAgSm9jaGVuIEVpc2luZ2VyICA8 am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIGFkZCBzdXBwb3J0IGZv ciAtLW1ha2VhcmdzIHRvIHRoZSBuaW5qYS1iYXNlZCBidWlsZApkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IGViMjI1MjMuLmM2ZTc0NGUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIwODUsNiArMjA4NSwxMSBA QCBzdWIgYnVpbGRRTWFrZVByb2plY3RzCiAgICAgICAgIH0KICAgICB9CiAKKyAgICAjIEF1dG9t YXRpY2FsbHkgZGV0ZXJtaW5lIHRoZSBudW1iZXIgb2YgQ1BVcyBmb3IgbWFrZSBvbmx5IGlmIHRo aXMgbWFrZSBhcmd1bWVudCBoYXZlbid0IGFscmVhZHkgYmVlbiBzcGVjaWZpZWQuCisgICAgaWYg KCRtYWtlYXJncyAhfiAvLWpccypcZCsvaSAmJiAoIWRlZmluZWQgJEVOVnsiTUFLRUZMQUdTIn0g fHwgKCRFTlZ7Ik1BS0VGTEFHUyJ9ICF+IC8talxzKlxkKy9pICkpKSB7CisgICAgICAgICRtYWtl YXJncyAuPSAiIC1qIiAuIG51bWJlck9mQ1BVcygpOworICAgIH0KKwogICAgIG15ICRxbWFrZXBh dGggPSBGaWxlOjpTcGVjLT5jYXRmaWxlKHNvdXJjZURpcigpLCAiVG9vbHMiLCAicW1ha2UiKTsK ICAgICBteSAkcW1ha2Vjb21tYW5kOwogICAgIGlmIChpc1dpbmRvd3MoKSkgewo=