76397 2012-01-16 11:58:19 -0800 HRTFPanner not rendering correctly on mac port 2012-01-19 09:53:00 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers jer.noble crogers eric.carlson jer.noble pnormand webkit.review.bot oldest_to_newest 536694 0 crogers 2012-01-16 11:58:19 -0800 Steps to reproduce 1. Visit http://chromium.googlecode.com/svn/trunk/samples/audio/simple.html 2. Move the red dot around the center. The panning is no longer smooth, but jumps around erratically. I believe this was likely caused by: http://trac.webkit.org/changeset/104859 It sounds like the azimuth and elevation are reversed, but it may be a different problem. This may also be an issue on the GTK port where this code has also been used for awhile. Unfortunately, we currently have no layout test for HRTFPanner... 536722 1 jer.noble 2012-01-16 13:04:29 -0800 Is it possible the bug is in the way that Composite.wav was generated? Should generating Composite.wav be a compile-time step? 536730 2 crogers 2012-01-16 13:16:58 -0800 You may want to try a quick test to see if it's simply that the ordering of the azimuth and elevations are reversed. In HRTFElevation.cpp check out: // The concatenated impulse response is a bus containing all // the elevations per azimuth, for all azimuths by increasing // order. So for a given azimuth and elevation we need to compute // the index of the wanted audio frames in the concatenated table. unsigned index = ((azimuth / AzimuthSpacing) * HRTFDatabase::NumberOfRawElevations) + elevationIndex; If you try reversing the roles of azimuth and elevation, it *might* fix the problem - worth checking Philippe? 536740 3 jer.noble 2012-01-16 13:45:07 -0800 I regenerated the composite file, and that appeared to take care of the erratic sound. Here's the command I used: sox $( \ for azimuth in {0..23}; do \ for elevation in 315 330 345 0 15 30 45 60 75 90; do \ printf "IRC_Composite_C_R0195_T%03d_P%03d.wav\n" "$(expr $azimuth \* 15)" "$elevation"; \ done; \ done;) \ Composite.wav 536741 4 jer.noble 2012-01-16 13:46:05 -0800 So it appears the root of the problem is that the description of the Composite.wav file inside HRTFElevation.cpp doesn't match the generated Composite.wav. This could be as easy a fix as committing a new Composite.wav. 536742 5 crogers 2012-01-16 13:50:07 -0800 Sounds reasonable to me. 536744 6 122680 jer.noble 2012-01-16 13:53:15 -0800 Created attachment 122680 Patch 536747 7 jer.noble 2012-01-16 13:55:49 -0800 You can check the Composite.wav file by downloading it and placing it in the appropriate location. (At least on the mac, this means in WebCore.framework/Resources/audio/Composite.wav. Other ports may add this file as a resource during compile time.) 536830 8 122680 eric.carlson 2012-01-16 17:46:03 -0800 Comment on attachment 122680 Patch rs=me 536915 9 pnormand 2012-01-17 00:11:20 -0800 Thanks for taking care of this issue! I indeed wrongly generated Composite.wav :( 538603 10 pnormand 2012-01-19 03:51:56 -0800 Jer, do you plan to land this or can we use the cq? 538742 11 jer.noble 2012-01-19 08:45:25 -0800 Sorry, yes, the cq is fine. 538773 12 122680 webkit.review.bot 2012-01-19 09:52:53 -0800 Comment on attachment 122680 Patch Clearing flags on attachment: 122680 Committed r105421: <http://trac.webkit.org/changeset/105421> 538774 13 webkit.review.bot 2012-01-19 09:53:00 -0800 All reviewed patches have been landed. Closing bug. 122680 2012-01-16 13:53:15 -0800 2012-01-19 09:52:53 -0800 Patch bug-76397-20120116135314.patch text/plain 2990 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGI4ODVmZDU3YTVkOGI5 M2E2MDM4OGI2NTAwNmViOGYwOTNkMzFmNC4uNWVlMDJkM2Y5MDc0NGJmODJlODgwYTA1ZTJjYjZi ZmE2ZmU3NGY3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTAxLTE2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIEhSVEZQYW5uZXIgbm90IHJl bmRlcmluZyBjb3JyZWN0bHkgb24gbWFjIHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc2Mzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBIUlRGIHJlc3VsdHMgYXJlIGN1cnJl bnRseSBub3QgdGVzdGFibGUuCisKKyAgICAgICAgUmUtZ2VuZXJhdGUgdGhlIENvbXBvc2l0ZS53 YXYgZmlsZSBmcm9tIGl0cyBjb25zdGl0dWVudCBhemltdXRoICYgZWxldmF0aW9uIGZpbGVzLgor CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vcmVzb3VyY2VzL0NvbXBvc2l0ZS53YXY6CisKKzIw MTItMDEtMTYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKICAgICAgICAgV2Vi QXVkaW86IE9wdGltaXplIEF1ZGlvQnVzOjpjcmVhdGVCeU1peGluZ1RvTW9ubygpCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjM5NAogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9yZXNvdXJjZXMvQ29tcG9zaXRlLndh diBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL3Jlc291cmNlcy9Db21wb3NpdGUud2F2 CmluZGV4IDYxN2RkMmFlMmI3ZTA2MmNmNzhjYjdkNDg2NDFkZTVkMjJiNjE1NzIuLjI1ZmM4MjMx NGM4YTM4ZDYzYjViMjZmZmU4MmQwOTM1NjBmZTNmZmIgMTAwNjQ0CkdJVCBiaW5hcnkgcGF0Y2gK ZGVsdGEgMTIxMAp6Y21aV29KeEUobzgwRyM5ODNIPEZrZGlANGg3NlpTaEVoVndrVT1EclAoc05k OyFzS2BRWEdOPWtySylxTElAPzQKemwhfDdNVnc9PzBBciM/LS1jVEdJTFhxTyY7RStMemdBfDdo NGh7fHlkZF9RV0g2NzAzeVdlLWQ/PnFQQXJRPVI/CnorPSsocSUoPktfJHQjZVN4QEJxeld8KWMh a1lScTYkMVNOaDU/ViZ6cXsyNDhEK2JDbFVGTzQ3V0U0N3wwTW1OSQp6OEhoVn13al9RK2s+IWpy Ti0lZFVBUlohRVZ0YnBFIXZnMCorX3o4bjxhZ0NGQmBBS3dHWWJrZVMzUilMJmMhIygKej9Rd0lO Z0hqeG4yV0Q7fTxlM2c8TXB6dkhaNSRRX2hJR31rZWIqUFN1XkApcjY9d3U9JCFiUENeajgrWUNA ZDNxCno/VzMmeGZufj11N0Umd3podSRreG5yaHh3OCk2JDFpa04mOFgkWDdqeG17MUdidT48TGB5 c0gyZHtNbHgrZ1ZqYgp6K1pKfU5hcSZPdU5jfU4qPmpyTlk8OHd8U1hmVVhjcHslVzBsVHVzZk5S SEg3WFhta2ZuVUozYCprRGdtJT0qam0KenVQfEJ7Xk0xOW00SX1Zaj1wU21DQnY8byFMTnNgUXB1 cE0hRWxueEJVNmpSdUchPVV8UDB+cFMhNjE7KkU9dnA3Cnp6Xy1HRm0qcmozMGdyV2xRakBeYUVx TGFQa3wtJnw0PVhNckhlQz15bnFeO0c+aTQpIUk+Pml8ZF5eWjw9e15LJAp6NG8pR2NGYFhrN0lx Z0tpfDAkMEZtMXVoeHJ6R0NYPE9OP1hDUHJBKHIyM0srcnVyfG5PY1NSeFE+JnlqcEpJdSEKekor N1ZgTGo7OUdqXjBzSGBfOWU/enJyZVZOJXEjK2FlP0FLZWw2Y1FBMVU5UShtQDNkU3wkb2Zqc0Uo ME9rU3NQCno0UXItaClweFJWK018VXFFbVYqKnBFI2l5K35KVTA2OHkjUERPNVZGV0tnbGo0UWBy Sz48X1dPJHdoQCp6PC0ocwp6eVRCT35TS00kd25xZm5pRylGLSQwNnE9WVQmOFBgYGxLPl9Vamxq ekV7YThKT08hPnB7Umx5bWp4Ul9CK0ZxblcKVHZ2YGMpZ3dpQmFuflZtTzRnYUhHdSR5UWMKCmRl bHRhIDEyMzgKemNtWHxCRi1UaWM2eT9BN2hDaFZyQVZvQHNQI2hje3BIUVRQa3xCZUxOR1BGWDIk Q1RiRFdQTiM1c0BQMDQ8ZXoyCno2NDA2cXExZVh5R2tsOGhaTkhRWjR5OHpPJGwlfjBsMGt8PzFf eUA+TDMrK2grVHAqUGQrKWpELWdvYUt6Qn1mLQp6Vl4hX3h6TklgfWtUQEZ1KEhXNXxhNyteJjNm MHNKZH5IPjhjRW50YGxDXiRGUGlHamNGZn5TUWs+KXRMeEErPmkKenIjcDB+QiYtVStHQS1ZTkhB QTk9Kmd6fTxZaUhrfil1RiRPdVlfM0Q8V1gqIXRoIWhYd3txNWpaMFpQbmFSeUZFCnpGKEBiMDdm cUs8aTk7M1l1MFlWfjNsJXlRYVMhbitzQFFUWl88WnBXPF92UnBtfnU+SF5IXm9fMEtqRnRLMHQk QAp6MWkyUkVMVDZndXFrYXk3SkBPa29eMU02bD1qaiZKc3l2bz9xJmJCP3o3YEMkK1NDJmVJeHw4 ayk2JVVlJiFRUG4KeiV0ZHl7RTVwaFlhMUh+NDZ1PX1wJmBGYj9MPzUyc1VeLUA1aXtEeGtWWDl+ SyhBPzM4ZUp5WlpVcEAtdmw3R04wCnpQLVJuWEtqfVEmUElWcjklZzhHa0k9KlJSZzRkeyVBQ1pm fSo1dntDNW8mTXBSPTVVc0Q9fVk2Ylg2XjdzdHJ1Rgp6RUBDYihQKnZNO0o2Y1FqdHdAbGF4YDBC N2YoZn0yZF5+PVN6TiVwVXIwNU94M1JMenYrJD15JDtHTih0O0ZXUG4Kelk1NlI4d2VicllXaW4z am9nbWdgZUgpLWRuRzREb2diOD9ocDRyeiM9N2tsQUA7dUJGdEI0b2orcUNzbkApRGotCnp7Mk9W NlU+dSRzT01QKFU8S1RKYzNjVzdEZ0taNFU/aHxuUz55JEgzdTFKdzZrOTlUfTE8MHt9bn5ZMlBH Yy0/Vwp6I3c9YFkqNWQxI0hQZGJ9QzVGaHxzNkF8IUNIVV5BQHdvX3tWNXZAN0pgRytMZWA1Pzsz NWA5b2BNQkJxQ1RxK3kKemV+K28+MWd6LU4pI1pXeGViVl50ODcyPStMWEAjT2s8Qio5c01FREUl KkduaDxXN3d3bnRCcGVrTCVnelgzb1h5CnpWRTFrcEVpSThZTHliODYqV3lpaHBzWHpmNm56VDg3 LXpjPFYwSy1SYzJubkp0K0c7XysxVH4pUyl9UFFZZGZPZgpoQWs3WCtyVlUySDlzTkJOaEVgTVdW PHUlWWxaMlZjSWRjbl5gVX08flpXe21xCgo=