76396 2012-01-16 11:35:47 -0800 REGRESSION(r105072): It broke committers_unittest.py 2012-01-16 12:11:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ossy ossy abarth danw dpranke eric ojan ossy rniwa webkit.review.bot oldest_to_newest 536684 0 ossy 2012-01-16 11:35:47 -0800 We have one more Dan as committer, and unit test can't handle this situation: http://trac.webkit.org/changeset/105072/trunk/Tools/Scripts/webkitpy/common/config/committers.py Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/config/committers_unittest.py", line 170, in test_contributors_by_fuzzy_match_with_legacy_names self._assert_fuzz_match('Dan', 'Dan Bernstein', 0) File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/config/committers_unittest.py", line 108, in _assert_fuzz_match self.assertEqual(([contributor.full_name for contributor in contributors], distance), (expected_names, expected_distance)) AssertionError: (['Dan Winship', 'Dan Bernstein'], 0) != (['Dan Bernstein'], 0) 536686 1 122668 ossy 2012-01-16 11:39:44 -0800 Created attachment 122668 Patch 536691 2 122668 abarth 2012-01-16 11:50:17 -0800 Comment on attachment 122668 Patch These tests seem poorly designed... 536693 3 eric 2012-01-16 11:57:43 -0800 rniwa is the man behind these tests iirc. 536696 4 ossy 2012-01-16 11:59:53 -0800 Ooops, it isn't Qt specific, it was copy/paste error :) 536699 5 danw 2012-01-16 12:04:16 -0800 Oh, awesome. I broke the build on my first commit. :-O (FWIW, I even ran committers_unittest.py, and it exited with status 0 without printing anything, so I figured I was good... guess I should have looked more carefully at the code.) 536701 6 122668 ossy 2012-01-16 12:05:08 -0800 Comment on attachment 122668 Patch Committed r105082 536702 7 ossy 2012-01-16 12:10:35 -0800 (In reply to comment #5) > Oh, awesome. I broke the build on my first commit. :-O > > (FWIW, I even ran committers_unittest.py, and it exited with status 0 without printing anything, so I figured I was good... guess I should have looked more carefully at the code.) Not a problem, the test was bad now. (Otherwise we usually run Tools/Scripts/test-webkitpy instead of individual test) 536704 8 eric 2012-01-16 12:11:49 -0800 (In reply to comment #5) > Oh, awesome. I broke the build on my first commit. :-O > > (FWIW, I even ran committers_unittest.py, and it exited with status 0 without printing anything, so I figured I was good... guess I should have looked more carefully at the code.) Despite the existence of those __main__ blocks, that's not really a sanctioned way to run the tests. test-webkitpy is your best bet. 122668 2012-01-16 11:39:44 -0800 2012-01-16 12:05:08 -0800 Patch bug-76396-20120116193942.patch text/plain 2462 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzVlZjg3NTlhOWEyZjg5ZDU4YjZkMDE4NTMxZjE4ODc1 N2Q0MDVhMC4uMjk1MTkwYTBhODFkZDdmZGRlMDhlNTNlNjExZDViMjMwOWIxZmU3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTE2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XSBSRUdSRVNTSU9OKHIxMDUwNzIpOiBJdCBicm9rZSBjb21taXR0ZXJzX3Vu aXR0ZXN0LnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03NjM5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnNfdW5pdHRlc3QucHk6 CisgICAgICAgIChDb21taXR0ZXJzVGVzdC5fYXNzZXJ0X2Z1enpfbWF0Y2gpOiBJdCBzaG91bGQg aGFuZGxlIG1vcmUgbmFtZXMuCisgICAgICAgIChDb21taXR0ZXJzVGVzdC50ZXN0X2NvbnRyaWJ1 dG9yc19ieV9mdXp6eV9tYXRjaF93aXRoX2xlZ2FjeV9uYW1lcyk6IEZpeCB0aGUgdGVzdGNhc2Uu CisKIDIwMTItMDEtMTYgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIEluY2x1ZGUgZ3RrKzMgaW4gdGhlIGpoYnVpbGQgbW9kdWxlcwpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRl cnNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29t bWl0dGVyc191bml0dGVzdC5weQppbmRleCBkM2IxMGI4MmEzYjBlYWVjMTc3NzJiZWJlMjc4NTcz NmJhOGE4ZmYxLi41M2Q5YzRkMTRmNGRmOTNmY2QzMTAyMDE2NjVjNGUwYTVhOTM1MDA0IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVyc191 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29t bWl0dGVyc191bml0dGVzdC5weQpAQCAtMTA0LDcgKzEwNCwxMCBAQCBjbGFzcyBDb21taXR0ZXJz VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIF9hc3NlcnRfZnV6el9tYXRjaChzZWxm LCB0ZXh0LCBuYW1lX29mX2V4cGVjdGVkX2NvbnRyaWJ1dG9yLCBleHBlY3RlZF9kaXN0YW5jZSk6 CiAgICAgICAgIGNvbW1pdHRlcnMgPSBDb21taXR0ZXJMaXN0KCkKICAgICAgICAgY29udHJpYnV0 b3JzLCBkaXN0YW5jZSA9IGNvbW1pdHRlcnMuY29udHJpYnV0b3JzX2J5X2Z1enp5X21hdGNoKHRl eHQpCi0gICAgICAgIGV4cGVjdGVkX25hbWVzID0gW25hbWVfb2ZfZXhwZWN0ZWRfY29udHJpYnV0 b3JdIGlmIG5hbWVfb2ZfZXhwZWN0ZWRfY29udHJpYnV0b3IgZWxzZSBbXQorICAgICAgICBpZiB0 eXBlKG5hbWVfb2ZfZXhwZWN0ZWRfY29udHJpYnV0b3IpIGlzIGxpc3Q6CisgICAgICAgICAgICBl eHBlY3RlZF9uYW1lcyA9IG5hbWVfb2ZfZXhwZWN0ZWRfY29udHJpYnV0b3IKKyAgICAgICAgZWxz ZToKKyAgICAgICAgICAgIGV4cGVjdGVkX25hbWVzID0gW25hbWVfb2ZfZXhwZWN0ZWRfY29udHJp YnV0b3JdIGlmIG5hbWVfb2ZfZXhwZWN0ZWRfY29udHJpYnV0b3IgZWxzZSBbXQogICAgICAgICBz ZWxmLmFzc2VydEVxdWFsKChbY29udHJpYnV0b3IuZnVsbF9uYW1lIGZvciBjb250cmlidXRvciBp biBjb250cmlidXRvcnNdLCBkaXN0YW5jZSksIChleHBlY3RlZF9uYW1lcywgZXhwZWN0ZWRfZGlz dGFuY2UpKQogCiAgICAgZGVmIHRlc3RfY29udHJpYnV0b3JzX2J5X2Z1enp5X21hdGNoKHNlbGYp OgpAQCAtMTY3LDcgKzE3MCw3IEBAIGNsYXNzIENvbW1pdHRlcnNUZXN0KHVuaXR0ZXN0LlRlc3RD YXNlKToKICMgICAgICAgIHNlbGYuX2Fzc2VydF9mdXp6X21hdGNoKCdDaHJpcycsICdDaHJpcyBC bHVtZW5iZXJnJywgMCkKICAgICAgICAgc2VsZi5fYXNzZXJ0X2Z1enpfbWF0Y2goJ2NibHUnLCAn Q2hyaXMgQmx1bWVuYmVyZycsIDApCiAKLSAgICAgICAgc2VsZi5fYXNzZXJ0X2Z1enpfbWF0Y2go J0RhbicsICdEYW4gQmVybnN0ZWluJywgMCkKKyAgICAgICAgc2VsZi5fYXNzZXJ0X2Z1enpfbWF0 Y2goJ0RhbicsIFsnRGFuIFdpbnNoaXAnLCAnRGFuIEJlcm5zdGVpbiddLCAwKQogICAgICAgICBz ZWxmLl9hc3NlcnRfZnV6el9tYXRjaCgnRGFuIEInLCAnRGFuIEJlcm5zdGVpbicsIDApCiAjICAg ICAgICBzZWxmLl9hc3NlcnRfZnV6el9tYXRjaCgnbWl0eicsICdEYW4gQmVybnN0ZWluJywgMCkK ICAgICAgICAgc2VsZi5fYXNzZXJ0X2Z1enpfbWF0Y2goJ01pdHogUGV0dGVsJywgJ0RhbiBCZXJu c3RlaW4nLCAxKQo=