76391 2012-01-16 09:52:04 -0800 Crash at WebCore::MediaControlRootElement::makeOpaque + 97 2012-01-19 10:53:54 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble dbates oldest_to_newest 536633 0 jer.noble 2012-01-16 09:52:04 -0800 Crash at WebCore::MediaControlRootElement::makeOpaque + 97 536634 1 jer.noble 2012-01-16 09:52:39 -0800 <rdar://problem/9670476> 536640 2 122659 jer.noble 2012-01-16 09:57:04 -0800 Created attachment 122659 Patch 537161 3 122659 dbates 2012-01-17 09:32:22 -0800 Comment on attachment 122659 Patch This patch needs to be rebased as it no longer applies cleanly because the function MediaControlRootElement::makeOpaque() has changed significantly. In particular, the line this patch changes no longer exists as it was removed in <http://trac.webkit.org/changeset/97157> (bug #58157). This changeset also moved the implementation of MediaControlRootElement::makeOpaque() into MediaControlPanelElement::makeOpaque() in file /Source/WebCore/html/shadow/MediaControlElements.cpp: <http://trac.webkit.org/browser/trunk/Source/WebCore/html/shadow/MediaControlElements.cpp?rev=105163#L207>. 538750 4 123139 jer.noble 2012-01-19 09:01:22 -0800 Created attachment 123139 Patch Rebased against new location of makeOpaque() code. 538788 5 123139 sullivan 2012-01-19 10:16:29 -0800 Comment on attachment 123139 Patch Is the case where document()->page() is nil ever expected? If not, maybe it’s worth adding an assertion? 538791 6 jer.noble 2012-01-19 10:23:06 -0800 (In reply to comment #5) > (From update of attachment 123139 [details]) > Is the case where document()->page() is nil ever expected? If not, maybe it’s worth adding an assertion? In the Document.h header, it states that page() "can be NULL", so I assumed it was expected. Thanks! 538803 7 jer.noble 2012-01-19 10:53:54 -0800 Committed r105425: <http://trac.webkit.org/changeset/105425> 122659 2012-01-16 09:57:04 -0800 2012-01-19 09:01:19 -0800 Patch bug-76391-20120116095703.patch text/plain 1655 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogOTM3MTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1MzRkZTJkZmM0M2ZhM2Ri MGMxYTIxYTlmOGU0YTMwZjg5YzM3MWRmLi4wNGZhNjc2OGM3NmI2ZTU5ZTM0NDZmNWRjNjVjYTFl N2YzMjIzNWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDEtMTYgIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggYXQgV2ViQ29yZTo6 TWVkaWFDb250cm9sUm9vdEVsZW1lbnQ6Om1ha2VPcGFxdWUgKyA5NworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYzOTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHM7IFNwZWN1bGF0aXZl IGZpeCBmb3IgY3Jhc2guCisKKyAgICAgICAgQ3Jhc2ggcmVwb3J0IGRhdGEgc3VnZ2VzdHMgdGhp cyBjcmFzaCBpcyBvY2N1cnJpbmcgYXMgdGhlIGRvY3VtZW50IGlzIGJlaW5nCisgICAgICAgIGNs b3NlZC4gIENoZWNrIHRoZSBudWxsaXR5IG9mIGRvY3VtZW50KCktPnBhZ2UoKSBiZWZvcmUgZGVy ZWYtaW5nLgorCisgICAgICAgICogaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sUm9vdEVsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250cm9sUm9vdEVsZW1lbnQ6Om1ha2VPcGFx dWUpOgorCiAyMDExLTA4LTIzICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBNZXNzYWdlRXZlbnQucG9ydHMgc2hvdWxkbid0IGV2ZXIgYmUgbnVsbC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbFJvb3RFbGVtZW50 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbFJvb3RFbGVtZW50 LmNwcAppbmRleCAxYzE4NWY4ZGYzOWQwMmQ3NTIzNWQwNmE5MjNiZWFkYmJlYjM0MWMwLi5mYzM4 MmZjZDBjNDg3ZDkyMjQ1Y2Y0MWUwYzU2ZWMwMGU3MGY5ODZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xSb290RWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sUm9vdEVsZW1lbnQuY3BwCkBAIC0y NDYsNyArMjQ2LDcgQEAgdm9pZCBNZWRpYUNvbnRyb2xSb290RWxlbWVudDo6bWFrZU9wYXF1ZSgp CiAgICAgICAgIHJldHVybjsKIAogICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCB0cmFu c2l0aW9uVmFsdWUsICgpKTsKLSAgICBpZiAodHJhbnNpdGlvblZhbHVlLmlzTnVsbCgpKQorICAg IGlmICh0cmFuc2l0aW9uVmFsdWUuaXNOdWxsKCkgJiYgZG9jdW1lbnQoKS0+cGFnZSgpKQogICAg ICAgICB0cmFuc2l0aW9uVmFsdWUgPSBTdHJpbmc6OmZvcm1hdCgib3BhY2l0eSAlLjFncyIsIGRv Y3VtZW50KCktPnBhZ2UoKS0+dGhlbWUoKS0+bWVkaWFDb250cm9sc0ZhZGVJbkR1cmF0aW9uKCkp OwogICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBvcGFjaXR5VmFsdWUsICgiMSIpKTsK IAo= 123139 2012-01-19 09:01:22 -0800 2012-01-19 10:16:28 -0800 Patch bug-76391-20120119090125.patch text/plain 1982 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVkNzRhNGQwMzI4NTgy ZWY0YWQ5MjQxY2E0YmQyNzhmOGNkMDY1Ni4uMGZmMTUwZGM0OWMwYjk5NzI3ZjhjMDg0MzRlZTcw MTRhODY1MDVkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTE2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGF0IFdlYkNvcmU6 Ok1lZGlhQ29udHJvbFJvb3RFbGVtZW50OjptYWtlT3BhcXVlICsgOTcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MzkxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBTcGVjdWxhdGl2 ZSBmaXggZm9yIGNyYXNoLgorCisgICAgICAgIENyYXNoIHJlcG9ydCBkYXRhIHN1Z2dlc3RzIHRo aXMgY3Jhc2ggaXMgb2NjdXJyaW5nIGFzIHRoZSBkb2N1bWVudCBpcyBiZWluZworICAgICAgICBj bG9zZWQuICBDaGVjayB0aGUgbnVsbGl0eSBvZiBkb2N1bWVudCgpLT5wYWdlKCkgYmVmb3JlIGRl cmVmLWluZy4KKworICAgICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJvbFBhbmVsRWxlbWVudDo6bWFrZU9wYXF1 ZSk6CisKIDIwMTItMDEtMTggIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXBsZW1lbnQgc2NyZWVuIHJlc29sdXRpb24g ZW11bGF0aW9uIGJhY2tlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L01l ZGlhQ29udHJvbEVsZW1lbnRzLmNwcAppbmRleCBkODhiODdmMDNiM2YyMmUyNWM2NWY2MWFlOWQ0 ZTQ3OWU3NGFlNjY3Li40NWI5NjMxNTIzMzY4MzBkZmRkNGY0ODNlZGU3ZGViOTdiZDAzNGFiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50 cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVu dHMuY3BwCkBAIC0yMDgsMTAgKzIwOCwxMiBAQCB2b2lkIE1lZGlhQ29udHJvbFBhbmVsRWxlbWVu dDo6bWFrZU9wYXF1ZSgpCiB7CiAgICAgaWYgKG1fb3BhcXVlKQogICAgICAgICByZXR1cm47Ci0g ICAgCisKKyAgICBkb3VibGUgZHVyYXRpb24gPSBkb2N1bWVudCgpLT5wYWdlKCkgPyBkb2N1bWVu dCgpLT5wYWdlKCktPnRoZW1lKCktPm1lZGlhQ29udHJvbHNGYWRlSW5EdXJhdGlvbigpIDogMDsK KwogICAgIENTU0lubGluZVN0eWxlRGVjbGFyYXRpb24qIHN0eWxlID0gZW5zdXJlSW5saW5lU3R5 bGVEZWNsKCk7CiAgICAgc3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5V2Via2l0VHJhbnNp dGlvblByb3BlcnR5LCBDU1NQcm9wZXJ0eU9wYWNpdHkpOwotICAgIHN0eWxlLT5zZXRQcm9wZXJ0 eShDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zaXRpb25EdXJhdGlvbiwgZG9jdW1lbnQoKS0+cGFnZSgp LT50aGVtZSgpLT5tZWRpYUNvbnRyb2xzRmFkZUluRHVyYXRpb24oKSwgQ1NTUHJpbWl0aXZlVmFs dWU6OkNTU19TKTsKKyAgICBzdHlsZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlXZWJraXRUcmFu c2l0aW9uRHVyYXRpb24sIGR1cmF0aW9uLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1MpOwogICAg IHN0eWxlLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eU9wYWNpdHksIDEuMCwgQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU19OVU1CRVIpOwogCiAgICAgbV9vcGFxdWUgPSB0cnVlOwo=