76370 2012-01-16 00:48:18 -0800 [EFL] Define the names of view smart class 2012-01-30 21:03:25 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 eunsol47.park webkit-unassigned g.czajkowski gyuyoung.kim hyuki.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 536406 0 eunsol47.park 2012-01-16 00:48:18 -0800 Tiled view names were created as Ewk_View_Tiled and EWK_View_Tiled. It should be modifed to be same to check the view's type. 536413 1 122602 eunsol47.park 2012-01-16 01:00:23 -0800 Created attachment 122602 proposed patch To make them more clear , Single view was also changed. 536414 2 122602 gyuyoung.kim 2012-01-16 01:08:42 -0800 Comment on attachment 122602 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=122602&action=review > Source/WebKit/efl/ChangeLog:9 > + so the definitions were modifined to make users not confused. modifined - > modified. > Source/WebKit/efl/ewk/ewk_private.h:47 > +#define EWK_VIEW_TILED_NAME "Ewk_View_Tiled" WebKit prefers *const* to *#define*. 536432 3 hyuki.kim 2012-01-16 01:58:38 -0800 > Source/WebKit/efl/ewk/ewk_view.cpp:270 > + INF("object is not a instance of EWK_VIEW_TILED_NAME"); \ is not a => isn't an ? 536474 4 122612 eunsol47.park 2012-01-16 04:06:14 -0800 Created attachment 122612 proposed patch applied comments. 1. *#define* changed to *const*. 2. modifined -> modified 3. is not a -> isn't an 536493 5 g.czajkowski 2012-01-16 05:10:52 -0800 View in context: https://bugs.webkit.org/attachment.cgi?id=122612&action=review > Source/WebKit/efl/ewk/ewk_private.h:62 > +static const char* ewkViewTiledName = "Ewk_View_Tiled"; static const char ewkViewTiledName[] = "Ewk_View_Tiled"; > Source/WebKit/efl/ewk/ewk_private.h:63 > +static const char* ewkViewSingleName = "Ewk_View_Single"; Ditto. 536495 6 122602 rakuco 2012-01-16 05:13:40 -0800 Comment on attachment 122602 proposed patch Flagging the first patch as obsolete and clearing its flags. 536831 7 122700 eunsol47.park 2012-01-16 17:59:06 -0800 Created attachment 122700 proposed patch 536833 8 eunsol47.park 2012-01-16 18:00:12 -0800 (In reply to comment #5) > View in context: https://bugs.webkit.org/attachment.cgi?id=122612&action=review > > > Source/WebKit/efl/ewk/ewk_private.h:62 > > +static const char* ewkViewTiledName = "Ewk_View_Tiled"; > > static const char ewkViewTiledName[] = "Ewk_View_Tiled"; > > > Source/WebKit/efl/ewk/ewk_private.h:63 > > +static const char* ewkViewSingleName = "Ewk_View_Single"; > > Ditto. updated patch 536835 9 122700 gyuyoung.kim 2012-01-16 18:14:18 -0800 Comment on attachment 122700 proposed patch LGTM. 536904 10 g.czajkowski 2012-01-16 23:37:38 -0800 (In reply to comment #8) > (In reply to comment #5) > > View in context: https://bugs.webkit.org/attachment.cgi?id=122612&action=review > > > > > Source/WebKit/efl/ewk/ewk_private.h:62 > > > +static const char* ewkViewTiledName = "Ewk_View_Tiled"; > > > > static const char ewkViewTiledName[] = "Ewk_View_Tiled"; > > > > > Source/WebKit/efl/ewk/ewk_private.h:63 > > > +static const char* ewkViewSingleName = "Ewk_View_Single"; > > > > Ditto. > updated patch LGTM. 537571 11 hyuki.kim 2012-01-17 19:20:31 -0800 > Source/WebKit/efl/ewk/ewk_private.h:63 > +static const char ewkViewSingleName[] = "Ewk_View_Single"; I have got this idea from reviewer morrita's comment for other patch. :) "It looks this should be just const int, without static. Static is for static variables, which are usually staying inside c/cpp file." 537708 12 122889 eunsol47.park 2012-01-18 01:31:45 -0800 Created attachment 122889 proposed patch 537710 13 eunsol47.park 2012-01-18 01:32:27 -0800 (In reply to comment #11) > > Source/WebKit/efl/ewk/ewk_private.h:63 > > +static const char ewkViewSingleName[] = "Ewk_View_Single"; > > I have got this idea from reviewer morrita's comment for other patch. :) > "It looks this should be just const int, without static. Static is for static variables, which are usually staying inside c/cpp file." patch is updated 537712 14 hyuki.kim 2012-01-18 01:35:23 -0800 (In reply to comment #13) > (In reply to comment #11) > > > Source/WebKit/efl/ewk/ewk_private.h:63 > > > +static const char ewkViewSingleName[] = "Ewk_View_Single"; > > > > I have got this idea from reviewer morrita's comment for other patch. :) > > "It looks this should be just const int, without static. Static is for static variables, which are usually staying inside c/cpp file." > > patch is updated Looks good. :) 543942 15 122889 kling 2012-01-27 03:48:46 -0800 Comment on attachment 122889 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=122889&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:270 > - if (!evas_object_smart_type_check(ewkView, "Ewk_View_Tiled")) { \ > - INF("object is not a instance of Ewk_View_Tiled"); \ > + if (!evas_object_smart_type_check(ewkView, ewkViewTiledName)) { \ > + INF("object isn't an instance of ewkViewTiledName"); \ Seems like the second line should be: INF("object isn't an instance of " ewkViewTiledName); \ As you don't want the variable name to leak into error messages. 544807 16 124479 eunsol47.park 2012-01-29 17:45:15 -0800 Created attachment 124479 proposed patch 544808 17 eunsol47.park 2012-01-29 17:52:02 -0800 (In reply to comment #15) > (From update of attachment 122889 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122889&action=review > > > Source/WebKit/efl/ewk/ewk_view.cpp:270 > > - if (!evas_object_smart_type_check(ewkView, "Ewk_View_Tiled")) { \ > > - INF("object is not a instance of Ewk_View_Tiled"); \ > > + if (!evas_object_smart_type_check(ewkView, ewkViewTiledName)) { \ > > + INF("object isn't an instance of ewkViewTiledName"); \ > > Seems like the second line should be: > INF("object isn't an instance of " ewkViewTiledName); \ > > As you don't want the variable name to leak into error messages. I've done it. 545761 18 124479 webkit.review.bot 2012-01-30 21:03:17 -0800 Comment on attachment 124479 proposed patch Clearing flags on attachment: 124479 Committed r106330: <http://trac.webkit.org/changeset/106330> 545762 19 webkit.review.bot 2012-01-30 21:03:25 -0800 All reviewed patches have been landed. Closing bug. 122602 2012-01-16 01:00:23 -0800 2012-01-16 05:13:40 -0800 proposed patch tiled_view_name.patch text/plain 3746 eunsol47.park ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyMjQ2MjJiLi42MTViOTcyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMTYgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0Bz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBEZWZpbmUgdGhlIG5hbWVzIG9mIHZpZXcgc21h cnQgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RyaW5ncyBvZiBld2tfdGlsZWRfdmlldydzIG5hbWUgd2VyZSBkZWZpbmVkIGRpZmZlcmVudGx5 LAorICAgICAgICBzbyB0aGUgZGVmaW5pdGlvbnMgd2VyZSBtb2RpZmluZWQgdG8gbWFrZSB1c2Vy cyBub3QgY29uZnVzZWQuCisKKyAgICAgICAgKiBld2svZXdrX3ByaXZhdGUuaDoKKyAgICAgICAg KiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAqIGV3ay9ld2tfdmlld19zaW5nbGUuY3BwOgor ICAgICAgICAoX2V3a192aWV3X3NpbmdsZV9zbWFydF9jbGFzc19uZXcpOgorICAgICAgICAqIGV3 ay9ld2tfdmlld190aWxlZC5jcHA6CisgICAgICAgIChld2tfdmlld190aWxlZF9zbWFydF9zZXQp OgorICAgICAgICAoX2V3a192aWV3X3RpbGVkX3NtYXJ0X2NsYXNzX25ldyk6CisKIDIwMTItMDEt MTMgIExlYW5kcm8gUGVyZWlyYSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAg W0VGTF0gU2VjdXJpdHlQb2xpY3kgd2hpdGVsaXN0IGludGVyZmFjZSBzaG91bGQgYmUgZXhwb3Nl ZCB0byBFV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZh dGUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCmluZGV4IGIxYzYwMzAu LjI2YWY2ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCkBAIC00Myw2ICs0Mywx MCBAQAogI2RlZmluZSBFV0tfVFlQRV9DSEVDSyAxCiAjZGVmaW5lIEVXS19BUkdCX0JZVEVTX1NJ WkUgNAogCisvLyBEZWZpbmVzIHRoZSBuYW1lcyBmb3IgaW5pdGlhbGl6aW5nIGV3a192aWV3X3Nt YXJ0X2NsYXNzCisjZGVmaW5lIEVXS19WSUVXX1RJTEVEX05BTUUgICAgIkV3a19WaWV3X1RpbGVk IgorI2RlZmluZSBFV0tfVklFV19TSU5HTEVfTkFNRSAgICAiRXdrX1ZpZXdfU2luZ2xlIgorCiAj aWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAjZGVmaW5lIEVXS19KU19PQkpFQ1RfTUFH SUMgMHg2OTY5NjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggN2ZkYmMxMS4u Zjc5OWYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0yNjYsOCArMjY2LDgg QEAgc3RydWN0IF9Fd2tfVmlld19Qcml2YXRlX0RhdGEgewogICAgIH0KIAogI2RlZmluZSBFV0tf VklFV19USUxFRF9UWVBFX0NIRUNLX09SX1JFVFVSTihld2tWaWV3LCAuLi4pIFwKLSAgICBpZiAo IWV2YXNfb2JqZWN0X3NtYXJ0X3R5cGVfY2hlY2soZXdrVmlldywgIkV3a19WaWV3X1RpbGVkIikp IHsgXAotICAgICAgICBJTkYoIm9iamVjdCBpcyBub3QgYSBpbnN0YW5jZSBvZiBFd2tfVmlld19U aWxlZCIpOyBcCisgICAgaWYgKCFldmFzX29iamVjdF9zbWFydF90eXBlX2NoZWNrKGV3a1ZpZXcs IEVXS19WSUVXX1RJTEVEX05BTUUpKSB7IFwKKyAgICAgICAgSU5GKCJvYmplY3QgaXMgbm90IGEg aW5zdGFuY2Ugb2YgRVdLX1ZJRVdfVElMRURfTkFNRSIpOyBcCiAgICAgICAgIHJldHVybiBfX1ZB X0FSR1NfXzsgXAogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3X3NpbmdsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xl LmNwcAppbmRleCBlZDcyNjMzLi43ZTIyYzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXdfc2luZ2xlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXdfc2luZ2xlLmNwcApAQCAtMzk2LDcgKzM5Niw3IEBAIEVpbmFfQm9vbCBld2tfdmlld19z aW5nbGVfc21hcnRfc2V0KEV3a19WaWV3X1NtYXJ0X0NsYXNzKiBhcGkpCiAKIHN0YXRpYyBpbmxp bmUgRXZhc19TbWFydCogX2V3a192aWV3X3NpbmdsZV9zbWFydF9jbGFzc19uZXcodm9pZCkKIHsK LSAgICBzdGF0aWMgRXdrX1ZpZXdfU21hcnRfQ2xhc3MgYXBpID0gRVdLX1ZJRVdfU01BUlRfQ0xB U1NfSU5JVF9OQU1FX1ZFUlNJT04oIkV3a19WaWV3X1NpbmdsZSIpOworICAgIHN0YXRpYyBFd2tf Vmlld19TbWFydF9DbGFzcyBhcGkgPSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVS U0lPTihFV0tfVklFV19TSU5HTEVfTkFNRSk7CiAgICAgc3RhdGljIEV2YXNfU21hcnQqIHNtYXJ0 ID0gMDsKIAogICAgIGlmIChFSU5BX1VOTElLRUxZKCFzbWFydCkpIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld190aWxlZC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXdfdGlsZWQuY3BwCmluZGV4IDMxMDFjMTIuLjNmOTcxMmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld190aWxlZC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmNwcApAQCAtMzQ3LDcgKzM0Nyw3IEBAIEVp bmFfQm9vbCBld2tfdmlld190aWxlZF9zbWFydF9zZXQoRXdrX1ZpZXdfU21hcnRfQ2xhc3MqIGFw aSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgaWYgKEVJTkFfVU5MSUtFTFkoIV9wYXJl bnRfc2Muc2MuYWRkKSkgewotICAgICAgICBfcGFyZW50X3NjLnNjLm5hbWUgPSAgIkV3a19WaWV3 X1RpbGVkIjsKKyAgICAgICAgX3BhcmVudF9zYy5zYy5uYW1lID0gIEVXS19WSUVXX1RJTEVEX05B TUU7CiAgICAgICAgIGV3a192aWV3X2Jhc2Vfc21hcnRfc2V0KCZfcGFyZW50X3NjKTsKICAgICAg ICAgYXBpLT5zYy5wYXJlbnQgPSByZWludGVycHJldF9jYXN0PEV2YXNfU21hcnRfQ2xhc3MqPigm X3BhcmVudF9zYyk7CiAgICAgfQpAQCAtMzc0LDcgKzM3NCw3IEBAIEVpbmFfQm9vbCBld2tfdmll d190aWxlZF9zbWFydF9zZXQoRXdrX1ZpZXdfU21hcnRfQ2xhc3MqIGFwaSkKIAogc3RhdGljIGlu bGluZSBFdmFzX1NtYXJ0KiBfZXdrX3ZpZXdfdGlsZWRfc21hcnRfY2xhc3NfbmV3KHZvaWQpCiB7 Ci0gICAgc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19WSUVXX1NNQVJUX0NM QVNTX0lOSVRfTkFNRV9WRVJTSU9OKCJFV0tfVmlld19UaWxlZCIpOworICAgIHN0YXRpYyBFd2tf Vmlld19TbWFydF9DbGFzcyBhcGkgPSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVS U0lPTihFV0tfVklFV19USUxFRF9OQU1FKTsKICAgICBzdGF0aWMgRXZhc19TbWFydCogc21hcnQg PSAwOwogCiAgICAgaWYgKEVJTkFfVU5MSUtFTFkoIXNtYXJ0KSkgewo= 122612 2012-01-16 04:06:14 -0800 2012-01-16 17:59:06 -0800 proposed patch tiled_view_name2.patch text/plain 3753 eunsol47.park ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyMjQ2MjJiLi5jODAyMGZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMTYgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0Bz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBEZWZpbmUgdGhlIG5hbWVzIG9mIHZpZXcgc21h cnQgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RyaW5ncyBvZiBld2tfdGlsZWRfdmlldydzIG5hbWUgd2VyZSBkZWZpbmVkIGRpZmZlcmVudGx5 LAorICAgICAgICBzbyB0aGUgZGVmaW5pdGlvbnMgd2VyZSBtb2RpZmllZCB0byBtYWtlIHVzZXJz IG5vdCBjb25mdXNlZC4KKworICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgorICAgICAgICAq IGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgICogZXdrL2V3a192aWV3X3NpbmdsZS5jcHA6Cisg ICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2NsYXNzX25ldyk6CisgICAgICAgICogZXdr L2V3a192aWV3X3RpbGVkLmNwcDoKKyAgICAgICAgKGV3a192aWV3X3RpbGVkX3NtYXJ0X3NldCk6 CisgICAgICAgIChfZXdrX3ZpZXdfdGlsZWRfc21hcnRfY2xhc3NfbmV3KToKKwogMjAxMi0wMS0x MyAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBb RUZMXSBTZWN1cml0eVBvbGljeSB3aGl0ZWxpc3QgaW50ZXJmYWNlIHNob3VsZCBiZSBleHBvc2Vk IHRvIEVXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0 ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXggYjFjNjAzMC4u MzBhZTc1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTU4LDYgKzU4LDEw IEBAIHN0cnVjdCBfRXdrX0pTX09iamVjdCB7CiB9OwogI2VuZGlmIC8vIEVOQUJMRShORVRTQ0FQ RV9QTFVHSU5fQVBJKQogCisvLyBEZWZpbmVzIHRoZSBuYW1lcyBmb3IgaW5pdGlhbGl6aW5nIGV3 a192aWV3X3NtYXJ0X2NsYXNzCitzdGF0aWMgY29uc3QgY2hhciogZXdrVmlld1RpbGVkTmFtZSA9 ICJFd2tfVmlld19UaWxlZCI7CitzdGF0aWMgY29uc3QgY2hhciogZXdrVmlld1NpbmdsZU5hbWUg PSAiRXdrX1ZpZXdfU2luZ2xlIjsKKwogLy8gZm9yd2FyZCBkZWNsYXJhdGlvbnMKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIHN0cnVjdCBQb3B1cE1lbnVDbGllbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmNwcAppbmRleCA3ZmRiYzExLi5hMTNjZjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmll dy5jcHAKQEAgLTI2Niw4ICsyNjYsOCBAQCBzdHJ1Y3QgX0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7 CiAgICAgfQogCiAjZGVmaW5lIEVXS19WSUVXX1RJTEVEX1RZUEVfQ0hFQ0tfT1JfUkVUVVJOKGV3 a1ZpZXcsIC4uLikgXAotICAgIGlmICghZXZhc19vYmplY3Rfc21hcnRfdHlwZV9jaGVjayhld2tW aWV3LCAiRXdrX1ZpZXdfVGlsZWQiKSkgeyBcCi0gICAgICAgIElORigib2JqZWN0IGlzIG5vdCBh IGluc3RhbmNlIG9mIEV3a19WaWV3X1RpbGVkIik7IFwKKyAgICBpZiAoIWV2YXNfb2JqZWN0X3Nt YXJ0X3R5cGVfY2hlY2soZXdrVmlldywgZXdrVmlld1RpbGVkTmFtZSkpIHsgXAorICAgICAgICBJ TkYoIm9iamVjdCBpc24ndCBhbiBpbnN0YW5jZSBvZiBld2tWaWV3VGlsZWROYW1lIik7IFwKICAg ICAgICAgcmV0dXJuIF9fVkFfQVJHU19fOyBcCiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfc2luZ2xlLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdmlld19zaW5nbGUuY3BwCmluZGV4IGVkNzI2MzMuLmU1ZThlZWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwCkBAIC0zOTYsNyArMzk2LDcgQEAgRWlu YV9Cb29sIGV3a192aWV3X3NpbmdsZV9zbWFydF9zZXQoRXdrX1ZpZXdfU21hcnRfQ2xhc3MqIGFw aSkKIAogc3RhdGljIGlubGluZSBFdmFzX1NtYXJ0KiBfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2Ns YXNzX25ldyh2b2lkKQogewotICAgIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkgPSBF V0tfVklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lPTigiRXdrX1ZpZXdfU2luZ2xlIik7 CisgICAgc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19WSUVXX1NNQVJUX0NM QVNTX0lOSVRfTkFNRV9WRVJTSU9OKGV3a1ZpZXdTaW5nbGVOYW1lKTsKICAgICBzdGF0aWMgRXZh c19TbWFydCogc21hcnQgPSAwOwogCiAgICAgaWYgKEVJTkFfVU5MSUtFTFkoIXNtYXJ0KSkgewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld190aWxlZC5jcHAKaW5kZXggMzEwMWMxMi4uN2Zl Y2U3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQuY3BwCkBAIC0zNDcs NyArMzQ3LDcgQEAgRWluYV9Cb29sIGV3a192aWV3X3RpbGVkX3NtYXJ0X3NldChFd2tfVmlld19T bWFydF9DbGFzcyogYXBpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoRUlOQV9V TkxJS0VMWSghX3BhcmVudF9zYy5zYy5hZGQpKSB7Ci0gICAgICAgIF9wYXJlbnRfc2Muc2MubmFt ZSA9ICAiRXdrX1ZpZXdfVGlsZWQiOworICAgICAgICBfcGFyZW50X3NjLnNjLm5hbWUgPSBld2tW aWV3VGlsZWROYW1lOwogICAgICAgICBld2tfdmlld19iYXNlX3NtYXJ0X3NldCgmX3BhcmVudF9z Yyk7CiAgICAgICAgIGFwaS0+c2MucGFyZW50ID0gcmVpbnRlcnByZXRfY2FzdDxFdmFzX1NtYXJ0 X0NsYXNzKj4oJl9wYXJlbnRfc2MpOwogICAgIH0KQEAgLTM3NCw3ICszNzQsNyBAQCBFaW5hX0Jv b2wgZXdrX3ZpZXdfdGlsZWRfc21hcnRfc2V0KEV3a19WaWV3X1NtYXJ0X0NsYXNzKiBhcGkpCiAK IHN0YXRpYyBpbmxpbmUgRXZhc19TbWFydCogX2V3a192aWV3X3RpbGVkX3NtYXJ0X2NsYXNzX25l dyh2b2lkKQogewotICAgIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkgPSBFV0tfVklF V19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lPTigiRVdLX1ZpZXdfVGlsZWQiKTsKKyAgICBz dGF0aWMgRXdrX1ZpZXdfU21hcnRfQ2xhc3MgYXBpID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5J VF9OQU1FX1ZFUlNJT04oZXdrVmlld1RpbGVkTmFtZSk7CiAgICAgc3RhdGljIEV2YXNfU21hcnQq IHNtYXJ0ID0gMDsKIAogICAgIGlmIChFSU5BX1VOTElLRUxZKCFzbWFydCkpIHsK 122700 2012-01-16 17:59:06 -0800 2012-01-18 01:31:45 -0800 proposed patch tiled_view_name3.patch text/plain 3755 eunsol47.park ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyMjQ2MjJiLi5jODAyMGZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMTYgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0Bz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBEZWZpbmUgdGhlIG5hbWVzIG9mIHZpZXcgc21h cnQgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RyaW5ncyBvZiBld2tfdGlsZWRfdmlldydzIG5hbWUgd2VyZSBkZWZpbmVkIGRpZmZlcmVudGx5 LAorICAgICAgICBzbyB0aGUgZGVmaW5pdGlvbnMgd2VyZSBtb2RpZmllZCB0byBtYWtlIHVzZXJz IG5vdCBjb25mdXNlZC4KKworICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgorICAgICAgICAq IGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgICogZXdrL2V3a192aWV3X3NpbmdsZS5jcHA6Cisg ICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2NsYXNzX25ldyk6CisgICAgICAgICogZXdr L2V3a192aWV3X3RpbGVkLmNwcDoKKyAgICAgICAgKGV3a192aWV3X3RpbGVkX3NtYXJ0X3NldCk6 CisgICAgICAgIChfZXdrX3ZpZXdfdGlsZWRfc21hcnRfY2xhc3NfbmV3KToKKwogMjAxMi0wMS0x MyAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBb RUZMXSBTZWN1cml0eVBvbGljeSB3aGl0ZWxpc3QgaW50ZXJmYWNlIHNob3VsZCBiZSBleHBvc2Vk IHRvIEVXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0 ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXggYjFjNjAzMC4u YjIyNWExNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTU4LDYgKzU4LDEw IEBAIHN0cnVjdCBfRXdrX0pTX09iamVjdCB7CiB9OwogI2VuZGlmIC8vIEVOQUJMRShORVRTQ0FQ RV9QTFVHSU5fQVBJKQogCisvLyBEZWZpbmVzIHRoZSBuYW1lcyBmb3IgaW5pdGlhbGl6aW5nIGV3 a192aWV3X3NtYXJ0X2NsYXNzCitzdGF0aWMgY29uc3QgY2hhciBld2tWaWV3VGlsZWROYW1lW10g PSAiRXdrX1ZpZXdfVGlsZWQiOworc3RhdGljIGNvbnN0IGNoYXIgZXdrVmlld1NpbmdsZU5hbWVb XSA9ICJFd2tfVmlld19TaW5nbGUiOworCiAvLyBmb3J3YXJkIGRlY2xhcmF0aW9ucwogbmFtZXNw YWNlIFdlYkNvcmUgewogc3RydWN0IFBvcHVwTWVudUNsaWVudDsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwCmluZGV4IDdmZGJjMTEuLmExM2NmMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmNwcApAQCAtMjY2LDggKzI2Niw4IEBAIHN0cnVjdCBfRXdrX1ZpZXdfUHJpdmF0ZV9EYXRh IHsKICAgICB9CiAKICNkZWZpbmUgRVdLX1ZJRVdfVElMRURfVFlQRV9DSEVDS19PUl9SRVRVUk4o ZXdrVmlldywgLi4uKSBcCi0gICAgaWYgKCFldmFzX29iamVjdF9zbWFydF90eXBlX2NoZWNrKGV3 a1ZpZXcsICJFd2tfVmlld19UaWxlZCIpKSB7IFwKLSAgICAgICAgSU5GKCJvYmplY3QgaXMgbm90 IGEgaW5zdGFuY2Ugb2YgRXdrX1ZpZXdfVGlsZWQiKTsgXAorICAgIGlmICghZXZhc19vYmplY3Rf c21hcnRfdHlwZV9jaGVjayhld2tWaWV3LCBld2tWaWV3VGlsZWROYW1lKSkgeyBcCisgICAgICAg IElORigib2JqZWN0IGlzbid0IGFuIGluc3RhbmNlIG9mIGV3a1ZpZXdUaWxlZE5hbWUiKTsgXAog ICAgICAgICByZXR1cm4gX19WQV9BUkdTX187IFwKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3X3NpbmdsZS5jcHAKaW5kZXggZWQ3MjYzMy4uZTVlOGVlZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3NpbmdsZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3NpbmdsZS5jcHAKQEAgLTM5Niw3ICszOTYsNyBAQCBF aW5hX0Jvb2wgZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X3NldChFd2tfVmlld19TbWFydF9DbGFzcyog YXBpKQogCiBzdGF0aWMgaW5saW5lIEV2YXNfU21hcnQqIF9ld2tfdmlld19zaW5nbGVfc21hcnRf Y2xhc3NfbmV3KHZvaWQpCiB7Ci0gICAgc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9 IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9WRVJTSU9OKCJFd2tfVmlld19TaW5nbGUi KTsKKyAgICBzdGF0aWMgRXdrX1ZpZXdfU21hcnRfQ2xhc3MgYXBpID0gRVdLX1ZJRVdfU01BUlRf Q0xBU1NfSU5JVF9OQU1FX1ZFUlNJT04oZXdrVmlld1NpbmdsZU5hbWUpOwogICAgIHN0YXRpYyBF dmFzX1NtYXJ0KiBzbWFydCA9IDA7CiAKICAgICBpZiAoRUlOQV9VTkxJS0VMWSghc21hcnQpKSB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQuY3BwIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmNwcAppbmRleCAzMTAxYzEyLi43 ZmVjZTdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld190aWxlZC5jcHAKQEAgLTM0 Nyw3ICszNDcsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfdGlsZWRfc21hcnRfc2V0KEV3a19WaWV3 X1NtYXJ0X0NsYXNzKiBhcGkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChFSU5B X1VOTElLRUxZKCFfcGFyZW50X3NjLnNjLmFkZCkpIHsKLSAgICAgICAgX3BhcmVudF9zYy5zYy5u YW1lID0gICJFd2tfVmlld19UaWxlZCI7CisgICAgICAgIF9wYXJlbnRfc2Muc2MubmFtZSA9IGV3 a1ZpZXdUaWxlZE5hbWU7CiAgICAgICAgIGV3a192aWV3X2Jhc2Vfc21hcnRfc2V0KCZfcGFyZW50 X3NjKTsKICAgICAgICAgYXBpLT5zYy5wYXJlbnQgPSByZWludGVycHJldF9jYXN0PEV2YXNfU21h cnRfQ2xhc3MqPigmX3BhcmVudF9zYyk7CiAgICAgfQpAQCAtMzc0LDcgKzM3NCw3IEBAIEVpbmFf Qm9vbCBld2tfdmlld190aWxlZF9zbWFydF9zZXQoRXdrX1ZpZXdfU21hcnRfQ2xhc3MqIGFwaSkK IAogc3RhdGljIGlubGluZSBFdmFzX1NtYXJ0KiBfZXdrX3ZpZXdfdGlsZWRfc21hcnRfY2xhc3Nf bmV3KHZvaWQpCiB7Ci0gICAgc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19W SUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9WRVJTSU9OKCJFV0tfVmlld19UaWxlZCIpOworICAg IHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkgPSBFV0tfVklFV19TTUFSVF9DTEFTU19J TklUX05BTUVfVkVSU0lPTihld2tWaWV3VGlsZWROYW1lKTsKICAgICBzdGF0aWMgRXZhc19TbWFy dCogc21hcnQgPSAwOwogCiAgICAgaWYgKEVJTkFfVU5MSUtFTFkoIXNtYXJ0KSkgewo= 122889 2012-01-18 01:31:45 -0800 2012-01-29 17:45:15 -0800 proposed patch tiled_view_name4.patch text/plain 3741 eunsol47.park ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyMjQ2MjJiLi5jODAyMGZmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMTYgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0Bz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBEZWZpbmUgdGhlIG5hbWVzIG9mIHZpZXcgc21h cnQgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RyaW5ncyBvZiBld2tfdGlsZWRfdmlldydzIG5hbWUgd2VyZSBkZWZpbmVkIGRpZmZlcmVudGx5 LAorICAgICAgICBzbyB0aGUgZGVmaW5pdGlvbnMgd2VyZSBtb2RpZmllZCB0byBtYWtlIHVzZXJz IG5vdCBjb25mdXNlZC4KKworICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgorICAgICAgICAq IGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgICogZXdrL2V3a192aWV3X3NpbmdsZS5jcHA6Cisg ICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2NsYXNzX25ldyk6CisgICAgICAgICogZXdr L2V3a192aWV3X3RpbGVkLmNwcDoKKyAgICAgICAgKGV3a192aWV3X3RpbGVkX3NtYXJ0X3NldCk6 CisgICAgICAgIChfZXdrX3ZpZXdfdGlsZWRfc21hcnRfY2xhc3NfbmV3KToKKwogMjAxMi0wMS0x MyAgTGVhbmRybyBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBb RUZMXSBTZWN1cml0eVBvbGljeSB3aGl0ZWxpc3QgaW50ZXJmYWNlIHNob3VsZCBiZSBleHBvc2Vk IHRvIEVXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0 ZS5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXggYjFjNjAzMC4u YmJmZjczNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKQEAgLTU4LDYgKzU4LDEw IEBAIHN0cnVjdCBfRXdrX0pTX09iamVjdCB7CiB9OwogI2VuZGlmIC8vIEVOQUJMRShORVRTQ0FQ RV9QTFVHSU5fQVBJKQogCisvLyBEZWZpbmVzIHRoZSBuYW1lcyBmb3IgaW5pdGlhbGl6aW5nIGV3 a192aWV3X3NtYXJ0X2NsYXNzCitjb25zdCBjaGFyIGV3a1ZpZXdUaWxlZE5hbWVbXSA9ICJFd2tf Vmlld19UaWxlZCI7Citjb25zdCBjaGFyIGV3a1ZpZXdTaW5nbGVOYW1lW10gPSAiRXdrX1ZpZXdf U2luZ2xlIjsKKwogLy8gZm9yd2FyZCBkZWNsYXJhdGlvbnMKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IHN0cnVjdCBQb3B1cE1lbnVDbGllbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRl eCA3ZmRiYzExLi5hMTNjZjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTI2 Niw4ICsyNjYsOCBAQCBzdHJ1Y3QgX0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgfQogCiAj ZGVmaW5lIEVXS19WSUVXX1RJTEVEX1RZUEVfQ0hFQ0tfT1JfUkVUVVJOKGV3a1ZpZXcsIC4uLikg XAotICAgIGlmICghZXZhc19vYmplY3Rfc21hcnRfdHlwZV9jaGVjayhld2tWaWV3LCAiRXdrX1Zp ZXdfVGlsZWQiKSkgeyBcCi0gICAgICAgIElORigib2JqZWN0IGlzIG5vdCBhIGluc3RhbmNlIG9m IEV3a19WaWV3X1RpbGVkIik7IFwKKyAgICBpZiAoIWV2YXNfb2JqZWN0X3NtYXJ0X3R5cGVfY2hl Y2soZXdrVmlldywgZXdrVmlld1RpbGVkTmFtZSkpIHsgXAorICAgICAgICBJTkYoIm9iamVjdCBp c24ndCBhbiBpbnN0YW5jZSBvZiBld2tWaWV3VGlsZWROYW1lIik7IFwKICAgICAgICAgcmV0dXJu IF9fVkFfQVJHU19fOyBcCiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXdfc2luZ2xlLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19z aW5nbGUuY3BwCmluZGV4IGVkNzI2MzMuLmU1ZThlZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdmlld19zaW5nbGUuY3BwCkBAIC0zOTYsNyArMzk2LDcgQEAgRWluYV9Cb29sIGV3a192 aWV3X3NpbmdsZV9zbWFydF9zZXQoRXdrX1ZpZXdfU21hcnRfQ2xhc3MqIGFwaSkKIAogc3RhdGlj IGlubGluZSBFdmFzX1NtYXJ0KiBfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2NsYXNzX25ldyh2b2lk KQogewotICAgIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkgPSBFV0tfVklFV19TTUFS VF9DTEFTU19JTklUX05BTUVfVkVSU0lPTigiRXdrX1ZpZXdfU2luZ2xlIik7CisgICAgc3RhdGlj IEV3a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFN RV9WRVJTSU9OKGV3a1ZpZXdTaW5nbGVOYW1lKTsKICAgICBzdGF0aWMgRXZhc19TbWFydCogc21h cnQgPSAwOwogCiAgICAgaWYgKEVJTkFfVU5MSUtFTFkoIXNtYXJ0KSkgewpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmNwcCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlld190aWxlZC5jcHAKaW5kZXggMzEwMWMxMi4uN2ZlY2U3YyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3RpbGVkLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQuY3BwCkBAIC0zNDcsNyArMzQ3LDcgQEAg RWluYV9Cb29sIGV3a192aWV3X3RpbGVkX3NtYXJ0X3NldChFd2tfVmlld19TbWFydF9DbGFzcyog YXBpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoRUlOQV9VTkxJS0VMWSghX3Bh cmVudF9zYy5zYy5hZGQpKSB7Ci0gICAgICAgIF9wYXJlbnRfc2Muc2MubmFtZSA9ICAiRXdrX1Zp ZXdfVGlsZWQiOworICAgICAgICBfcGFyZW50X3NjLnNjLm5hbWUgPSBld2tWaWV3VGlsZWROYW1l OwogICAgICAgICBld2tfdmlld19iYXNlX3NtYXJ0X3NldCgmX3BhcmVudF9zYyk7CiAgICAgICAg IGFwaS0+c2MucGFyZW50ID0gcmVpbnRlcnByZXRfY2FzdDxFdmFzX1NtYXJ0X0NsYXNzKj4oJl9w YXJlbnRfc2MpOwogICAgIH0KQEAgLTM3NCw3ICszNzQsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdf dGlsZWRfc21hcnRfc2V0KEV3a19WaWV3X1NtYXJ0X0NsYXNzKiBhcGkpCiAKIHN0YXRpYyBpbmxp bmUgRXZhc19TbWFydCogX2V3a192aWV3X3RpbGVkX3NtYXJ0X2NsYXNzX25ldyh2b2lkKQogewot ICAgIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkgPSBFV0tfVklFV19TTUFSVF9DTEFT U19JTklUX05BTUVfVkVSU0lPTigiRVdLX1ZpZXdfVGlsZWQiKTsKKyAgICBzdGF0aWMgRXdrX1Zp ZXdfU21hcnRfQ2xhc3MgYXBpID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9OQU1FX1ZFUlNJ T04oZXdrVmlld1RpbGVkTmFtZSk7CiAgICAgc3RhdGljIEV2YXNfU21hcnQqIHNtYXJ0ID0gMDsK IAogICAgIGlmIChFSU5BX1VOTElLRUxZKCFzbWFydCkpIHsK 124479 2012-01-29 17:45:15 -0800 2012-01-30 21:03:17 -0800 proposed patch tiled_view_name5.patch text/plain 3722 eunsol47.park ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA4OGQzYWU5Li5lYmU0OTgyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDEtMjkgIEV1bnNvbCBQYXJrICA8ZXVuc29sNDcucGFya0Bz YW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBEZWZpbmUgdGhlIG5hbWVzIG9mIHZpZXcgc21h cnQgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RyaW5ncyBvZiBld2tfdGlsZWRfdmlldydzIG5hbWUgd2VyZSBkZWZpbmVkIGRpZmZlcmVudGx5 LAorICAgICAgICBzbyB0aGUgZGVmaW5pdGlvbnMgd2VyZSBtb2RpZmllZCB0byBtYWtlIHVzZXJz IG5vdCBjb25mdXNlZC4KKworICAgICAgICAqIGV3ay9ld2tfcHJpdmF0ZS5oOgorICAgICAgICAq IGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgICogZXdrL2V3a192aWV3X3NpbmdsZS5jcHA6Cisg ICAgICAgIChfZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X2NsYXNzX25ldyk6CisgICAgICAgICogZXdr L2V3a192aWV3X3RpbGVkLmNwcDoKKyAgICAgICAgKGV3a192aWV3X3RpbGVkX3NtYXJ0X3NldCk6 CisgICAgICAgIChfZXdrX3ZpZXdfdGlsZWRfc21hcnRfY2xhc3NfbmV3KToKKwogMjAxMi0wMS0y NiAgVG9tYXN6IE1vcmF3c2tpICA8dC5tb3Jhd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBb RUZMXSBBZGRlZCBtaXNzaW5nIE5FVFNDQVBFX1BMVUdJTl9BUEkgbWFjcm8uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfcHJpdmF0ZS5oCmluZGV4IGIxYzYwMzAuLmJiZmY3MzQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfcHJpdmF0ZS5oCkBAIC01OCw2ICs1OCwxMCBAQCBzdHJ1Y3QgX0V3a19KU19PYmpl Y3QgewogfTsKICNlbmRpZiAvLyBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIAorLy8gRGVm aW5lcyB0aGUgbmFtZXMgZm9yIGluaXRpYWxpemluZyBld2tfdmlld19zbWFydF9jbGFzcworY29u c3QgY2hhciBld2tWaWV3VGlsZWROYW1lW10gPSAiRXdrX1ZpZXdfVGlsZWQiOworY29uc3QgY2hh ciBld2tWaWV3U2luZ2xlTmFtZVtdID0gIkV3a19WaWV3X1NpbmdsZSI7CisKIC8vIGZvcndhcmQg ZGVjbGFyYXRpb25zCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiBzdHJ1Y3QgUG9wdXBNZW51Q2xpZW50 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggYTY4YmJhYi4uODUzYjM0MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0yNjcsOCArMjY3LDggQEAgc3RydWN0IF9F d2tfVmlld19Qcml2YXRlX0RhdGEgewogICAgIH0KIAogI2RlZmluZSBFV0tfVklFV19USUxFRF9U WVBFX0NIRUNLX09SX1JFVFVSTihld2tWaWV3LCAuLi4pIFwKLSAgICBpZiAoIWV2YXNfb2JqZWN0 X3NtYXJ0X3R5cGVfY2hlY2soZXdrVmlldywgIkV3a19WaWV3X1RpbGVkIikpIHsgXAotICAgICAg ICBJTkYoIm9iamVjdCBpcyBub3QgYSBpbnN0YW5jZSBvZiBFd2tfVmlld19UaWxlZCIpOyBcCisg ICAgaWYgKCFldmFzX29iamVjdF9zbWFydF90eXBlX2NoZWNrKGV3a1ZpZXcsIGV3a1ZpZXdUaWxl ZE5hbWUpKSB7IFwKKyAgICAgICAgSU5GKCJvYmplY3QgaXNuJ3QgYW4gaW5zdGFuY2Ugb2YgJXMi LCBld2tWaWV3VGlsZWROYW1lKTsgXAogICAgICAgICByZXR1cm4gX19WQV9BUkdTX187IFwKICAg ICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlld19zaW5nbGUu Y3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3NpbmdsZS5jcHAKaW5kZXggZWQ3 MjYzMy4uZTVlOGVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 X3NpbmdsZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3NpbmdsZS5j cHAKQEAgLTM5Niw3ICszOTYsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfc2luZ2xlX3NtYXJ0X3Nl dChFd2tfVmlld19TbWFydF9DbGFzcyogYXBpKQogCiBzdGF0aWMgaW5saW5lIEV2YXNfU21hcnQq IF9ld2tfdmlld19zaW5nbGVfc21hcnRfY2xhc3NfbmV3KHZvaWQpCiB7Ci0gICAgc3RhdGljIEV3 a19WaWV3X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9W RVJTSU9OKCJFd2tfVmlld19TaW5nbGUiKTsKKyAgICBzdGF0aWMgRXdrX1ZpZXdfU21hcnRfQ2xh c3MgYXBpID0gRVdLX1ZJRVdfU01BUlRfQ0xBU1NfSU5JVF9OQU1FX1ZFUlNJT04oZXdrVmlld1Np bmdsZU5hbWUpOwogICAgIHN0YXRpYyBFdmFzX1NtYXJ0KiBzbWFydCA9IDA7CiAKICAgICBpZiAo RUlOQV9VTkxJS0VMWSghc21hcnQpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXdfdGlsZWQuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3X3Rp bGVkLmNwcAppbmRleCBiNzJkNmFlLi5lNWI4MjYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ZpZXdfdGlsZWQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdmlld190aWxlZC5jcHAKQEAgLTM0Nyw3ICszNDcsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdf dGlsZWRfc21hcnRfc2V0KEV3a19WaWV3X1NtYXJ0X0NsYXNzKiBhcGkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgIGlmIChFSU5BX1VOTElLRUxZKCFfcGFyZW50X3NjLnNjLmFkZCkpIHsK LSAgICAgICAgX3BhcmVudF9zYy5zYy5uYW1lID0gICJFd2tfVmlld19UaWxlZCI7CisgICAgICAg IF9wYXJlbnRfc2Muc2MubmFtZSA9IGV3a1ZpZXdUaWxlZE5hbWU7CiAgICAgICAgIGV3a192aWV3 X2Jhc2Vfc21hcnRfc2V0KCZfcGFyZW50X3NjKTsKICAgICAgICAgYXBpLT5zYy5wYXJlbnQgPSBy ZWludGVycHJldF9jYXN0PEV2YXNfU21hcnRfQ2xhc3MqPigmX3BhcmVudF9zYyk7CiAgICAgfQpA QCAtMzc0LDcgKzM3NCw3IEBAIEVpbmFfQm9vbCBld2tfdmlld190aWxlZF9zbWFydF9zZXQoRXdr X1ZpZXdfU21hcnRfQ2xhc3MqIGFwaSkKIAogc3RhdGljIGlubGluZSBFdmFzX1NtYXJ0KiBfZXdr X3ZpZXdfdGlsZWRfc21hcnRfY2xhc3NfbmV3KHZvaWQpCiB7Ci0gICAgc3RhdGljIEV3a19WaWV3 X1NtYXJ0X0NsYXNzIGFwaSA9IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTkFNRV9WRVJTSU9O KCJFV0tfVmlld19UaWxlZCIpOworICAgIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBhcGkg PSBFV0tfVklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lPTihld2tWaWV3VGlsZWROYW1l KTsKICAgICBzdGF0aWMgRXZhc19TbWFydCogc21hcnQgPSAwOwogCiAgICAgaWYgKEVJTkFfVU5M SUtFTFkoIXNtYXJ0KSkgewo=