76344 2012-01-15 09:16:36 -0800 [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions 2012-01-25 12:39:18 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76343 1 mrobinson mrobinson andersca cgarcia sam oldest_to_newest 536264 0 mrobinson 2012-01-15 09:16:36 -0800 During policy decision, navigation events that were not triggered by the mouse should claim that they were triggered by WebMouseEvent::NoButton intsead of WebMouseEvent::LeftButton. 536271 1 122569 mrobinson 2012-01-15 10:33:58 -0800 Created attachment 122569 Patch 539897 2 122569 sam 2012-01-20 16:21:42 -0800 Comment on attachment 122569 Patch If you can, it would be great to add a test case to TestWebKitAPI, but it is not absolutely necessary for this simple a fix. 540161 3 123454 mrobinson 2012-01-21 12:06:17 -0800 Created attachment 123454 Patch adding test 540162 4 mrobinson 2012-01-21 12:09:22 -0800 Added a patch with a test. GTK+ doesn't yet build the C API tests yet, so I'm doing this blindly. If it passes the EWS I'll land it and watch the bots. Thanks for the review! 542534 5 mrobinson 2012-01-25 12:37:19 -0800 Committed r105916: <http://trac.webkit.org/changeset/105916> 122569 2012-01-15 10:33:58 -0800 2012-01-25 12:39:07 -0800 Patch bug-76344-20120115103357.patch text/plain 2530 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2RlNDkxY2JmYjhmZmRl YzNkZWVjMTNhZTU4MDE3Zjc2ZTlkMjNlMC4uMWExY2M3MTE0OWRmZGQ2MzE0MDlmNTJjMDViOGM3 NTk3ZTJiM2UxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTE1ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbV0syXSBOYXZp Z2F0aW9uIGV2ZW50cyBub3QgdHJpZ2dlcmVkIGJ5IGEgbW91c2UgZXZlbnQgY2xhaW0gdG8gYmUg dHJpZ2dlcmVkIGJ5IHRoZSBsZWZ0IG1vdXNlIGJ1dHRvbiBkdXJpbmcgcG9saWN5IGRlY2lzaW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYzNDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGNy ZWF0aW5nIEluamVjdGVkQnVuZGxlTmF2aWdhdGlvbkFjdGlvbnMsIGluaXRpYWxpemUgdGhlIG1v dXNlIGJ1dHRvbiB0byBOb0J1dHRvbi4KKyAgICAgICAgVGhpcyBlbnN1cmVzIHRoYXQgd2hlbiB0 aGVyZSBpcyBubyBtb3VzZSBldmVudCBhc3NvY2lhdGVkIHdpdGggdGhlIGFjdGlvbiwgd2hlbiB0 aGUgZXZlbnQKKyAgICAgICAgaGl0cyB0aGUgY2xpZW50LUFQSSBsYXllciwgdGhlIGJ1dHRvbiBp cyBzdGlsbCBOb0J1dHRvbi4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv SW5qZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5q ZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9uOjpJbmplY3RlZEJ1bmRsZU5hdmlnYXRpb25BY3Rp b24pOiBJbml0aWFsaXplIG1fbW91c2VCdXR0b24KKyAgICAgICAgdG8gV2ViTW91c2VFdmVudDo6 Tm9CdXR0b24uCisKIDIwMTItMDEtMTQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4K IAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA2OTYyOTU+IENyYXNoIGluIFdlYlByb2Nlc3Mg YXQgY29tLmFwcGxlLkNGTmV0d29yazogVVJMQ3JlZGVudGlhbFN0b3JhZ2U6OkNyZWF0ZUN1cnJl bnRQZXJzaXN0ZW50Q3JlZGVudGlhbHMgKyAyOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9u LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRC dW5kbGVOYXZpZ2F0aW9uQWN0aW9uLmNwcAppbmRleCA3YTQwZWU2ZmI0Zjg4NTE0NDAyNDA0YmY2 MjcwYmMzNWI3Njc4OTU3Li40MjgxMzU0ODFhZmQ5YzUxYjNhYmQyNzZjZTg2MTZkMzk2ZjhiNDNl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0lu amVjdGVkQnVuZGxlTmF2aWdhdGlvbkFjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZU5hdmlnYXRpb25BY3Rpb24uY3Bw CkBAIC04NiwxMCArODYsMTAgQEAgUGFzc1JlZlB0cjxJbmplY3RlZEJ1bmRsZU5hdmlnYXRpb25B Y3Rpb24+IEluamVjdGVkQnVuZGxlTmF2aWdhdGlvbkFjdGlvbjo6Y3JlYXQKIH0KIAogSW5qZWN0 ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9uOjpJbmplY3RlZEJ1bmRsZU5hdmlnYXRpb25BY3Rpb24o V2ViRnJhbWUqIGZyYW1lLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uJiBuYXZpZ2F0aW9uQWN0aW9u LCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4gcHJwRm9ybVN0YXRlKQorICAgIDogbV9uYXZpZ2F0aW9u VHlwZShuYXZpZ2F0aW9uQWN0aW9uLnR5cGUoKSkKKyAgICAsIG1fbW9kaWZpZXJzKG1vZGlmaWVy c0Zvck5hdmlnYXRpb25BY3Rpb24obmF2aWdhdGlvbkFjdGlvbikpCisgICAgLCBtX21vdXNlQnV0 dG9uKFdlYk1vdXNlRXZlbnQ6Ok5vQnV0dG9uKQogewotICAgIG1fbmF2aWdhdGlvblR5cGUgICAg PSBuYXZpZ2F0aW9uQWN0aW9uLnR5cGUoKTsKLSAgICBtX21vZGlmaWVycyAgICAgICAgID0gbW9k aWZpZXJzRm9yTmF2aWdhdGlvbkFjdGlvbihuYXZpZ2F0aW9uQWN0aW9uKTsKLQogICAgIGlmIChj b25zdCBNb3VzZUV2ZW50KiBtb3VzZUV2ZW50ID0gbW91c2VFdmVudEZvck5hdmlnYXRpb25BY3Rp b24obmF2aWdhdGlvbkFjdGlvbikpIHsKICAgICAgICAgbV9oaXRUZXN0UmVzdWx0ID0gSW5qZWN0 ZWRCdW5kbGVIaXRUZXN0UmVzdWx0OjpjcmVhdGUoZnJhbWUtPmNvcmVGcmFtZSgpLT5ldmVudEhh bmRsZXIoKS0+aGl0VGVzdFJlc3VsdEF0UG9pbnQobW91c2VFdmVudC0+YWJzb2x1dGVMb2NhdGlv bigpLCBmYWxzZSkpOwogICAgICAgICBtX21vdXNlQnV0dG9uICAgPSBtb3VzZUJ1dHRvbkZvck1v dXNlRXZlbnQobW91c2VFdmVudCk7Cg== 123454 2012-01-21 12:06:17 -0800 2012-01-25 12:39:18 -0800 Patch adding test bug-76344-20120121120617.patch text/plain 4708 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjExY2ZmY2UyNDBhODU0 ZTNmNWEzMDM1MmU1NDVmNmZkZTRjOGE2My4uZjQ5OGIwZmI1ODE4NzQ3ZGNjZThhZWY1YmI3N2Nj NmE5Y2JlZTJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTIxICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbV0syXSBOYXZp Z2F0aW9uIGV2ZW50cyBub3QgdHJpZ2dlcmVkIGJ5IGEgbW91c2UgZXZlbnQgY2xhaW0gdG8gYmUg dHJpZ2dlcmVkIGJ5IHRoZSBsZWZ0IG1vdXNlIGJ1dHRvbiBkdXJpbmcgcG9saWN5IGRlY2lzaW9u cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYzNDQK KworICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgorCisgICAgICAgIFdoZW4gY3JlYXRp bmcgSW5qZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9ucywgaW5pdGlhbGl6ZSB0aGUgbW91c2Ug YnV0dG9uIHRvIE5vQnV0dG9uLgorICAgICAgICBUaGlzIGVuc3VyZXMgdGhhdCB3aGVuIHRoZXJl IGlzIG5vIG1vdXNlIGV2ZW50IGFzc29jaWF0ZWQgd2l0aCB0aGUgYWN0aW9uLCB3aGVuIHRoZSBl dmVudAorICAgICAgICBoaXRzIHRoZSBjbGllbnQtQVBJIGxheWVyLCB0aGUgYnV0dG9uIGlzIHN0 aWxsIE5vQnV0dG9uLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZU5hdmlnYXRpb25BY3Rpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpJbmplY3Rl ZEJ1bmRsZU5hdmlnYXRpb25BY3Rpb246OkluamVjdGVkQnVuZGxlTmF2aWdhdGlvbkFjdGlvbik6 IEluaXRpYWxpemUgbV9tb3VzZUJ1dHRvbgorICAgICAgICB0byBXZWJNb3VzZUV2ZW50OjpOb0J1 dHRvbi4KKwogMjAxMi0wMS0yMSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSBXZWJLaXQyIHJlbWVtYmVyIHRoZSBoZWlnaHQgb2YgdGhlIFdlYiBJ bnNwZWN0b3Igd2hlbiBpdCBpcyBkb2NrZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlTmF2aWdhdGlvbkFjdGlvbi5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVu ZGxlTmF2aWdhdGlvbkFjdGlvbi5jcHAKaW5kZXggN2E0MGVlNmZiNGY4ODUxNDQwMjQwNGJmNjI3 MGJjMzViNzY3ODk1Ny4uNDI4MTM1NDgxYWZkOWM1MWIzYWJkMjc2Y2U4NjE2ZDM5NmY4YjQzZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9Jbmpl Y3RlZEJ1bmRsZU5hdmlnYXRpb25BY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9uLmNwcApA QCAtODYsMTAgKzg2LDEwIEBAIFBhc3NSZWZQdHI8SW5qZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0 aW9uPiBJbmplY3RlZEJ1bmRsZU5hdmlnYXRpb25BY3Rpb246OmNyZWF0CiB9CiAKIEluamVjdGVk QnVuZGxlTmF2aWdhdGlvbkFjdGlvbjo6SW5qZWN0ZWRCdW5kbGVOYXZpZ2F0aW9uQWN0aW9uKFdl YkZyYW1lKiBmcmFtZSwgY29uc3QgTmF2aWdhdGlvbkFjdGlvbiYgbmF2aWdhdGlvbkFjdGlvbiwg UGFzc1JlZlB0cjxGb3JtU3RhdGU+IHBycEZvcm1TdGF0ZSkKKyAgICA6IG1fbmF2aWdhdGlvblR5 cGUobmF2aWdhdGlvbkFjdGlvbi50eXBlKCkpCisgICAgLCBtX21vZGlmaWVycyhtb2RpZmllcnNG b3JOYXZpZ2F0aW9uQWN0aW9uKG5hdmlnYXRpb25BY3Rpb24pKQorICAgICwgbV9tb3VzZUJ1dHRv bihXZWJNb3VzZUV2ZW50OjpOb0J1dHRvbikKIHsKLSAgICBtX25hdmlnYXRpb25UeXBlICAgID0g bmF2aWdhdGlvbkFjdGlvbi50eXBlKCk7Ci0gICAgbV9tb2RpZmllcnMgICAgICAgICA9IG1vZGlm aWVyc0Zvck5hdmlnYXRpb25BY3Rpb24obmF2aWdhdGlvbkFjdGlvbik7Ci0KICAgICBpZiAoY29u c3QgTW91c2VFdmVudCogbW91c2VFdmVudCA9IG1vdXNlRXZlbnRGb3JOYXZpZ2F0aW9uQWN0aW9u KG5hdmlnYXRpb25BY3Rpb24pKSB7CiAgICAgICAgIG1faGl0VGVzdFJlc3VsdCA9IEluamVjdGVk QnVuZGxlSGl0VGVzdFJlc3VsdDo6Y3JlYXRlKGZyYW1lLT5jb3JlRnJhbWUoKS0+ZXZlbnRIYW5k bGVyKCktPmhpdFRlc3RSZXN1bHRBdFBvaW50KG1vdXNlRXZlbnQtPmFic29sdXRlTG9jYXRpb24o KSwgZmFsc2UpKTsKICAgICAgICAgbV9tb3VzZUJ1dHRvbiAgID0gbW91c2VCdXR0b25Gb3JNb3Vz ZUV2ZW50KG1vdXNlRXZlbnQpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMv Q2hhbmdlTG9nCmluZGV4IGE3NjQxY2U5ZGU4NjQyMTg1YWQxN2VhODdmMjZlYmJjNTZlM2IxYmEu LmM2ODg1Y2MwYTBmYWFiMDczMjAxOGE5NzdmN2MzN2RjZTc2NTFlMWYgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx Mi0wMS0yMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW1dLMl0gTmF2aWdhdGlvbiBldmVudHMgbm90IHRyaWdnZXJlZCBieSBhIG1vdXNlIGV2ZW50 IGNsYWltIHRvIGJlIHRyaWdnZXJlZCBieSB0aGUgbGVmdCBtb3VzZSBidXR0b24gZHVyaW5nIHBv bGljeSBkZWNpc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc2MzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgdGVzdCB2ZXJpZnlpbmcgdGhhdCB0aGUgbW91c2UgYnV0dG9uIGR1cmluZyBw b2xpY3kgZGVjaXNpb25zIGZvcgorICAgICAgICBldmVudHMgbm90IHRyaWdnZXJlZCBieSBtb3Vz ZSBldmVudHMgaXMgTm9CdXR0b24uCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDIvUGFnZUxvYWRCYXNpYy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpkZWNpZGVQ b2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKTogQWRkZWQgdGVzdC4KKyAgICAgICAgKFRlc3RXZWJL aXRBUEk6OmRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbik6IEFkZGVkIHRlc3QuCisKIDIw MTItMDEtMjAgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRo ZSBsZWFreSBEQyBjaGVjayBzaG91bGQgdXNlIGFkb3B0UHRyIGFzIGEgc2lnbmFsIGluc3RlYWQg b2YgT3duUHRyIHRvIGdldCBsZXNzIGZhbHNlIHBvc2l0aXZlcy4KZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9QYWdlTG9hZEJhc2ljLmNwcCBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9QYWdlTG9hZEJhc2ljLmNwcAppbmRleCAwMTkxYjY1 OTNkZDY1MmEwMTM3MjNjM2FjZGU0NzQ5ZmUxOTQ0NzI5Li5mN2JiZjczMmZmNmY0NGQyYjhlMzNm NmI1NmNjYWRiYWI0ZDc5NzUxIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdDIvUGFnZUxvYWRCYXNpYy5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXQyL1BhZ2VMb2FkQmFzaWMuY3BwCkBAIC05MCw2ICs5MCw3IEBAIHN0YXRpYyB2b2lk IGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVS ZWYgZnJhbWUsIFdLCiAgICAgU3RhdGUqIHN0YXRlID0gcmVpbnRlcnByZXRfY2FzdDxTdGF0ZSo+ KGNvbnN0X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8pKTsKICAgICBFWFBFQ1RfRkFMU0Uoc3RhdGUt PmRpZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUpOwogICAgIEVYUEVDVF9GQUxTRShzdGF0 ZS0+ZGlkQ29tbWl0TG9hZEZvckZyYW1lKTsKKyAgICBFWFBFQ1RfVFJVRShtb3VzZUJ1dHRvbiA9 IGtXS0V2ZW50TW91c2VCdXR0b25Ob0J1dHRvbik7CiAKICAgICBzdGF0ZS0+ZGlkRGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvbkFjdGlvbiA9IHRydWU7CiAKQEAgLTk4LDYgKzk5LDcgQEAgc3RhdGlj IHZvaWQgZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihXS1BhZ2VSZWYgcGFnZSwgV0tG cmFtZVJlZiBmcmFtZSwgV0sKIAogc3RhdGljIHZvaWQgZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93 QWN0aW9uKFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS0ZyYW1lTmF2aWdhdGlv blR5cGUgbmF2aWdhdGlvblR5cGUsIFdLRXZlbnRNb2RpZmllcnMgbW9kaWZpZXJzLCBXS0V2ZW50 TW91c2VCdXR0b24gbW91c2VCdXR0b24sIFdLVVJMUmVxdWVzdFJlZiByZXF1ZXN0LCBXS1N0cmlu Z1JlZiBmcmFtZU5hbWUsIFdLRnJhbWVQb2xpY3lMaXN0ZW5lclJlZiBsaXN0ZW5lciwgV0tUeXBl UmVmIHVzZXJEYXRhLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogeworICAgIEVYUEVDVF9UUlVF KG1vdXNlQnV0dG9uID0ga1dLRXZlbnRNb3VzZUJ1dHRvbk5vQnV0dG9uKTsKICAgICBXS0ZyYW1l UG9saWN5TGlzdGVuZXJVc2UobGlzdGVuZXIpOwogfQogCg==