76342 2012-01-14 18:44:18 -0800 [Qt] Remove references to PagePointer in the FrameNetworkingContext 2012-01-16 06:28:46 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf hausmann webkit.review.bot zeno zoltan oldest_to_newest 536234 0 ahf 2012-01-14 18:44:18 -0800 Zeno and I were working on some related code during the same time and we came up with two different solutions to the same problem namely how to get access to the WebPage object in our QNAM wrapper. This should be cleaned up such that we only have one way of getting this information :-) 536236 1 122560 ahf 2012-01-14 19:12:25 -0800 Created attachment 122560 Patch 536237 2 ahf 2012-01-14 19:13:04 -0800 Adding Zeno for Seal of Approval and Simon for review :-) 536252 3 122560 hausmann 2012-01-15 02:18:49 -0800 Comment on attachment 122560 Patch Yay for cleanup 536258 4 zeno 2012-01-15 05:27:51 -0800 That's a much nicer solution indeed! - Thx. :) 536522 5 122560 webkit.review.bot 2012-01-16 06:28:41 -0800 Comment on attachment 122560 Patch Clearing flags on attachment: 122560 Committed r105062: <http://trac.webkit.org/changeset/105062> 536523 6 webkit.review.bot 2012-01-16 06:28:46 -0800 All reviewed patches have been landed. Closing bug. 122560 2012-01-14 19:12:25 -0800 2012-01-16 06:28:41 -0800 Patch bug-76342-20120115041222.patch text/plain 4247 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2VkOTQwZGRkMzlmNzZi NjE3YjVhYjQxMGVmMzk0MjI2ZWMwZmRiMi4uMDJiY2JhNzMyMzI2NGVkMWUyNDZkYTdjOGFhMWIz MzRlNTRmMzFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTE0ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgorCisgICAgICAgIFtR dF0gUmVtb3ZlIHJlZmVyZW5jZXMgdG8gUGFnZVBvaW50ZXIgaW4gdGhlIEZyYW1lTmV0d29ya2lu Z0NvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc2MzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZU5ldHdvcmtpbmdDb250 ZXh0KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL3F0L1F0TmV0d29ya0FjY2Vzc01hbmFnZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpRdE5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpvYnRhaW5PcmlnaW5h dGluZ1dlYlBhZ2UpOgorICAgICAgICAqIFdlYlByb2Nlc3MvcXQvUXROZXR3b3JrQWNjZXNzTWFu YWdlci5oOgorCiAyMDEyLTAxLTEzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5j b20+CiAKICAgICAgICAgRGVsYXkgdXBkYXRpbmcgdGhlIHJvb3QgY29tcG9zaXRpbmcgbGF5ZXIg aWYgdGhlIGxheWVyIHRyZWUgc3RhdGUgaXMgZnJvemVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJD bGllbnQuY3BwCmluZGV4IDNkMGUyMjIwNWQyNDQzZGE4Mjg3NGVkODc4YzMyNGM2NWY3MmExYmUu LjQyZmVlMzQ1YTFmNTNlZGU0Mjc0MWJjZDgzOWNiNjQyZDMzNTU3YzAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGll bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC0xNDM5LDEyICsxNDM5LDYgQEAgdm9pZCBXZWJGcmFt ZUxvYWRlckNsaWVudDo6ZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0KCkKIFBhc3NSZWZQdHI8RnJhbWVO ZXR3b3JraW5nQ29udGV4dD4gV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZU5ldHdvcmtpbmdD b250ZXh0KCkKIHsKICAgICBSZWZQdHI8V2ViRnJhbWVOZXR3b3JraW5nQ29udGV4dD4gY29udGV4 dCA9IFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OmNyZWF0ZShtX2ZyYW1lKTsKLSNpZiBQTEFU Rk9STShRVCkKLSAgICAvLyBXZSBlbmNhcHN1bGF0ZSB0aGUgV2ViUGFnZSBwb2ludGVyIGFzIGEg cHJvcGVydHkgb2YgdGhlIG9yaWdpbmF0aW5nIFFPYmplY3QuCi0gICAgUU9iamVjdCogb3JpZ2lu YXRpbmdPYmplY3QgPSBjb250ZXh0LT5vcmlnaW5hdGluZ09iamVjdCgpOwotICAgIEFTU0VSVChv cmlnaW5hdGluZ09iamVjdCk7Ci0gICAgb3JpZ2luYXRpbmdPYmplY3QtPnNldFByb3BlcnR5KCJQ YWdlUG9pbnRlciIsIFFWYXJpYW50Ojpmcm9tVmFsdWUoc3RhdGljX2Nhc3Q8dm9pZCo+KG1fZnJh bWUtPnBhZ2UoKSkpKTsKLSNlbmRpZgogICAgIHJldHVybiBjb250ZXh0LnJlbGVhc2UoKTsKIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9RdE5ldHdvcmtBY2Nl c3NNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvUXROZXR3b3JrQWNj ZXNzTWFuYWdlci5jcHAKaW5kZXggNTdiOTUzZmVhZGM3NzRkZWQ2YzYxYjEzYmQ4NzAyY2VkZjE5 OTgxOS4uMTc4YTU2NWM2M2NlYzFkYjViNzIwNTM3YmNmMjdjZDQ5YzYzYjgxYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9RdE5ldHdvcmtBY2Nlc3NNYW5hZ2VyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0TmV0d29ya0FjY2Vzc01hbmFn ZXIuY3BwCkBAIC00MSwyNSArNDEsMTQgQEAgUXROZXR3b3JrQWNjZXNzTWFuYWdlcjo6UXROZXR3 b3JrQWNjZXNzTWFuYWdlcihXZWJQcm9jZXNzKiB3ZWJQcm9jZXNzKQogewogfQogCi1RdE5ldHdv cmtBY2Nlc3NNYW5hZ2VyOjpRdE5ldHdvcmtBY2Nlc3NNYW5hZ2VyKFFPYmplY3QqIHBhcmVudCkK LSAgICA6IFFOZXR3b3JrQWNjZXNzTWFuYWdlcihwYXJlbnQpCi0gICAgLCBtX3dlYlByb2Nlc3Mo MCkKLXsKLX0KLQogV2ViUGFnZSogUXROZXR3b3JrQWNjZXNzTWFuYWdlcjo6b2J0YWluT3JpZ2lu YXRpbmdXZWJQYWdlKGNvbnN0IFFOZXR3b3JrUmVxdWVzdCYgcmVxdWVzdCkKIHsKICAgICBRT2Jq ZWN0KiBvcmlnaW5hdGluZ09iamVjdCA9IHJlcXVlc3Qub3JpZ2luYXRpbmdPYmplY3QoKTsKICAg ICBpZiAoIW9yaWdpbmF0aW5nT2JqZWN0KQogICAgICAgICByZXR1cm4gMDsKIAotICAgIFFWYXJp YW50IHBhZ2VQdHIgPSBvcmlnaW5hdGluZ09iamVjdC0+cHJvcGVydHkoIlBhZ2VQb2ludGVyIik7 Ci0gICAgaWYgKCFwYWdlUHRyLmlzVmFsaWQoKSB8fCAhcGFnZVB0ci5jYW5Db252ZXJ0PHZvaWQq PigpKQotICAgICAgICByZXR1cm4gMDsKLQotICAgIFdlYlBhZ2UqIHdlYlBhZ2UgPSBzdGF0aWNf Y2FzdDxXZWJQYWdlKj4ocGFnZVB0ci52YWx1ZTx2b2lkKj4oKSk7Ci0gICAgUV9BU1NFUlQod2Vi UGFnZSk7Ci0gICAgcmV0dXJuIHdlYlBhZ2U7CisgICAgcXVsb25nbG9uZyBwYWdlSUQgPSBvcmln aW5hdGluZ09iamVjdC0+cHJvcGVydHkoInBhZ2VJRCIpLnRvVUxvbmdMb25nKCk7CisgICAgcmV0 dXJuIG1fd2ViUHJvY2Vzcy0+d2ViUGFnZShwYWdlSUQpOwogfQogCiBRTmV0d29ya1JlcGx5KiBR dE5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpjcmVhdGVSZXF1ZXN0KE9wZXJhdGlvbiBvcGVyYXRpb24s IGNvbnN0IFFOZXR3b3JrUmVxdWVzdCYgcmVxdWVzdCwgUUlPRGV2aWNlKiBvdXREYXRhKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9RdE5ldHdvcmtBY2Nlc3NNYW5h Z2VyLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0TmV0d29ya0FjY2Vzc01hbmFn ZXIuaAppbmRleCA4ZDllYjFkMGViNzc2ODQzZTA3MDBiMjI3NTM0MTMwODU2ODE4Yzk3Li4xYWY2 ZmMyZWRiMTM2ZWQyNTZkM2FiNTExMWU0ODVkYmU4NWEwYjUxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0TmV0d29ya0FjY2Vzc01hbmFnZXIuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0TmV0d29ya0FjY2Vzc01hbmFnZXIuaApAQCAtMzgs MTUgKzM4LDE1IEBAIGNsYXNzIFdlYlByb2Nlc3M7CiBjbGFzcyBRdE5ldHdvcmtBY2Nlc3NNYW5h Z2VyIDogcHVibGljIFFOZXR3b3JrQWNjZXNzTWFuYWdlciB7CiAgICAgUV9PQkpFQ1QKIHB1Ymxp YzoKLSAgICBRdE5ldHdvcmtBY2Nlc3NNYW5hZ2VyKFFPYmplY3QqIHBhcmVudCk7CiAgICAgUXRO ZXR3b3JrQWNjZXNzTWFuYWdlcihXZWJQcm9jZXNzKik7CiAgICAgdm9pZCByZWdpc3RlckFwcGxp Y2F0aW9uU2NoZW1lKGNvbnN0IFdlYlBhZ2UqLCBjb25zdCBRU3RyaW5nJiBzY2hlbWUpOwogCiBw cm90ZWN0ZWQ6CiAgICAgdmlydHVhbCBRTmV0d29ya1JlcGx5KiBjcmVhdGVSZXF1ZXN0KE9wZXJh dGlvbiwgY29uc3QgUU5ldHdvcmtSZXF1ZXN0JiwgUUlPRGV2aWNlKiBvdXRnb2luZ0RhdGEgPSAw KSBPVkVSUklERTsKLSAgICBzdGF0aWMgV2ViUGFnZSogb2J0YWluT3JpZ2luYXRpbmdXZWJQYWdl KGNvbnN0IFFOZXR3b3JrUmVxdWVzdCYpOwogCiBwcml2YXRlOgorICAgIFdlYlBhZ2UqIG9idGFp bk9yaWdpbmF0aW5nV2ViUGFnZShjb25zdCBRTmV0d29ya1JlcXVlc3QmKTsKKwogICAgIFFNdWx0 aUhhc2g8Y29uc3QgV2ViUGFnZSosIFFTdHJpbmc+IG1fYXBwbGljYXRpb25TY2hlbWVzOwogICAg IFdlYlByb2Nlc3MqIG1fd2ViUHJvY2VzczsKIAo=