<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>76341</bug_id>
          
          <creation_ts>2012-01-14 13:13:01 -0800</creation_ts>
          <short_desc>[Qt] Enable -Werror on Mac OS X builds</short_desc>
          <delta_ts>2014-02-03 03:19:37 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>OS X 10.7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>76340</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexander Færøy">ahf</reporter>
          <assigned_to name="Alexander Færøy">ahf</assigned_to>
          <cc>eric</cc>
    
    <cc>ossy</cc>
    
    <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>536214</commentid>
    <comment_count>0</comment_count>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-14 13:13:01 -0800</bug_when>
    <thetext>SSIA.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536215</commentid>
    <comment_count>1</comment_count>
      <attachid>122557</attachid>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-14 13:15:05 -0800</bug_when>
    <thetext>Created attachment 122557
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536216</commentid>
    <comment_count>2</comment_count>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-14 13:15:32 -0800</bug_when>
    <thetext>Adding Tor Arne for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536240</commentid>
    <comment_count>3</comment_count>
      <attachid>122557</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-01-14 19:15:18 -0800</bug_when>
    <thetext>Comment on attachment 122557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122557&amp;action=review

&gt; Tools/ChangeLog:1
&gt; +2012-01-14  Alexander FÃ¦rÃ¸y  &lt;alexander.faeroy@nokia.com&gt;

that did not work</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536241</commentid>
    <comment_count>4</comment_count>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-01-14 19:17:00 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; that did not work

So far, all my patches has looked like that in the review tool, but they look fine when they are commited. 

The curse of having dodgy letters in the surname :-(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536401</commentid>
    <comment_count>5</comment_count>
      <attachid>122557</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-01-16 00:38:30 -0800</bug_when>
    <thetext>Comment on attachment 122557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122557&amp;action=review

&gt;&gt; Tools/ChangeLog:1
&gt;&gt; +2012-01-14  Alexander FÃ¦rÃ¸y  &lt;alexander.faeroy@nokia.com&gt;
&gt; 
&gt; that did not work

Actually it&apos;s correct. It&apos;s just that in bugzilla it&apos;s not shown correctly, but when landing the utf-8 encoding is preserved correctly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536486</commentid>
    <comment_count>6</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2012-01-16 04:37:01 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=122557) [details]
&gt; Patch

Do you have a bug tracking the warnings that are left to fix before we land this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>603957</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-04-17 05:53:58 -0700</bug_when>
    <thetext>Why didn&apos;t you guys land it? Is there any warning now on Mac?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604079</commentid>
    <comment_count>8</comment_count>
    <who name="Alexander Færøy">ahf</who>
    <bug_when>2012-04-17 09:28:47 -0700</bug_when>
    <thetext>There are still some warnings that needs to get fixed before this can be landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>800111</commentid>
    <comment_count>9</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2013-01-04 02:20:08 -0800</bug_when>
    <thetext>Are those warnings tracked?  Should this be resolved &quot;LATER&quot; and fixed once those are?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>975379</commentid>
    <comment_count>10</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2014-02-03 03:19:37 -0800</bug_when>
    <thetext>=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>122557</attachid>
            <date>2012-01-14 13:15:05 -0800</date>
            <delta_ts>2012-01-16 00:38:30 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-76341-20120114221502.patch</filename>
            <type>text/plain</type>
            <size>1117</size>
            <attacher name="Alexander Færøy">ahf</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWYxOGFhZDlmNTMwZGUwNGE0ZGQwNmU1NDI3ZjZlMGRk
MDQzNTZmNS4uZTMxMGRkNjFkNWYzMWM2OWY5NWViNGZmNzA2MTg1YWE1ZjE4Nzg4MSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy
IEBACisyMDEyLTAxLTE0ICBBbGV4YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9r
aWEuY29tPgorCisgICAgICAgIFtRdF0gRW5hYmxlIC1XZXJyb3Igb24gTWFjIE9TIFggYnVpbGRz
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjM0MQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcW1ha2Uv
bWtzcGVjcy9mZWF0dXJlcy91bml4L2RlZmF1bHRfcG9zdC5wcmY6CisKIDIwMTItMDEtMTQgIEph
bWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1d
IEZhaWxpbmcgd2Via2l0X3VuaXRfdGVzdHMgZG9lcyBub3QgbWFrZSB0aGUgY3ItbGludXggRVdT
IGJ1YmJsZSByZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvdW5p
eC9kZWZhdWx0X3Bvc3QucHJmIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy91bml4L2Rl
ZmF1bHRfcG9zdC5wcmYKaW5kZXggM2NjNzMwYTc2ZGU2ZDdhNWU0NzVmZGYzYzU3MTY1ZDM5MWNj
NTE0MC4uNWI3N2VjZDkwZjhjNTVlZThjN2MzZDNlYjRkMzhlNzkwNDY5NjhkMiAxMDA2NDQKLS0t
IGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy91bml4L2RlZmF1bHRfcG9zdC5wcmYKKysr
IGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy91bml4L2RlZmF1bHRfcG9zdC5wcmYKQEAg
LTE5LDYgKzE5LDEwIEBAIGxpbnV4LWcrKyogewogICAgIH0KIH0KIAorbWFjIHsKKyAgICBRTUFL
RV9DWFhGTEFHUyArPSAtV2Vycm9yCit9CisKIGNvbnRhaW5zKFRFTVBMQVRFLCBhcHApOiBDT05G
SUcgKz0gcnBhdGgKIAogbG9hZChkZWZhdWx0X3Bvc3QpCg==
</data>
<flag name="review"
          id="123382"
          type_id="1"
          status="+"
          setter="hausmann"
    />
          </attachment>
      

    </bug>

</bugzilla>