76329 2012-01-13 19:10:47 -0800 Unmatched transparency layer begin/end on a filtered element with an opacity ancestor 2012-01-16 00:29:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser achicu simon.fraser webkit-bug-importer oldest_to_newest 536124 0 122531 simon.fraser 2012-01-13 19:10:47 -0800 Created attachment 122531 Testcase The attached test case hits ASSERTION FAILED: m_transparencyCount > 0 when painting, if the context has paintingDisabled() (e.g. when doing a Find in Safari). 536128 1 simon.fraser 2012-01-13 19:15:35 -0800 The issue is that RenderLayer::beginTransparencyLayers() bails if context->paintingDisabled() is true, so never starting the transparency layer. However, when rendering the child, filterPainter hands back a context with painting enabled. We then hit beginTransparencyLayers() in the if (localPaintFlags & PaintLayerPaintingCompositingForegroundPhase) clause, since haveTransparency was passed in from the ancestor. We should just not apply filters if the context has painting disabled. 536130 2 122533 simon.fraser 2012-01-13 19:33:22 -0800 Created attachment 122533 Patch 536131 3 webkit-bug-importer 2012-01-13 19:34:38 -0800 <rdar://problem/10695409> 536134 4 122533 mitz 2012-01-13 19:58:49 -0800 Comment on attachment 122533 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122533&action=review > Source/WebCore/ChangeLog:14 > + Manual test: > + ManualTests/filters/opacity-above-filter.html Could this be a TestWebKitAPI test instead? 536182 5 simon.fraser 2012-01-14 07:52:16 -0800 http://trac.webkit.org/changeset/105019 536398 6 achicu 2012-01-16 00:29:52 -0800 (In reply to comment #5) > http://trac.webkit.org/changeset/105019 Thanks! 122531 2012-01-13 19:10:47 -0800 2012-01-13 19:10:47 -0800 Testcase opacity-above-filter.html text/html 561 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgPHN0eWxlPgogICAgCiAgICAuY29udGFp bmVyIHsKICAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgICBvcGFjaXR5OiAwLjg7CiAgICAg IG1hcmdpbjogMTBweDsKCiAgICB9CiAgICAKICAgIC5ib3ggewogICAgICB3aWR0aDogMjAwcHg7 CiAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7CiAgICAg IGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwogICAgfQogICAgLnRyYW5zZm9ybWVkIHsKLyogICAg ICBwb3NpdGlvbjogYWJzb2x1dGU7Ki8KICAgICAgdG9wOiAzMDBweDsKICAgICAgbGVmdDogMjAw cHg7CiAgICAgIC13ZWJraXQtZmlsdGVyOiBibHVyKDEwcHgpOyAKICAgIH0KICAgIAogIDwvc3R5 bGU+CjwvaGVhZD4KPGJvZHk+CgogIDxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CiAgICA8cD4KICAg ICAgPGRpdiBjbGFzcz0idHJhbnNmb3JtZWQgYm94Ij4KICAgICAgICAKICAgICAgPC9kaXY+U29t ZSB0ZXh0IGhlcmUKICAgICAgPC9wPgogIDwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 122533 2012-01-13 19:33:22 -0800 2012-01-13 19:58:49 -0800 Patch bug-76329-20120113193320.patch text/plain 4181 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0OTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM2Yjg2ZjEyMWI4ODBk MTRhODViNmU4YTBhYjc3NDdhNWFjNTI2MC4uYmY2MTM1YjMyMjlhZWM2YmUzY2NiYTExNzNkNTcz ZDBkNDkwMzYwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAxLTEzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVubWF0Y2hlZCB0 cmFuc3BhcmVuY3kgbGF5ZXIgYmVnaW4vZW5kIG9uIGEgZmlsdGVyZWQgZWxlbWVudCB3aXRoIGFu IG9wYWNpdHkgYW5jZXN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc2MzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBkb2luZyBhIHBhaW50IHdpdGggcGFpbnRpbmcgZGlzYWJsZWQgb24gdGhl IEdyYXBoaWNzQ29udGV4dCwgYXMgd2UgZG8KKyAgICAgICAgZm9yIHVwZGF0aW5nIGNvbnRyb2wg dGludHMsIG9yIGNvbXB1dGluZyB0ZXh0IHJlY3RhbmdsZXMgb24gRmluZCwgZG8gbm90CisgICAg ICAgIGFwcGx5IGZpbHRlciBlZmZlY3RzLiBUaGlzIGlzIGJvdGggYSBwZXJmb3JtYW5jZSBnYWlu LCBhbmQgZml4ZXMgYW4gaXNzdWUKKyAgICAgICAgd2l0aCBtaXNtYXRjaGVkIGJlZ2luL2VuZCB0 cmFuc3BhcmVuY3kgbGF5ZXJzLgorICAgICAgICAKKyAgICAgICAgTWFudWFsIHRlc3Q6CisgICAg ICAgICAgICBNYW51YWxUZXN0cy9maWx0ZXJzL29wYWNpdHktYWJvdmUtZmlsdGVyLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJMYXllcjo6cGFpbnRMYXllckNvbnRlbnRzKToKKwogMjAxMi0wMS0xMiAgT2phbiBWYWZh aSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBmbGV4LWFsaWduCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCA5NWYzZGRhNjVhNzE0 ODdiZTk1NTBmMWVkNzc1MWJhNTQzMmQwMTUzLi4zMjJiOGNiYTU5MzM2MjgzOGU3ZTczMTI4NmI4 NjVmNmIxYmIxMjQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK QEAgLTI4NjMsNyArMjg2Myw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXJDb250ZW50 cyhSZW5kZXJMYXllciogcm9vdExheWVyLCBHcmFwaGljc0NvbnRleHQqIGNvCiAgICAgICAgICAg ICAgICAgYmVnaW5UcmFuc3BhcmVuY3lMYXllcnMoY29udGV4dCwgcm9vdExheWVyLCBwYWludEJl aGF2aW9yKTsKICAgICAgICAgCiAjaWYgRU5BQkxFKENTU19GSUxURVJTKQotICAgICAgICAgICAg aWYgKGZpbHRlclBhaW50ZXIuaGF2ZUZpbHRlckVmZmVjdCgpKQorICAgICAgICAgICAgaWYgKGZp bHRlclBhaW50ZXIuaGF2ZUZpbHRlckVmZmVjdCgpICYmICFjb250ZXh0LT5wYWludGluZ0Rpc2Fi bGVkKCkpCiAgICAgICAgICAgICAgICAgY29udGV4dCA9IGZpbHRlclBhaW50ZXIuYmVnaW5GaWx0 ZXJFZmZlY3QodGhpcywgY29udGV4dCwgdHJhbnNwYXJlbmN5Q2xpcEJveCh0aGlzLCByb290TGF5 ZXIsIHBhaW50QmVoYXZpb3IpKTsKICNlbmRpZgogICAgICAgICAKQEAgLTI4OTIsNyArMjg5Miw3 IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnBhaW50TGF5ZXJDb250ZW50cyhSZW5kZXJMYXllciogcm9v dExheWVyLCBHcmFwaGljc0NvbnRleHQqIGNvCiAKICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiAg ICAgICAgICAgICAvLyBJZiB0aGUgZmlsdGVyIHdhcyBub3Qgc3RhcnRlZCB5ZXQsIHN0YXJ0IGl0 IG5vdywgYWZ0ZXIgdGhlIHRyYW5zcGFyZW5jeSBsYXllciB3YXMgbGF6aWx5IGNyZWF0ZWQuCi0g ICAgICAgICAgICBpZiAoZmlsdGVyUGFpbnRlci5oYXZlRmlsdGVyRWZmZWN0KCkgJiYgIWZpbHRl clBhaW50ZXIuaGFzU3RhcnRlZEZpbHRlckVmZmVjdCgpKQorICAgICAgICAgICAgaWYgKGZpbHRl clBhaW50ZXIuaGF2ZUZpbHRlckVmZmVjdCgpICYmICFmaWx0ZXJQYWludGVyLmhhc1N0YXJ0ZWRG aWx0ZXJFZmZlY3QoKSAmJiAhY29udGV4dC0+cGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICAg ICAgICAgIGNvbnRleHQgPSBmaWx0ZXJQYWludGVyLmJlZ2luRmlsdGVyRWZmZWN0KHRoaXMsIGNv bnRleHQsIHRyYW5zcGFyZW5jeUNsaXBCb3godGhpcywgcm9vdExheWVyLCBwYWludEJlaGF2aW9y KSk7CiAjZW5kaWYKICAgICAgICAgICAgIC8vIFNldCB1cCB0aGUgY2xpcCB1c2VkIHdoZW4gcGFp bnRpbmcgb3VyIGNoaWxkcmVuLgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu ZGV4IDEwZDViYzEzNjJiZTNiODExYzZiMjIwNGQ4N2U4MzBlODc3MzJhYzMuLmQ2MzBiZTBhYjk0 OTg1ZGViMDMwNmViNjkyNDZlMGM1ZmU5MGI4MzQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wMS0xMyAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBVbm1hdGNoZWQgdHJhbnNwYXJlbmN5 IGxheWVyIGJlZ2luL2VuZCBvbiBhIGZpbHRlcmVkIGVsZW1lbnQgd2l0aCBhbiBvcGFjaXR5IGFu Y2VzdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NjMyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgTWFudWFsIHRlc3Qgd2l0aCBhIGZpbHRlcmVkIGVsZW1lbnQgYXMgYSBkZXNjZW5kYW50 IG9mIGFuIGVsZW1lbnQgd2l0aAorICAgICAgICBvcGFjaXR5LiBEb2luZyBhIEZpbmQgaXMgbmVj ZXNzYXJ5IHRvIGV4ZXJjaXNlIHRoZSB0ZXN0LgorCisgICAgICAgICogTWFudWFsVGVzdHMvZmls dGVycy9vcGFjaXR5LWFib3ZlLWZpbHRlci5odG1sOiBBZGRlZC4KKwogMjAxMi0wMS0xMyAgR3Jl Z2cgVGF2YXJlcyAgPGdtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBBZGQgV2ViR0xDb250ZXh0 R3JvdXAgYXMgc3RlcCB0b3dhcmQgc2hhcmluZyBXZWJHTCByZXNvdXJjZXMKZGlmZiAtLWdpdCBh L01hbnVhbFRlc3RzL2ZpbHRlcnMvb3BhY2l0eS1hYm92ZS1maWx0ZXIuaHRtbCBiL01hbnVhbFRl c3RzL2ZpbHRlcnMvb3BhY2l0eS1hYm92ZS1maWx0ZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lY2FjMGJj NDM3MjYyNjMyMDM4Y2UxNWNjMGM1ZGE0MTA5Y2ZkZTY4Ci0tLSAvZGV2L251bGwKKysrIGIvTWFu dWFsVGVzdHMvZmlsdGVycy9vcGFjaXR5LWFib3ZlLWZpbHRlci5odG1sCkBAIC0wLDAgKzEsMjcg QEAKKzwhRE9DVFlQRSBodG1sPgorCis8aHRtbD4KKzxoZWFkPgorICA8c3R5bGU+CisgICAgCisg ICAgLmNvbnRhaW5lciB7CisgICAgICBvcGFjaXR5OiAwLjg7CisgICAgICBtYXJnaW46IDEwcHg7 CisgICAgfQorICAgIAorICAgIC5maWx0ZXJlZCB7CisgICAgICB3aWR0aDogMTAwcHg7CisgICAg ICBoZWlnaHQ6IDEwMHB4OworICAgICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAgICAgIC13 ZWJraXQtZmlsdGVyOiBibHVyKDEwcHgpOworICAgIH0KKyAgPC9zdHlsZT4KKzwvaGVhZD4KKzxi b2R5PgorICA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzYzMjkiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjMyOTwvYT4K KyAgPHA+T3BlbiB0aGlzIHRlc3QgaW4gU2FmYXJpLCBhbmQgaGl0IENvbW1hbmQtRiB0byBGaW5k LiBBIGRlYnVnIGJ1aWxkIHNob3VsZCBub3QgYXNzZXJ0LjwvcD4KKyAgPGRpdiBjbGFzcz0iY29u dGFpbmVyIj4KKyAgICAgIDxkaXYgY2xhc3M9ImZpbHRlcmVkIGJveCI+PC9kaXY+CisgIDwvZGl2 PgorPC9ib2R5PgorPC9odG1sPgo=