76313 2012-01-13 14:43:41 -0800 [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red 2012-01-14 11:29:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot jamesr abarth enne eric jamesr oldest_to_newest 536006 0 webkit.review.bot 2012-01-13 14:43:41 -0800 [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red Requested by jamesr on #webkit. 536007 1 jamesr 2012-01-13 14:44:21 -0800 See https://bugs.webkit.org/show_bug.cgi?id=76274. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green. 536022 2 enne 2012-01-13 15:10:46 -0800 (In reply to comment #1) > See https://bugs.webkit.org/show_bug.cgi?id=76274. The first and second patches on this bug make webkit_unit_tests fail, but the bubble is still green. abarth says that this is what's checking for unit test failures. 15:01 < abarth> self._tool.executive.run_and_throw_if_fail(webkit_unit_tests_command, cwd=self._tool.scm().checkout_root) In local testing, webkit_unit_tests returned an exit code of 1 on failure and 0 on success. 536043 3 abarth 2012-01-13 15:32:08 -0800 Maybe the perl wrapper eats the return code? 536044 4 abarth 2012-01-13 15:33:00 -0800 The way I would test this is by locally introducing an error in the unit tests and seeing if that line throws. 536098 5 jamesr 2012-01-13 17:20:19 -0800 We appear to lose the exit code going through the perl wrapper script run-chromium-webkit-unit-tests 536101 6 122521 jamesr 2012-01-13 17:22:36 -0800 Created attachment 122521 Patch 536102 7 jamesr 2012-01-13 17:23:02 -0800 This is what http://perldoc.perl.org/functions/system.html says you are supposed to do, and it seems to work. 536108 8 122521 abarth 2012-01-13 17:36:57 -0800 Comment on attachment 122521 Patch Ok. I surrender. 536188 9 122550 jamesr 2012-01-14 10:12:28 -0800 Created attachment 122550 Patch for landing 536201 10 122550 webkit.review.bot 2012-01-14 11:28:57 -0800 Comment on attachment 122550 Patch for landing Clearing flags on attachment: 122550 Committed r105022: <http://trac.webkit.org/changeset/105022> 536202 11 webkit.review.bot 2012-01-14 11:29:01 -0800 All reviewed patches have been landed. Closing bug. 122521 2012-01-13 17:22:36 -0800 2012-01-14 10:12:22 -0800 Patch bug-76313-20120113172234.patch text/plain 1355 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWM2NTU0ZmI4N2I2MmI3Yzg0ZjM5YmM3NTY1NTdlN2Y5 NzIwYTA1Zi4uZTFlYzQ0NTRlYzIwYzEwMTk3OGVjZjdmZWI4MDdmMzMxYzE5ZjY3MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTEzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW2Nocm9taXVtXSBGYWlsaW5nIHdlYmtpdF91bml0X3Rlc3RzIGRvZXMgbm90IG1h a2UgdGhlIGNyLWxpbnV4IEVXUyBidWJibGUgcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjMxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBleGl0IGNvZGUgb2YgdGhpcyBzY3JpcHQgc2hvdWxk IGJlIHRoZSBleGl0IGNvZGUgb2Ygd2Via2l0X3VuaXRfdGVzdHMuIFRlc3RlZCBtYW51YWxseS4K KworICAgICAgICAqIFNjcmlwdHMvcnVuLWNocm9taXVtLXdlYmtpdC11bml0LXRlc3RzOgorCiAy MDEyLTAxLTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVt b3ZlIC0tZHJ5LXJ1biBzdXBwb3J0IGZyb20gd2Via2l0LXBhdGNoCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3J1bi1jaHJvbWl1bS13ZWJraXQtdW5pdC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMv cnVuLWNocm9taXVtLXdlYmtpdC11bml0LXRlc3RzCmluZGV4IGU0OGViM2ZiZWM2Yjc4ZjljYjNm OWMzNWMwYzcyMmYwMzUwM2YwY2MuLjQzNzcxMWJlN2ZkNzFiMDA2NWFjODU4NTQ3OGY1MzFhODlh MWI5MDMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWNocm9taXVtLXdlYmtpdC11bml0 LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWNocm9taXVtLXdlYmtpdC11bml0LXRlc3Rz CkBAIC0zNiw0ICszNiw1IEBAIHVzZSB3ZWJraXRkaXJzOwogcHVzaChAQVJHViwgIi0tY2hyb21p dW0iKTsKIHNldENvbmZpZ3VyYXRpb24oKTsKIG15ICRwYXRoVG9CaW5hcnkgPSBwcm9kdWN0RGly KCkgLiAiL3dlYmtpdF91bml0X3Rlc3RzIjsKLWV4aXQgc3lzdGVtICgkcGF0aFRvQmluYXJ5LCBA QVJHVik7CisjIHBlcmwncyAic3lzdGVtIiBmdW5jdGlvbidzIHJldHVybiB2YWx1ZSBoYXMgdG8g YmUgcmlnaHQgc2hpZnRlZCBieSA4IHRvIGdldCB0aGUgcHJvZ3JhbSdzIGV4aXQgY29kZS4gd3Rm PworZXhpdCBzeXN0ZW0gKCRwYXRoVG9CaW5hcnksIEBBUkdWKSA+PiA4Owo= 122550 2012-01-14 10:12:28 -0800 2012-01-14 11:28:57 -0800 Patch for landing bug-76313-20120114101227.patch text/plain 1346 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWM2NTU0ZmI4N2I2MmI3Yzg0ZjM5YmM3NTY1NTdlN2Y5 NzIwYTA1Zi4uYzlkNWY5NmQ2NzBjNDhmZjQ2ODViNzIwYTI3N2ZkY2JlNjkwZThhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAxLTEzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW2Nocm9taXVtXSBGYWlsaW5nIHdlYmtpdF91bml0X3Rlc3RzIGRvZXMgbm90IG1h a2UgdGhlIGNyLWxpbnV4IEVXUyBidWJibGUgcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjMxMworCisgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g QmFydGguCisKKyAgICAgICAgVGhlIGV4aXQgY29kZSBvZiB0aGlzIHNjcmlwdCBzaG91bGQgYmUg dGhlIGV4aXQgY29kZSBvZiB3ZWJraXRfdW5pdF90ZXN0cy4gVGVzdGVkIG1hbnVhbGx5LgorCisg ICAgICAgICogU2NyaXB0cy9ydW4tY2hyb21pdW0td2Via2l0LXVuaXQtdGVzdHM6CisKIDIwMTIt MDEtMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUg LS1kcnktcnVuIHN1cHBvcnQgZnJvbSB3ZWJraXQtcGF0Y2gKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvcnVuLWNocm9taXVtLXdlYmtpdC11bml0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4t Y2hyb21pdW0td2Via2l0LXVuaXQtdGVzdHMKaW5kZXggZTQ4ZWIzZmJlYzZiNzhmOWNiM2Y5YzM1 YzBjNzIyZjAzNTAzZjBjYy4uNGU2YTUwMjM1NzNjYjZlMGQ3ZTNjMTAyMmFiMzVlYzgyMmMwNjc0 ZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tY2hyb21pdW0td2Via2l0LXVuaXQtdGVz dHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tY2hyb21pdW0td2Via2l0LXVuaXQtdGVzdHMKQEAg LTM2LDQgKzM2LDUgQEAgdXNlIHdlYmtpdGRpcnM7CiBwdXNoKEBBUkdWLCAiLS1jaHJvbWl1bSIp Owogc2V0Q29uZmlndXJhdGlvbigpOwogbXkgJHBhdGhUb0JpbmFyeSA9IHByb2R1Y3REaXIoKSAu ICIvd2Via2l0X3VuaXRfdGVzdHMiOwotZXhpdCBzeXN0ZW0gKCRwYXRoVG9CaW5hcnksIEBBUkdW KTsKKyMgcGVybCdzICJzeXN0ZW0iIGZ1bmN0aW9uJ3MgcmV0dXJuIHZhbHVlIGhhcyB0byBiZSBy aWdodCBzaGlmdGVkIGJ5IDggdG8gZ2V0IHRoZSBwcm9ncmFtJ3MgZXhpdCBjb2RlLgorZXhpdCBz eXN0ZW0gKCRwYXRoVG9CaW5hcnksIEBBUkdWKSA+PiA4Owo=