76310 2012-01-13 14:11:03 -0800 Remove StackBounds from JSGlobalData 2012-01-23 13:36:33 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 535978 0 mhahnenberg 2012-01-13 14:11:03 -0800 It appears that the distinction between a Default GlobalDataType for JSGlobalData and others serves no visible purpose when determining which StackBounds object to return--we should always return the StackBounds of the current thread (i.e. wtfThreadData().stack()). If this is indeed the case, we should remove this distinction to simplify the code base. 539865 1 123398 mhahnenberg 2012-01-20 15:43:06 -0800 Created attachment 123398 Patch 540315 2 123398 sam 2012-01-22 14:09:46 -0800 Comment on attachment 123398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123398&action=review > Source/JavaScriptCore/runtime/JSGlobalData.h:229 > const StackBounds& stack() > { > - return (globalDataType == Default) > - ? m_stack > - : wtfThreadData().stack(); > + return wtfThreadData().stack(); > } It seems odd to keep this interface, if it no longer access JSGlobalData members. 540793 3 mhahnenberg 2012-01-23 13:36:33 -0800 Committed r105638: <http://trac.webkit.org/changeset/105638> 123398 2012-01-20 15:43:06 -0800 2012-01-22 14:09:46 -0800 Patch bug-76310-20120120154305.patch text/plain 2696 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 OTRlOTU4OTI4ZDMzZDJhYjgwNmU3YzE0MTM3NGViNjBjMzEyNjk3Li5lYThjNzFlZDUzZTIzNTI5 ZGQ4MzhiYTI1YzI1M2RmNDQ0Y2QxMjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMi0wMS0yMCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw bGUuY29tPgorCisgICAgICAgIFJlbW92ZSBTdGFja0JvdW5kcyBmcm9tIEpTR2xvYmFsRGF0YQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYzMTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3YW50IHRv IHJlbW92ZSB0aGUgZGlmZmVyZW5jZSBiZXR3ZWVuIHZhcmlvdXMgdHlwZXMgb2YgSlNHbG9iYWxE YXRhcyB3aGVuIGZldGNoaW5nIHRoZSAKKyAgICAgICAgc3RhY2sgYm91bmRzIHdoaWxlIHdlJ3Jl IGNvbnNlcnZhdGl2ZWx5IHNjYW5uaW5nIHRoZSBzdGFjaywgYmVjYXVzZSBpZiBhIGNsaWVudCBv ZiBhIAorICAgICAgICBKU0dsb2JhbERhdGEgdXNlcyBpdCBpbmNvcnJlY3RseSwgd2UgY2FuIGVu ZCB1cCBnZXR0aW5nIHRoZSBib3VuZHMgZm9yIHRoZSB3cm9uZyBzdGFjaywgCisgICAgICAgIHdo aWNoIGNhbiBjYXVzZSBhIGNyYXNoLiBTaW5jZSB0aGUgZGlzdGluY3Rpb24gc2VydmVzIG5vIHZp c2libGUgcHVycG9zZSwgd2UndmUgcmVtb3ZlZCBpdC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNH bG9iYWxEYXRhLmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxEYXRhOjpKU0dsb2JhbERhdGEp OgorICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxEYXRhLmg6CisgICAgICAgIChKU0M6OkpTR2xv YmFsRGF0YTo6c3RhY2spOgorCiAyMDEyLTAxLTE5ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgYW4gb2Jzb2xldGUgY29tbWVudCBh Ym91dCBmZWF0dXJlcy5neXBpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0dsb2JhbERhdGEuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH bG9iYWxEYXRhLmNwcAppbmRleCA1MDhjNTFlYjEyYjNiZjdkYjkxM2QxODA0ZmQ5YTYxNDBkMGZm YTc1Li5iYmU1MjBhMWUzOTBlY2IwMzRiMzhjYTk5NDc4ZDI2MzM2ZWUwNjczIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5jcHAKQEAgLTE2Miw4ICsx NjIsNiBAQCBKU0dsb2JhbERhdGE6OkpTR2xvYmFsRGF0YShHbG9iYWxEYXRhVHlwZSBnbG9iYWxE YXRhVHlwZSwgVGhyZWFkU3RhY2tUeXBlIHRocmVhZAogI2VuZGlmCiB7CiAgICAgaW50ZXJwcmV0 ZXIgPSBuZXcgSW50ZXJwcmV0ZXI7Ci0gICAgaWYgKGdsb2JhbERhdGFUeXBlID09IERlZmF1bHQp Ci0gICAgICAgIG1fc3RhY2sgPSB3dGZUaHJlYWREYXRhKCkuc3RhY2soKTsKIAogICAgIC8vIE5l ZWQgdG8gYmUgY2FyZWZ1bCB0byBrZWVwIGV2ZXJ5dGhpbmcgY29uc2lzdGVudCBoZXJlCiAgICAg SWRlbnRpZmllclRhYmxlKiBleGlzdGluZ0VudHJ5SWRlbnRpZmllclRhYmxlID0gd3RmVGhyZWFk RGF0YSgpLnNldEN1cnJlbnRJZGVudGlmaWVyVGFibGUoaWRlbnRpZmllclRhYmxlKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxEYXRhLmgKaW5kZXggZTYxODU4ZWFk MDA0YThmYWQyM2Q2M2UwMTdmNmQzYTljNDc4YTUxZS4uZDFjNTdlOGNmZGQ5ZGMyODQxYjhiMDI2 NmRhYjJmMjA4MWM0ZTlkMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNHbG9iYWxEYXRhLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH bG9iYWxEYXRhLmgKQEAgLTIyNSw5ICsyMjUsNyBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAg ICBjb25zdCBTdGFja0JvdW5kcyYgc3RhY2soKQogICAgICAgICB7Ci0gICAgICAgICAgICByZXR1 cm4gKGdsb2JhbERhdGFUeXBlID09IERlZmF1bHQpCi0gICAgICAgICAgICAgICAgPyBtX3N0YWNr Ci0gICAgICAgICAgICAgICAgOiB3dGZUaHJlYWREYXRhKCkuc3RhY2soKTsKKyAgICAgICAgICAg IHJldHVybiB3dGZUaHJlYWREYXRhKCkuc3RhY2soKTsKICAgICAgICAgfQogCiAgICAgICAgIE93 blB0cjxQYXJzZXJBcmVuYT4gcGFyc2VyQXJlbmE7CkBAIC0zNTksNyArMzU3LDYgQEAgbmFtZXNw YWNlIEpTQyB7CiAjaWYgRU5BQkxFKEpJVCkgJiYgRU5BQkxFKElOVEVSUFJFVEVSKQogICAgICAg ICBib29sIG1fY2FuVXNlSklUOwogI2VuZGlmCi0gICAgICAgIFN0YWNrQm91bmRzIG1fc3RhY2s7 CiAjaWYgRU5BQkxFKEdDX1ZBTElEQVRJT04pCiAgICAgICAgIGJvb2wgbV9pc0luaXRpYWxpemlu Z09iamVjdDsKICNlbmRpZgo=