76292 2012-01-13 11:16:18 -0800 [EFL] Emit "resource,request,willsend" from ewk_view. 2012-01-17 07:03:05 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco gyuyoung.kim leandro lucas.de.marchi tonikitoo oldest_to_newest 535825 0 rakuco 2012-01-13 11:16:18 -0800 [EFL] Emit "resource,request,willsend" from ewk_view. 535826 1 122469 rakuco 2012-01-13 11:16:54 -0800 Created attachment 122469 Patch 536759 2 leandro 2012-01-16 14:19:13 -0800 LGTM. 536832 3 122469 ryuan.choi 2012-01-16 17:59:42 -0800 Comment on attachment 122469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122469&action=review > Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:178 > + const FrameLoader* frameLoader = loader->frameLoader(); > + const bool isMainFrameRequest = (loader && loader == frameLoader->provisionalDocumentLoader() && frameLoader->isLoadingMainFrame()); If loader can be null, 177 line make crash. 536865 4 122706 rakuco 2012-01-16 20:16:38 -0800 Created attachment 122706 Take Ryuan's comment into account 537077 5 rakuco 2012-01-17 07:03:05 -0800 Committed r105152: <http://trac.webkit.org/changeset/105152> 122469 2012-01-13 11:16:54 -0800 2012-01-16 20:16:31 -0800 Patch bug-76292-20120113171754.patch text/plain 2895 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZWNhNjM4ZTgz OTI0N2QwM2FiNDk2ODM3YzllYjUxZDEyMWE4NGNiNC4uZWQzN2U3NDU4MWRkMDdmNWI4NmFiNjQ1 MmY1OGU0MTVmODllNzViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTAxLTEzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIEVtaXQgInJlc291cmNlLHJlcXVlc3Qsd2lsbHNlbmQiIGZyb20gZXdrX3Zp ZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug ZXdrX3ZpZXcgZGlzcGF0Y2ggdGhlICJyZXNvdXJjZSxyZXF1ZXN0LHdpbGxzZW5kIiBzaWduYWwg YXMgd2VsbCwKKyAgICAgICAgc28gdGhhdCBpdCBpcyBwb3NzaWJsZSB0byBrbm93IHdoZXRoZXIg dGhlIHJlcXVlc3QgaXMgZm9yIHRoZSBtYWluCisgICAgICAgIGZyYW1lIGl0c2VsZiBvciBmb3Ig YW55dGhpbmcgZWxzZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xp ZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNw YXRjaFdpbGxTZW5kUmVxdWVzdCk6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTIt MDEtMTMgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBbRUZMXSBSZW1vdmUgZXh0ZXJuICJDIiBmcm9tIGV3a19wcml2YXRlLmgKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZsLmNw cCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZs LmNwcAppbmRleCAzN2M3MzhjMjI2NzFkNTMwNjMwNDkzZGVjOGQwNDVjZDljMjAyYzgyLi42YjFl NjE0YWMwMWRjZjIzOWQyNTdlNzdhYjBmNDQ3YTkxZTdiYmRlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVmbC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3Bw CkBAIC0xNzIsNiArMTcyLDEzIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRFZmw6OmRpc3BhdGNo V2lsbFNlbmRSZXF1ZXN0KERvY3VtZW50TG9hZGVyKiBsb2FkZXIsIHVuc2lnCiAKICAgICBld2tf ZnJhbWVfcmVxdWVzdF93aWxsX3NlbmQobV9mcmFtZSwgJnJlcXVlc3QpOwogCisgICAgLy8gV2Ug d2FudCB0byBkaXN0aW5ndWlzaCBiZXR3ZWVuIGEgcmVxdWVzdCBmb3IgYSBkb2N1bWVudCB0byBi ZSBsb2FkZWQgaW50bworICAgIC8vIHRoZSBtYWluIGZyYW1lLCBhIHN1Yi1mcmFtZSwgb3IgdGhl IHN1Yi1vYmplY3RzIGluIHRoYXQgZG9jdW1lbnQgKHZpYSBDaHJvbWl1bSkuCisgICAgY29uc3Qg RnJhbWVMb2FkZXIqIGZyYW1lTG9hZGVyID0gbG9hZGVyLT5mcmFtZUxvYWRlcigpOworICAgIGNv bnN0IGJvb2wgaXNNYWluRnJhbWVSZXF1ZXN0ID0gKGxvYWRlciAmJiBsb2FkZXIgPT0gZnJhbWVM b2FkZXItPnByb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIoKSAmJiBmcmFtZUxvYWRlci0+aXNMb2Fk aW5nTWFpbkZyYW1lKCkpOworICAgIGlmIChpc01haW5GcmFtZVJlcXVlc3QpCisgICAgICAgIGV2 YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwobV92aWV3LCAicmVzb3VyY2UscmVxdWVzdCx3 aWxsc2VuZCIsICZyZXF1ZXN0KTsKKwogICAgIGlmIChyZXF1ZXN0LnVybCAhPSBvcmlnLnVybCkg ewogICAgICAgICBjb3JlUmVxdWVzdC5zZXRVUkwoS1VSTChLVVJMKCksIHJlcXVlc3QudXJsKSk7 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKaW5kZXggZDBiZTYxZDc1MjQ5MDc4YzJkY2ViMzM4 NjA5NTE0ODRmYzY3NDlmZS4uYTQzMzUzNzRmNDhjZDVhZTY1M2ZjZjRiOTgyODU5YjU3OTc3ZmZl YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAgLTYxLDYgKzYxLDcgQEAKICAqICAtICJt aXhlZGNvbnRlbnQsZGlzcGxheWVkIiwgdm9pZDogYW55IG9mIHRoZSBjb250YWluaW5nIGZyYW1l cyBoYXMgbG9hZGVkIGFuZCBkaXNwbGF5ZWQgbWl4ZWQgY29udGVudC4KICAqICAtICJtaXhlZGNv bnRlbnQscnVuIiwgdm9pZDogYW55IG9mIHRoZSBjb250YWluaW5nIGZyYW1lcyBoYXMgbG9hZGVk IGFuZCBydW4gbWl4ZWQgY29udGVudC4KICAqICAtICJyZWFkeSIsIHZvaWQ6IHBhZ2UgaXMgZnVs bHkgbG9hZGVkLgorICogIC0gInJlc291cmNlLHJlcXVlc3Qsd2lsbHNlbmQiLCBFd2tfRnJhbWVf UmVzb3VyY2VfUmVxdWVzdCo6IHRoZSBuZXR3b3JrIHJlcXVlc3QgZm9yIHRoZSBtYWluIGZyYW1l IHdpbGwgYmUgc2VudC4KICAqICAtICJzY3JvbGxiYXJzLHZpc2libGUsZ2V0IiwgRWluYV9Cb29s ICo6IGV4cGVjdHMgYSBAYyBFSU5BX1RSVUUgaWYgc2Nyb2xsYmFycwogICogICAgYXJlIHZpc2li bGU7IEBjIEVJTkFfRkFMU0UsIG90aGVyd2lzZS4KICAqICAtICJzY3JvbGxiYXJzLHZpc2libGUs c2V0IiwgRWluYV9Cb29sOiBzZXRzIHNjcm9sbGJhcnMgdmlzaWJpbGl0eS4K 122706 2012-01-16 20:16:38 -0800 2012-01-17 06:52:39 -0800 Take Ryuan's comment into account bug-76292-20120117021736.patch text/plain 2931 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggZDIxNTA0MTAz MjFkOWRlYmQ1OTg2MDgxNDI0YzVjMDU1MjVlMzQ3NS4uZDE3MzBlZGNhZjM5YzgxMDcxZWM0Yjhh ZDVkMTEyYmRmYTAzYzlmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTAxLTEzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisg ICAgICAgIFtFRkxdIEVtaXQgInJlc291cmNlLHJlcXVlc3Qsd2lsbHNlbmQiIGZyb20gZXdrX3Zp ZXcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI5 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug ZXdrX3ZpZXcgZGlzcGF0Y2ggdGhlICJyZXNvdXJjZSxyZXF1ZXN0LHdpbGxzZW5kIiBzaWduYWwg YXMgd2VsbCwKKyAgICAgICAgc28gdGhhdCBpdCBpcyBwb3NzaWJsZSB0byBrbm93IHdoZXRoZXIg dGhlIHJlcXVlc3QgaXMgZm9yIHRoZSBtYWluCisgICAgICAgIGZyYW1lIGl0c2VsZiBvciBmb3Ig YW55dGhpbmcgZWxzZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xp ZW50RWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNw YXRjaFdpbGxTZW5kUmVxdWVzdCk6CisgICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTIt MDEtMTYgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtF RkxdIEJ1aWxkIGZpeCB3aGVuIHVzaW5nIHBhbmdvIGFzIGZvbnQgYmFja2VuZHMuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEVm bC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVu dEVmbC5jcHAKaW5kZXggMzdjNzM4YzIyNjcxZDUzMDYzMDQ5M2RlYzhkMDQ1Y2Q5YzIwMmM4Mi4u MWQ0ZDY0YTlmNzRiZTRiZTg1MjJmNTkwMWVlYWU0MmEyZGRlZmI4OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRFZmwuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50RWZs LmNwcApAQCAtMTcyLDYgKzE3MiwxNSBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50RWZsOjpkaXNw YXRjaFdpbGxTZW5kUmVxdWVzdChEb2N1bWVudExvYWRlciogbG9hZGVyLCB1bnNpZwogCiAgICAg ZXdrX2ZyYW1lX3JlcXVlc3Rfd2lsbF9zZW5kKG1fZnJhbWUsICZyZXF1ZXN0KTsKIAorICAgIC8v IFdlIHdhbnQgdG8gZGlzdGluZ3Vpc2ggYmV0d2VlbiBhIHJlcXVlc3QgZm9yIGEgZG9jdW1lbnQg dG8gYmUgbG9hZGVkIGludG8KKyAgICAvLyB0aGUgbWFpbiBmcmFtZSwgYSBzdWItZnJhbWUsIG9y IHRoZSBzdWItb2JqZWN0cyBpbiB0aGF0IGRvY3VtZW50ICh2aWEgQ2hyb21pdW0pLgorICAgIGlm IChsb2FkZXIpIHsKKyAgICAgICAgY29uc3QgRnJhbWVMb2FkZXIqIGZyYW1lTG9hZGVyID0gbG9h ZGVyLT5mcmFtZUxvYWRlcigpOworICAgICAgICBjb25zdCBib29sIGlzTWFpbkZyYW1lUmVxdWVz dCA9IChsb2FkZXIgPT0gZnJhbWVMb2FkZXItPnByb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIoKSAm JiBmcmFtZUxvYWRlci0+aXNMb2FkaW5nTWFpbkZyYW1lKCkpOworICAgICAgICBpZiAoaXNNYWlu RnJhbWVSZXF1ZXN0KQorICAgICAgICAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfY2Fs bChtX3ZpZXcsICJyZXNvdXJjZSxyZXF1ZXN0LHdpbGxzZW5kIiwgJnJlcXVlc3QpOworICAgIH0K KwogICAgIGlmIChyZXF1ZXN0LnVybCAhPSBvcmlnLnVybCkgewogICAgICAgICBjb3JlUmVxdWVz dC5zZXRVUkwoS1VSTChLVVJMKCksIHJlcXVlc3QudXJsKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmgKaW5kZXggZDBiZTYxZDc1MjQ5MDc4YzJkY2ViMzM4NjA5NTE0ODRmYzY3NDlmZS4uYTQz MzUzNzRmNDhjZDVhZTY1M2ZjZjRiOTgyODU5YjU3OTc3ZmZlYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmgKQEAgLTYxLDYgKzYxLDcgQEAKICAqICAtICJtaXhlZGNvbnRlbnQsZGlzcGxheWVk Iiwgdm9pZDogYW55IG9mIHRoZSBjb250YWluaW5nIGZyYW1lcyBoYXMgbG9hZGVkIGFuZCBkaXNw bGF5ZWQgbWl4ZWQgY29udGVudC4KICAqICAtICJtaXhlZGNvbnRlbnQscnVuIiwgdm9pZDogYW55 IG9mIHRoZSBjb250YWluaW5nIGZyYW1lcyBoYXMgbG9hZGVkIGFuZCBydW4gbWl4ZWQgY29udGVu dC4KICAqICAtICJyZWFkeSIsIHZvaWQ6IHBhZ2UgaXMgZnVsbHkgbG9hZGVkLgorICogIC0gInJl c291cmNlLHJlcXVlc3Qsd2lsbHNlbmQiLCBFd2tfRnJhbWVfUmVzb3VyY2VfUmVxdWVzdCo6IHRo ZSBuZXR3b3JrIHJlcXVlc3QgZm9yIHRoZSBtYWluIGZyYW1lIHdpbGwgYmUgc2VudC4KICAqICAt ICJzY3JvbGxiYXJzLHZpc2libGUsZ2V0IiwgRWluYV9Cb29sICo6IGV4cGVjdHMgYSBAYyBFSU5B X1RSVUUgaWYgc2Nyb2xsYmFycwogICogICAgYXJlIHZpc2libGU7IEBjIEVJTkFfRkFMU0UsIG90 aGVyd2lzZS4KICAqICAtICJzY3JvbGxiYXJzLHZpc2libGUsc2V0IiwgRWluYV9Cb29sOiBzZXRz IHNjcm9sbGJhcnMgdmlzaWJpbGl0eS4K