76288 2012-01-13 10:47:09 -0800 GCC compiler version is not detected properly for QNX qcc variant 2012-01-13 18:47:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 efidler efidler leandro rakuco rwlbuis webkit.review.bot oldest_to_newest 535788 0 efidler 2012-01-13 10:47:09 -0800 QNX is built with the qcc variant of GCC, which doesn't support -dumpversion. 535799 1 122460 efidler 2012-01-13 10:56:22 -0800 Created attachment 122460 Patch 535843 2 122460 leandro 2012-01-13 11:30:26 -0800 Comment on attachment 122460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122460&action=review > Source/cmake/WebKitHelpers.cmake:15 > + EXEC_PROGRAM("${CMAKE_CXX_COMPILER} -E -Wp,-dM - < /dev/null | grep __VERSION__ | sed -e 's/^[^\"]*\"//' -e 's/\".*$//'" OUTPUT_VARIABLE COMPILER_VERSION) Nice trick. I'd grep for '^#define __VERSION__ ', in the event that '__VERSION__' is present in some other predefined macro. Also, since this part of the code is just interested in the compiler version numbers anyway, I'd use the more readable "grep -E -o '[0-9]+\.[0-9]+\.?[0-9]+?'" instead of that sed command. This have the added benefit of detecting gcc version as "4.6.2" even if the returned string is "4.6.2 20111223 (prerelease)" (or similar), which is important here as this is used to enable/disable flags to workaround compiler bugs. 535956 3 122491 efidler 2012-01-13 13:42:54 -0800 Created attachment 122491 Patch 536003 4 122491 rwlbuis 2012-01-13 14:39:19 -0800 Comment on attachment 122491 Patch LGTM. 536114 5 122491 webkit.review.bot 2012-01-13 18:47:43 -0800 Comment on attachment 122491 Patch Clearing flags on attachment: 122491 Committed r105014: <http://trac.webkit.org/changeset/105014> 536115 6 webkit.review.bot 2012-01-13 18:47:47 -0800 All reviewed patches have been landed. Closing bug. 122460 2012-01-13 10:56:22 -0800 2012-01-13 13:42:49 -0800 Patch bug-76288-20120113135621.patch text/plain 1860 efidler U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IGVhNDc4MjgxMzUzZjAyNzg5ZWIzOTcxODAxN2FkNWQxMTkxOTQyZGUuLjc0MGRkMzhkMTQ0NGQw N2JlYmEzMGE3NzlmZjgyMmE2NjM1Zjc1MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC03LDkgKzcsMTYgQEAgTUFDUk8oV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFy Z2V0KQogICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiIpCiAgICAgRU5ESUYgKCkKIAor ICAgIElOQ0xVREUoVGVzdENYWEFjY2VwdHNGbGFnKQorICAgIENIRUNLX0NYWF9BQ0NFUFRTX0ZM QUcoIi1kdW1wdmVyc2lvbiIgQ01BS0VfQ1hYX0FDQ0VQVFNfRFVNUFZFUlNJT04pCisgICAgSUYg KENNQUtFX0NYWF9BQ0NFUFRTX0RVTVBWRVJTSU9OKQorICAgICAgICBFWEVDX1BST0dSQU0oJHtD TUFLRV9DWFhfQ09NUElMRVJ9IEFSR1MgLWR1bXB2ZXJzaW9uIE9VVFBVVF9WQVJJQUJMRSBDT01Q SUxFUl9WRVJTSU9OKQorICAgIEVMU0UgKCkKKyAgICAgICAgRVhFQ19QUk9HUkFNKCIke0NNQUtF X0NYWF9DT01QSUxFUn0gLUUgLVdwLC1kTSAtIDwgL2Rldi9udWxsIHwgZ3JlcCBfX1ZFUlNJT05f XyB8IHNlZCAtZSAncy9eW15cIl0qXCIvLycgLWUgJ3MvXCIuKiQvLyciIE9VVFBVVF9WQVJJQUJM RSBDT01QSUxFUl9WRVJTSU9OKQorICAgIEVORElGICgpCisKICAgICAjIERpc2FibGUgc29tZSBv cHRpbWl6YXRpb25zIG9uIGJ1Z2d5IGNvbXBpbGVyIHZlcnNpb25zCiAgICAgIyBHQ0MgNC41LjEg ZG9lcyBub3QgaW1wbGVtZW50IC1mdHJlZS1zcmEgY29ycmVjdGx5Ci0gICAgRVhFQ19QUk9HUkFN KCR7Q01BS0VfQ1hYX0NPTVBJTEVSfSBBUkdTIC1kdW1wdmVyc2lvbiBPVVRQVVRfVkFSSUFCTEUg Q09NUElMRVJfVkVSU0lPTikKICAgICBJRiAoJHtDT01QSUxFUl9WRVJTSU9OfSBTVFJFUVVBTCAi NC41LjEiKQogICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJTEVfRkxB R1N9IC1mbm8tdHJlZS1zcmEiKQogICAgIEVORElGICgpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggZGIyODM1ODNiOWRhY2E1NzU2MjVmYjc5MzhhYWIwMGM0Mzg2Yjll ZS4uZTg5YTBiODU4MGE2ZTkzOTZmNDYwZjhkY2JkYmE1ZTk2NjczYjNiYSAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTEzICBF bGkgRmlkbGVyICA8ZWZpZGxlckByaW0uY29tPgorCisgICAgICAgIEdDQyBjb21waWxlciB2ZXJz aW9uIGlzIG5vdCBkZXRlY3RlZCBwcm9wZXJseSBmb3IgUU5YIHFjYyB2YXJpYW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI4OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3ZpZGUgYW4gYWx0ZXJu YXRpdmUgd2F5IG9mIGdldHRpbmcgdGhlIGNvbXBpbGVyIHZlcnNpb24gZm9yIEdDQyB2YXJpYW50 cworICAgICAgICB0aGF0IGRvbid0IHN1cHBvcnQgLWR1bXB2ZXJzaW9uIChzdWNoIGFzIHFjYyku CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxMi0w MS0xMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNDgwNS4K 122491 2012-01-13 13:42:54 -0800 2012-01-13 18:47:42 -0800 Patch bug-76288-20120113164252.patch text/plain 1872 efidler U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IGVhNDc4MjgxMzUzZjAyNzg5ZWIzOTcxODAxN2FkNWQxMTkxOTQyZGUuLmI1NDQ4ZDk5MGJlYzZm MGMyM2ZhNDY5NGMzNWZjZjdlNDNmNmRlYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC03LDkgKzcsMTYgQEAgTUFDUk8oV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFHUyBfdGFy Z2V0KQogICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiIpCiAgICAgRU5ESUYgKCkKIAor ICAgIElOQ0xVREUoVGVzdENYWEFjY2VwdHNGbGFnKQorICAgIENIRUNLX0NYWF9BQ0NFUFRTX0ZM QUcoIi1kdW1wdmVyc2lvbiIgQ01BS0VfQ1hYX0FDQ0VQVFNfRFVNUFZFUlNJT04pCisgICAgSUYg KENNQUtFX0NYWF9BQ0NFUFRTX0RVTVBWRVJTSU9OKQorICAgICAgICBFWEVDX1BST0dSQU0oJHtD TUFLRV9DWFhfQ09NUElMRVJ9IEFSR1MgLWR1bXB2ZXJzaW9uIE9VVFBVVF9WQVJJQUJMRSBDT01Q SUxFUl9WRVJTSU9OKQorICAgIEVMU0UgKCkKKyAgICAgICAgRVhFQ19QUk9HUkFNKCIke0NNQUtF X0NYWF9DT01QSUxFUn0gLUUgLVdwLC1kTSAtIDwgL2Rldi9udWxsIHwgZ3JlcCAnI2RlZmluZSBf X1ZFUlNJT05fXycgfCBncmVwIC1FIC1vICdbMC05XStcXC5bMC05XStcXC4/WzAtOV0rPyciIE9V VFBVVF9WQVJJQUJMRSBDT01QSUxFUl9WRVJTSU9OKQorICAgIEVORElGICgpCisKICAgICAjIERp c2FibGUgc29tZSBvcHRpbWl6YXRpb25zIG9uIGJ1Z2d5IGNvbXBpbGVyIHZlcnNpb25zCiAgICAg IyBHQ0MgNC41LjEgZG9lcyBub3QgaW1wbGVtZW50IC1mdHJlZS1zcmEgY29ycmVjdGx5Ci0gICAg RVhFQ19QUk9HUkFNKCR7Q01BS0VfQ1hYX0NPTVBJTEVSfSBBUkdTIC1kdW1wdmVyc2lvbiBPVVRQ VVRfVkFSSUFCTEUgQ09NUElMRVJfVkVSU0lPTikKICAgICBJRiAoJHtDT01QSUxFUl9WRVJTSU9O fSBTVFJFUVVBTCAiNC41LjEiKQogICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xE X0NPTVBJTEVfRkxBR1N9IC1mbm8tdHJlZS1zcmEiKQogICAgIEVORElGICgpCmRpZmYgLS1naXQg YS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZGIyODM1ODNiOWRhY2E1NzU2MjVmYjc5Mzhh YWIwMGM0Mzg2YjllZS4uZTg5YTBiODU4MGE2ZTkzOTZmNDYwZjhkY2JkYmE1ZTk2NjczYjNiYSAx MDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDEyLTAxLTEzICBFbGkgRmlkbGVyICA8ZWZpZGxlckByaW0uY29tPgorCisgICAgICAgIEdDQyBj b21waWxlciB2ZXJzaW9uIGlzIG5vdCBkZXRlY3RlZCBwcm9wZXJseSBmb3IgUU5YIHFjYyB2YXJp YW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI4 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Zp ZGUgYW4gYWx0ZXJuYXRpdmUgd2F5IG9mIGdldHRpbmcgdGhlIGNvbXBpbGVyIHZlcnNpb24gZm9y IEdDQyB2YXJpYW50cworICAgICAgICB0aGF0IGRvbid0IHN1cHBvcnQgLWR1bXB2ZXJzaW9uIChz dWNoIGFzIHFjYykuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFr ZToKKwogMjAxMi0wMS0xMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwNDgwNS4K