76286 2012-01-13 10:39:02 -0800 Eval in strict mode does not need dynamic checks 2012-01-13 12:32:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wingo wingo barraclough fpizlo ggaren oliver webkit.review.bot oldest_to_newest 535777 0 wingo 2012-01-13 10:39:02 -0800 The patch to be attached says: * runtime/JSActivation.cpp (JSC::JSActivation::JSActivation): Eval in strict mode cannot introduce variables, so it not impose the need for dynamic checks. 535779 1 122451 wingo 2012-01-13 10:40:11 -0800 Created attachment 122451 Patch 535806 2 ggaren 2012-01-13 11:01:16 -0800 This looks right to me. Oliver, what do you think? 535848 3 122451 oliver 2012-01-13 11:36:42 -0800 Comment on attachment 122451 Patch Oh, i never thought about doing it that way. Hilariously simple. r=me. 535895 4 122451 webkit.review.bot 2012-01-13 12:31:57 -0800 Comment on attachment 122451 Patch Clearing flags on attachment: 122451 Committed r104970: <http://trac.webkit.org/changeset/104970> 535896 5 webkit.review.bot 2012-01-13 12:32:01 -0800 All reviewed patches have been landed. Closing bug. 122451 2012-01-13 10:40:11 -0800 2012-01-13 12:31:57 -0800 Patch bug-76286-20120113194009.patch text/plain 1783 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0OTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh ODhiOTM4ODU0MmE5ODE2MmFjNGY1YmM0YWUwY2Q2MmVmNWJmMWEyLi5jZjVhMzdhMmEzOWIwNzE1 ODRhNjE1NjUzNTVlNmQyN2QwMDFiNmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMi0wMS0xMyAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CisK KyAgICAgICAgRXZhbCBpbiBzdHJpY3QgbW9kZSBkb2VzIG5vdCBuZWVkIGR5bmFtaWMgY2hlY2tz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI4Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGlt ZS9KU0FjdGl2YXRpb24uY3BwIChKU0M6OkpTQWN0aXZhdGlvbjo6SlNBY3RpdmF0aW9uKToKKyAg ICAgICAgRXZhbCBpbiBzdHJpY3QgbW9kZSBjYW5ub3QgaW50cm9kdWNlIHZhcmlhYmxlcywgc28g aXQgbm90IGltcG9zZQorICAgICAgICB0aGUgbmVlZCBmb3IgZHluYW1pYyBjaGVja3MuCisKIDIw MTItMDEtMTMgIFlvdW5nVGFlY2sgU29uZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5nLmNvbT4K IAogICAgICAgICBbRUZMXSBBZGQgT3duUHRyIHNwZWNpYWxpemF0aW9uIGZvciBFaW5hX01vZHVs ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlv bi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FjdGl2YXRpb24uY3BwCmlu ZGV4IGMwNmY4ODExN2E5YjY4NmJkMmRmZjFhZmM0MzM1ODI5MGU2NTg5YmQuLjNlMDU3MzhlYjU0 YzdiMDRjZWY3MmMxNWIzYmMyN2U5MzhhOGM1NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNBY3RpdmF0aW9uLmNwcApAQCAtNDUsNyArNDUsNyBAQCBKU0FjdGl2YXRp b246OkpTQWN0aXZhdGlvbihDYWxsRnJhbWUqIGNhbGxGcmFtZSwgRnVuY3Rpb25FeGVjdXRhYmxl KiBmdW5jdGlvbkV4ZQogICAgIDogQmFzZShjYWxsRnJhbWUtPmdsb2JhbERhdGEoKSwgY2FsbEZy YW1lLT5nbG9iYWxEYXRhKCkuYWN0aXZhdGlvblN0cnVjdHVyZS5nZXQoKSwgZnVuY3Rpb25FeGVj dXRhYmxlLT5zeW1ib2xUYWJsZSgpLCBjYWxsRnJhbWUtPnJlZ2lzdGVycygpKQogICAgICwgbV9u dW1DYXB0dXJlZEFyZ3MobWF4KGNhbGxGcmFtZS0+YXJndW1lbnRDb3VudCgpLCBmdW5jdGlvbkV4 ZWN1dGFibGUtPnBhcmFtZXRlckNvdW50KCkpKQogICAgICwgbV9udW1DYXB0dXJlZFZhcnMoZnVu Y3Rpb25FeGVjdXRhYmxlLT5jYXB0dXJlZFZhcmlhYmxlQ291bnQoKSkKLSAgICAsIG1fcmVxdWly ZXNEeW5hbWljQ2hlY2tzKGZ1bmN0aW9uRXhlY3V0YWJsZS0+dXNlc0V2YWwoKSkKKyAgICAsIG1f cmVxdWlyZXNEeW5hbWljQ2hlY2tzKGZ1bmN0aW9uRXhlY3V0YWJsZS0+dXNlc0V2YWwoKSAmJiAh ZnVuY3Rpb25FeGVjdXRhYmxlLT5pc1N0cmljdE1vZGUoKSkKICAgICAsIG1fYXJndW1lbnRzUmVn aXN0ZXIoZnVuY3Rpb25FeGVjdXRhYmxlLT5nZW5lcmF0ZWRCeXRlY29kZSgpLmFyZ3VtZW50c1Jl Z2lzdGVyKCkpCiB7CiB9Cg==