76284 2012-01-13 10:11:07 -0800 [GTK] Include gtk+3 in the jhbuild modules 2012-01-16 10:40:41 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76333 1 mario webkit-unassigned mrobinson pnormand webkit.review.bot oldest_to_newest 535757 0 mario 2012-01-13 10:11:07 -0800 We need to add gtk+3 to the jhbuild modules to avoid breaking things if building with a too recent version of GTK+ (greater than 3.3.4), which would fail to find symbols like g_menu_*(), not present in glib 2.31.2 (the version currently included in WKGTK's jhbuild modules). We could raise glib up to 2.31.4, but this would cause even more trouble when trying to build libsoup (it will fail to link due to not finding g_module_open() while generating the introspection information) and so it seems more sensible to add gtk+3, instead. 535760 1 122447 mario 2012-01-13 10:14:33 -0800 Created attachment 122447 Patch proposal Reviewer: If you give r+ to this patch, feel free to set cq+ if you want, otherwise I'll push it next week. 536169 2 122447 webkit.review.bot 2012-01-14 05:23:38 -0800 Comment on attachment 122447 Patch proposal Clearing flags on attachment: 122447 Committed r105017: <http://trac.webkit.org/changeset/105017> 536170 3 webkit.review.bot 2012-01-14 05:23:41 -0800 All reviewed patches have been landed. Closing bug. 536171 4 pnormand 2012-01-14 05:36:38 -0800 configure: error: Package requirements (glib-2.0 >= 2.31.0 atk >= 2.1.5 pango >= 1.29.0 cairo >= 1.10.0 cairo-gobject >= 1.10.0 gdk-pixbuf-2.0 >= 2.23.5) were not met: Requested 'atk >= 2.1.5' but version of Atk is 2.0.1 Requested 'pango >= 1.29.0' but version of Pango is 1.28.4 Rolling out. 536174 5 pnormand 2012-01-14 05:38:56 -0800 ^^ 536194 6 mrobinson 2012-01-14 10:45:03 -0800 (In reply to comment #5) > ^^ Sorry Mario. I probably should have been a little clearer when explaining this before. It's important to figure out what version of GTK+ the bots are using and start with that in the jhbuild modules. 536402 7 mario 2012-01-16 00:41:00 -0800 (In reply to comment #6) > (In reply to comment #5) > > ^^ > > Sorry Mario. I probably should have been a little clearer when explaining this before. It's important to figure out what version of GTK+ the bots are using and start with that in the jhbuild modules. No problem. I'm now trying a full build with a new version of this patch (using gtk+ 3.0.12, as in the 64 bit debug bot) and, if it works, I'll be uploading it pretty soon. Thanks! 536455 8 122609 mario 2012-01-16 03:27:14 -0800 Created attachment 122609 Patch proposal Attaching new patch including GTK+ 3.0.12 (version currently present in the GTK 64bit debug bot) in the moduleset. Also, added as dependency for "gnome-icon-theme", as per the deps-graph in GNOME's modulesets. Last, I added the '-lm' flag manually in jhbuildrc, since for some reason the tarball for GTK 3.0.12 was not "smart enough" for adding it when linking the tests,so it would fail (at least for me) due to not being able to find floor() function :/. If there's a better way to workaround this issue, I'm all ears. 536520 9 122609 pnormand 2012-01-16 06:20:59 -0800 Comment on attachment 122609 Patch proposal Ok let's try this one :) 536659 10 122609 webkit.review.bot 2012-01-16 10:40:37 -0800 Comment on attachment 122609 Patch proposal Clearing flags on attachment: 122609 Committed r105075: <http://trac.webkit.org/changeset/105075> 536660 11 webkit.review.bot 2012-01-16 10:40:41 -0800 All reviewed patches have been landed. Closing bug. 122447 2012-01-13 10:14:33 -0800 2012-01-16 03:27:14 -0800 Patch proposal 0001-2012-01-13-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2147 mario RnJvbSA0ZjUwODEwMGI5Mzc0MTg4NGY4NzRmMzVmYmNkNzNiOTFhOTBjNDk3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDEzIEphbiAyMDEyIDE5OjEyOjQxICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wMS0xMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIEluY2x1ZGUgZ3RrKzMgaW4gdGhlIGpoYnVpbGQgbW9kdWxlcwogICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI4NAoKICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBndGsvamhidWlsZC5tb2R1 bGVzOiBBZGQgc29tZSBndGsrMyB0byB0aGUgamhidWlsZCBtb2R1bGVzZXQuCi0tLQogVG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiBUb29scy9ndGsvamhidWlsZC5t b2R1bGVzIHwgICAxMiArKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9u cygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggYTBjZjliNy4uNWQzY2VkYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAxLTEz ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBb R1RLXSBJbmNsdWRlIGd0ayszIGluIHRoZSBqaGJ1aWxkIG1vZHVsZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2Mjg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVzOiBB ZGQgc29tZSBndGsrMyB0byB0aGUgamhidWlsZCBtb2R1bGVzZXQuCisKIDIwMTItMDEtMTMgIEdh Ym9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgogCiAgICAgICAgIFtHVEtdIGd0a2Rv Yy5weSBpZ25vcmluZyBMREZMQUdTIGFuZCBDRkxBR1MgZW52aXJvbm1lbnQgdmFyaWFibGVzCmRp ZmYgLS1naXQgYS9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZ3RrL2poYnVpbGQu bW9kdWxlcwppbmRleCBmMWEyYzViLi42MmRhZWNlIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvamhi dWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKQEAgLTksNiArOSw3 IEBACiAgICAgICA8ZGVwIHBhY2thZ2U9ImZvbnRzIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImZv bnRjb25maWciLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZnJlZXR5cGU2Ii8+CisgICAgICA8ZGVw IHBhY2thZ2U9Imd0aysiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgogICAgICAgPGRl cCBwYWNrYWdlPSJnbGliLW5ldHdvcmtpbmciLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ25vbWUt aWNvbi10aGVtZSIvPgpAQCAtOTAsNiArOTEsMTcgQEAKICAgICAgICAgICAgICBtZDVzdW09Ijc5 MzkwNjczZjVkMDdhOGZiMzQyYmMwOWI1MDU1YjZmIi8+CiAgIDwvYXV0b3Rvb2xzPgogCisgIDxh dXRvdG9vbHMgaWQ9Imd0aysiPgorICAgIDxkZXBlbmRlbmNpZXM+CisgICAgICA8ZGVwIHBhY2th Z2U9ImdsaWIiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iY2Fpcm8iLz4KKyAgICA8L2RlcGVuZGVu Y2llcz4KKyAgICA8YnJhbmNoIG1vZHVsZT0iL3B1Yi9HTk9NRS9zb3VyY2VzL2d0aysvMy4zL2d0 aystMy4zLjQudGFyLnh6IiB2ZXJzaW9uPSIzLjMuNCIKKyAgICAgICAgICAgIHJlcG89ImZ0cC5n bm9tZS5vcmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6YmNhNzA5ZGEyOWFlY2RhODc0MjFl YWRkNjc2MmEwYWFjMDVmYTU0MjJiOTgzYjRhNzk4OTU3MDg5YTIzYTJlNiIKKyAgICAgICAgICAg IG1kNXN1bT0iMDM2OWFiODU4MTFlOTZhZmY0ZmY5N2ZiMDY1MjVjY2YiLz4KKyAgPC9hdXRvdG9v bHM+CisKICAgPGF1dG90b29scyBpZD0iZ2xpYiI+CiAgICAgPGRlcGVuZGVuY2llcz4KICAgICAg IDxkZXAgcGFja2FnZT0ibGliZmZpIi8+Ci0tIAoxLjcuNy41Cgo= 122609 2012-01-16 03:27:14 -0800 2012-01-16 10:40:37 -0800 Patch proposal 0001-2012-01-13-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3022 mario RnJvbSA4ZTdiMTI1YTNkNzljNzY1YTY1MjU1Y2QzZGQyZmRkZmVjYWZmMTI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDEzIEphbiAyMDEyIDE5OjEyOjQxICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wMS0xMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIEluY2x1ZGUgZ3RrKzMgaW4gdGhlIGpoYnVpbGQgbW9kdWxlcwogICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI4NAoKICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBndGsvamhidWlsZC5tb2R1 bGVzOiBBZGQgc29tZSBndGsrMyB0byB0aGUgamhidWlsZCBtb2R1bGVzZXQuCi0tLQogVG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiBUb29scy9ndGsvamhidWlsZC5t b2R1bGVzIHwgICAxNSArKysrKysrKysrKysrKysKIFRvb2xzL2d0ay9qaGJ1aWxkcmMgICAgICAg fCAgICAzICsrKwogMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCA4NTIwZmJkLi5mYTQ1MDEyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDEtMTMgIE1hcmlvIFNhbmNoZXog UHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEluY2x1ZGUgZ3Rr KzMgaW4gdGhlIGpoYnVpbGQgbW9kdWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzYyODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGd0ay9qaGJ1aWxkLm1vZHVsZXM6IEFkZCBzb21lIGd0ayszIHRv IHRoZSBqaGJ1aWxkIG1vZHVsZXNldC4KKwogMjAxMi0wMS0xNSAgUGFibG8gRmxvdXJldCAgPHBh YmxvZkBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgRml4IGNvbXBpbGF0aW9uIGVycm9ycyBvbiBi dWlsZC13ZWJraXQgLS1kZWJ1ZyAtLW5vLXZpZGVvIG9uIG1hYy4KZGlmZiAtLWdpdCBhL1Rvb2xz L2d0ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IGYx YTJjNWIuLjJkY2JmNjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysr IGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtOSw2ICs5LDcgQEAKICAgICAgIDxkZXAg cGFja2FnZT0iZm9udHMiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZm9udGNvbmZpZyIvPgogICAg ICAgPGRlcCBwYWNrYWdlPSJmcmVldHlwZTYiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ3RrKyIv PgogICAgICAgPGRlcCBwYWNrYWdlPSJnbGliIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIt bmV0d29ya2luZyIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJnbm9tZS1pY29uLXRoZW1lIi8+CkBA IC05MCw2ICs5MSwxNyBAQAogICAgICAgICAgICAgIG1kNXN1bT0iNzkzOTA2NzNmNWQwN2E4ZmIz NDJiYzA5YjUwNTViNmYiLz4KICAgPC9hdXRvdG9vbHM+CiAKKyAgPGF1dG90b29scyBpZD0iZ3Rr KyI+CisgICAgPGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgorICAg ICAgPGRlcCBwYWNrYWdlPSJjYWlybyIvPgorICAgIDwvZGVwZW5kZW5jaWVzPgorICAgIDxicmFu Y2ggbW9kdWxlPSIvcHViL0dOT01FL3NvdXJjZXMvZ3RrKy8zLjAvZ3RrKy0zLjAuMTIudGFyLnh6 IiB2ZXJzaW9uPSIzLjAuMTIiCisgICAgICAgICAgICByZXBvPSJmdHAuZ25vbWUub3JnIgorICAg ICAgICAgICAgaGFzaD0ic2hhMjU2OjIxOWZkZWExMjA4OTc5ODE4NDBlOTA5ZmFjNDBkNGQ0MzNm ZTA2MWEzN2IxMmI5NDAyZTIxNWM4MTllYmVhZTkiCisgICAgICAgICAgICBtZDVzdW09ImI5ODY5 YjY3MWIwZmU1OTA1ZGNlMmZlZTU3Yzk2NWNmIi8+CisgIDwvYXV0b3Rvb2xzPgorCiAgIDxhdXRv dG9vbHMgaWQ9ImdsaWIiPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9 ImxpYmZmaSIvPgpAQCAtMTQwLDYgKzE1Miw5IEBACiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRv dG9vbHMgaWQ9Imdub21lLWljb24tdGhlbWUiIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+CisgICAg PGRlcGVuZGVuY2llcz4KKyAgICAgIDxkZXAgcGFja2FnZT0iZ3RrKyIvPgorICAgIDwvZGVwZW5k ZW5jaWVzPgogICAgIDxicmFuY2ggbW9kdWxlPSJwdWIvR05PTUUvc291cmNlcy9nbm9tZS1pY29u LXRoZW1lLzMuMi9nbm9tZS1pY29uLXRoZW1lLTMuMi4xLnRhci54eiIgdmVyc2lvbj0iMy4yLjEi CiAgICAgICAgICAgICByZXBvPSJmdHAuZ25vbWUub3JnIgogICAgICAgICAgICAgaGFzaD0ic2hh MjU2OmE3ZjBhOGIxN2U5MWFjMzM4ZmRiYzAxYWM1OWE4NzM4ZTljMWUyMDFkZTQ5MmMwNzBkNDNh YWNmMjkxYTg5NTkiCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvamhidWlsZHJjIGIvVG9vbHMvZ3Rr L2poYnVpbGRyYwppbmRleCA5ODY1ZTU2Li5iMGE4Y2NhIDEwMDY0NAotLS0gYS9Ub29scy9ndGsv amhidWlsZHJjCisrKyBiL1Rvb2xzL2d0ay9qaGJ1aWxkcmMKQEAgLTQ0LDMgKzQ0LDYgQEAgYWRk cGF0aCgnUEtHX0NPTkZJR19QQVRIJywgb3MucGF0aC5qb2luKG9zLnNlcCwgJ3VzcicsICdzaGFy ZScsICdwa2djb25maWcnKSkKIAogYWRkcGF0aCgnWERHX0RBVEFfRElSUycsICcvdXNyL3NoYXJl JykKIGFkZHBhdGgoJ1hER19DT05GSUdfRElSUycsICcvZXRjL3hkZycpCisKKyMgR1RLKyAzLjAu MTIgbWlzc2VzIHRoZSAtbG0gZmxhZyB3aGVuIGxpbmtpbmcgdGhlIHRlc3RzLgorbW9kdWxlX21h a2VhcmdzWydndGsrJ10gPSAnTERGTEFHUz0iLWxtIiAnICsgbWFrZWFyZ3MKLS0gCjEuNy43LjUK Cg==