7627 2006-03-06 11:42:30 -0800 SVG from the W3C SVG 1.1 test suite (cubic01.svg) renders as all black 2006-04-05 21:33:38 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://www.w3.org/TR/SVG11/images/paths/cubic01.svg P2 Major --- 1 rwlbuis webkit-unassigned chris oldest_to_newest 35313 0 rwlbuis 2006-03-06 11:42:30 -0800 The svg indicated by the URL renders as one black rect, while it should show path(s). 35325 1 6902 rwlbuis 2006-03-06 13:52:11 -0800 Created attachment 6902 Possible fix 35417 2 6917 rwlbuis 2006-03-07 05:21:21 -0800 Created attachment 6917 New patch Patch tested and okayed by mitzpettel 35425 3 6917 darin 2006-03-07 08:59:33 -0800 Comment on attachment 6917 New patch Needs change log. Needs layout test, or perhaps an existing test already checks this. If you omit the boolean, then true is the default, so I suggest omitting it instead of passing true. 35452 4 rwlbuis 2006-03-07 13:47:59 -0800 (In reply to comment #3) > (From update of attachment 6917 [edit]) > Needs change log. Needs layout test, or perhaps an existing test already checks > this. If you omit the boolean, then true is the default, so I suggest omitting > it instead of passing true. > Hi Darin, I can do most of the above, however I could not explain so far why the change works. I'd really like to be able to do this before seeing the change in, so I'll keep looking for the reason, but if anyone else can explain why it works, please let me know.. Cheers, Rob. 35533 5 6917 darin 2006-03-08 08:59:20 -0800 Comment on attachment 6917 New patch Seems relatively straightforward to investigate further. One idea is to figure out what is parsed differently in the CSS in the different modes. The DOM inspector might even help. Another idea is to reduce this test page further. Marking this patch review- because we don't want to land it until we understand what's wrong, and because it needs change log, layout test, etc. 38496 6 rwlbuis 2006-04-04 04:32:17 -0700 *** Bug 8041 has been marked as a duplicate of this bug. *** 38534 7 hyatt 2006-04-04 13:19:30 -0700 This is the correct fix. SVG is always parsed in strict mode because it's XML, so passing "true" instead of checking the document's mode is the right thing to do. 38535 8 6917 hyatt 2006-04-04 13:19:50 -0700 Comment on attachment 6917 New patch r=me 38536 9 rwlbuis 2006-04-04 13:27:05 -0700 After quite some time looking in the wrong places, I found out in non-strict mode in CSSGrammar.y all class values are lower cased, causing mismatching when we really are looking for class values with upper case in them. So class=foo is not a problem, but class=Foo is, as shown by several testcases. Cheers, Rob. 38543 10 7509 rwlbuis 2006-04-04 13:58:03 -0700 Created attachment 7509 Even more complete patch This time it should have everything, testcase, changelogs etc... Cheers, Rob. 38546 11 7509 eric 2006-04-04 14:45:25 -0700 Comment on attachment 7509 Even more complete patch Looks great. 6902 2006-03-06 13:52:11 -0800 2006-03-07 05:21:21 -0800 Possible fix 7627.diff text/plain 639 rwlbuis SW5kZXg6IFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVudEltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVudEltcGwuY3BwCShyZXZpc2lv biAxMzE2NikKKysrIFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVudEltcGwuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDcsNyArMTA3LDcgQEAKICAgICAgICAgbV9sb2FkaW5nID0gdHJ1 ZTsKICAKICAgICAgICAgbV9zaGVldCA9IG5ldyBDU1NTdHlsZVNoZWV0SW1wbCh0aGlzKTsKLSAg ICAgICAgbV9zaGVldC0+cGFyc2VTdHJpbmcodGV4dENvbnRlbnQoKSwgZmFsc2UpOy8vIWdldERv Y3VtZW50KCktPmluQ29tcGF0TW9kZSgpKTsKKyAgICAgICAgbV9zaGVldC0+cGFyc2VTdHJpbmco dGV4dENvbnRlbnQoKSwgdHJ1ZSk7Ly8hZ2V0RG9jdW1lbnQoKS0+aW5Db21wYXRNb2RlKCkpOwog CiAgICAgICAgIE1lZGlhTGlzdEltcGwgKm1lZGlhTGlzdCA9IG5ldyBNZWRpYUxpc3RJbXBsKG1f c2hlZXQuZ2V0KCksIG1lZGlhRG9tU3RyaW5nKTsKICAgICAgICAgbV9zaGVldC0+c2V0TWVkaWEo bWVkaWFMaXN0KTsK 6917 2006-03-07 05:21:21 -0800 2006-04-04 13:58:03 -0700 New patch 7627.diff text/plain 646 rwlbuis SW5kZXg6IFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVudEltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVudEltcGwuY3BwCShyZXZpc2lv biAxMzE4NSkKKysrIFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVudEltcGwuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDgsNyArMTA4LDcgQEAgdm9pZCBTVkdTdHlsZUVsZW1lbnRJbXBs OjpjaGlsZHJlbkNoYW5nZQogICAgICAgICBtX2xvYWRpbmcgPSB0cnVlOwogIAogICAgICAgICBt X3NoZWV0ID0gbmV3IENTU1N0eWxlU2hlZXRJbXBsKHRoaXMpOwotICAgICAgICBtX3NoZWV0LT5w YXJzZVN0cmluZyh0ZXh0Q29udGVudCgpLCBmYWxzZSk7Ly8hZ2V0RG9jdW1lbnQoKS0+aW5Db21w YXRNb2RlKCkpOworICAgICAgICBtX3NoZWV0LT5wYXJzZVN0cmluZyh0ZXh0Q29udGVudCgpLCB0 cnVlKTsKIAogICAgICAgICBNZWRpYUxpc3RJbXBsICptZWRpYUxpc3QgPSBuZXcgTWVkaWFMaXN0 SW1wbChtX3NoZWV0LmdldCgpLCBtZWRpYURvbVN0cmluZyk7CiAgICAgICAgIG1fc2hlZXQtPnNl dE1lZGlhKG1lZGlhTGlzdCk7Cg== 7509 2006-04-04 13:58:03 -0700 2006-04-04 14:45:25 -0700 Even more complete patch 7627.diff text/plain 2379 rwlbuis SW5kZXg6IExheW91dFRlc3RzL3N2Zy9jdXN0b20vY2xhc3Mtc2VsZWN0b3Iuc3ZnCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3N2Zy9jdXN0b20vY2xhc3Mtc2VsZWN0b3Iuc3ZnCShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9jbGFzcy1zZWxlY3Rvci5zdmcJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsOSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBzdGFuZGFsb25lPSJu byI/PgorPCFET0NUWVBFIHN2ZyBQVUJMSUMgIi0vL1czQy8vRFREIFNWRyAxLjEvL0VOIgorICAi aHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEuZHRkIj4KKzxzdmcg eG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB3aWR0aD0iNDAwIiBoZWlnaHQ9IjQw MCI+Cis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPjwhW0NEQVRBWworLkZvbyB7IGZpbGw6IGdyZWVu OyBzdHJva2Utd2lkdGg6MiB9CitdXT48L3N0eWxlPgorPHJlY3QgY2xhc3M9IkZvbyIgeD0iMTAw IiB5PSIxMDAiIHdpZHRoPSIyMDAiIGhlaWdodD0iMjAwIi8+Cis8L3N2Zz4KSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNjg1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsOSBAQAorMjAwNi0wNC0wNCAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvY3VzdG9t L2NsYXNzLXNlbGVjdG9yLnN2ZzogQWRkZWQuCisKIDIwMDYtMDQtMDQgIEp1c3RpbiBHYXJjaWEg IDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBkYXJpbgpJ bmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJ KHJldmlzaW9uIDEzNjg1KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNiBAQAorMjAwNi0wNC0wNCAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGZvciBodHRw Oi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTc2Mjc6CisgICAgICAg IFNWRyBmcm9tIHRoZSBXM0MgU1ZHIDEuMSB0ZXN0IHN1aXRlIChjdWJpYzAxLnN2ZykgcmVuZGVy cyBhcyBhbGwgYmxhY2sKKworICAgICAgICBGaXggdGhpcyBzdmcgc3R5bGVzaGVldCB0byB1c2Ug c3RyaWN0LW1vZGUsIGFzIHRoaXMgbWFrZXMgc3VyZQorICAgICAgICBjbGFzcyBzZWxlY3Rpbmcg aXMgZG9uZSBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBrc3ZnMi9zdmcvU1ZHU3R5bGVFbGVtZW50 LmNwcDoKKyAgICAgICAgKFNWR1N0eWxlRWxlbWVudDo6Y2hpbGRyZW5DaGFuZ2VkKToKKwogMjAw Ni0wNC0wNCAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IGRhcmluCkluZGV4OiBXZWJDb3JlL2tzdmcyL3N2Zy9TVkdTdHlsZUVs ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUva3N2ZzIvc3ZnL1NWR1N0eWxlRWxlbWVu dC5jcHAJKHJldmlzaW9uIDEzNjg0KQorKysgV2ViQ29yZS9rc3ZnMi9zdmcvU1ZHU3R5bGVFbGVt ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAyLDcgKzEwMiw3IEBAIHZvaWQgU1ZHU3R5bGVF bGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoKQogICAgICAgICBtX2xvYWRpbmcgPSB0cnVlOwogIAog ICAgICAgICBtX3NoZWV0ID0gbmV3IENTU1N0eWxlU2hlZXQodGhpcyk7Ci0gICAgICAgIG1fc2hl ZXQtPnBhcnNlU3RyaW5nKHRleHRDb250ZW50KCksIGZhbHNlKTsvLyFkb2N1bWVudCgpLT5pbkNv bXBhdE1vZGUoKSk7CisgICAgICAgIG1fc2hlZXQtPnBhcnNlU3RyaW5nKHRleHRDb250ZW50KCkp OyAvLyBTVkcgY3NzIGlzIGFsd2F5cyBwYXJzZWQgaW4gc3RyaWN0IG1vZGUKIAogICAgICAgICBN ZWRpYUxpc3QgKm1lZGlhTGlzdCA9IG5ldyBNZWRpYUxpc3QobV9zaGVldC5nZXQoKSwgX21lZGlh KTsKICAgICAgICAgbV9zaGVldC0+c2V0TWVkaWEobWVkaWFMaXN0KTsK