76269 2012-01-13 05:54:10 -0800 [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables 2012-01-13 09:04:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned gustavo mrobinson ossy pnormand webkit.review.bot xan.lopez oldest_to_newest 535619 0 rgabor 2012-01-13 05:54:10 -0800 gtkdoc.py drop the LDFLAGS and CFLAGS environment variables when it runs gtkdoc_scangobj. It would be good if it just add the new flags instead of remove what was set. This would make easier the cross compilation of GTK WebKit. 535621 1 122418 rgabor 2012-01-13 05:59:50 -0800 Created attachment 122418 proposed patch 535626 2 122418 gustavo 2012-01-13 06:06:42 -0800 Comment on attachment 122418 proposed patch Attachment 122418 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11157579 535647 3 122425 rgabor 2012-01-13 06:51:05 -0800 Created attachment 122425 proposed patch v2 535686 4 122425 mrobinson 2012-01-13 08:10:08 -0800 Comment on attachment 122425 proposed patch v2 Thanks for the fix! 535721 5 122425 webkit.review.bot 2012-01-13 09:04:47 -0800 Comment on attachment 122425 proposed patch v2 Clearing flags on attachment: 122425 Committed r104942: <http://trac.webkit.org/changeset/104942> 535722 6 webkit.review.bot 2012-01-13 09:04:51 -0800 All reviewed patches have been landed. Closing bug. 122418 2012-01-13 05:59:50 -0800 2012-01-13 06:51:05 -0800 proposed patch gtkdoc_patch text/plain 1180 rgabor SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNDkyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAxLTEzICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9y Zz4KKworICAgICAgICBbR1RLXSBndGtkb2MucHkgaWdub3JpbmcgTERGTEFHUyBhbmQgQ0ZMQUdT IGVudmlyb25tZW50IHZhcmlhYmxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzYyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGd0ay9ndGtkb2MucHk6CisgICAgICAgIChHVEtEb2MuX3J1bl9ndGtk b2Nfc2NhbmdvYmopOgorCiAyMDEyLTAxLTEzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdUkVHUkVTU0lPTihyMTA0ODgxKTpJdCBicm9r ZSBodW5kcmVkcyBvZiB0ZXN0cwpJbmRleDogVG9vbHMvZ3RrL2d0a2RvYy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9ndGsvZ3RrZG9jLnB5CShyZXZpc2lvbiAxMDQ5MTkpCisrKyBUb29scy9ndGsv Z3RrZG9jLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsOSArMjkwLDkgQEAgY2xhc3MgR1RLRG9j KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgZW52WydSVU4nXSA9ICdMRF9MSUJSQVJZX1BBVEg9 IiVzIiAnICUgc2VsZi5saWJyYXJ5X3BhdGgKIAogICAgICAgICBpZiBsZGZsYWdzOgotICAgICAg ICAgICAgZW52WydMREZMQUdTJ10gPSBsZGZsYWdzCisgICAgICAgICAgICBlbnZbJ0xERkxBR1Mn XSArPSBsZGZsYWdzCiAgICAgICAgIGlmIHNlbGYuY2ZsYWdzOgotICAgICAgICAgICAgZW52WydD RkxBR1MnXSA9IHNlbGYuY2ZsYWdzCisgICAgICAgICAgICBlbnZbJ0NGTEFHUyddICs9IHNlbGYu Y2ZsYWdzCiAKICAgICAgICAgaWYgJ0NGTEFHUycgaW4gZW52OgogICAgICAgICAgICAgc2VsZi5s b2dnZXIuZGVidWcoJ0NGTEFHUz0lcycsIGVudlsnQ0ZMQUdTJ10pCg== 122425 2012-01-13 06:51:05 -0800 2012-01-13 09:04:47 -0800 proposed patch v2 gtkdoc_patch2 text/plain 1249 rgabor SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwNDkyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTAxLTEzICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9y Zz4KKworICAgICAgICBbR1RLXSBndGtkb2MucHkgaWdub3JpbmcgTERGTEFHUyBhbmQgQ0ZMQUdT IGVudmlyb25tZW50IHZhcmlhYmxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzYyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGd0ay9ndGtkb2MucHk6CisgICAgICAgIChHVEtEb2MuX3J1bl9ndGtk b2Nfc2NhbmdvYmopOgorCiAyMDEyLTAxLTEzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtXSzJdUkVHUkVTU0lPTihyMTA0ODgxKTpJdCBicm9r ZSBodW5kcmVkcyBvZiB0ZXN0cwpJbmRleDogVG9vbHMvZ3RrL2d0a2RvYy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9ndGsvZ3RrZG9jLnB5CShyZXZpc2lvbiAxMDQ5MTkpCisrKyBUb29scy9ndGsv Z3RrZG9jLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOTAsOSArMjkwLDkgQEAgY2xhc3MgR1RLRG9j KG9iamVjdCk6CiAgICAgICAgICAgICAgICAgZW52WydSVU4nXSA9ICdMRF9MSUJSQVJZX1BBVEg9 IiVzIiAnICUgc2VsZi5saWJyYXJ5X3BhdGgKIAogICAgICAgICBpZiBsZGZsYWdzOgotICAgICAg ICAgICAgZW52WydMREZMQUdTJ10gPSBsZGZsYWdzCisgICAgICAgICAgICBlbnZbJ0xERkxBR1Mn XSA9ICclcyAlcycgJSAoZW52LmdldCgnTERGTEFHUycsICcnKSwgbGRmbGFncykKICAgICAgICAg aWYgc2VsZi5jZmxhZ3M6Ci0gICAgICAgICAgICBlbnZbJ0NGTEFHUyddID0gc2VsZi5jZmxhZ3MK KyAgICAgICAgICAgIGVudlsnQ0ZMQUdTJ10gPSAnJXMgJXMnICUgKGVudi5nZXQoJ0NGTEFHUycs ICcnKSwgc2VsZi5jZmxhZ3MpCiAKICAgICAgICAgaWYgJ0NGTEFHUycgaW4gZW52OgogICAgICAg ICAgICAgc2VsZi5sb2dnZXIuZGVidWcoJ0NGTEFHUz0lcycsIGVudlsnQ0ZMQUdTJ10pCg==