76250 2012-01-13 00:06:29 -0800 [EFL] Remove extern "C" from ewk_private.h 2012-01-13 07:49:54 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 535485 0 gyuyoung.kim 2012-01-13 00:06:29 -0800 ewk_private.h defines internal functions used by WebKit itself. There is no chance to be used by C application. So, extern "C" keyword is unneeded in ewk_private.h. 535488 1 122384 gyuyoung.kim 2012-01-13 00:12:19 -0800 Created attachment 122384 Patch 535602 2 122384 kling 2012-01-13 05:27:10 -0800 Comment on attachment 122384 Patch Looks legit. 535675 3 122384 webkit.review.bot 2012-01-13 07:49:49 -0800 Comment on attachment 122384 Patch Clearing flags on attachment: 122384 Committed r104937: <http://trac.webkit.org/changeset/104937> 535676 4 webkit.review.bot 2012-01-13 07:49:54 -0800 All reviewed patches have been landed. Closing bug. 122384 2012-01-13 00:12:19 -0800 2012-01-13 07:49:49 -0800 Patch bug-76250-20120113171218.patch text/plain 1674 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0ODk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggN2EwYmQyNjQ3 N2JiNDk1ZTE1M2Q2OTFlYTcxMGI1ZGI4NWFhM2U5NC4uNWZiOGYxMGY3OGU0YTM2Zjk2MDZiODRi ZDU1ZTNjNTRiODYxMWFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTAxLTEyICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0VGTF0gUmVtb3ZlIGV4dGVybiAiQyIgZnJvbSBld2tfcHJpdmF0ZS5oCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI1MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGV3a19wcml2YXRlLmggZGVmaW5l cyBpbnRlcm5hbCBmdW5jdGlvbnMgdXNlZCBieSBXZWJLaXQgaXRzZWxmLiBUaGVyZSBpcyBubyBj aGFuY2UgdG8gYmUgdXNlZCBieSBDIGFwcGxpY2F0aW9uLgorICAgICAgICBTbywgZXh0ZXJuICJD IiBrZXl3b3JkIGlzIHVubmVlZGVkIGluIGV3a19wcml2YXRlLmguCisKKyAgICAgICAgKiBld2sv ZXdrX3ByaXZhdGUuaDoKKwogMjAxMi0wMS0xMiAgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3ph amtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBNb3ZlIG1hY3JvIGNoZWNraW5n IHRvIGZ1bmN0aW9ucycgZGVmaW5pdGlvbiBpbiBld2tfanMuY3BwLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ByaXZhdGUuaAppbmRleCAyMDI1OTQxYzliNDZiMDhhOTBmYWE1NTk0MzlmMjE4ZDI5ZGY5 MTQwLi5iMWM2MDMwYWFjNTUwNDNhZjA4MjU2NDExNDA5ZTE4ZDAwMWE4ZTI2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9ld2svZXdrX3ByaXZhdGUuaApAQCAtMzksMTAgKzM5LDYgQEAKICNpbmNsdWRlIDx3dGYv UGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KIAotI2lmZGVmIF9fY3BsdXNw bHVzCi1leHRlcm4gIkMiIHsKLSNlbmRpZgotCiAvLyBJZiBkZWZpbmVkLCBld2sgd2lsbCBkbyB0 eXBlIGNoZWNraW5nIHRvIGVuc3VyZSBvYmplY3RzIGFyZSBvZiBjb3JyZWN0IHR5cGUKICNkZWZp bmUgRVdLX1RZUEVfQ0hFQ0sgMQogI2RlZmluZSBFV0tfQVJHQl9CWVRFU19TSVpFIDQKQEAgLTIy Nyw4ICsyMjMsNCBAQCB2b2lkIGV3a19mcmFtZV9taXhlZF9jb250ZW50X3J1bl9zZXQoRXZhc19P YmplY3QqIGV3a0ZyYW1lLCBib29sIGhhc1J1bik7CiB2b2lkIGV3a192aWV3X21peGVkX2NvbnRl bnRfZGlzcGxheWVkX3NldChFdmFzX09iamVjdCogZXdrVmlldywgYm9vbCBoYXNEaXNwbGF5ZWQp Owogdm9pZCBld2tfdmlld19taXhlZF9jb250ZW50X3J1bl9zZXQoRXZhc19PYmplY3QqIGV3a1Zp ZXcsIGJvb2wgaGFzUnVuKTsKIAotI2lmZGVmIF9fY3BsdXNwbHVzCi0KLX0KLSNlbmRpZgogI2Vu ZGlmIC8vIGV3a19wcml2YXRlX2gK