76247 2012-01-12 22:24:24 -0800 [Qt][WK2]REGRESSION(r104881): Mock scrollbars broke hundreds of tests 2012-10-01 04:08:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 67217 79666 1 ossy ossy hausmann kbalazs kenneth mitz ossy simon.fraser oldest_to_newest 535447 0 ossy 2012-01-12 22:24:24 -0800 Mock scrollbars was enabled by default: http://trac.webkit.org/changeset/104881 And unfortunately it broke 393 tests on Qt WK2 platform: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r104881%20%2818492%29/results.html 535448 1 ossy 2012-01-12 22:27:11 -0800 These test (and others too) results were same on Qt-WK1 and on Qt-WK2 before, but they differ now. It wouldn't be good if wk1 and wk2 results were diverge. 535496 2 122388 ossy 2012-01-13 00:25:00 -0800 Created attachment 122388 Patch 535498 3 ossy 2012-01-13 00:25:53 -0800 (In reply to comment #2) > Created an attachment (id=122388) [details] > Patch It is a workaround. I think we should disable mock scrollbars on Qt until somebody can check it and find a proper fix. 535521 4 122388 ossy 2012-01-13 01:41:46 -0800 Comment on attachment 122388 Patch Clearing flags on attachment: 122388 Committed r104910: <http://trac.webkit.org/changeset/104910> 731427 5 kbalazs 2012-10-01 00:22:07 -0700 I think we only need to enable mock scrollbars for qt DRT (that has never been happended so far) and rebaseline results. I experimented with this and on the tests I tried there was no difference in the wk1 and wk2 results (although I did not run all). 731428 6 kbalazs 2012-10-01 00:30:22 -0700 (In reply to comment #5) > I think we only need to enable mock scrollbars for qt DRT I mean for DRT as well as for WTR. 731558 7 kbalazs 2012-10-01 04:08:39 -0700 Let's track the enabling of mock scrollbars in bug 98011 122388 2012-01-13 00:25:00 -0800 2012-01-13 01:41:46 -0800 Patch bug-76247-20120113092458.patch text/plain 1506 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0OTAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGZjNmM5ZDFkYmNjN2NhMDBkZWNhNTg3MTI1OTVkYmQ4 NDJjNWJlYy4uNWViYTEyMTc2OTQxMDk2NzI4YTg4OWNlYWUzYjc4N2ZhNWRlNmYwNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTAxLTEzICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1F0XVtXSzJdUkVHUkVTU0lPTihyMTA0ODgxKTpJdCBicm9rZSBodW5kcmVkcyBv ZiB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzYyNDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0 Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyk6IERpc2FibGUgbW9jayBz Y3JvbGxiYXJzIG9uIFF0IGJ5IGRlZmF1bHQuICh3b3JrYXJvdW5kKQorCiAyMDEyLTAxLTEyICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1pdGlnYXRl IHNjcm9sbGJhciBkaWZmZXJlbmNlcyB3aGVuIHJ1bm5pbmcgcGl4ZWwgdGVzdHMKZGlmZiAtLWdp dCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggNzdhNjg4MWZiZTI5MTZhMDli OTdiYTQwZWQ0NzM3NjNmZjM5ZTFmZC4uOWQ1Mzk1OTkyNjVmZmQ4MjQwNTI4YTY3ZTA0NzJiOTQx NjA4ZGQ2ZCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxl ci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAg LTQyNyw3ICs0MjcsMTIgQEAgYm9vbCBUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lz dGVudFZhbHVlcygpCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogICAgIFdLUHJlZmVyZW5j ZXNTZXRGdWxsU2NyZWVuRW5hYmxlZChwcmVmZXJlbmNlcywgdHJ1ZSk7CiAjZW5kaWYKKworLy8g W1F0XVtXSzJdUkVHUkVTU0lPTihyMTA0ODgxKTpJdCBicm9rZSBodW5kcmVkcyBvZiB0ZXN0cwor Ly8gRklYTUU6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI0Nwor I2lmICFQTEFURk9STShRVCkKICAgICBXS1ByZWZlcmVuY2VzU2V0TW9ja1Njcm9sbGJhcnNFbmFi bGVkKHByZWZlcmVuY2VzLCB0cnVlKTsKKyNlbmRpZgogCiAjaWYgIVBMQVRGT1JNKFFUKQogICAg IHN0YXRpYyBXS1N0cmluZ1JlZiBzdGFuZGFyZEZvbnRGYW1pbHkgPSBXS1N0cmluZ0NyZWF0ZVdp dGhVVEY4Q1N0cmluZygiVGltZXMiKTsK