76245 2012-01-12 21:50:05 -0800 [Mac][DRT] should allow query string for the file URL. 2012-01-18 18:00:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76156 1 morrita morrita aroben rniwa tony webkit.review.bot oldest_to_newest 535433 0 morrita 2012-01-12 21:50:05 -0800 This is a part of effort to run Dromaeo on DRT. Dromaeo select the subset of test to run by reading the query string. But DRT cannot pass it because file urls don't support query string. So we need some way to give a context other than query string to run the test. By injecting some script from outside, we can start the script by emulating user operation. This kind of automation helper would be helpful to run existing testcases. We can do - invoking layoutTestController without touching the page source. - emulating user operation like clicking - modifying page DOM to format the report. 535438 1 rniwa 2012-01-12 22:04:18 -0800 Can we run the tests inside an iframe? 535440 2 morrita 2012-01-12 22:05:34 -0800 (In reply to comment #1) > Can we run the tests inside an iframe? Ah, that looks better idea actually. I'll try. 535758 3 tony 2012-01-13 10:12:03 -0800 FWIW, I am able to load file:///test.html?test and file:///test.html#test in Safari Mac and Chrome Linux. window.location seems to have properly parsed the query string and the fragment. 536307 4 morrita 2012-01-15 17:00:50 -0800 (In reply to comment #3) > FWIW, I am able to load file:///test.html?test and file:///test.html#test in Safari Mac and Chrome Linux. window.location seems to have properly parsed the query string and the fragment. Hmm interesting. May be we can fix DRT to handle it. Its Filename to URl conversion look doubtful. 536843 5 122702 morrita 2012-01-16 18:58:30 -0800 Created attachment 122702 Ultra trivial one-line change 537472 6 122702 webkit.review.bot 2012-01-17 17:16:44 -0800 Comment on attachment 122702 Ultra trivial one-line change Clearing flags on attachment: 122702 Committed r105218: <http://trac.webkit.org/changeset/105218> 537473 7 webkit.review.bot 2012-01-17 17:16:49 -0800 All reviewed patches have been landed. Closing bug. 538005 8 aroben 2012-01-18 11:04:02 -0800 Are you planning to add this ability to other ports of DRT, and to WebKitTestRunner? 538373 9 morrita 2012-01-18 18:00:23 -0800 Hi Adam, thank you for your interest! (In reply to comment #8) > Are you planning to add this ability to other ports of DRT, and to WebKitTestRunner? I don't have any concrete plan yet. But it should be done when we add perf tests on the waterfall. I'm currently focusing on ensuring the feasibility of the idea, that is to run third party perf tests on DRT. So any help would be appreciated ;-) 122702 2012-01-16 18:58:30 -0800 2012-01-17 17:16:44 -0800 Ultra trivial one-line change bug-76245-20120117115828.patch text/plain 1601 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTA1MTEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjdkNTQ3MGYxNzBmZTcyOWU2MTg0OGY5YjRhN2E4NTM3 NTRlNDk5MS4uYmE0ODU2YmI2OWI3NmVkMDJiNzllNjRkMDgzY2E0ZjZmNDc4N2NkYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAxLTE2ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0ub3JnPgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjI0NQor ICAgICAgICBbTWFjXVtEUlRdIHNob3VsZCBhbGxvdyBxdWVyeSBzdHJpbmcgZm9yIHRoZSBmaWxl IFVSTC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU YXVnaHQgRFJUIGFib3V0IGZpbGU6Ly8gYXMgYSB1cmwgaW5zdGVhZCBvZiBhIGZpbGUgcGF0aC4K KyAgICAgICAgV2UgYXJlIG5vdyBhYmxlIHRvIHVzZSBhIHBhdGggZmlsZTovLy9mb28vYmFyLmh0 bWw/YmF6IGFzIGEgdXJsCisgICAgICAgIHdpdGggd2hpY2ggRFJUIG9wZW5zICIvZm9vL2Jhci5o dG1sIiB3aXRoICJiYXoiIGFzIGEgcXVlcnkgc3RyaW5nLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOgorICAgICAgICAocnVuVGVzdCk6CisKIDIwMTIt MDEtMTYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtX aW5DYWlyb10gQnVpbGQgZml4IGFmdGVyIHIxMDQxNTUuIFNldmVyYWwgZGVidWcgdGFyZ2V0cyB3 ZXJlIG5vdApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJU cmVlLm1tIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCmluZGV4 IDhlZDAzNDRjMWRiMmYzZWVmZmM2ODBmMjAwNWM0NTVjNGFmZGExYTYuLjEwM2E2OTEzOGQzNWM4 MDU5Y2RlNWNjNzgwYzYzMDRlNjA2NjZlZGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMv RHVtcFJlbmRlclRyZWUubW0KQEAgLTEyODMsNyArMTI4Myw3IEBAIHN0YXRpYyB2b2lkIHJ1blRl c3QoY29uc3Qgc3RyaW5nJiB0ZXN0UGF0aE9yVVJMKQogICAgIH0KIAogICAgIE5TVVJMICp1cmw7 Ci0gICAgaWYgKFtwYXRoT3JVUkxTdHJpbmcgaGFzUHJlZml4OkAiaHR0cDovLyJdIHx8IFtwYXRo T3JVUkxTdHJpbmcgaGFzUHJlZml4OkAiaHR0cHM6Ly8iXSkKKyAgICBpZiAoW3BhdGhPclVSTFN0 cmluZyBoYXNQcmVmaXg6QCJodHRwOi8vIl0gfHwgW3BhdGhPclVSTFN0cmluZyBoYXNQcmVmaXg6 QCJodHRwczovLyJdIHx8IFtwYXRoT3JVUkxTdHJpbmcgaGFzUHJlZml4OkAiZmlsZTovLyJdKQog ICAgICAgICB1cmwgPSBbTlNVUkwgVVJMV2l0aFN0cmluZzpwYXRoT3JVUkxTdHJpbmddOwogICAg IGVsc2UKICAgICAgICAgdXJsID0gW05TVVJMIGZpbGVVUkxXaXRoUGF0aDpwYXRoT3JVUkxTdHJp bmddOwo=