76226 2012-01-12 16:53:57 -0800 table border spacing test for CSS3 calc 2012-01-25 04:39:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 16662 1 mikelawther mikelawther jchaffraix webkit.review.bot oldest_to_newest 535303 0 mikelawther 2012-01-12 16:53:57 -0800 table border spacing test for CSS3 calc 535305 1 122339 mikelawther 2012-01-12 16:55:51 -0800 Created attachment 122339 Patch 541748 2 122339 jchaffraix 2012-01-24 15:09:36 -0800 Comment on attachment 122339 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122339&action=review > LayoutTests/css3/calc/table-border-spacing.html:5 > + vertical-align: top; Nit: This line is not be needed for the test. > LayoutTests/css3/calc/table-border-spacing.html:15 > + position: relative Ditto. 542015 3 122339 mikelawther 2012-01-24 22:27:45 -0800 Comment on attachment 122339 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122339&action=review Thanks for the review Julien! >> LayoutTests/css3/calc/table-border-spacing.html:5 >> + vertical-align: top; > > Nit: This line is not be needed for the test. Done. >> LayoutTests/css3/calc/table-border-spacing.html:15 >> + position: relative > > Ditto. Done. 542016 4 123884 mikelawther 2012-01-24 22:28:20 -0800 Created attachment 123884 Patch for landing 542191 5 123884 webkit.review.bot 2012-01-25 04:39:18 -0800 Comment on attachment 123884 Patch for landing Clearing flags on attachment: 123884 Committed r105869: <http://trac.webkit.org/changeset/105869> 542192 6 webkit.review.bot 2012-01-25 04:39:22 -0800 All reviewed patches have been landed. Closing bug. 122339 2012-01-12 16:55:51 -0800 2012-01-24 22:28:11 -0800 Patch bug-76226-20120113115548.patch text/plain 3260 mikelawther U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0ODczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmJiM2Q1ZjI2ZDUzZjg0NzM5YTNi MThkNDY3N2FlOTdhNWYzMWNiYi4uZTgwNjFhZDczOWYwOGE3ZjlkMTllOTFhMDNiMTgwN2RmNTRk YTI1MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTEyICBNaWtlIExhd3RoZXIgIDxt aWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgdGFibGUgYm9yZGVyIHNwYWNpbmcg dGVzdCBmb3IgQ1NTMyBjYWxjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NjIyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3RzIGZvciBmdXR1cmUgaW1wbGVtZW50YXRpb24gb2YgQ1NTMyBjYWxjKCkg KHNlZSBodHRwOi8vd2Via2l0Lm9yZy9iLzE2NjYyKQorCisgICAgICAgIFRoZXNlIHRlc3RzIGFy ZSBleHBlY3RlZCB0byAnZmFpbCcsIGFuZCB3aWxsIHBhc3Mgb25jZSBjYWxjKCkgZnVuY3Rpb25h bGl0eSBpcyBsYW5kZWQuCisgICAgICAgIEZvciBub3csIHRoZXkgc2VydmUgdG8gZGVtb25zdHJh dGUgdGhhdCB0aGUgY3VycmVudCBjb2RlIGRvZXNuJ3QgY3Jhc2ggb24gdGhlc2UgdGVzdHMuCisK KyAgICAgICAgKiBjc3MzL2NhbGMvdGFibGUtYm9yZGVyLXNwYWNpbmctZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBjc3MzL2NhbGMvdGFibGUtYm9yZGVyLXNwYWNpbmcuaHRtbDogQWRk ZWQuCisKIDIwMTItMDEtMTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAg ICAgICBOb2RlSXRlcmF0b3IgbG9zZXMgdHJhY2sgb2YgdGhlIHJlZmVyZW5jZSBub2RlIHdoZW4g dGhlIHJlZmVyZW5jZSBub2RlIGlzIHJlbW92ZWQgZnJvbSB0aGUgZG9jdW1lbnQgKElFVEMgbmlf cmVtb3ZlUmVmZXJlbmNlTm9kZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvY2FsYy90 YWJsZS1ib3JkZXItc3BhY2luZy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jc3MzL2NhbGMv dGFibGUtYm9yZGVyLXNwYWNpbmctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM1OGVmMDMyMzkx MjhjZmY2MWI4MzI3OTRmMTg3MmViZTFmNjUwNGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9jc3MzL2NhbGMvdGFibGUtYm9yZGVyLXNwYWNpbmctZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsNiBAQAorRkFJTCBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RpbXVsdXMiKS5vZmZzZXRX aWR0aCBzaG91bGQgYmUgNDE2LiBXYXMgMjc4LgorRkFJTCBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgic3RpbXVsdXMiKS5vZmZzZXRIZWlnaHQgc2hvdWxkIGJlIDIwNS4gV2FzIDEzNi4KK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9jc3MzL2NhbGMvdGFibGUtYm9yZGVyLXNwYWNpbmcuaHRtbCBiL0xheW91 dFRlc3RzL2NzczMvY2FsYy90YWJsZS1ib3JkZXItc3BhY2luZy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmVj NTMyYjA0MGFjYjc3M2Y4MjRlYzc3NDE0ODg4ZmFmNTQ0ZTQ1ZjgKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9jc3MzL2NhbGMvdGFibGUtYm9yZGVyLXNwYWNpbmcuaHRtbApAQCAtMCww ICsxLDUwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c3R5bGU+CisgICAgdGQgeyAKKyAg ICAgICAgdmVydGljYWwtYWxpZ246IHRvcDsgCisgICAgICAgIHBhZGRpbmc6IDA7IAorICAgICAg ICB3aWR0aDogNTBweDsgCisgICAgICAgIGhlaWdodDogNjBweDsgCisgICAgICAgIGJhY2tncm91 bmQtY29sb3I6IGJsdWU7IAorICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjayAKKyAgICB9 CisgICAgdGFibGUgeyAKKyAgICAgICAgYm9yZGVyLXNwYWNpbmc6IC13ZWJraXQtY2FsYygxMHB4 ICogMiArIDVweCk7IAorICAgICAgICBib3JkZXI6IDNweCBzb2xpZCBibGFjazsgCisgICAgICAg IHBvc2l0aW9uOiByZWxhdGl2ZSAKKyAgICB9Cis8L3N0eWxlPgorPHRhYmxlIGlkPSJzdGltdWx1 cyI+CisgICAgPHRyPgorICAgICAgICA8dGQ+PC90ZD4KKyAgICAgICAgPHRkPjwvdGQ+CisgICAg ICAgIDx0ZD48L3RkPgorICAgICAgICA8dGQ+PC90ZD4KKyAgICAgICAgPHRkPjwvdGQ+CisgICAg PC90cj4KKyAgICA8dHI+CisgICAgICAgIDx0ZD48L3RkPgorICAgICAgICA8dGQ+PC90ZD4KKyAg ICAgICAgPHRkPjwvdGQ+CisgICAgICAgIDx0ZD48L3RkPgorICAgICAgICA8dGQ+PC90ZD4KKyAg ICA8L3RyPgorPC90YWJsZT4KKzxzY3JpcHQ+CisgICAgdmFyIGlubmVyQm9yZGVyID0gMTsKKyAg ICB2YXIgb3V0ZXJCb3JkZXIgPSAzOworICAgIHZhciBpbm5lcldpZHRoID0gNTAgKyAyICogaW5u ZXJCb3JkZXI7CisgICAgdmFyIGlubmVySGVpZ2h0ID0gNjAgKyAyICogaW5uZXJCb3JkZXI7Cisg ICAgdmFyIGJvcmRlclNwYWNpbmcgPSAyNTsKKyAgICB2YXIgcm93cyA9IDI7CisgICAgdmFyIGNv bHVtbnMgPSA1OworCisgICAgdmFyIGV4cGVjdGVkV2lkdGggPSBpbm5lcldpZHRoICogY29sdW1u cyArIGJvcmRlclNwYWNpbmcgKiAoY29sdW1ucyArIDEpICsgMiAqIG91dGVyQm9yZGVyOworICAg IHZhciBleHBlY3RlZEhlaWdodCA9IGlubmVySGVpZ2h0ICogcm93cyArIGJvcmRlclNwYWNpbmcg KiAocm93cyArIDEpICsgMiAqIG91dGVyQm9yZGVyOworCisgICAgc2hvdWxkRXZhbHVhdGVUbygn ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN0aW11bHVzIikub2Zmc2V0V2lkdGgnLCBleHBlY3Rl ZFdpZHRoKTsKKyAgICBzaG91bGRFdmFsdWF0ZVRvKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi c3RpbXVsdXMiKS5vZmZzZXRIZWlnaHQnLCBleHBlY3RlZEhlaWdodCk7Cis8L3NjcmlwdD4gICAg Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4KKwo= 123884 2012-01-24 22:28:20 -0800 2012-01-25 04:39:18 -0800 Patch for landing bug-76226-20120125172817.patch text/plain 3202 mikelawther U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0ODczCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmJiM2Q1ZjI2ZDUzZjg0NzM5YTNi MThkNDY3N2FlOTdhNWYzMWNiYi4uMmY1NDAzZTcyMTVhZTRhNjBiY2E5OTU1NGQ0OTJhZWRkNjgz OWUwYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTEyICBNaWtlIExhd3RoZXIgIDxt aWtlbGF3dGhlckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgdGFibGUgYm9yZGVyIHNwYWNpbmcg dGVzdCBmb3IgQ1NTMyBjYWxjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NjIyNgorCisgICAgICAgIFJldmlld2VkIGJ5IEp1bGllbiBDaGFmZnJhaXgu CisKKyAgICAgICAgVGVzdHMgZm9yIGZ1dHVyZSBpbXBsZW1lbnRhdGlvbiBvZiBDU1MzIGNhbGMo KSAoc2VlIGh0dHA6Ly93ZWJraXQub3JnL2IvMTY2NjIpCisKKyAgICAgICAgVGhlc2UgdGVzdHMg YXJlIGV4cGVjdGVkIHRvICdmYWlsJywgYW5kIHdpbGwgcGFzcyBvbmNlIGNhbGMoKSBmdW5jdGlv bmFsaXR5IGlzIGxhbmRlZC4KKyAgICAgICAgRm9yIG5vdywgdGhleSBzZXJ2ZSB0byBkZW1vbnN0 cmF0ZSB0aGF0IHRoZSBjdXJyZW50IGNvZGUgZG9lc24ndCBjcmFzaCBvbiB0aGVzZSB0ZXN0cy4K KworICAgICAgICAqIGNzczMvY2FsYy90YWJsZS1ib3JkZXItc3BhY2luZy1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGNzczMvY2FsYy90YWJsZS1ib3JkZXItc3BhY2luZy5odG1sOiBB ZGRlZC4KKwogMjAxMi0wMS0xMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIE5vZGVJdGVyYXRvciBsb3NlcyB0cmFjayBvZiB0aGUgcmVmZXJlbmNlIG5vZGUgd2hl biB0aGUgcmVmZXJlbmNlIG5vZGUgaXMgcmVtb3ZlZCBmcm9tIHRoZSBkb2N1bWVudCAoSUVUQyBu aV9yZW1vdmVSZWZlcmVuY2VOb2RlKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9jYWxj L3RhYmxlLWJvcmRlci1zcGFjaW5nLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NzczMvY2Fs Yy90YWJsZS1ib3JkZXItc3BhY2luZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzU4ZWYwMzIz OTEyOGNmZjYxYjgzMjc5NGYxODcyZWJlMWY2NTA0YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2NzczMvY2FsYy90YWJsZS1ib3JkZXItc3BhY2luZy1leHBlY3RlZC50eHQKQEAgLTAs MCArMSw2IEBACitGQUlMIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJzdGltdWx1cyIpLm9mZnNl dFdpZHRoIHNob3VsZCBiZSA0MTYuIFdhcyAyNzguCitGQUlMIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJzdGltdWx1cyIpLm9mZnNldEhlaWdodCBzaG91bGQgYmUgMjA1LiBXYXMgMTM2LgorUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2NzczMvY2FsYy90YWJsZS1ib3JkZXItc3BhY2luZy5odG1sIGIvTGF5 b3V0VGVzdHMvY3NzMy9jYWxjL3RhYmxlLWJvcmRlci1zcGFjaW5nLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u Y2ZmMWJkNWU3MDBjMDM3N2I5MTQ2MzRiYjdhMWM3ZmQ0Y2Y3ZWExOQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2NzczMvY2FsYy90YWJsZS1ib3JkZXItc3BhY2luZy5odG1sCkBAIC0w LDAgKzEsNDggQEAKKzwhRE9DVFlQRSBodG1sPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzdHlsZT4KKyAgICB0ZCB7IAor ICAgICAgICBwYWRkaW5nOiAwOyAKKyAgICAgICAgd2lkdGg6IDUwcHg7IAorICAgICAgICBoZWln aHQ6IDYwcHg7IAorICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOyAKKyAgICAgICAgYm9y ZGVyOiAxcHggc29saWQgYmxhY2sgCisgICAgfQorICAgIHRhYmxlIHsgCisgICAgICAgIGJvcmRl ci1zcGFjaW5nOiAtd2Via2l0LWNhbGMoMTBweCAqIDIgKyA1cHgpOyAKKyAgICAgICAgYm9yZGVy OiAzcHggc29saWQgYmxhY2s7IAorICAgIH0KKzwvc3R5bGU+Cis8dGFibGUgaWQ9InN0aW11bHVz Ij4KKyAgICA8dHI+CisgICAgICAgIDx0ZD48L3RkPgorICAgICAgICA8dGQ+PC90ZD4KKyAgICAg ICAgPHRkPjwvdGQ+CisgICAgICAgIDx0ZD48L3RkPgorICAgICAgICA8dGQ+PC90ZD4KKyAgICA8 L3RyPgorICAgIDx0cj4KKyAgICAgICAgPHRkPjwvdGQ+CisgICAgICAgIDx0ZD48L3RkPgorICAg ICAgICA8dGQ+PC90ZD4KKyAgICAgICAgPHRkPjwvdGQ+CisgICAgICAgIDx0ZD48L3RkPgorICAg IDwvdHI+Cis8L3RhYmxlPgorPHNjcmlwdD4KKyAgICB2YXIgaW5uZXJCb3JkZXIgPSAxOworICAg IHZhciBvdXRlckJvcmRlciA9IDM7CisgICAgdmFyIGlubmVyV2lkdGggPSA1MCArIDIgKiBpbm5l ckJvcmRlcjsKKyAgICB2YXIgaW5uZXJIZWlnaHQgPSA2MCArIDIgKiBpbm5lckJvcmRlcjsKKyAg ICB2YXIgYm9yZGVyU3BhY2luZyA9IDI1OworICAgIHZhciByb3dzID0gMjsKKyAgICB2YXIgY29s dW1ucyA9IDU7CisKKyAgICB2YXIgZXhwZWN0ZWRXaWR0aCA9IGlubmVyV2lkdGggKiBjb2x1bW5z ICsgYm9yZGVyU3BhY2luZyAqIChjb2x1bW5zICsgMSkgKyAyICogb3V0ZXJCb3JkZXI7CisgICAg dmFyIGV4cGVjdGVkSGVpZ2h0ID0gaW5uZXJIZWlnaHQgKiByb3dzICsgYm9yZGVyU3BhY2luZyAq IChyb3dzICsgMSkgKyAyICogb3V0ZXJCb3JkZXI7CisKKyAgICBzaG91bGRFdmFsdWF0ZVRvKCdk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RpbXVsdXMiKS5vZmZzZXRXaWR0aCcsIGV4cGVjdGVk V2lkdGgpOworICAgIHNob3VsZEV2YWx1YXRlVG8oJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJz dGltdWx1cyIpLm9mZnNldEhlaWdodCcsIGV4cGVjdGVkSGVpZ2h0KTsKKzwvc2NyaXB0PiAgICAK KzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorCg==