76221 2012-01-12 15:46:13 -0800 NRWT should categorize options in --help 2012-02-10 10:51:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 37836 1 thorton webkit-unassigned abarth dpranke eric ojan webkit.review.bot oldest_to_newest 535235 0 thorton 2012-01-12 15:46:13 -0800 I keep getting lost in the wall of text that is new-run-webkit-tests --help. optparse has option groups, and our options are already grouped into reasonable groups! I have a patch. 535239 1 122327 thorton 2012-01-12 15:48:40 -0800 Created attachment 122327 patch 535242 2 webkit.review.bot 2012-01-12 15:52:31 -0800 Attachment 122327 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:157: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 554181 3 eric 2012-02-10 10:32:38 -0800 Ha! See bug 37836. 554184 4 eric 2012-02-10 10:33:57 -0800 My (ancient) fix was more about cleaning up the code than the display. I agree we should clean up the display. 554186 5 eric 2012-02-10 10:34:26 -0800 We also can remove/hide many of these options. 554196 6 122327 webkit.review.bot 2012-02-10 10:41:27 -0800 Comment on attachment 122327 patch Rejecting attachment 122327 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 198 (offset 44 lines). Hunk #2 FAILED at 175. Hunk #3 succeeded at 269 (offset 43 lines). Hunk #4 succeeded at 286 (offset 43 lines). Hunk #5 FAILED at 307. Hunk #6 FAILED at 381. Hunk #7 succeeded at 454 (offset 51 lines). 3 out of 7 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11480744 554197 7 thorton 2012-02-10 10:42:27 -0800 (In reply to comment #6) > (From update of attachment 122327 [details]) > Rejecting attachment 122327 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > 198 (offset 44 lines). > Hunk #2 FAILED at 175. > Hunk #3 succeeded at 269 (offset 43 lines). > Hunk #4 succeeded at 286 (offset 43 lines). > Hunk #5 FAILED at 307. > Hunk #6 FAILED at 381. > Hunk #7 succeeded at 454 (offset 51 lines). > 3 out of 7 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output: http://queues.webkit.org/results/11480744 I didn't really expect that to still apply after a month; I'll commit it manually. 554204 8 thorton 2012-02-10 10:51:16 -0800 Landed in http://trac.webkit.org/changeset/107415 122327 2012-01-12 15:48:40 -0800 2012-02-10 10:41:27 -0800 patch nrwt.patch text/plain 6458 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMmNh MDM0Li5lYTRmZDZlYyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTEyICBUaW0gSG9ydG9uICA8dGltb3Ro eV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE5SV1Qgc2hvdWxkIGNhdGVnb3JpemUgb3B0 aW9ucyBpbiAtLWhlbHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc2MjIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBVc2Ugb3B0cGFyc2UncyBPcHRpb25Hcm91cCBtZWNoYW5pc20gdG8gbG9n aWNhbGx5IGdyb3VwIE5SV1QncyBvcHRpb25zLAorICAgICAgICBwcm92aWRpbmcgYSBiZXR0ZXIg ZXhwZXJpZW5jZSB3aGVuIHNjYW5uaW5nIGFsbCB0aGUgb3B0aW9ucy4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAg IChwYXJzZV9hcmdzKToKKwogMjAxMi0wMS0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBOZWVkIGEgc2NyaXB0IHRvIHJ1biB0ZXN0cyBpbiBQZXJmb3JtYW5j ZVRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCA5YjQ4NTU3Li5hNjlmODU4IDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMu cHkKQEAgLTE1NCwxMSArMTU0LDEzIEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAgICAg IiIiUHJvdmlkZXMgYSBkZWZhdWx0IHNldCBvZiBjb21tYW5kIGxpbmUgYXJncy4KIAogICAgIFJl dHVybnMgYSB0dXBsZSBvZiBvcHRpb25zLCBhcmdzIGZyb20gb3B0cGFyc2UiIiIKKyAgICAKKyAg ICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlvbnMgPSBbXQogCiAgICAgIyBGSVhNRTogQWxsIG9mIHRo ZXNlIG9wdGlvbnMgc2hvdWxkIGJlIHN0b3JlZCBjbG9zZXIgdG8gdGhlIGNvZGUgd2hpY2gKICAg ICAjIEZJWE1FOiBhY3R1YWxseSB1c2VzIHRoZW0uIGNvbmZpZ3VyYXRpb25fb3B0aW9ucyBzaG91 bGQgbW92ZQogICAgICMgRklYTUU6IHRvIFdlYktpdFBvcnQgYW5kIGJlIHNoYXJlZCBhY3Jvc3Mg YWxsIHNjcmlwdHMuCi0gICAgY29uZmlndXJhdGlvbl9vcHRpb25zID0gWworICAgIG9wdGlvbl9n cm91cF9kZWZpbml0aW9ucy5hcHBlbmQoKCJDb25maWd1cmF0aW9uIE9wdGlvbnMiLCBbCiAgICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItdCIsICItLXRhcmdldCIsIGRlc3Q9ImNvbmZpZ3Vy YXRpb24iLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSIoREVQUkVDQVRFRCki KSwKICAgICAgICAgIyBGSVhNRTogLS1oZWxwIHNob3VsZCBkaXNwbGF5IHdoaWNoIGNvbmZpZ3Vy YXRpb24gaXMgZGVmYXVsdC4KQEAgLTE3MywxMiArMTc1LDEyIEBAIGRlZiBwYXJzZV9hcmdzKGFy Z3M9Tm9uZSk6CiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLXF0JywgYWN0aW9uPSdz dG9yZV9jb25zdCcsIGNvbnN0PSdxdCcsIGRlc3Q9InBsYXRmb3JtIiwgaGVscD0nQWxpYXMgZm9y IC0tcGxhdGZvcm09cXQnKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oJy0tZ3RrJywg YWN0aW9uPSdzdG9yZV9jb25zdCcsIGNvbnN0PSdndGsnLCBkZXN0PSJwbGF0Zm9ybSIsIGhlbHA9 J0FsaWFzIGZvciAtLXBsYXRmb3JtPWd0aycpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlv bignLS1lZmwnLCBhY3Rpb249J3N0b3JlX2NvbnN0JywgY29uc3Q9J2VmbCcsIGRlc3Q9InBsYXRm b3JtIiwgaGVscD0nQWxpYXMgZm9yIC0tcGxhdGZvcm09ZWZsJyksCi0gICAgXQorICAgIF0pKQog Ci0gICAgcHJpbnRfb3B0aW9ucyA9IHByaW50aW5nLnByaW50X29wdGlvbnMoKQorICAgIG9wdGlv bl9ncm91cF9kZWZpbml0aW9ucy5hcHBlbmQoKCJQcmludGluZyBPcHRpb25zIiwgcHJpbnRpbmcu cHJpbnRfb3B0aW9ucygpKSkKIAogICAgICMgRklYTUU6IFRoZXNlIG9wdGlvbnMgc2hvdWxkIG1v dmUgb250byB0aGUgQ2hyb21pdW1Qb3J0LgotICAgIGNocm9taXVtX29wdGlvbnMgPSBbCisgICAg b3B0aW9uX2dyb3VwX2RlZmluaXRpb25zLmFwcGVuZCgoIkNocm9taXVtLXNwZWNpZmljIE9wdGlv bnMiLCBbCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWNocm9taXVtIiwgYWN0aW9u PSJzdG9yZV90cnVlIiwgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgIGhlbHA9InVzZSB0aGUg Q2hyb21pdW0gcG9ydCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1zdGFydHVw LWRpYWxvZyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsCkBAIC0yMjQsOSArMjI2LDkgQEAgZGVmIHBh cnNlX2FyZ3MoYXJncz1Ob25lKToKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tcGVy LXRpbGUtcGFpbnRpbmciLAogICAgICAgICAgICAgYWN0aW9uPSJzdG9yZV90cnVlIiwKICAgICAg ICAgICAgIGhlbHA9IlVzZSBwZXItdGlsZSBwYWludGluZyBvZiBjb21wb3NpdGVkIHBhZ2VzIiks Ci0gICAgXQorICAgIF0pKQogCi0gICAgd2Via2l0X29wdGlvbnMgPSBbCisgICAgb3B0aW9uX2dy b3VwX2RlZmluaXRpb25zLmFwcGVuZCgoIldlYktpdCBPcHRpb25zIiwgWwogICAgICAgICBvcHRw YXJzZS5tYWtlX29wdGlvbigiLS1nYy1iZXR3ZWVuLXRlc3RzIiwgYWN0aW9uPSJzdG9yZV90cnVl IiwgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgIGhlbHA9IkZvcmNlIGdhcmJhZ2UgY29sbGVj dGlvbiBiZXR3ZWVuIGVhY2ggdGVzdCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigi LS1jb21wbGV4LXRleHQiLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZWZhdWx0PUZhbHNlLApAQCAt MjQxLDE1ICsyNDMsMTUgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncz1Ob25lKToKICAgICAgICAgICAg IGhlbHA9IlVzZSBXZWJLaXRUZXN0UnVubmVyIHJhdGhlciB0aGFuIER1bXBSZW5kZXJUcmVlLiIp LAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1yb290IiwgYWN0aW9uPSJzdG9yZSIs CiAgICAgICAgICAgICBoZWxwPSJQYXRoIHRvIGEgcHJlLWJ1aWx0IHJvb3Qgb2YgV2ViS2l0IChm b3IgcnVubmluZyB0ZXN0cyB1c2luZyBhIG5pZ2h0bHkgYnVpbGQgb2YgV2ViS2l0KSIpLAotICAg IF0KKyAgICBdKSkKIAotICAgIG9sZF9ydW5fd2Via2l0X3Rlc3RzX2NvbXBhdCA9IFsKKyAgICBv cHRpb25fZ3JvdXBfZGVmaW5pdGlvbnMuYXBwZW5kKCgiT1JXVCBDb21wYXRpYmlsaXR5IE9wdGlv bnMiLCBbCiAgICAgICAgICMgRklYTUU6IFJlbW92ZSB0aGlzIG9wdGlvbiBvbmNlIHRoZSBib3Rz IGRvbid0IHJlZmVyIHRvIGl0LgogICAgICAgICAjIHJlc3VsdHMuaHRtbCBpcyBzbWFydCBlbm91 Z2ggdG8gZmlndXJlIHRoaXMgb3V0IGl0c2VsZi4KICAgICAgICAgX2NvbXBhdF9zaGltX29wdGlv bigiLS11c2UtcmVtb3RlLWxpbmtzLXRvLXRlc3RzIiksCi0gICAgXQorICAgIF0pKQogCi0gICAg cmVzdWx0c19vcHRpb25zID0gWworICAgIG9wdGlvbl9ncm91cF9kZWZpbml0aW9ucy5hcHBlbmQo KCJSZXN1bHRzIE9wdGlvbnMiLCBbCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItcCIs ICItLXBpeGVsLXRlc3RzIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAgIGRlc3Q9 InBpeGVsX3Rlc3RzIiwgaGVscD0iRW5hYmxlIHBpeGVsLXRvLXBpeGVsIFBORyBjb21wYXJpc29u cyIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1uby1waXhlbC10ZXN0cyIsIGFj dGlvbj0ic3RvcmVfZmFsc2UiLApAQCAtMzA1LDkgKzMwNyw5IEBAIGRlZiBwYXJzZV9hcmdzKGFy Z3M9Tm9uZSk6CiAgICAgICAgICAgICBkZWZhdWx0PVRydWUsIGhlbHA9IlJ1biBIVFRQIGFuZCBX ZWJTb2NrZXQgdGVzdHMgKGRlZmF1bHQpIiksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9u KCItLW5vLWh0dHAiLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwgZGVzdD0iaHR0cCIsCiAgICAgICAg ICAgICBoZWxwPSJEb24ndCBydW4gSFRUUCBhbmQgV2ViU29ja2V0IHRlc3RzIiksCi0gICAgXQor ICAgIF0pKQogCi0gICAgdGVzdF9vcHRpb25zID0gWworICAgIG9wdGlvbl9ncm91cF9kZWZpbml0 aW9ucy5hcHBlbmQoKCJUZXN0aW5nIE9wdGlvbnMiLCBbCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vf b3B0aW9uKCItLWJ1aWxkIiwgZGVzdD0iYnVpbGQiLAogICAgICAgICAgICAgYWN0aW9uPSJzdG9y ZV90cnVlIiwgZGVmYXVsdD1UcnVlLAogICAgICAgICAgICAgaGVscD0iQ2hlY2sgdG8gZW5zdXJl IHRoZSBEdW1wUmVuZGVyVHJlZSBidWlsZCBpcyB1cC10by1kYXRlICIKQEAgLTM3OSwxNiArMzgx LDE2IEBAIGRlZiBwYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CiAgICAgICAgIG9wdHBhcnNlLm1ha2Vf b3B0aW9uKCItLW5vLXJldHJ5LWZhaWx1cmVzIiwgYWN0aW9uPSJzdG9yZV9mYWxzZSIsCiAgICAg ICAgICAgICBkZXN0PSJyZXRyeV9mYWlsdXJlcyIsCiAgICAgICAgICAgICBoZWxwPSJEb24ndCBy ZS10cnkgYW55IHRlc3RzIHRoYXQgcHJvZHVjZSB1bmV4cGVjdGVkIHJlc3VsdHMuIiksCi0gICAg XQorICAgIF0pKQogCi0gICAgbWlzY19vcHRpb25zID0gWworICAgIG9wdGlvbl9ncm91cF9kZWZp bml0aW9ucy5hcHBlbmQoKCJNaXNjZWxsYW5lb3VzIE9wdGlvbnMiLCBbCiAgICAgICAgIG9wdHBh cnNlLm1ha2Vfb3B0aW9uKCItLWxpbnQtdGVzdC1maWxlcyIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIs CiAgICAgICAgIGRlZmF1bHQ9RmFsc2UsIGhlbHA9KCJNYWtlcyBzdXJlIHRoZSB0ZXN0IGZpbGVz IHBhcnNlIGZvciBhbGwgIgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjb25maWd1cmF0 aW9ucy4gRG9lcyBub3QgcnVuIGFueSB0ZXN0cy4iKSksCi0gICAgXQorICAgIF0pKQogCiAgICAg IyBGSVhNRTogTW92ZSB0aGVzZSBpbnRvIGpzb25fcmVzdWx0c19nZW5lcmF0b3IucHkKLSAgICBy ZXN1bHRzX2pzb25fb3B0aW9ucyA9IFsKKyAgICBvcHRpb25fZ3JvdXBfZGVmaW5pdGlvbnMuYXBw ZW5kKCgiUmVzdWx0IEpTT04gT3B0aW9ucyIsIFsKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRp b24oIi0tbWFzdGVyLW5hbWUiLCBoZWxwPSJUaGUgbmFtZSBvZiB0aGUgYnVpbGRib3QgbWFzdGVy LiIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1idWlsZGVyLW5hbWUiLCBkZWZh dWx0PSJEVU1NWV9CVUlMREVSX05BTUUiLAogICAgICAgICAgICAgaGVscD0oIlRoZSBuYW1lIG9m IHRoZSBidWlsZGVyIHNob3duIG9uIHRoZSB3YXRlcmZhbGwgcnVubmluZyAiCkBAIC00MDEsMTIg KzQwMywxNCBAQCBkZWYgcGFyc2VfYXJncyhhcmdzPU5vbmUpOgogICAgICAgICBvcHRwYXJzZS5t YWtlX29wdGlvbigiLS10ZXN0LXJlc3VsdHMtc2VydmVyIiwgZGVmYXVsdD0iIiwKICAgICAgICAg ICAgIGhlbHA9KCJJZiBzcGVjaWZpZWQsIHVwbG9hZCByZXN1bHRzIGpzb24gZmlsZXMgdG8gdGhp cyBhcHBlbmdpbmUgIgogICAgICAgICAgICAgICAgICAgInNlcnZlci4iKSksCi0gICAgXQorICAg IF0pKQogCi0gICAgb3B0aW9uX2xpc3QgPSAoY29uZmlndXJhdGlvbl9vcHRpb25zICsgcHJpbnRf b3B0aW9ucyArCi0gICAgICAgICAgICAgICAgICAgY2hyb21pdW1fb3B0aW9ucyArIHdlYmtpdF9v cHRpb25zICsgcmVzdWx0c19vcHRpb25zICsgdGVzdF9vcHRpb25zICsKLSAgICAgICAgICAgICAg ICAgICBtaXNjX29wdGlvbnMgKyByZXN1bHRzX2pzb25fb3B0aW9ucyArIG9sZF9ydW5fd2Via2l0 X3Rlc3RzX2NvbXBhdCkKLSAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2Vy KG9wdGlvbl9saXN0PW9wdGlvbl9saXN0KQorICAgIG9wdGlvbl9wYXJzZXIgPSBvcHRwYXJzZS5P cHRpb25QYXJzZXIoKQorCisgICAgZm9yIGdyb3VwX25hbWUsIGdyb3VwX29wdGlvbnMgaW4gb3B0 aW9uX2dyb3VwX2RlZmluaXRpb25zOgorICAgICAgICBvcHRpb25fZ3JvdXAgPSBvcHRwYXJzZS5P cHRpb25Hcm91cChvcHRpb25fcGFyc2VyLCBncm91cF9uYW1lKQorICAgICAgICBvcHRpb25fZ3Jv dXAuYWRkX29wdGlvbnMoZ3JvdXBfb3B0aW9ucykKKyAgICAgICAgb3B0aW9uX3BhcnNlci5hZGRf b3B0aW9uX2dyb3VwKG9wdGlvbl9ncm91cCkKIAogICAgIHJldHVybiBvcHRpb25fcGFyc2VyLnBh cnNlX2FyZ3MoYXJncykKIAo=