76213 2012-01-12 14:17:34 -0800 Web Inspector: Disconnecting the front-end does not disable profiling. 2012-01-13 09:43:35 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 kpiascik webkit-unassigned apavlov bweinstein joepeck keishi loislo oliver pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 535154 0 kpiascik 2012-01-12 14:17:34 -0800 It is possible to disable developer extras without disabling profiling. This leads to an assertion failure in JSDOMWindowBase.cpp. ASSERT(enabled || !supportsProfiling(thisObject)); from IRC: [17:04:06] <olliej> kpiascik: technically the assertion isn't harmful, but it wil mean poor performance and poor memory usage We should disable profiling when the front-end is detached. 535629 1 122420 kpiascik 2012-01-13 06:17:26 -0800 Created attachment 122420 patch 535649 2 122420 pfeldman 2012-01-13 06:54:57 -0800 Comment on attachment 122420 patch View in context: https://bugs.webkit.org/attachment.cgi?id=122420&action=review > Source/WebCore/inspector/InspectorController.cpp:236 > + disableProfiler(); You should call disable() from within InspectorProfilerAgent::clearFrontend() instead. 535660 3 122427 kpiascik 2012-01-13 07:11:37 -0800 Created attachment 122427 updated patch 535737 4 122427 webkit.review.bot 2012-01-13 09:43:30 -0800 Comment on attachment 122427 updated patch Clearing flags on attachment: 122427 Committed r104945: <http://trac.webkit.org/changeset/104945> 535738 5 webkit.review.bot 2012-01-13 09:43:35 -0800 All reviewed patches have been landed. Closing bug. 122420 2012-01-13 06:17:26 -0800 2012-01-13 07:11:37 -0800 patch 0001-2012-01-12-Konrad-Piascik-kpiascik-rim.com.patch text/plain 1915 kpiascik RnJvbSAwM2Y0NzI4NmY3YmM1OWQ3MWYxY2M0NWE4YWI3MTc4ZDJlMGMyZmU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25yYWQgUGlhc2NpayA8a3BpYXNjaWtAcmltLmNvbT4KRGF0 ZTogVGh1LCAxMiBKYW4gMjAxMiAxODoxNjoxNyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTIt MDEtMTIgIEtvbnJhZCBQaWFzY2lrICA8a3BpYXNjaWtAcmltLmNvbT4KCiAgICAgICAgV2ViIElu c3BlY3RvcjogRGlzY29ubmVjdGluZyB0aGUgZnJvbnQtZW5kIGRvZXMgbm90IGRpc2FibGUgcHJv ZmlsaW5nLgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NjIxMwoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgTm90IHRl c3RhYmxlLgoKICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzY29ubmVjdEZyb250ZW5kKToK LS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDEyICsrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuY3BwIHwgICAgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDAg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNmZWFkYWUuLjUwYTFlZGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMi0wMS0xMyAgS29ucmFkIFBpYXNjaWsgIDxrcGlhc2Npa0By aW0uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IERpc2Nvbm5lY3RpbmcgdGhlIGZyb250 LWVuZCBkb2VzIG5vdCBkaXNhYmxlIHByb2ZpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm90IHRlc3RhYmxlLgorCisgICAgICAgICogaW5zcGVj dG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9y Q29udHJvbGxlcjo6ZGlzY29ubmVjdEZyb250ZW5kKToKKwogMjAxMi0wMS0xMiAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgU2Nyb2xsRWxhc3Rp Y2l0eUNvbnRyb2xsZXIgbWVtYmVycyBwcml2YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNzVkNmI0OS4uMDQ5YzU2NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcApA QCAtMjMzLDYgKzIzMyw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzY29ubmVjdEZy b250ZW5kKCkKIAogICAgIG1faW5zcGVjdG9yRnJvbnRlbmQuY2xlYXIoKTsKIAorICAgIGRpc2Fi bGVQcm9maWxlcigpOwogICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZnJvbnRlbmREZWxl dGVkKCk7CiAgICAgaWYgKCFJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246Omhhc0Zyb250ZW5kcygp KQogICAgICAgICBTY3JpcHRDb250cm9sbGVyOjpzZXRDYXB0dXJlQ2FsbFN0YWNrRm9yVW5jYXVn aHRFeGNlcHRpb25zKGZhbHNlKTsKLS0gCjEuNy43LjQKCg== 122427 2012-01-13 07:11:37 -0800 2012-01-13 09:43:30 -0800 updated patch 0001-Web-Inspector-Disconnecting-the-front-end-does-not-d.patch text/plain 1725 kpiascik RnJvbSA5ZmQ0MmE0Nzk5ZWJiMThlMDJmZDE1MDQ1NGFhZWMyNWRiZGFiNDljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25yYWQgUGlhc2NpayA8a3BpYXNjaWtAcmltLmNvbT4KRGF0 ZTogRnJpLCAxMyBKYW4gMjAxMiAxMDowOTo1OCAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIFdlYiBJ bnNwZWN0b3I6IERpc2Nvbm5lY3RpbmcgdGhlIGZyb250LWVuZCBkb2VzIG5vdCBkaXNhYmxlCiBw cm9maWxpbmcuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjIxMwoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpOb3QgdGVzdGFibGUuCgoqIGluc3BlY3Rvci9J bnNwZWN0b3JQcm9maWxlckFnZW50LmNwcDoKKFdlYkNvcmU6Okluc3BlY3RvclByb2ZpbGVyQWdl bnQ6OmNsZWFyRnJvbnRlbmQpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcCAgIHwgICAgMiArKwogMiBmaWxlcyBjaGFu Z2VkLCAxNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjZmVh ZGFlLi41NzMwNzVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDEtMTMgIEtv bnJhZCBQaWFzY2lrICA8a3BpYXNjaWtAcmltLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBEaXNjb25uZWN0aW5nIHRoZSBmcm9udC1lbmQgZG9lcyBub3QgZGlzYWJsZSBwcm9maWxpbmcu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjIxMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdCB0ZXN0 YWJsZS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OmNsZWFyRnJvbnRlbmQp OgorCiAyMDEyLTAxLTEyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgTWFrZSBTY3JvbGxFbGFzdGljaXR5Q29udHJvbGxlciBtZW1iZXJzIHByaXZhdGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFn ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQcm9maWxlckFnZW50 LmNwcAppbmRleCA5M2Q1MjQyLi5mZGQ1NmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwCkBAIC0yNzksNiArMjc5LDggQEAg dm9pZCBJbnNwZWN0b3JQcm9maWxlckFnZW50OjpjbGVhckZyb250ZW5kKCkKIHsKICAgICBtX2Zy b250ZW5kID0gMDsKICAgICBzdG9wKCk7CisgICAgRXJyb3JTdHJpbmcgZXJyb3I7CisgICAgZGlz YWJsZSgmZXJyb3IpOwogfQogCiB2b2lkIEluc3BlY3RvclByb2ZpbGVyQWdlbnQ6OnJlc3RvcmUo KQotLSAKMS43LjcuNAoK