76190 2012-01-12 10:10:10 -0800 [Qt] [PATCH] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box. 2012-06-02 00:13:05 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 johannesobermayr webkit-unassigned ahf hausmann ossy webkit.review.bot oldest_to_newest 534935 0 122267 johannesobermayr 2012-01-12 10:10:10 -0800 Created attachment 122267 Patch Please use 'git am 0001-Use-Ok-and-Cancel-buttons-in-JavaScript-confirm-box.patch' to keep author information ... Maybe you should create a qtwebkit-patches mailing list for a quick and comfortable sending patches via 'git send-email' ... See: http://www.javascripter.net/faq/confirm.htm Fixes: https://bugs.kde.org/show_bug.cgi?id=287629 535088 1 ahf 2012-01-12 13:00:41 -0800 (In reply to comment #0) > Please use 'git am 0001-Use-Ok-and-Cancel-buttons-in-JavaScript-confirm-box.patch' to keep author information ... The WebKit project doesn't work like that since the official repository is a subversion repository even though most of the QtWebKit developers uses the Git trees since we can actively work on QtWebKit without ever having to "git push" or "svn commit" because we have tons of automated review and commit tools :-) Please have a look at http://trac.webkit.org/wiki/QtWebKitContrib and http://www.webkit.org/coding/contributing.html and upload a version of your patch that contains a proper ChangeLog entry :-) > Maybe you should create a qtwebkit-patches mailing list for a quick and comfortable sending patches via 'git send-email' ... Wont work since all patches must be reviewed of an approved WebKit reviewer and the reviewer tool is built into our Bugzilla setup :-) 535092 2 johannesobermayr 2012-01-12 13:05:46 -0800 Sorry for wasting your time ... 535094 3 ahf 2012-01-12 13:07:19 -0800 (In reply to comment #2) > Sorry for wasting your time ... You are not wasting our time. The patch looks clean enough for me, but I am not a reviewer. If you resubmit it with a proper ChangeLog entry, I will CC some reviewers who can review your changes :-) 535099 4 johannesobermayr 2012-01-12 13:14:34 -0800 With such stupid rules I regret of spending a few hours to detect the issue :-( Fix it yourself ... 535282 5 122267 noam 2012-01-12 16:24:26 -0800 Comment on attachment 122267 Patch Patch does not include changelog. 535513 6 hausmann 2012-01-13 01:19:05 -0800 (In reply to comment #4) > With such stupid rules I regret of spending a few hours to detect the issue :-( I'm sorry Johannes that you feel that way, but this is just like in KDE or any other open source project: There are rules about contributing source code. In KDE you have to understand SVN, write a descriptive commit message and adhere to BUG:12344 etc. standards for the bugzilla integration. Then you need to get yourself access to the KDE SVN repository or find a kind soul to review & commit the patch for you. In the Git project you need to use git send-email to send your patch to the git list, CC Junio and make sure your commit has the right Signed-off-by. In Qt you have to upload your patch to Gerrit and it needs to have a unique Change-Id, generated by a git commit hook. And lastly in WebKit you upload your patch to Bugzilla together with a ChangeLog entry. The documentation at http://www.webkit.org/coding/contributing.html explains the necessary steps and the tools available make it easy to "play by the rules". But as you can see, every project has such rules. If you do not want to play by those rules but still get your change contributed, then you need to approach a fellow developer with kind words asking him to do the "paperwork" on your behalf. In WebKit's case however you still need to do the initial patch upload to accept the contribution licensing agreement, but it is possible to get help for getting your patch reviewed and landed manually. I'm re-opening this bug because the issue you discovered still appears to be valid, regardless of your feelings towards the patch contribution process of WebKit. 635246 7 johannesobermayr 2012-05-28 08:26:30 -0700 Closing because nobody is interested in pushing it within 5 months. See a good workflow: 1. http://lists.x.org/archives/xorg-devel/2012-May/031381.html 2. http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=7fdd8bd6d2ba7bf113d4109e6bb6f750f909565f 3. http://lists.x.org/archives/xorg-devel/2012-May/031385.html 637240 8 144821 zarvai 2012-05-30 08:10:12 -0700 Created attachment 144821 new patch Patch with changelog. 637260 9 ossy 2012-05-30 08:27:50 -0700 Reopen to let EWS bots test the patch 639981 10 144821 webkit.review.bot 2012-06-02 00:13:00 -0700 Comment on attachment 144821 new patch Clearing flags on attachment: 144821 Committed r119315: <http://trac.webkit.org/changeset/119315> 639982 11 webkit.review.bot 2012-06-02 00:13:05 -0700 All reviewed patches have been landed. Closing bug. 122267 2012-01-12 10:10:10 -0800 2012-01-12 16:24:26 -0800 Patch 0001-Use-Ok-and-Cancel-buttons-in-JavaScript-confirm-box.patch text/plain 1857 johannesobermayr RnJvbSBmYmY0MjllNGQ4ZjFmNmIyZjczYzMwYjM2MjlkNjc5NmIwMThkYzcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2hhbm5lcyBPYmVybWF5ciA8am9oYW5uZXNvYmVybWF5ckBn bXguZGU+CkRhdGU6IFR1ZSwgMTAgSmFuIDIwMTIgMjA6MjE6MzEgKzAxMDAKU3ViamVjdDogW1BB VENIXSBVc2UgJ09rJyBhbmQgJ0NhbmNlbCcgYnV0dG9ucyBpbiBKYXZhU2NyaXB0IGNvbmZpcm0g Ym94LgoKU2VlOiBodHRwOi8vd3d3LmphdmFzY3JpcHRlci5uZXQvZmFxL2NvbmZpcm0uaHRtCgpG aXhlczogaHR0cHM6Ly9idWdzLmtkZS5vcmcvc2hvd19idWcuY2dpP2lkPTI4NzYyOQotLS0KIFNv dXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcCB8ICAgIDQgKystLQogMSBmaWxlcyBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwCmluZGV4IDhmMGYxNTMuLmFjZDJiZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv cXQvQXBpL3F3ZWJwYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKQEAgLTIxMTksNyArMjExOSw3IEBAIHZvaWQgUVdlYlBhZ2U6OmphdmFTY3JpcHRBbGVydChR V2ViRnJhbWUgKmZyYW1lLCBjb25zdCBRU3RyaW5nJiBtc2cpCiAgICAgVGhpcyBmdW5jdGlvbiBp cyBjYWxsZWQgd2hlbmV2ZXIgYSBKYXZhU2NyaXB0IHByb2dyYW0gcnVubmluZyBpbnNpZGUgXGEg ZnJhbWUgY2FsbHMgdGhlIGNvbmZpcm0oKSBmdW5jdGlvbgogICAgIHdpdGggdGhlIG1lc3NhZ2Us IFxhIG1zZy4gUmV0dXJucyB0cnVlIGlmIHRoZSB1c2VyIGNvbmZpcm1zIHRoZSBtZXNzYWdlOyBv dGhlcndpc2UgcmV0dXJucyBmYWxzZS4KIAotICAgIFRoZSBkZWZhdWx0IGltcGxlbWVudGF0aW9u IGV4ZWN1dGVzIHRoZSBxdWVyeSB1c2luZyBRTWVzc2FnZUJveDo6aW5mb3JtYXRpb24gd2l0aCBR TWVzc2FnZUJveDo6WWVzIGFuZCBRTWVzc2FnZUJveDo6Tm8gYnV0dG9ucy4KKyAgICBUaGUgZGVm YXVsdCBpbXBsZW1lbnRhdGlvbiBleGVjdXRlcyB0aGUgcXVlcnkgdXNpbmcgUU1lc3NhZ2VCb3g6 OmluZm9ybWF0aW9uIHdpdGggUU1lc3NhZ2VCb3g6Ok9rIGFuZCBRTWVzc2FnZUJveDo6Q2FuY2Vs IGJ1dHRvbnMuCiAqLwogYm9vbCBRV2ViUGFnZTo6amF2YVNjcmlwdENvbmZpcm0oUVdlYkZyYW1l ICpmcmFtZSwgY29uc3QgUVN0cmluZyYgbXNnKQogewpAQCAtMjEyOCw3ICsyMTI4LDcgQEAgYm9v bCBRV2ViUGFnZTo6amF2YVNjcmlwdENvbmZpcm0oUVdlYkZyYW1lICpmcmFtZSwgY29uc3QgUVN0 cmluZyYgbXNnKQogICAgIHJldHVybiB0cnVlOwogI2Vsc2UKICAgICBRV2lkZ2V0KiBwYXJlbnQg PSAoZC0+Y2xpZW50KSA/IGQtPmNsaWVudC0+b3duZXJXaWRnZXQoKSA6IDA7Ci0gICAgcmV0dXJu IFFNZXNzYWdlQm94OjpZZXMgPT0gUU1lc3NhZ2VCb3g6OmluZm9ybWF0aW9uKHBhcmVudCwgdHIo IkphdmFTY3JpcHQgQ29uZmlybSAtICUxIikuYXJnKG1haW5GcmFtZSgpLT51cmwoKS5ob3N0KCkp LCBRdDo6ZXNjYXBlKG1zZyksIFFNZXNzYWdlQm94OjpZZXMsIFFNZXNzYWdlQm94OjpObyk7Cisg ICAgcmV0dXJuIFFNZXNzYWdlQm94OjpPayA9PSBRTWVzc2FnZUJveDo6aW5mb3JtYXRpb24ocGFy ZW50LCB0cigiSmF2YVNjcmlwdCBDb25maXJtIC0gJTEiKS5hcmcobWFpbkZyYW1lKCktPnVybCgp Lmhvc3QoKSksIFF0Ojplc2NhcGUobXNnKSwgUU1lc3NhZ2VCb3g6Ok9rLCBRTWVzc2FnZUJveDo6 Q2FuY2VsKTsKICNlbmRpZgogfQogCi0tIAoxLjcuNwoK 144821 2012-05-30 08:10:12 -0700 2012-06-02 00:13:00 -0700 new patch yesok.patch text/plain 2128 zarvai ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRleCBkOWIwMDc3Li5hZmJkYzNmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9xdC9BcGkvcXdlYnBhZ2UuY3BwCkBAIC0yMDk2LDcgKzIwOTYsNyBAQCB2b2lkIFFXZWJQYWdl OjpqYXZhU2NyaXB0QWxlcnQoUVdlYkZyYW1lICpmcmFtZSwgY29uc3QgUVN0cmluZyYgbXNnKQog ICAgIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIHdoZW5ldmVyIGEgSmF2YVNjcmlwdCBwcm9ncmFt IHJ1bm5pbmcgaW5zaWRlIFxhIGZyYW1lIGNhbGxzIHRoZSBjb25maXJtKCkgZnVuY3Rpb24KICAg ICB3aXRoIHRoZSBtZXNzYWdlLCBcYSBtc2cuIFJldHVybnMgdHJ1ZSBpZiB0aGUgdXNlciBjb25m aXJtcyB0aGUgbWVzc2FnZTsgb3RoZXJ3aXNlIHJldHVybnMgZmFsc2UuCiAKLSAgICBUaGUgZGVm YXVsdCBpbXBsZW1lbnRhdGlvbiBleGVjdXRlcyB0aGUgcXVlcnkgdXNpbmcgUU1lc3NhZ2VCb3g6 OmluZm9ybWF0aW9uIHdpdGggUU1lc3NhZ2VCb3g6OlllcyBhbmQgUU1lc3NhZ2VCb3g6Ok5vIGJ1 dHRvbnMuCisgICAgVGhlIGRlZmF1bHQgaW1wbGVtZW50YXRpb24gZXhlY3V0ZXMgdGhlIHF1ZXJ5 IHVzaW5nIFFNZXNzYWdlQm94OjppbmZvcm1hdGlvbiB3aXRoIFFNZXNzYWdlQm94OjpPayBhbmQg UU1lc3NhZ2VCb3g6OkNhbmNlbCBidXR0b25zLgogKi8KIGJvb2wgUVdlYlBhZ2U6OmphdmFTY3Jp cHRDb25maXJtKFFXZWJGcmFtZSAqZnJhbWUsIGNvbnN0IFFTdHJpbmcmIG1zZykKIHsKQEAgLTIx MDksOCArMjEwOSw4IEBAIGJvb2wgUVdlYlBhZ2U6OmphdmFTY3JpcHRDb25maXJtKFFXZWJGcmFt ZSAqZnJhbWUsIGNvbnN0IFFTdHJpbmcmIG1zZykKICAgICBib3guc2V0V2luZG93VGl0bGUodHIo IkphdmFTY3JpcHQgQ29uZmlybSAtICUxIikuYXJnKG1haW5GcmFtZSgpLT51cmwoKS5ob3N0KCkp KTsKICAgICBib3guc2V0VGV4dEZvcm1hdChRdDo6UGxhaW5UZXh0KTsKICAgICBib3guc2V0VGV4 dChtc2cpOwotICAgIGJveC5zZXRTdGFuZGFyZEJ1dHRvbnMoUU1lc3NhZ2VCb3g6OlllcyB8IFFN ZXNzYWdlQm94OjpObyk7Ci0gICAgcmV0dXJuIFFNZXNzYWdlQm94OjpZZXMgPT0gYm94LmV4ZWMo KTsKKyAgICBib3guc2V0U3RhbmRhcmRCdXR0b25zKFFNZXNzYWdlQm94OjpPayB8IFFNZXNzYWdl Qm94OjpDYW5jZWwpOworICAgIHJldHVybiBRTWVzc2FnZUJveDo6T2sgPT0gYm94LmV4ZWMoKTsK ICNlbmRpZgogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGU4Mjc0MGYuLjhhN2QwODcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMzAgIFpvbHRhbiBBcnZhaSAgPHphcnZh aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBVc2UgJ09rJyBhbmQgJ0NhbmNlbCcg YnV0dG9ucyBpbiBKYXZhU2NyaXB0IGNvbmZpcm0gYm94LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYxOTAKKyAgICAgICAgQmFzZWQgb24gSm9oYW5u ZXMgT2Jlcm1heXJzIChqb2hhbm5lc29iZXJtYXlyQGdteC5kZSkgcGF0Y2guCisgICAgICAgIFNl ZTogaHR0cDovL3d3dy5qYXZhc2NyaXB0ZXIubmV0L2ZhcS9jb25maXJtLmh0bQorICAgICAgICBG aXhlczogaHR0cHM6Ly9idWdzLmtkZS5vcmcvc2hvd19idWcuY2dpP2lkPTI4NzYyOQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL3F3ZWJwYWdl LmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjpqYXZhU2NyaXB0Q29uZmlybSk6CisKIDIwMTItMDUt MjkgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAg ICAgIFtRdF0gU3luYyB1cCBmYXZpY29uLWltcGxlbWVudGF0aW9uIHdpdGggV2ViVmlldyB1cmwg Y2hhbmdlcyBpbiByMTE4MTU4Cg==