76165 2012-01-12 03:59:40 -0800 [EFL] Add visible field into ewk_tiled_backing_store's data. 2012-01-16 05:26:54 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 hyuki.kim webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 534725 0 hyuki.kim 2012-01-12 03:59:40 -0800 Using of evas_object_visible_get() API can't gurantee the correctness of evas_object's visible status if it's called inside of evas_object's smart_show() method. From the EFL's evas_object_show() API's implementation, I could see the reason why. EAPI void evas_object_show(Evas_Object *obj) { MAGIC_CHECK(obj, Evas_Object, MAGIC_OBJ); return; MAGIC_CHECK_END(); if (obj->delete_me) return; if (evas_object_intercept_call_show(obj)) return; if (obj->smart.smart) { if (obj->smart.smart->smart_class->show) obj->smart.smart->smart_class->show(obj); // This calls object's smart_show() method. e.g) _ewk_tiled_backing_store_smart_show() } if (obj->cur.visible) { return; } obj->cur.visible = 1; // This will set the visibility of object and it is used by evas_object_visible_get() API. 534732 1 122210 hyuki.kim 2012-01-12 04:11:24 -0800 Created attachment 122210 Patch. 535465 2 122210 gyuyoung.kim 2012-01-12 23:23:55 -0800 Comment on attachment 122210 Patch. Looks OK. :-) 535533 3 122210 zimmermann 2012-01-13 02:04:27 -0800 Comment on attachment 122210 Patch. r=me. 535562 4 122210 webkit.review.bot 2012-01-13 03:25:22 -0800 Comment on attachment 122210 Patch. Clearing flags on attachment: 122210 Committed r104915: <http://trac.webkit.org/changeset/104915> 535563 5 webkit.review.bot 2012-01-13 03:25:27 -0800 All reviewed patches have been landed. Closing bug. 535667 6 122210 rakuco 2012-01-13 07:39:54 -0800 Comment on attachment 122210 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=122210&action=review > Source/WebKit/efl/ChangeLog:10 > + Using of evas_object_visible_get() API can't gurantee the correctness of > + evas_object's visible status if it's called inside of evas_object's > + smart_show() method. This sounds weird. What kind of problems were you having, and couldn't they be solved if you call the parent show/hide functions in your smart_{show,hide} _before_ the functions enabling/disabling rendering? 536306 7 hyuki.kim 2012-01-15 16:59:51 -0800 (In reply to comment #6) > (From update of attachment 122210 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122210&action=review > > > Source/WebKit/efl/ChangeLog:10 > > + Using of evas_object_visible_get() API can't gurantee the correctness of > > + evas_object's visible status if it's called inside of evas_object's > > + smart_show() method. > > This sounds weird. What kind of problems were you having, and couldn't they be solved if you call the parent show/hide functions in your smart_{show,hide} _before_ the functions enabling/disabling rendering? for example, If any API which is using evas_object_visible_getUI provide unexpected behavior if it would be called inside of smart_show api. I had already checked the case you suggested too, but it wasn't effective either. but, let me check it one more time. 536380 8 hyuki.kim 2012-01-15 23:27:58 -0800 (In reply to comment #6) > (From update of attachment 122210 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122210&action=review > > > Source/WebKit/efl/ChangeLog:10 > > + Using of evas_object_visible_get() API can't gurantee the correctness of > > + evas_object's visible status if it's called inside of evas_object's > > + smart_show() method. > > This sounds weird. What kind of problems were you having, and couldn't they be solved if you call the parent show/hide functions in your smart_{show,hide} _before_ the functions enabling/disabling rendering? Double check was done. No significant effect from change calling position of parent show/hide function. I have also checked the return value as follows. static void _ewk_tiled_backing_store_smart_show(Evas_Object* ewkBackingStore) { printf("visible = %d in \n",evas_object_visible_get(ewkBackingStore)); ewk_tiled_backing_store_enable_render(ewkBackingStore); _parent_sc.show(ewkBackingStore); printf("visible = %d out \n",evas_object_visible_get(ewkBackingStore)); } AFAIK, as parent's methods are just for smart clipped, it calls evas_object_smart_clipped_smart_show() or hide(). 536498 9 rakuco 2012-01-16 05:26:54 -0800 (In reply to comment #8) > I have also checked the return value as follows. > > static void _ewk_tiled_backing_store_smart_show(Evas_Object* ewkBackingStore) > { > printf("visible = %d in \n",evas_object_visible_get(ewkBackingStore)); > ewk_tiled_backing_store_enable_render(ewkBackingStore); > _parent_sc.show(ewkBackingStore); > printf("visible = %d out \n",evas_object_visible_get(ewkBackingStore)); > } Hmm, the problem is that this is called from evas_object_show() before it sets its own `cur.visible' to 1. If these functions which have been patched are indeed called from the smart_show function, the flag added by the patch is probably needed. Thanks for the details. 122210 2012-01-12 04:11:24 -0800 2012-01-13 07:39:54 -0800 Patch. 0112_active.patch text/plain 4111 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA5OWI2MTAyLi5iOTExMTVmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMDEtMTIgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIHZpc2libGUgZmllbGQgaW50byBld2tfdGls ZWRfYmFja2luZ19zdG9yZSdzIGRhdGEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NjE2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzaW5nIG9mIGV2YXNfb2JqZWN0X3Zpc2libGVfZ2V0KCkgQVBJIGNh bid0IGd1cmFudGVlIHRoZSBjb3JyZWN0bmVzcyBvZgorICAgICAgICBldmFzX29iamVjdCdzIHZp c2libGUgc3RhdHVzIGlmIGl0J3MgY2FsbGVkIGluc2lkZSBvZiBldmFzX29iamVjdCdzCisgICAg ICAgIHNtYXJ0X3Nob3coKSBtZXRob2QuCisgICAgICAgIFNvLCBhIHZpc2libGUgZmxhZyBmb3Ig dGhlIGV3a190aWxlZF9iYWNraW5nX3N0b3JlIGlzIGFkZGVkLgorICAgICAgICBJbiBhZGRpdGlv biwgYXMgdGlsZXMgYXJlIG5vdCB2aXNpYmxlLCBld2tfdGlsZWRfYmFja2luZ19zdG9yZSB3aWxs IHB1c2gKKyAgICAgICAgaXRzIG93biB0aWxlcyBpbnRvIHRoZSBjYWNoZSB3aGVuIGl0IGRpc2Fw ZWFyLgorCisgICAgICAgICogZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmNwcDoKKyAgICAg ICAgKF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV91cGRhdGVzX3Byb2Nlc3MpOgorICAgICAgICAo X2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1fcHJvY2Vzc19pZGxlcl9zdGFydCk6CisgICAg ICAgIChfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9maWxsKToKKyAgICAgICAgKF9ld2tf dGlsZWRfYmFja2luZ19zdG9yZV9zbWFydF9tZW1iZXJfYWRkKToKKyAgICAgICAgKF9ld2tfdGls ZWRfYmFja2luZ19zdG9yZV9zbWFydF9zaG93KToKKyAgICAgICAgKF9ld2tfdGlsZWRfYmFja2lu Z19zdG9yZV9zbWFydF9oaWRlKToKKwogMjAxMi0wMS0xMSAgSnVuZ0ppayBMZWUgIDxqdW5namlr LmxlZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBSZWZhY3RvciBzaW5nbGUgYmFja2lu ZyBzdG9yZSBzY3JvbGwgY29kZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9l d2tfdGlsZWRfYmFja2luZ19zdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3Rp bGVkX2JhY2tpbmdfc3RvcmUuY3BwCmluZGV4IDA5NDc2N2EuLmZmYzY3MWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmNwcApAQCAtNzMs NiArNzMsNyBAQCBzdHJ1Y3QgX0V3a19UaWxlZF9CYWNraW5nX1N0b3JlX0RhdGEgewogICAgICAg ICAgICAgICAgIEV2YXNfQ29vcmQgeCwgeTsKICAgICAgICAgICAgIH0gY3VyLCBvbGQsIGJhc2Us IHpvb21DZW50ZXI7CiAgICAgICAgIH0gb2Zmc2V0OworICAgICAgICBib29sIHZpc2libGUgOiAx OwogICAgIH0gdmlldzsKICAgICBFdmFzX0NvbG9yc3BhY2UgY29sb3JTcGFjZTsKICAgICBzdHJ1 Y3QgewpAQCAtMTMzLDcgKzEzNCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmVfdXBkYXRlc19wcm9jZXNzKEV3a19UaWxlZF9CYWNraW5nX1N0CiAgICAgICog aW4gdGhlIHF1ZXVlIGluIG9yZGVyIHRvIG5vdCBtaXNzIGFueSB1cGRhdGVzIGFmdGVyIHRoZSBy ZW5kZXIgaXMKICAgICAgKiByZXN1bWVkLgogICAgICAqLwotICAgIGlmIChwcml2LT5yZW5kZXIu c3VzcGVuZCB8fCAhZXZhc19vYmplY3RfdmlzaWJsZV9nZXQocHJpdi0+c2VsZikpCisgICAgaWYg KHByaXYtPnJlbmRlci5zdXNwZW5kIHx8ICFwcml2LT52aWV3LnZpc2libGUpCiAgICAgICAgIHJl dHVybjsKIAogICAgIGlmIChwcml2LT5wcm9jZXNzLnByZUNhbGxiYWNrKQpAQCAtMzgyLDcgKzM4 Myw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9w cm9jZXNzX2lkbGVyX3N0b3AoRXdrX1RpbGVkX0JhCiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBfZXdr X3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9wcm9jZXNzX2lkbGVyX3N0YXJ0KEV3a19UaWxlZF9C YWNraW5nX1N0b3JlX0RhdGEqIHByaXYpCiB7Ci0gICAgaWYgKHByaXYtPnJlbmRlci5pZGxlciB8 fCAhZXZhc19vYmplY3RfdmlzaWJsZV9nZXQocHJpdi0+c2VsZikpCisgICAgaWYgKHByaXYtPnJl bmRlci5pZGxlciB8fCAhcHJpdi0+dmlldy52aXNpYmxlKQogICAgICAgICByZXR1cm47CiAgICAg cHJpdi0+cmVuZGVyLmlkbGVyID0gZWNvcmVfaWRsZXJfYWRkKAogICAgICAgICBfZXdrX3RpbGVk X2JhY2tpbmdfc3RvcmVfaXRlbV9wcm9jZXNzX2lkbGVyX2NiLCBwcml2KTsKQEAgLTQxMyw3ICs0 MTQsNyBAQCBzdGF0aWMgRWluYV9Cb29sIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9lbmFibGVf cmVuZGVyKEV3a19UaWxlZF9CYWNraW5nX1N0b3JlXwogCiBzdGF0aWMgaW5saW5lIEVpbmFfQm9v bCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9maWxsKEV3a19UaWxlZF9CYWNraW5nX1N0 b3JlX0RhdGEqIHByaXYsIEV3a19UaWxlZF9CYWNraW5nX1N0b3JlX0l0ZW0qIGl0ZW0sIHVuc2ln bmVkIGxvbmcgY29sdW1uLCB1bnNpZ25lZCBsb25nIHJvdykKIHsKLSAgICBpZiAoIWV2YXNfb2Jq ZWN0X3Zpc2libGVfZ2V0KHByaXYtPnNlbGYpKQorICAgIGlmICghcHJpdi0+dmlldy52aXNpYmxl KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICB1bnNpZ25lZCBsb25nIGN1cnJlbnRDb2x1 bW4gPSBwcml2LT5tb2RlbC5iYXNlLmNvbHVtbiArIGNvbHVtbjsKQEAgLTY0NCw3ICs2NDUsNyBA QCBzdGF0aWMgdm9pZCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfc21hcnRfbWVtYmVyX2FkZChF dmFzX09iamVjdCogZXdrQmFja2luZ1N0bwogICAgIGlmICghcHJpdi0+Y29udGVudHNDbGlwcGVy KQogICAgICAgICByZXR1cm47CiAgICAgZXZhc19vYmplY3RfY2xpcF9zZXQobWVtYmVyLCBwcml2 LT5jb250ZW50c0NsaXBwZXIpOwotICAgIGlmIChldmFzX29iamVjdF92aXNpYmxlX2dldChld2tC YWNraW5nU3RvcmUpKQorICAgIGlmIChwcml2LT52aWV3LnZpc2libGUpCiAgICAgICAgIGV2YXNf b2JqZWN0X3Nob3cocHJpdi0+Y29udGVudHNDbGlwcGVyKTsKIH0KIApAQCAtODA1LDEzICs4MDYs MTggQEAgc3RhdGljIHZvaWQgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX3NtYXJ0X3Jlc2l6ZShF dmFzX09iamVjdCogZXdrQmFja2luZ1N0b3JlLAogCiBzdGF0aWMgdm9pZCBfZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmVfc21hcnRfc2hvdyhFdmFzX09iamVjdCogZXdrQmFja2luZ1N0b3JlKQogewor ICAgIFBSSVZfREFUQV9HRVRfT1JfUkVUVVJOKGV3a0JhY2tpbmdTdG9yZSwgcHJpdik7CisgICAg cHJpdi0+dmlldy52aXNpYmxlID0gdHJ1ZTsKICAgICBld2tfdGlsZWRfYmFja2luZ19zdG9yZV9l bmFibGVfcmVuZGVyKGV3a0JhY2tpbmdTdG9yZSk7CiAgICAgX3BhcmVudF9zYy5zaG93KGV3a0Jh Y2tpbmdTdG9yZSk7CiB9CiAKIHN0YXRpYyB2b2lkIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9z bWFydF9oaWRlKEV2YXNfT2JqZWN0KiBld2tCYWNraW5nU3RvcmUpCiB7CisgICAgUFJJVl9EQVRB X0dFVF9PUl9SRVRVUk4oZXdrQmFja2luZ1N0b3JlLCBwcml2KTsKKyAgICBwcml2LT52aWV3LnZp c2libGUgPSBmYWxzZTsKICAgICBld2tfdGlsZWRfYmFja2luZ19zdG9yZV9kaXNhYmxlX3JlbmRl cihld2tCYWNraW5nU3RvcmUpOworICAgIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV90aWxlX2Rp c3NvY2lhdGVfYWxsKHByaXYpOwogICAgIF9wYXJlbnRfc2MuaGlkZShld2tCYWNraW5nU3RvcmUp OwogfQogCg==