76154 2012-01-12 00:23:39 -0800 A Frame with frame flattening can be stuck in a state in which performPostLayoutTasks() is never executed 2012-01-12 16:19:39 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin bdakin ddkilzer eric.carlson hyatt kenneth koivisto max.hong.shen simon.fraser yael zalan oldest_to_newest 534615 0 benjamin 2012-01-12 00:23:39 -0800 For <rdar://problem/10363387>. With Frame Flattening, performPostLayoutTasks() is always executed asynchronously. If FrameView::unscheduleRelayout() is executed when a pending post layout task timer exists, performPostLayoutTasks() will never be executed for this frame. Here is the sequence of events 1) there is a layout, and since inSubframeLayoutWithFrameFlattening == true, m_hasPendingPostLayoutTasks becomes true and a post layout is scheduled 2) there is a FrameView::unscheduleRelayout(), which kill the timer, and leave m_hasPendingPostLayoutTasks == true so m_hasPendingPostLayoutTasks == true, and in the common case that would get processed in the next layout() but here we only execute the post layout on timer 3) all the next layouts skip the postLayout() tasks because m_hasPendingPostLayoutTasks == true 534628 1 122183 benjamin 2012-01-12 00:45:32 -0800 Created attachment 122183 Patch 534633 2 benjamin 2012-01-12 00:48:57 -0800 I have trouble making a test for this. I do not have yet a reliable way to trigger FrameView::unscheduleRelayout() after a layout() but before the timer. I would appreciate if you could already check if this looks correct. 534926 3 122183 simon.fraser 2012-01-12 09:59:31 -0800 Comment on attachment 122183 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122183&action=review I think Beth should look at this. > Source/WebCore/ChangeLog:14 > + This patch revert the handling of the postLayoutTasks to its state prior to r66552. Presumably without regressing the bug that r66552 fixed? Can you say more here about how you managed that? 535009 4 benjamin 2012-01-12 11:42:38 -0800 > > Source/WebCore/ChangeLog:14 > > + This patch revert the handling of the postLayoutTasks to its state prior to r66552. > > Presumably without regressing the bug that r66552 fixed? Can you say more here about how you managed that? This do not revert r66552, just revert a detail of the patch: the change from the timer to a bool to manage the state. 535016 5 benjamin 2012-01-12 11:48:29 -0800 Some more context: r66552 changed the postLayoutTasks from the timer to a bool, and stopped the timer on unschedudeRelayout. That change makes sense. But then, r77988 change the way the postLayoutTasks are performed, and that is when everything went to hell. 535086 6 122183 koivisto 2012-01-12 13:00:16 -0800 Comment on attachment 122183 Patch Looks good to me and reducing complexity here a bit is nice (assuming the earlier problematic cases are still handled somehow). 535159 7 122183 bdakin 2012-01-12 14:24:17 -0800 Comment on attachment 122183 Patch Well if Antti's on board, so am I ;-) Looks good. And since I desperately can't remember why I added m_hasPendingPostLayoutTasks, I can't really object to its removal. I still think you should test the original reproducibility steps of that bug that I was fixing when I added it, but r=me. 535275 8 benjamin 2012-01-12 16:19:39 -0800 Committed r104874: <http://trac.webkit.org/changeset/104874> 122183 2012-01-12 00:45:32 -0800 2012-01-12 14:24:17 -0800 Patch bug-76154-20120112004531.patch text/plain 6407 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzBhN2Q3ZDUyZThkMGFh YjVkYmYwYjhlMjI1NWIxYTJjMmU5NjQxYi4uNDk0N2VjM2FjZmRlYjQzNmVkNWQyZmY1OWZmZTU0 MDc3ZDQ3M2Y3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDEyLTAxLTEyICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIEEgRnJhbWUgd2l0 aCBmcmFtZSBmbGF0dGVuaW5nIGNhbiBiZSBzdHVjayBpbiBhIHN0YXRlIGluIHdoaWNoIHBlcmZv cm1Qb3N0TGF5b3V0VGFza3MoKSBpcyBuZXZlciBleGVjdXRlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYxNTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBhIGZyYW1lIHdpdGggaW5TdWJmcmFtZUxh eW91dFdpdGhGcmFtZUZsYXR0ZW5pbmcgPT0gdHJ1ZSwgaWYKKyAgICAgICAgLW1faGFzUGVuZGlu Z1Bvc3RMYXlvdXRUYXNrcyA9PSB0cnVlCisgICAgICAgIC1GcmFtZVZpZXc6OnVuc2NoZWR1bGVS ZWxheW91dCgpIGlzIGV4ZWN1dGVkCisgICAgICAgIC0tPnRoZSB0aW1lciBtX3Bvc3RMYXlvdXRU YXNrc1RpbWVyIGlzIHN0b3BwZWQKKyAgICAgICAgLS0+bm8gdGltZXIgaXMgc2NoZWR1bGVkIGR1 ZSB0byBtX2hhc1BlbmRpbmdQb3N0TGF5b3V0VGFza3MgPT0gdHJ1ZSAmJiBpblN1YmZyYW1lTGF5 b3V0V2l0aEZyYW1lRmxhdHRlbmluZyA9PSB0cnVlCisKKyAgICAgICAgVGhpcyBwYXRjaCByZXZl cnQgdGhlIGhhbmRsaW5nIG9mIHRoZSBwb3N0TGF5b3V0VGFza3MgdG8gaXRzIHN0YXRlIHByaW9y IHRvIHI2NjU1Mi4KKworICAgICAgICBUaGUgdGltZXIgaXRzZWxmIGlzIHVzZWQgYXMgdGhlIG9u bHkgc3RhdGUgdG8ga25vdyBpZiBwb3N0IGxheW91dCB0YXNrcyBhcmUgc2NoZWR1bGVkLgorCisg ICAgICAgIEZvciB0aGUgY2FzZSB3aXRob3V0IGZyYW1lIGZsYXR0ZW5pbmc6CisgICAgICAgIC1Q cmlvciB0byB0aGlzIHBhdGNoLCB3aGVuIEZyYW1lVmlldzo6dW5zY2hlZHVsZVJlbGF5b3V0KCkg d2FzIGV4ZWN1dGVkLCB0aGUgcG9zdExheW91dFRhc2tzVGltZXIgd2FzIGtpbGxlZCwKKyAgICAg ICAgYW5kIHRoZSBwb3N0IGxheW91dCB0YXNrcyB3b3VsZCBiZSBleGVjdXRlZCBkdXJpbmcgdGhl IG5leHQgbGF5b3V0KCkuCisgICAgICAgIC1BZnRlciB0aGlzIHBhdGNoLCB0aGUgcG9zdCBsYXlv dXQgdGFza3Mgc3RheSBzY2hlZHVsZWQgYW5kIGFyZSBleGVjdXRlZCBvbiB0aGUgbmV4dCBldmVu dCBsb29wIGlmIGxheW91dCgpCisgICAgICAgIHdhcyBub3QgaW52b2tlZCBiZWZvcmUuCisKKyAg ICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6 OkZyYW1lVmlldyk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6On5GcmFtZVZpZXcpOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXNldCk6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZVZpZXc6OmxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnVuc2NoZWR1 bGVSZWxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmZsdXNoQW55UGVuZGlu Z1Bvc3RMYXlvdXRUYXNrcyk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnBlcmZvcm1Q b3N0TGF5b3V0VGFza3MpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisKIDIwMTEtMTIt MjEgIFNoYXcgQW5keSAgPGFuZHkuc2hhd0BkaWdpYS5jb20+CiAKICAgICAgICAgRml4IGJ1aWxk IGlzc3VlIG9uIFdpbmRvd3Mgd2hlbiBRdCBpcyBjb25maWd1cmVkIHdpdGggLWx0Y2cKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRleCA1NmY2YzYwYzI3ODE5MzdiZjBhMzZlYjNjZDMzMWFm NTRhOTgxZjI1Li5jZjkwNTMwNzA4Y2ZlZmY2ZjEzODdhOTJjOTgyNjQyNWE2ODBkNzljIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCkBAIC0xMzQsNyArMTM0LDYgQEAgRnJhbWVWaWV3OjpG cmFtZVZpZXcoRnJhbWUqIGZyYW1lKQogI2lmIEVOQUJMRShTVkcpCiAgICAgLCBtX2luTGF5b3V0 UGFyZW50VmlldyhmYWxzZSkKICNlbmRpZgotICAgICwgbV9oYXNQZW5kaW5nUG9zdExheW91dFRh c2tzKGZhbHNlKQogICAgICwgbV9pblN5bmNocm9ub3VzUG9zdExheW91dChmYWxzZSkKICAgICAs IG1fcG9zdExheW91dFRhc2tzVGltZXIodGhpcywgJkZyYW1lVmlldzo6cG9zdExheW91dFRpbWVy RmlyZWQpCiAgICAgLCBtX2lzVHJhbnNwYXJlbnQoZmFsc2UpCkBAIC0xODYsNyArMTg1LDcgQEAg UGFzc1JlZlB0cjxGcmFtZVZpZXc+IEZyYW1lVmlldzo6Y3JlYXRlKEZyYW1lKiBmcmFtZSwgY29u c3QgSW50U2l6ZSYgaW5pdGlhbFNpemUKIAogRnJhbWVWaWV3Ojp+RnJhbWVWaWV3KCkKIHsKLSAg ICBpZiAobV9oYXNQZW5kaW5nUG9zdExheW91dFRhc2tzKSB7CisgICAgaWYgKG1fcG9zdExheW91 dFRhc2tzVGltZXIuaXNBY3RpdmUoKSkgewogICAgICAgICBtX3Bvc3RMYXlvdXRUYXNrc1RpbWVy LnN0b3AoKTsKICAgICAgICAgbV9hY3Rpb25TY2hlZHVsZXItPmNsZWFyKCk7CiAgICAgfQpAQCAt MjMyLDcgKzIzMSw2IEBAIHZvaWQgRnJhbWVWaWV3OjpyZXNldCgpCiAgICAgbV9sYXlvdXRTY2hl ZHVsaW5nRW5hYmxlZCA9IHRydWU7CiAgICAgbV9pbkxheW91dCA9IGZhbHNlOwogICAgIG1faW5T eW5jaHJvbm91c1Bvc3RMYXlvdXQgPSBmYWxzZTsKLSAgICBtX2hhc1BlbmRpbmdQb3N0TGF5b3V0 VGFza3MgPSBmYWxzZTsKICAgICBtX2xheW91dENvdW50ID0gMDsKICAgICBtX25lc3RlZExheW91 dENvdW50ID0gMDsKICAgICBtX3Bvc3RMYXlvdXRUYXNrc1RpbWVyLnN0b3AoKTsKQEAgLTk5NCwx MSArOTkyLDEwIEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWUpCiAg ICAgewogICAgICAgICBUZW1wb3JhcnlDaGFuZ2U8Ym9vbD4gY2hhbmdlU2NoZWR1bGluZ0VuYWJs ZWQobV9sYXlvdXRTY2hlZHVsaW5nRW5hYmxlZCwgZmFsc2UpOwogCi0gICAgICAgIGlmICghbV9u ZXN0ZWRMYXlvdXRDb3VudCAmJiAhbV9pblN5bmNocm9ub3VzUG9zdExheW91dCAmJiBtX2hhc1Bl bmRpbmdQb3N0TGF5b3V0VGFza3MgJiYgIWluU3ViZnJhbWVMYXlvdXRXaXRoRnJhbWVGbGF0dGVu aW5nKSB7CisgICAgICAgIGlmICghbV9uZXN0ZWRMYXlvdXRDb3VudCAmJiAhbV9pblN5bmNocm9u b3VzUG9zdExheW91dCAmJiBtX3Bvc3RMYXlvdXRUYXNrc1RpbWVyLmlzQWN0aXZlKCkgJiYgIWlu U3ViZnJhbWVMYXlvdXRXaXRoRnJhbWVGbGF0dGVuaW5nKSB7CiAgICAgICAgICAgICAvLyBUaGlz IGlzIGEgbmV3IHRvcC1sZXZlbCBsYXlvdXQuIElmIHRoZXJlIGFyZSBhbnkgcmVtYWluaW5nIHRh c2tzIGZyb20gdGhlIHByZXZpb3VzCiAgICAgICAgICAgICAvLyBsYXlvdXQsIGZpbmlzaCB0aGVt IG5vdy4KICAgICAgICAgICAgIG1faW5TeW5jaHJvbm91c1Bvc3RMYXlvdXQgPSB0cnVlOwotICAg ICAgICAgICAgbV9wb3N0TGF5b3V0VGFza3NUaW1lci5zdG9wKCk7CiAgICAgICAgICAgICBwZXJm b3JtUG9zdExheW91dFRhc2tzKCk7CiAgICAgICAgICAgICBtX2luU3luY2hyb25vdXNQb3N0TGF5 b3V0ID0gZmFsc2U7CiAgICAgICAgIH0KQEAgLTExNzAsNyArMTE2Nyw3IEBAIHZvaWQgRnJhbWVW aWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWUpCiAgICAgICAgIHVwZGF0ZU92ZXJmbG93U3Rh dHVzKGxheW91dFdpZHRoKCkgPCBjb250ZW50c1dpZHRoKCksCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxheW91dEhlaWdodCgpIDwgY29udGVudHNIZWlnaHQoKSk7CiAKLSAgICBpZiAo IW1faGFzUGVuZGluZ1Bvc3RMYXlvdXRUYXNrcykgeworICAgIGlmICghbV9wb3N0TGF5b3V0VGFz a3NUaW1lci5pc0FjdGl2ZSgpKSB7CiAgICAgICAgIGlmICghbV9pblN5bmNocm9ub3VzUG9zdExh eW91dCkgewogICAgICAgICAgICAgaWYgKGluU3ViZnJhbWVMYXlvdXRXaXRoRnJhbWVGbGF0dGVu aW5nKSB7CiAgICAgICAgICAgICAgICAgaWYgKFJlbmRlclZpZXcqIHJvb3QgPSByb290UmVuZGVy ZXIodGhpcykpCkBAIC0xMTgzLDEyICsxMTgwLDExIEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlvdXQo Ym9vbCBhbGxvd1N1YnRyZWUpCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgCi0g ICAgICAgIGlmICghbV9oYXNQZW5kaW5nUG9zdExheW91dFRhc2tzICYmIChuZWVkc0xheW91dCgp IHx8IG1faW5TeW5jaHJvbm91c1Bvc3RMYXlvdXQgfHwgaW5TdWJmcmFtZUxheW91dFdpdGhGcmFt ZUZsYXR0ZW5pbmcpKSB7CisgICAgICAgIGlmICghbV9wb3N0TGF5b3V0VGFza3NUaW1lci5pc0Fj dGl2ZSgpICYmIChuZWVkc0xheW91dCgpIHx8IG1faW5TeW5jaHJvbm91c1Bvc3RMYXlvdXQgfHwg aW5TdWJmcmFtZUxheW91dFdpdGhGcmFtZUZsYXR0ZW5pbmcpKSB7CiAgICAgICAgICAgICAvLyBJ ZiB3ZSBuZWVkIGxheW91dCBvciBhcmUgYWxyZWFkeSBpbiBhIHN5bmNocm9ub3VzIGNhbGwgdG8g cG9zdExheW91dFRhc2tzKCksIAogICAgICAgICAgICAgLy8gZGVmZXIgd2lkZ2V0IHVwZGF0ZXMg YW5kIGV2ZW50IGRpc3BhdGNoIHVudGlsIGFmdGVyIHdlIHJldHVybi4gcG9zdExheW91dFRhc2tz KCkKICAgICAgICAgICAgIC8vIGNhbiBtYWtlIHVzIG5lZWQgdG8gdXBkYXRlIGFnYWluLCBhbmQg d2UgY2FuIGdldCBzdHVjayBpbiBhIG5hc3R5IGN5Y2xlIHVubGVzcwogICAgICAgICAgICAgLy8g d2UgY2FsbCBpdCB0aHJvdWdoIHRoZSB0aW1lciBoZXJlLgotICAgICAgICAgICAgbV9oYXNQZW5k aW5nUG9zdExheW91dFRhc2tzID0gdHJ1ZTsKICAgICAgICAgICAgIG1fcG9zdExheW91dFRhc2tz VGltZXIuc3RhcnRPbmVTaG90KDApOwogICAgICAgICAgICAgaWYgKG5lZWRzTGF5b3V0KCkpIHsK ICAgICAgICAgICAgICAgICBtX2FjdGlvblNjaGVkdWxlci0+cGF1c2UoKTsKQEAgLTIwOTMsOCAr MjA4OSw2IEBAIHZvaWQgRnJhbWVWaWV3OjpzZXROZWVkc0xheW91dCgpCiAKIHZvaWQgRnJhbWVW aWV3Ojp1bnNjaGVkdWxlUmVsYXlvdXQoKQogewotICAgIG1fcG9zdExheW91dFRhc2tzVGltZXIu c3RvcCgpOwotCiAgICAgaWYgKCFtX2xheW91dFRpbWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIHJl dHVybjsKIApAQCAtMjI3NiwxNiArMjI3MCwxNSBAQCBib29sIEZyYW1lVmlldzo6dXBkYXRlV2lk Z2V0cygpCiAKIHZvaWQgRnJhbWVWaWV3OjpmbHVzaEFueVBlbmRpbmdQb3N0TGF5b3V0VGFza3Mo KQogewotICAgIGlmICghbV9oYXNQZW5kaW5nUG9zdExheW91dFRhc2tzKQorICAgIGlmICghbV9w b3N0TGF5b3V0VGFza3NUaW1lci5pc0FjdGl2ZSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBt X3Bvc3RMYXlvdXRUYXNrc1RpbWVyLnN0b3AoKTsKICAgICBwZXJmb3JtUG9zdExheW91dFRhc2tz KCk7CiB9CiAKIHZvaWQgRnJhbWVWaWV3OjpwZXJmb3JtUG9zdExheW91dFRhc2tzKCkKIHsKLSAg ICBtX2hhc1BlbmRpbmdQb3N0TGF5b3V0VGFza3MgPSBmYWxzZTsKKyAgICBtX3Bvc3RMYXlvdXRU YXNrc1RpbWVyLnN0b3AoKTsKIAogICAgIG1fZnJhbWUtPnNlbGVjdGlvbigpLT5zZXRDYXJldFJl Y3ROZWVkc1VwZGF0ZSgpOwogICAgIG1fZnJhbWUtPnNlbGVjdGlvbigpLT51cGRhdGVBcHBlYXJh bmNlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAppbmRleCA4MGI1MmI1NzhmNmYxZDBlZGYzMmQ5 ZTYzODc1Y2Q4NzM2Zjg0MzU1Li5hYzI2OTYxMmRjMWEyMWZkODUzMjQ0NTEzN2RmMzk4ZWY5MDdk NGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTQyNSw3ICs0MjUsNiBAQCBwcml2YXRl OgogI2lmIEVOQUJMRShTVkcpCiAgICAgYm9vbCBtX2luTGF5b3V0UGFyZW50VmlldzsKICNlbmRp ZgotICAgIGJvb2wgbV9oYXNQZW5kaW5nUG9zdExheW91dFRhc2tzOwogICAgIGJvb2wgbV9pblN5 bmNocm9ub3VzUG9zdExheW91dDsKICAgICBpbnQgbV9sYXlvdXRDb3VudDsKICAgICB1bnNpZ25l ZCBtX25lc3RlZExheW91dENvdW50Owo=