76097 2012-01-11 12:50:02 -0800 Object.defineProperty([], 'length', {}) should not make length read-only 2012-01-11 17:30:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 534158 0 barraclough 2012-01-11 12:50:02 -0800 We should be checking writablePresent(). 534174 1 122081 barraclough 2012-01-11 13:01:54 -0800 Created attachment 122081 Fix 534447 2 barraclough 2012-01-11 17:30:42 -0800 Fixed in r104777. 122081 2012-01-11 13:01:54 -0800 2012-01-11 13:04:43 -0800 Fix 76097.patch text/plain 7263 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA0NzM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTAxLTExICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBPYmplY3QuZGVmaW5lUHJvcGVydHkoW10sICdsZW5ndGgnLCB7fSkgc2hvdWxk IG5vdCBtYWtlIGxlbmd0aCByZWFkLW9ubHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc2MDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3BwOgorICAgICAgICAoSlNDOjpK U0FycmF5OjpkZWZpbmVPd25Qcm9wZXJ0eSk6CisgICAgICAgICAgICAtIFdlIHNob3VsZCBiZSBj aGVja2luZyB3cml0YWJsZVByZXNlbnQoKS4KKwogMjAxMi0wMS0xMCAgTWFyayBSb3dlICA8bXJv d2VAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMDY3Mzc5Mj4ganNjIHNo b3VsZCBpbnN0YWxsIGRpcmVjdGx5IGluIHRvIHZlcnNpb25lZCBSZXNvdXJjZXMgc3ViZm9sZGVy CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNp b24gMTA0NjIwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUzMSwxMCArNTMxLDEwIEBAIGJvb2wgSlNBcnJheTo6ZGVmaW5l T3duUHJvcGVydHkoSlNPYmplY3QKICAgICBpZiAocHJvcGVydHlOYW1lID09IGV4ZWMtPnByb3Bl cnR5TmFtZXMoKS5sZW5ndGgpIHsKICAgICAgICAgLy8gQWxsIHBhdGhzIHRocm91Z2ggbGVuZ3Ro IGRlZmluaXRpb24gY2FsbCB0aGUgZGVmYXVsdCBbW0RlZmluZU93blByb3BlcnR5XV0sIGhlbmNl OgogICAgICAgICAvLyBmcm9tIEVTNS4xIDguMTIuOSA3LmEuCi0gICAgICAgIGlmIChkZXNjcmlw dG9yLmNvbmZpZ3VyYWJsZSgpKQorICAgICAgICBpZiAoZGVzY3JpcHRvci5jb25maWd1cmFibGVQ cmVzZW50KCkgJiYgZGVzY3JpcHRvci5jb25maWd1cmFibGUoKSkKICAgICAgICAgICAgIHJldHVy biByZWplY3QoZXhlYywgdGhyb3dFeGNlcHRpb24sICJBdHRlbXB0aW5nIHRvIGNoYW5nZSBjb25m aWd1cmFibGUgYXR0cmlidXRlIG9mIHVuY29uZmlndXJhYmxlIHByb3BlcnR5LiIpOwogICAgICAg ICAvLyBmcm9tIEVTNS4xIDguMTIuOSA3LmIuCi0gICAgICAgIGlmIChkZXNjcmlwdG9yLmVudW1l cmFibGUoKSkKKyAgICAgICAgaWYgKGRlc2NyaXB0b3IuZW51bWVyYWJsZVByZXNlbnQoKSAmJiBk ZXNjcmlwdG9yLmVudW1lcmFibGUoKSkKICAgICAgICAgICAgIHJldHVybiByZWplY3QoZXhlYywg dGhyb3dFeGNlcHRpb24sICJBdHRlbXB0aW5nIHRvIGNoYW5nZSBlbnVtZXJhYmxlIGF0dHJpYnV0 ZSBvZiB1bmNvbmZpZ3VyYWJsZSBwcm9wZXJ0eS4iKTsKIAogICAgICAgICAvLyBhLiBJZiB0aGUg W1tWYWx1ZV1dIGZpZWxkIG9mIERlc2MgaXMgYWJzZW50LCB0aGVuCkBAIC01NDIsMTEgKzU0Miwx MiBAQCBib29sIEpTQXJyYXk6OmRlZmluZU93blByb3BlcnR5KEpTT2JqZWN0CiAgICAgICAgIGlm IChkZXNjcmlwdG9yLmlzQWNjZXNzb3JEZXNjcmlwdG9yKCkpCiAgICAgICAgICAgICByZXR1cm4g cmVqZWN0KGV4ZWMsIHRocm93RXhjZXB0aW9uLCAiQXR0ZW1wdGluZyB0byBjaGFuZ2UgYWNjZXNz IG1lY2hhbmlzbSBmb3IgYW4gdW5jb25maWd1cmFibGUgcHJvcGVydHkuIik7CiAgICAgICAgIC8v IGZyb20gRVM1LjEgOC4xMi45IDEwLmEuCi0gICAgICAgIGlmICghYXJyYXktPmlzTGVuZ3RoV3Jp dGFibGUoKSAmJiBkZXNjcmlwdG9yLndyaXRhYmxlKCkpCisgICAgICAgIGlmICghYXJyYXktPmlz TGVuZ3RoV3JpdGFibGUoKSAmJiBkZXNjcmlwdG9yLndyaXRhYmxlUHJlc2VudCgpICYmIGRlc2Ny aXB0b3Iud3JpdGFibGUoKSkKICAgICAgICAgICAgIHJldHVybiByZWplY3QoZXhlYywgdGhyb3dF eGNlcHRpb24sICJBdHRlbXB0aW5nIHRvIGNoYW5nZSB3cml0YWJsZSBhdHRyaWJ1dGUgb2YgdW5j b25maWd1cmFibGUgcHJvcGVydHkuIik7CiAgICAgICAgIC8vIFRoaXMgZGVzY3JpcHRvciBpcyBl aXRoZXIganVzdCBtYWtpbmcgbGVuZ3RoIHJlYWQtb25seSwgb3IgY2hhbmdpbmcgbm90aGluZyEK ICAgICAgICAgaWYgKCFkZXNjcmlwdG9yLnZhbHVlKCkpIHsKLSAgICAgICAgICAgIGFycmF5LT5z ZXRMZW5ndGhXcml0YWJsZShleGVjLCBkZXNjcmlwdG9yLndyaXRhYmxlKCkpOworICAgICAgICAg ICAgaWYgKGRlc2NyaXB0b3Iud3JpdGFibGVQcmVzZW50KCkpCisgICAgICAgICAgICAgICAgYXJy YXktPnNldExlbmd0aFdyaXRhYmxlKGV4ZWMsIGRlc2NyaXB0b3Iud3JpdGFibGUoKSk7CiAgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogICAgICAgICAKQEAgLTU2MSw3ICs1NjIs OCBAQCBib29sIEpTQXJyYXk6OmRlZmluZU93blByb3BlcnR5KEpTT2JqZWN0CiAKICAgICAgICAg Ly8gQmFzZWQgb24gU2FtZVZhbHVlIGNoZWNrIGluIDguMTIuOSwgdGhpcyBpcyBhbHdheXMgb2th eS4KICAgICAgICAgaWYgKG5ld0xlbiA9PSBhcnJheS0+bGVuZ3RoKCkpIHsKLSAgICAgICAgICAg IGFycmF5LT5zZXRMZW5ndGhXcml0YWJsZShleGVjLCBkZXNjcmlwdG9yLndyaXRhYmxlKCkpOwor ICAgICAgICAgICAgaWYgKGRlc2NyaXB0b3Iud3JpdGFibGVQcmVzZW50KCkpCisgICAgICAgICAg ICAgICAgYXJyYXktPnNldExlbmd0aFdyaXRhYmxlKGV4ZWMsIGRlc2NyaXB0b3Iud3JpdGFibGUo KSk7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogCkBAIC01ODgsMTMgKzU5 MCwxNyBAQCBib29sIEpTQXJyYXk6OmRlZmluZU93blByb3BlcnR5KEpTT2JqZWN0CiAgICAgICAg ICAgICAvLyAyLiBJZiBuZXdXcml0YWJsZSBpcyBmYWxzZSwgc2V0IG5ld0xlbkRlc2MuW1tXcml0 YWJsZV0gdG8gZmFsc2UuCiAgICAgICAgICAgICAvLyAzLiBDYWxsIHRoZSBkZWZhdWx0IFtbRGVm aW5lT3duUHJvcGVydHldXSBpbnRlcm5hbCBtZXRob2QgKDguMTIuOSkgb24gQSBwYXNzaW5nICJs ZW5ndGgiLCBuZXdMZW5EZXNjLCBhbmQgZmFsc2UgYXMgYXJndW1lbnRzLgogICAgICAgICAgICAg Ly8gNC4gUmVqZWN0LgotICAgICAgICAgICAgYXJyYXktPnNldExlbmd0aFdyaXRhYmxlKGV4ZWMs IGRlc2NyaXB0b3Iud3JpdGFibGUoKSk7CisgICAgICAgICAgICBpZiAoZGVzY3JpcHRvci53cml0 YWJsZVByZXNlbnQoKSkKKyAgICAgICAgICAgICAgICBhcnJheS0+c2V0TGVuZ3RoV3JpdGFibGUo ZXhlYywgZGVzY3JpcHRvci53cml0YWJsZSgpKTsKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICAgICAgfQogCiAgICAgICAgIC8vIG0uIElmIG5ld1dyaXRhYmxlIGlzIGZhbHNlLCB0aGVu Ci0gICAgICAgIC8vIGkuIENhbGwgdGhlIGRlZmF1bHQgW1tEZWZpbmVPd25Qcm9wZXJ0eV1dIGlu dGVybmFsIG1ldGhvZCAoOC4xMi45KSBvbiBBIHBhc3NpbmcgImxlbmd0aCIsIFByb3BlcnR5IERl c2NyaXB0b3J7W1tXcml0YWJsZV1dOiBmYWxzZX0sIGFuZCBmYWxzZSBhcyBhcmd1bWVudHMuIFRo aXMgY2FsbCB3aWxsIGFsd2F5cyByZXR1cm4gdHJ1ZS4KLSAgICAgICAgYXJyYXktPnNldExlbmd0 aFdyaXRhYmxlKGV4ZWMsIGRlc2NyaXB0b3Iud3JpdGFibGUoKSk7CisgICAgICAgIC8vIGkuIENh bGwgdGhlIGRlZmF1bHQgW1tEZWZpbmVPd25Qcm9wZXJ0eV1dIGludGVybmFsIG1ldGhvZCAoOC4x Mi45KSBvbiBBIHBhc3NpbmcgImxlbmd0aCIsCisgICAgICAgIC8vICAgIFByb3BlcnR5IERlc2Ny aXB0b3J7W1tXcml0YWJsZV1dOiBmYWxzZX0sIGFuZCBmYWxzZSBhcyBhcmd1bWVudHMuIFRoaXMg Y2FsbCB3aWxsIGFsd2F5cworICAgICAgICAvLyAgICByZXR1cm4gdHJ1ZS4KKyAgICAgICAgaWYg KGRlc2NyaXB0b3Iud3JpdGFibGVQcmVzZW50KCkpCisgICAgICAgICAgICBhcnJheS0+c2V0TGVu Z3RoV3JpdGFibGUoZXhlYywgZGVzY3JpcHRvci53cml0YWJsZSgpKTsKICAgICAgICAgLy8gbi4g UmV0dXJuIHRydWUuCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KSW5kZXg6IExheW91dFRl c3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlz aW9uIDEwNDczNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE0IEBACisyMDEyLTAxLTExICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdo QGFwcGxlLmNvbT4KKworICAgICAgICBPYmplY3QuZGVmaW5lUHJvcGVydHkoW10sICdsZW5ndGgn LCB7fSkgc2hvdWxkIG5vdCBtYWtlIGxlbmd0aCByZWFkLW9ubHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MDk3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2pzL2FycmF5LWRlZmluZU93blBy b3BlcnR5LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9hcnJh eS1kZWZpbmVPd25Qcm9wZXJ0eS5qczoKKyAgICAgICAgICAgIC0gQWRkZWQgdGVzdC4KKwogMjAx Mi0wMS0xMSAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2No cm9taXVtXSBDb2xvciBwcm9maWxlcyBhcmUgaW5jb3JyZWN0IGZvciBpbWFnZXMgd2l0aG91dCBw cmVtdWx0aXBsaWVkIGFscGhhCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2FycmF5LWRlZmlu ZU93blByb3BlcnR5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2pzL2FycmF5LWRlZmluZU93blByb3BlcnR5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTA0NjA0 KQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9hcnJheS1kZWZpbmVPd25Qcm9wZXJ0eS1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTcsNiArNyw3IEBAIFBBU1MgT2JqZWN0LmRlZmluZVBy b3BlcnR5KFtdLCAneCcsIHsgZ2UKIFBBU1MgT2JqZWN0LmRlZmluZVByb3BlcnR5KFtdLCAnbGVu Z3RoJywgeyB2YWx1ZTogMSB9KS5sZW5ndGggaXMgMQogUEFTUyB2YXIgYSA9IE9iamVjdC5kZWZp bmVQcm9wZXJ0eShbXSwgJ2xlbmd0aCcsIHsgd3JpdGFibGU6IGZhbHNlIH0pOyBhWzFdID0gMTsg YS5sZW5ndGggaXMgMAogUEFTUyB2YXIgYSA9IE9iamVjdC5kZWZpbmVQcm9wZXJ0eShbXSwgJ2xl bmd0aCcsIHsgd3JpdGFibGU6IGZhbHNlIH0pOyBhLmxlbmd0aCA9IDE7IGEubGVuZ3RoIGlzIDAK K1BBU1MgdmFyIGEgPSBPYmplY3QuZGVmaW5lUHJvcGVydHkoW10sICdsZW5ndGgnLCB7fSk7IGEu bGVuZ3RoID0gMTsgYS5sZW5ndGggaXMgMQogUEFTUyBPYmplY3QuZGVmaW5lUHJvcGVydHkoW10s ICdsZW5ndGgnLCB7IGdldDpmdW5jdGlvbigpe3JldHVybiB0cnVlO30gfSkgdGhyZXcgZXhjZXB0 aW9uIFR5cGVFcnJvcjogQXR0ZW1wdGluZyB0byBjaGFuZ2UgYWNjZXNzIG1lY2hhbmlzbSBmb3Ig YW4gdW5jb25maWd1cmFibGUgcHJvcGVydHkuLgogUEFTUyBPYmplY3QuZGVmaW5lUHJvcGVydHko W10sICdsZW5ndGgnLCB7IGVudW1lcmFibGU6IHRydWUgfSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVF cnJvcjogQXR0ZW1wdGluZyB0byBjaGFuZ2UgZW51bWVyYWJsZSBhdHRyaWJ1dGUgb2YgdW5jb25m aWd1cmFibGUgcHJvcGVydHkuLgogUEFTUyBPYmplY3QuZGVmaW5lUHJvcGVydHkoW10sICdsZW5n dGgnLCB7IGNvbmZpZ3VyYWJsZTogdHJ1ZSB9KSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBB dHRlbXB0aW5nIHRvIGNoYW5nZSBjb25maWd1cmFibGUgYXR0cmlidXRlIG9mIHVuY29uZmlndXJh YmxlIHByb3BlcnR5Li4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2Fy cmF5LWRlZmluZU93blByb3BlcnR5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv anMvc2NyaXB0LXRlc3RzL2FycmF5LWRlZmluZU93blByb3BlcnR5LmpzCShyZXZpc2lvbiAxMDQ2 MDQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9hcnJheS1kZWZpbmVPd25Q cm9wZXJ0eS5qcwkod29ya2luZyBjb3B5KQpAQCAtNyw2ICs3LDggQEAgc2hvdWxkQmVUcnVlKCJP YmplY3QuZGVmaW5lUHJvcGVydHkoW10sIAogc2hvdWxkQmUoIk9iamVjdC5kZWZpbmVQcm9wZXJ0 eShbXSwgJ2xlbmd0aCcsIHsgdmFsdWU6IDEgfSkubGVuZ3RoIiwgJzEnKTsKIHNob3VsZEJlKCJ2 YXIgYSA9IE9iamVjdC5kZWZpbmVQcm9wZXJ0eShbXSwgJ2xlbmd0aCcsIHsgd3JpdGFibGU6IGZh bHNlIH0pOyBhWzFdID0gMTsgYS5sZW5ndGgiLCAnMCcpOwogc2hvdWxkQmUoInZhciBhID0gT2Jq ZWN0LmRlZmluZVByb3BlcnR5KFtdLCAnbGVuZ3RoJywgeyB3cml0YWJsZTogZmFsc2UgfSk7IGEu bGVuZ3RoID0gMTsgYS5sZW5ndGgiLCAnMCcpOworLy8gSWYgd3JpdGFibGUgaXMgbm90IHNwZWNp ZmllZCwgaXQgc2hvdWxkIG5vdCBjaGFuZ2UuCitzaG91bGRCZSgidmFyIGEgPSBPYmplY3QuZGVm aW5lUHJvcGVydHkoW10sICdsZW5ndGgnLCB7fSk7IGEubGVuZ3RoID0gMTsgYS5sZW5ndGgiLCAn MScpOwogCiAvLyBUaGUgbGVuZ3RoIHByb3BlcnR5IGNhbiBiZSByZXBsYWNlZCB3aXRoIGFuIGFj Y2Vzc29yLCBvciBtYWRlIGVpdGhlciBlbnVtZXJhYmxlIG9yIGNvbmZpZ3VyYWJsZS4KIHNob3Vs ZFRocm93KCJPYmplY3QuZGVmaW5lUHJvcGVydHkoW10sICdsZW5ndGgnLCB7IGdldDpmdW5jdGlv bigpe3JldHVybiB0cnVlO30gfSkiKTsK