76085 2012-01-11 11:47:11 -0800 IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable 2012-01-12 12:10:25 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 76198 1 eric abarth abarth eric.carlson webkit.review.bot oldest_to_newest 534076 0 eric 2012-01-11 11:47:11 -0800 IETC audio-interface-inherit.129 claims NETWORK_NO_SOURCE should not be overrideable http://samples.msdn.microsoft.com/ietestcenter/html5/MediaElements/audio-interface-inherit.129.htm I'm not sure there is a bug here. We define NETWORK_NO_SOURCE on HTMLMediaElement, per the spec: http://www.whatwg.org/specs/web-apps/current-work/#media-elements Even though that value is constant, it seems any object instance which has HTMLMediaElement can still set its own NETWORK_NO_SOURCE, no? 534171 1 eric 2012-01-11 13:00:22 -0800 Actually, my understanding was incorrect. This is a bug in our code generator, not implying readonly from const: http://www.w3.org/TR/WebIDL/#es-constants 534175 2 eric 2012-01-11 13:02:22 -0800 Nope, that's wrong too. It's already being generated readonly: { "NETWORK_NO_SOURCE", DontDelete | ReadOnly, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsHTMLMediaElementNETWORK_NO_SOURCE), (intptr_t)0, NoIntrinsic }, 534193 3 eric 2012-01-11 13:13:59 -0800 I'm unclear from the WebIDL spec. http://www.w3.org/TR/WebIDL/#es-constants 4.5.4. Constants For each constant defined on an interface A, there must be a corresponding property on the interface object, if it exists. The property has the following characteristics: The name of the property is the identifier of the constant. The value of the property is that which is obtained by converting the constant’s IDL value to an ECMAScript value. The property has attributes { [[Writable]]: false, [[Enumerable]]: true, [[Configurable]]: false }. In addition, a property with the same characteristics must exist on the interface prototype object. Does that mean that each instance of an HTMLAudioElement has to have NETWORK_NO_SOURCE defined readonly? Currently it appears we just define this on the prototype. 534194 4 eric 2012-01-11 13:15:17 -0800 > audio = document.createElement("audio") <audio>​</audio>​ > audio.__proto__ HTMLAudioElement > audio.NETWORK_NO_SOURCE 3 > audio.__proto__ = null null > audio.NETWORK_NO_SOURCE undefined 534199 5 abarth 2012-01-11 13:19:10 -0800 I'm pretty sure the test is wrong. The constant is supposed to appear in the interface and the interface prototype, not the instance. Assigning to the property on the instance creates a new property on the instance that shadows the readonly property on the prototype. 534254 6 122097 abarth 2012-01-11 14:19:30 -0800 Created attachment 122097 Patch 534364 7 122097 webkit.review.bot 2012-01-11 16:08:21 -0800 Comment on attachment 122097 Patch Clearing flags on attachment: 122097 Committed r104761: <http://trac.webkit.org/changeset/104761> 534365 8 webkit.review.bot 2012-01-11 16:08:26 -0800 All reviewed patches have been landed. Closing bug. 122097 2012-01-11 14:19:30 -0800 2012-01-11 16:08:21 -0800 Patch bug-76085-20120111141929.patch text/plain 2802 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwNDc0NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTExICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSUVUQyBhdWRpby1pbnRlcmZhY2UtaW5oZXJpdC4x MjkgY2xhaW1zIE5FVFdPUktfTk9fU09VUkNFIHNob3VsZCBub3QgYmUgb3ZlcnJpZGVhYmxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjA4NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGZhciBhcyBJ IGNhbiB0ZWxsLCB0aGUgSUVUQyB0ZXN0IG9mIHRoaXMgZmVhdHVyZSBpcyB3cm9uZy4KKyAgICAg ICAgTkVUV09SS19OT19TT1VSQ0Ugc2hvdWxkIGJlIGltbXV0YWJsZSBvbiB0aGUgaW50ZXJmYWNl IG9iamVjdCBhbmQgb24KKyAgICAgICAgdGhlIGludGVyZmFjZSBwcm90b3R5cGUgb2JqZWN0LCBi dXQgSmF2YVNjcmlwdCBzaG91bGQgYmUgYWJsZSB0byBzaGFkb3cKKyAgICAgICAgdGhlIHByb3Bl cnR5IG9uIGFuIGluc3RhbmNlLgorCisgICAgICAgICogbWVkaWEvbmV0d29yay1uby1zb3VyY2Ut Y29uc3Qtc2hhZG93LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvbmV0d29y ay1uby1zb3VyY2UtY29uc3Qtc2hhZG93Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTAxLTExICBSYXlt b25kIFRveSAgPHJ0b3lAZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWJhdWRpbyBsYXlvdXQgdGVz dHMgbmVlZCB0byBvdmVycmlkZSB0aGUgV2ViS2l0V2ViQXVkaW9FbmFibGVkCkluZGV4OiBMYXlv dXRUZXN0cy9tZWRpYS9uZXR3b3JrLW5vLXNvdXJjZS1jb25zdC1zaGFkb3ctZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL25ldHdvcmstbm8tc291cmNlLWNvbnN0 LXNoYWRvdy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9u ZXR3b3JrLW5vLXNvdXJjZS1jb25zdC1zaGFkb3ctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDE1IEBACitUZXN0IHRoYXQgTkVUV09SS19OT19TT1VSQ0UgaXMgaW1tdXRhYmxl IGF0IHRoZSBhcHByb3ByaWF0ZSB0aW1lcworCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBIVE1MTWVkaWFFbGVtZW50Lk5FVFdPUktfTk9fU09VUkNFIGlzIDMKK1BBU1MgSFRN TE1lZGlhRWxlbWVudC5wcm90b3R5cGUuTkVUV09SS19OT19TT1VSQ0UgaXMgMworUEFTUyBlbGVt ZW50Lk5FVFdPUktfTk9fU09VUkNFIGlzIDMKK1BBU1MgSFRNTE1lZGlhRWxlbWVudC5ORVRXT1JL X05PX1NPVVJDRSBpcyAzCitQQVNTIEhUTUxBdWRpb0VsZW1lbnQucHJvdG90eXBlLk5FVFdPUktf Tk9fU09VUkNFIGlzIDMKK1BBU1MgZWxlbWVudC5ORVRXT1JLX05PX1NPVVJDRSBpcyAxNQorUEFT UyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExh eW91dFRlc3RzL21lZGlhL25ldHdvcmstbm8tc291cmNlLWNvbnN0LXNoYWRvdy5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL25ldHdvcmstbm8tc291cmNlLWNvbnN0LXNoYWRv dy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvbmV0d29yay1uby1zb3Vy Y2UtY29uc3Qtc2hhZG93Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjEgQEAKKzwhRE9D VFlQRSBodG1sPgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdCB0aGF0IE5FVFdPUktf Tk9fU09VUkNFIGlzIGltbXV0YWJsZSBhdCB0aGUgYXBwcm9wcmlhdGUgdGltZXMiKTsKKworc2hv dWxkQmUoIkhUTUxNZWRpYUVsZW1lbnQuTkVUV09SS19OT19TT1VSQ0UiLCAiMyIpOworc2hvdWxk QmUoIkhUTUxNZWRpYUVsZW1lbnQucHJvdG90eXBlLk5FVFdPUktfTk9fU09VUkNFIiwgIjMiKTsK KwordmFyIGVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJhdWRpbyIpOworCitzaG91 bGRCZSgiZWxlbWVudC5ORVRXT1JLX05PX1NPVVJDRSIsICIzIik7CisKK0hUTUxNZWRpYUVsZW1l bnQuTkVUV09SS19OT19TT1VSQ0UgPSAxMzsKK0hUTUxNZWRpYUVsZW1lbnQucHJvdG90eXBlLk5F VFdPUktfTk9fU09VUkNFID0gMTQ7CitlbGVtZW50Lk5FVFdPUktfTk9fU09VUkNFID0gMTU7CisK K3Nob3VsZEJlKCJIVE1MTWVkaWFFbGVtZW50Lk5FVFdPUktfTk9fU09VUkNFIiwgIjMiKTsKK3No b3VsZEJlKCJIVE1MQXVkaW9FbGVtZW50LnByb3RvdHlwZS5ORVRXT1JLX05PX1NPVVJDRSIsICIz Iik7CitzaG91bGRCZSgiZWxlbWVudC5ORVRXT1JLX05PX1NPVVJDRSIsICIxNSIpOworPC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4K