76080 2012-01-11 11:26:40 -0800 Webpages flash white when switching between windows 2012-01-11 11:38:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 534054 0 andersca 2012-01-11 11:26:40 -0800 Webpages flash white when switching between windows 534057 1 122057 andersca 2012-01-11 11:27:43 -0800 Created attachment 122057 Patch 534065 2 122057 mitz 2012-01-11 11:34:20 -0800 Comment on attachment 122057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122057&action=review > Source/WebKit2/ChangeLog:9 > + Introduce a _windowHasValidBackingStore boolean and only paint white if it's false. Is it really unconditionally white? > Source/WebKit2/ChangeLog:17 > + * UIProcess/API/mac/WKView.mm: > + (-[WKView setFrameSize:]): > + (-[WKView viewDidMoveToWindow]): > + (-[WKView _windowDidMiniaturize:]): > + (-[WKView _windowDidChangeBackingProperties:]): > + (-[WKView drawRect:]): > + Please add comments here. > Source/WebKit2/UIProcess/API/mac/WKView.mm:192 > + // The window server invalidates the backing store of whenever the window is resized or minimized. Typo: “of whenever”. > Source/WebKit2/UIProcess/API/mac/WKView.mm:1980 > + // didn't paint with white, to avoid garbage in those areas. Is it really always white? 534070 3 andersca 2012-01-11 11:38:35 -0800 Committed r104727: <http://trac.webkit.org/changeset/104727> 122057 2012-01-11 11:27:43 -0800 2012-01-11 11:34:20 -0800 Patch bug-76080-20120111112743.patch text/plain 4388 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDNkYWM1ZjZmNjkwODY2 NWMzNWZiN2EwMzc5MzQ5ZjM4ZDhjYWVhNC4uMmUxYTJkODk0NTU1MjA1YmI4NTlkZDcwZTVhNDEx YzhjMDNlYzc5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTAxLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgV2VicGFnZXMgZmxh c2ggd2hpdGUgd2hlbiBzd2l0Y2hpbmcgYmV0d2VlbiB3aW5kb3dzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjA4MAorICAgICAgICA8cmRhcjovL3By b2JsZW0vOTg5MzU2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbnRyb2R1Y2UgYSBfd2luZG93SGFzVmFsaWRCYWNraW5nU3RvcmUgYm9vbGVhbiBh bmQgb25seSBwYWludCB3aGl0ZSBpZiBpdCdzIGZhbHNlLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgc2V0RnJhbWVTaXplOl0pOgor ICAgICAgICAoLVtXS1ZpZXcgdmlld0RpZE1vdmVUb1dpbmRvd10pOgorICAgICAgICAoLVtXS1Zp ZXcgX3dpbmRvd0RpZE1pbmlhdHVyaXplOl0pOgorICAgICAgICAoLVtXS1ZpZXcgX3dpbmRvd0Rp ZENoYW5nZUJhY2tpbmdQcm9wZXJ0aWVzOl0pOgorICAgICAgICAoLVtXS1ZpZXcgZHJhd1JlY3Q6 XSk6CisKKzIwMTItMDEtMTEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4K KwogICAgICAgICBGaXggdGhlIE1hYyBHQ0MgYnVpbGQuCiAKICAgICAgICAgV29yayBhcm91bmQg dGhlIGZhY3QgdGhhdCBHQ0MgZG9lc24ndCB3b3JrIHZlcnkgd2VsbCB3aXRoIEJsb2NrcyBhbmQg QysrIG9iamV0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFj L1dLVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQpp bmRleCAxZTI1MDliYTY5N2U1ZGE5MWJhZGI1OWNjNTQwNDJlN2VjODczMzU1Li44ZmNlMWNhYjRi NDExMzA1YTU3NzM3ZmIyOTRlMzA4Yzg5ZGZjMDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCkBAIC0xODcsNyArMTg3LDEzIEBAIHN0cnVjdCBXS1ZpZXdJ bnRlcnByZXRLZXlFdmVudHNQYXJhbWV0ZXJzIHsKICAgICBOU1JlY3QgX3dpbmRvd0JvdHRvbUNv cm5lckludGVyc2VjdGlvblJlY3Q7CiAgICAgCiAgICAgdW5zaWduZWQgX2ZyYW1lU2l6ZVVwZGF0 ZXNEaXNhYmxlZENvdW50OworCisgICAgLy8gV2hldGhlciB0aGUgY29udGFpbmluZyB3aW5kb3cg b2YgdGhlIFdLVmlldyBoYXMgYSB2YWxpZCBiYWNraW5nIHN0b3JlLgorICAgIC8vIFRoZSB3aW5k b3cgc2VydmVyIGludmFsaWRhdGVzIHRoZSBiYWNraW5nIHN0b3JlIG9mIHdoZW5ldmVyIHRoZSB3 aW5kb3cgaXMgcmVzaXplZCBvciBtaW5pbWl6ZWQuCisgICAgLy8gV2UgdXNlIHRoaXMgZmxhZyB0 byBkZXRlcm1pbmUgd2hlbiB3ZSBuZWVkIHRvIHBhaW50IHdoaXRlIGlmIHRoZSB3ZWIgcHJvY2Vz cyBpcyB1bnJlc3BvbnNpdmUuCisgICAgQk9PTCBfd2luZG93SGFzVmFsaWRCYWNraW5nU3RvcmU7 CiB9CisKIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdLVmlld0RhdGEKQEAgLTMyNCw2ICszMzAs OSBAQCBzdHJ1Y3QgV0tWaWV3SW50ZXJwcmV0S2V5RXZlbnRzUGFyYW1ldGVycyB7CiAKIC0gKHZv aWQpc2V0RnJhbWVTaXplOihOU1NpemUpc2l6ZQogeworICAgIGlmICghTlNFcXVhbFNpemVzKHNp emUsIFtzZWxmIGZyYW1lXS5zaXplKSkKKyAgICAgICAgX2RhdGEtPl93aW5kb3dIYXNWYWxpZEJh Y2tpbmdTdG9yZSA9IE5POworCiAgICAgW3N1cGVyIHNldEZyYW1lU2l6ZTpzaXplXTsKICAgICAK ICAgICBpZiAoIVtzZWxmIGZyYW1lU2l6ZVVwZGF0ZXNEaXNhYmxlZF0pCkBAIC0xODE4LDYgKzE4 MjcsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKiBjb25zdCBiYWNraW5nUHJvcGVydHlPbGRTY2FsZUZh Y3RvcktleSA9IEAiTlNCYWNraW5nUHJvcGVydHlPbAogICAgIC8vIHVwZGF0ZSB0aGUgYWN0aXZl IHN0YXRlIGZpcnN0IGFuZCB0aGVuIG1ha2UgaXQgdmlzaWJsZS4gSWYgdGhlIHZpZXcgaXMgYWJv dXQgdG8gYmUgaGlkZGVuLCB3ZSBoaWRlIGl0IGZpcnN0IGFuZCB0aGVuCiAgICAgLy8gdXBkYXRl IHRoZSBhY3RpdmUgc3RhdGUuCiAgICAgaWYgKFtzZWxmIHdpbmRvd10pIHsKKyAgICAgICAgX2Rh dGEtPl93aW5kb3dIYXNWYWxpZEJhY2tpbmdTdG9yZSA9IE5POwogICAgICAgICBfZGF0YS0+X3Bh Z2UtPnZpZXdTdGF0ZURpZENoYW5nZShXZWJQYWdlUHJveHk6OlZpZXdXaW5kb3dJc0FjdGl2ZSk7 CiAgICAgICAgIF9kYXRhLT5fcGFnZS0+dmlld1N0YXRlRGlkQ2hhbmdlKFdlYlBhZ2VQcm94eTo6 Vmlld0lzVmlzaWJsZSB8IFdlYlBhZ2VQcm94eTo6Vmlld0lzSW5XaW5kb3cpOwogICAgICAgICBb c2VsZiBfdXBkYXRlV2luZG93VmlzaWJpbGl0eV07CkBAIC0xODgzLDYgKzE4OTMsOCBAQCBzdGF0 aWMgTlNTdHJpbmcgKiBjb25zdCBiYWNraW5nUHJvcGVydHlPbGRTY2FsZUZhY3RvcktleSA9IEAi TlNCYWNraW5nUHJvcGVydHlPbAogCiAtICh2b2lkKV93aW5kb3dEaWRNaW5pYXR1cml6ZTooTlNO b3RpZmljYXRpb24gKilub3RpZmljYXRpb24KIHsKKyAgICBfZGF0YS0+X3dpbmRvd0hhc1ZhbGlk QmFja2luZ1N0b3JlID0gTk87CisKICAgICBbc2VsZiBfdXBkYXRlV2luZG93VmlzaWJpbGl0eV07 CiB9CiAKQEAgLTE5MTksNiArMTkzMSw3IEBAIHN0YXRpYyBOU1N0cmluZyAqIGNvbnN0IGJhY2tp bmdQcm9wZXJ0eU9sZFNjYWxlRmFjdG9yS2V5ID0gQCJOU0JhY2tpbmdQcm9wZXJ0eU9sCiAgICAg aWYgKG9sZEJhY2tpbmdTY2FsZUZhY3RvciA9PSBuZXdCYWNraW5nU2NhbGVGYWN0b3IpIAogICAg ICAgICByZXR1cm47IAogCisgICAgX2RhdGEtPl93aW5kb3dIYXNWYWxpZEJhY2tpbmdTdG9yZSA9 IE5POwogICAgIF9kYXRhLT5fcGFnZS0+c2V0SW50cmluc2ljRGV2aWNlU2NhbGVGYWN0b3IobmV3 QmFja2luZ1NjYWxlRmFjdG9yKTsKIH0KIApAQCAtMTk2Myw5ICsxOTc2LDE1IEBAIHN0YXRpYyB2 b2lkIGRyYXdQYWdlQmFja2dyb3VuZChDR0NvbnRleHRSZWYgY29udGV4dCwgV2ViUGFnZVByb3h5 KiBwYWdlLCBjb25zdCBJCiAgICAgICAgICAgICBJbnRSZWN0IHJlY3QgPSBlbmNsb3NpbmdJbnRS ZWN0KHJlY3RzQmVpbmdEcmF3bltpXSk7CiAgICAgICAgICAgICBkcmF3aW5nQXJlYS0+cGFpbnQo Y29udGV4dCwgcmVjdCwgdW5wYWludGVkUmVnaW9uKTsKIAotICAgICAgICAgICAgVmVjdG9yPElu dFJlY3Q+IHVucGFpbnRlZFJlY3RzID0gdW5wYWludGVkUmVnaW9uLnJlY3RzKCk7Ci0gICAgICAg ICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHVucGFpbnRlZFJlY3RzLnNpemUoKTsgKytpKQot ICAgICAgICAgICAgICAgIGRyYXdQYWdlQmFja2dyb3VuZChjb250ZXh0LCBfZGF0YS0+X3BhZ2Uu Z2V0KCksIHVucGFpbnRlZFJlY3RzW2ldKTsKKyAgICAgICAgICAgIC8vIElmIHRoZSB3aW5kb3cg ZG9lc24ndCBoYXZlIGEgdmFsaWQgYmFja2luZyBzdG9yZSwgd2UgbmVlZCB0byBmaWxsIHRoZSBw YXJ0cyBvZiB0aGUgcGFnZSB0aGF0IHdlCisgICAgICAgICAgICAvLyBkaWRuJ3QgcGFpbnQgd2l0 aCB3aGl0ZSwgdG8gYXZvaWQgZ2FyYmFnZSBpbiB0aG9zZSBhcmVhcy4KKyAgICAgICAgICAgIGlm ICghX2RhdGEtPl93aW5kb3dIYXNWYWxpZEJhY2tpbmdTdG9yZSkgeworICAgICAgICAgICAgICAg IFZlY3RvcjxJbnRSZWN0PiB1bnBhaW50ZWRSZWN0cyA9IHVucGFpbnRlZFJlZ2lvbi5yZWN0cygp OworICAgICAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgdW5wYWludGVkUmVjdHMu c2l6ZSgpOyArK2kpCisgICAgICAgICAgICAgICAgICAgIGRyYXdQYWdlQmFja2dyb3VuZChjb250 ZXh0LCBfZGF0YS0+X3BhZ2UuZ2V0KCksIHVucGFpbnRlZFJlY3RzW2ldKTsKKworICAgICAgICAg ICAgICAgIF9kYXRhLT5fd2luZG93SGFzVmFsaWRCYWNraW5nU3RvcmUgPSBZRVM7CisgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgICB9IGVsc2UgCiAgICAgICAgIGRyYXdQYWdlQmFja2dyb3Vu ZChjb250ZXh0LCBfZGF0YS0+X3BhZ2UuZ2V0KCksIGVuY2xvc2luZ0ludFJlY3QocmVjdCkpOwo=