76054 2012-01-11 05:30:34 -0800 [GTK] Web process should use the same locale as the UI process 2012-01-11 22:59:15 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand oldest_to_newest 533818 0 cgarcia 2012-01-11 05:30:34 -0800 For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole. 533819 1 122011 cgarcia 2012-01-11 05:32:11 -0800 Created attachment 122011 Patch 533822 2 pnormand 2012-01-11 05:38:18 -0800 (In reply to comment #0) > For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole. Shouldn't the WebProcess only set the locale when runned in the tests context then? 533824 3 cgarcia 2012-01-11 05:41:04 -0800 unit tests is just and example, this way we make sure locale will be the same. 533825 4 122011 gustavo 2012-01-11 05:42:42 -0800 Comment on attachment 122011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122011&action=review That looks fine to me. I wondered the same thing as Philippe, but I realized having the same locale for all processes would be desired in any case. > Source/WebKit2/ChangeLog:3 > + [GTK] Web process should use the same locale than UI process I think 'than' is not correct in this case, I think 'as the' would be (notice I am not a native speaker, though) 533826 5 cgarcia 2012-01-11 05:43:00 -0800 I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process. 533827 6 pnormand 2012-01-11 05:47:37 -0800 (In reply to comment #5) > I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process. Ok thanks for the clarification. 534580 7 cgarcia 2012-01-11 22:59:15 -0800 Committed r104792: <http://trac.webkit.org/changeset/104792> 122011 2012-01-11 05:32:11 -0800 2012-01-11 05:42:42 -0800 Patch wk2-child-process-locale.diff text/plain 1492 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2YjFiYzE0Li41NGQ2ODkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTItMDEtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYiBwcm9jZXNzIHNob3VsZCB1c2UgdGhlIHNhbWUgbG9jYWxl IHRoYW4gVUkgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzYwNTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcDoK KyAgICAgICAgKFdlYktpdDo6Y2hpbGRTZXR1cEZ1bmN0aW9uKTogTWFrZSBjaGlsZCBwcm9jZXNz IHVzZSB0aGUgc2FtZQorICAgICAgICBsb2NhbGUgdGhhbiBpdHMgcGFyZW50LgorCiAyMDEyLTAx LTA5ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgogCiAgICAgICAgIFtR dF1bV0syXSBQaW5jaCB6b29tIHNob3VsZCBhZmZlY3QgdGhlIHBhZ2Ugc2l6ZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJH dGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1 bmNoZXJHdGsuY3BwCmluZGV4IGQ3YTUwODIuLmM2MzQ1YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0 ay5jcHAKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0ZpbGVTeXN0ZW0uaD4K ICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlSGFuZGxlLmg+CiAjaW5jbHVkZSA8ZXJybm8uaD4K KyNpbmNsdWRlIDxsb2NhbGUuaD4KICNpZiBPUyhMSU5VWCkKICNpbmNsdWRlIDxzeXMvcHJjdGwu aD4KICNlbmRpZgpAQCAtNTgsNiArNTksOSBAQCBzdGF0aWMgdm9pZCBjaGlsZFNldHVwRnVuY3Rp b24oZ3BvaW50ZXIgdXNlckRhdGEpCiAgICAgaW50IHNvY2tldCA9IEdQT0lOVEVSX1RPX0lOVCh1 c2VyRGF0YSk7CiAgICAgY2xvc2Uoc29ja2V0KTsKIAorICAgIC8vIE1ha2UgY2hpbGQgcHJvY2Vz cyBpbmhlcml0IHBhcmVudCdzIGxvY2FsZS4KKyAgICBnX3NldGVudigiTENfQUxMIiwgc2V0bG9j YWxlKExDX0FMTCwgMCksIFRSVUUpOworCiAjaWYgT1MoTElOVVgpCiAgICAgLy8gS2lsbCBjaGls ZCBwcm9jZXNzIHdoZW4gcGFyZW50IGRpZXMuCiAgICAgcHJjdGwoUFJfU0VUX1BERUFUSFNJRywg U0lHS0lMTCk7Cg==