<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>76043</bug_id>
          
          <creation_ts>2012-01-11 02:33:14 -0800</creation_ts>
          <short_desc>CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code</short_desc>
          <delta_ts>2012-01-16 04:05:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>73190</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Roland Steiner">rolandsteiner</reporter>
          <assigned_to name="Roland Steiner">rolandsteiner</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>dominicc</cc>
    
    <cc>hyatt</cc>
    
    <cc>koivisto</cc>
    
    <cc>macpherson</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>533763</commentid>
    <comment_count>0</comment_count>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2012-01-11 02:33:14 -0800</bug_when>
    <thetext>The end of the constructor and appendAuthorStylesheets contain what is essentially the same code. It should be possible to use a common function that handles appending author stylesheets.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>533766</commentid>
    <comment_count>1</comment_count>
      <attachid>121998</attachid>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2012-01-11 02:37:54 -0800</bug_when>
    <thetext>Created attachment 121998
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>534742</commentid>
    <comment_count>2</comment_count>
      <attachid>121998</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2012-01-12 04:26:02 -0800</bug_when>
    <thetext>Comment on attachment 121998
Patch

I don&apos;t think this is right factoring. We will need to do collectFeatures differently in append case to avoid going through all the stylesheets again. We don&apos;t generally use iterators with Vectors. I&apos;d like to eliminate the pointless StyleSheetVector typedef.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536317</commentid>
    <comment_count>3</comment_count>
      <attachid>122579</attachid>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2012-01-15 18:19:54 -0800</bug_when>
    <thetext>Created attachment 122579
new patch, smaller

New, smaller patch. Adds a const-accessor for the vector to StyleSheetList. Perhaps not terribly elegant, but it&apos;s a) const only and b) there&apos;s a precedent with StyleSheetList::swap(). This way no iterators are necessary (still using &apos;StyleSheetVector&apos; within StyleSheetList for consistency).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536318</commentid>
    <comment_count>4</comment_count>
      <attachid>122579</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-01-15 18:24:35 -0800</bug_when>
    <thetext>Comment on attachment 122579
new patch, smaller

Attachment 122579 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11214031</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536319</commentid>
    <comment_count>5</comment_count>
      <attachid>122579</attachid>
    <who name="Early Warning System Bot">webkit-ews</who>
    <bug_when>2012-01-15 18:24:39 -0800</bug_when>
    <thetext>Comment on attachment 122579
new patch, smaller

Attachment 122579 did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11251031</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536321</commentid>
    <comment_count>6</comment_count>
      <attachid>122579</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-15 18:44:18 -0800</bug_when>
    <thetext>Comment on attachment 122579
new patch, smaller

Attachment 122579 did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11254025</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536329</commentid>
    <comment_count>7</comment_count>
      <attachid>122583</attachid>
    <who name="Roland Steiner">rolandsteiner</who>
    <bug_when>2012-01-15 19:38:27 -0800</bug_when>
    <thetext>Created attachment 122583
new patch, fixed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536459</commentid>
    <comment_count>8</comment_count>
      <attachid>122583</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2012-01-16 03:29:17 -0800</bug_when>
    <thetext>Comment on attachment 122583
new patch, fixed

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536471</commentid>
    <comment_count>9</comment_count>
      <attachid>122583</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-16 04:05:21 -0800</bug_when>
    <thetext>Comment on attachment 122583
new patch, fixed

Clearing flags on attachment: 122583

Committed r105052: &lt;http://trac.webkit.org/changeset/105052&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>536473</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-01-16 04:05:26 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>121998</attachid>
            <date>2012-01-11 02:37:54 -0800</date>
            <delta_ts>2012-01-15 18:19:48 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-76043-20120111193752.patch</filename>
            <type>text/plain</type>
            <size>6925</size>
            <attacher name="Roland Steiner">rolandsteiner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE3NzVlNTc4NTc0OWYy
NWNiMzljMTU1ZmY3NjE5ZGNhN2I1M2M4Ni4uNDI4ZWE3YzgyZWI0ZDFmMzYxZjY5MmFlM2VlZTFm
MDA5MDI2OWY1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAxLTExICBSb2xh
bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENTU1N0
eWxlU2VsZWN0b3IgY29uc3RydWN0b3IgYW5kIGFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKCkgY29u
dGFpbiBkdXBsaWNhdGVkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTc2MDQzCisKKyAgICAgICAgU3R5bGVTaGVldExpc3QgZXNzZW50aWFsbHkg
aXMgYSB2ZWN0b3IgYXJvdW5kIGEgU3R5bGVTaGVldFZlY3Rvciwgd2hpY2ggaXMgdXNlZCBpbiBh
cHBlbmRBdXRob3JTdHlsZXNoZWV0cygpLgorICAgICAgICBVc2UgaXRlcmF0b3JzIHJhdGhlciB0
aGFuIHRoZSBjb250YWluZXIgaXRzZWxmIHRvIGFsbG93IGFwcGVuZEF1dGhvclN0eWxlc2hlZXRz
KCkgdG8gYmUgcmUtdXNlZCBpbiB0aGUgY29uc3RydWN0b3IuCisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAocmVmYWN0b3Jpbmcp
CisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpDU1NTdHlsZVNlbGVjdG9yOjpDU1NTdHlsZVNlbGVjdG9yKToKKyAgICAgICAgKFdlYkNvcmU6
OkNTU1N0eWxlU2VsZWN0b3I6OmFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKToKKyAgICAgICAgKiBj
c3MvQ1NTU3R5bGVTZWxlY3Rvci5oOgorICAgICAgICAqIGNzcy9TdHlsZVNoZWV0TGlzdC5oOgor
ICAgICAgICAoV2ViQ29yZTo6U3R5bGVTaGVldExpc3Q6OmJlZ2luKToKKyAgICAgICAgKFdlYkNv
cmU6OlN0eWxlU2hlZXRMaXN0OjplbmQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dXBkYXRlQWN0aXZlU3R5bGVzaGVldHMpOgorCiAy
MDEyLTAxLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAog
ICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA0NTA3LgpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3Nz
L0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IDA4ODM4ZjI3MTIxYWY1MTFiMGM4OWRhYTZhMjlh
MzI3YWEzNTRhZDMuLjhhN2Y3MzVmYzIzOGJjZDQ5N2FlYWNlMmZlODc3ZTkyNThiYzIwZWMgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTk1LDcgKzk1LDYgQEAK
ICNpbmNsdWRlICJTdHlsZUNhY2hlZEltYWdlLmgiCiAjaW5jbHVkZSAiU3R5bGVQZW5kaW5nSW1h
Z2UuaCIKICNpbmNsdWRlICJTdHlsZUdlbmVyYXRlZEltYWdlLmgiCi0jaW5jbHVkZSAiU3R5bGVT
aGVldExpc3QuaCIKICNpbmNsdWRlICJUZXh0LmgiCiAjaW5jbHVkZSAiVHJhbnNmb3JtYXRpb25N
YXRyaXguaCIKICNpbmNsdWRlICJUcmFuc2xhdGVUcmFuc2Zvcm1PcGVyYXRpb24uaCIKQEAgLTQx
MiwxOCArNDExLDcgQEAgQ1NTU3R5bGVTZWxlY3Rvcjo6Q1NTU3R5bGVTZWxlY3RvcihEb2N1bWVu
dCogZG9jdW1lbnQsIFN0eWxlU2hlZXRMaXN0KiBzdHlsZVNoZWUKICAgICAgICAgbV9hdXRob3JT
dHlsZS0+YWRkUnVsZXNGcm9tU2hlZXQobWFwcGVkRWxlbWVudFNoZWV0LCAqbV9tZWRpdW0sIHRo
aXMpOwogCiAgICAgLy8gYWRkIHN0eWxlc2hlZXRzIGZyb20gZG9jdW1lbnQKLSAgICB1bnNpZ25l
ZCBsZW5ndGggPSBzdHlsZVNoZWV0cy0+bGVuZ3RoKCk7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0g
MDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgIFN0eWxlU2hlZXQqIHNoZWV0ID0gc3R5bGVT
aGVldHMtPml0ZW0oaSk7Ci0gICAgICAgIGlmIChzaGVldC0+aXNDU1NTdHlsZVNoZWV0KCkgJiYg
IXNoZWV0LT5kaXNhYmxlZCgpKQotICAgICAgICAgICAgbV9hdXRob3JTdHlsZS0+YWRkUnVsZXNG
cm9tU2hlZXQoc3RhdGljX2Nhc3Q8Q1NTU3R5bGVTaGVldCo+KHNoZWV0KSwgKm1fbWVkaXVtLCB0
aGlzKTsKLSAgICB9Ci0gICAgbV9hdXRob3JTdHlsZS0+c2hyaW5rVG9GaXQoKTsKLQotICAgIGNv
bGxlY3RGZWF0dXJlcygpOwotICAgIAotICAgIGlmIChkb2N1bWVudC0+cmVuZGVyZXIoKSAmJiBk
b2N1bWVudC0+cmVuZGVyZXIoKS0+c3R5bGUoKSkKLSAgICAgICAgZG9jdW1lbnQtPnJlbmRlcmVy
KCktPnN0eWxlKCktPmZvbnQoKS51cGRhdGUoZm9udFNlbGVjdG9yKCkpOworICAgIGFwcGVuZEF1
dGhvclN0eWxlc2hlZXRzKHN0eWxlU2hlZXRzLT5iZWdpbigpLCBzdHlsZVNoZWV0cy0+ZW5kKCkp
OwogfQogCiB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmNvbGxlY3RGZWF0dXJlcygpCkBAIC00NDUs
MTUgKzQzMywxNSBAQCB2b2lkIENTU1N0eWxlU2VsZWN0b3I6OmNvbGxlY3RGZWF0dXJlcygpCiAg
ICAgICAgIG1fZmVhdHVyZXMudW5jb21tb25BdHRyaWJ1dGVSdWxlcy0+c2hyaW5rVG9GaXQoKTsK
IH0KIAotdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjphcHBlbmRBdXRob3JTdHlsZXNoZWV0cyh1bnNp
Z25lZCBmaXJzdE5ldywgY29uc3QgVmVjdG9yPFJlZlB0cjxTdHlsZVNoZWV0PiA+JiBzdHlsZXNo
ZWV0cykKK3ZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwZW5kQXV0aG9yU3R5bGVzaGVldHMoU3R5
bGVTaGVldFZlY3Rvcjo6Y29uc3RfaXRlcmF0b3IgYmVnaW4sIFN0eWxlU2hlZXRWZWN0b3I6OmNv
bnN0X2l0ZXJhdG9yIGVuZCkKIHsKICAgICAvLyBUaGlzIGhhbmRsZXMgc2hlZXRzIGFkZGVkIHRv
IHRoZSBlbmQgb2YgdGhlIHN0eWxlc2hlZXQgbGlzdCBvbmx5LiBJbiBvdGhlciBjYXNlcyB0aGUg
c3R5bGUgcmVzb2x2ZXIKICAgICAvLyBuZWVkcyB0byBiZSByZWNvbnN0cnVjdGVkLiBUbyBoYW5k
bGUgaW5zZXJ0aW9ucyB0b28gdGhlIHJ1bGUgb3JkZXIgbnVtYmVycyB3b3VsZCBuZWVkIHRvIGJl
IHVwZGF0ZWQuCi0gICAgdW5zaWduZWQgc2l6ZSA9IHN0eWxlc2hlZXRzLnNpemUoKTsKLSAgICBm
b3IgKHVuc2lnbmVkIGkgPSBmaXJzdE5ldzsgaSA8IHNpemU7ICsraSkgewotICAgICAgICBpZiAo
IXN0eWxlc2hlZXRzW2ldLT5pc0NTU1N0eWxlU2hlZXQoKSB8fCBzdHlsZXNoZWV0c1tpXS0+ZGlz
YWJsZWQoKSkKKyAgICBmb3IgKDsgYmVnaW4gIT0gZW5kOyArK2JlZ2luKSB7CisgICAgICAgIFN0
eWxlU2hlZXQqIHNoZWV0ID0gYmVnaW4tPmdldCgpOworICAgICAgICBpZiAoIXNoZWV0LT5pc0NT
U1N0eWxlU2hlZXQoKSB8fCBzaGVldC0+ZGlzYWJsZWQoKSkKICAgICAgICAgICAgIGNvbnRpbnVl
OwotICAgICAgICBtX2F1dGhvclN0eWxlLT5hZGRSdWxlc0Zyb21TaGVldChzdGF0aWNfY2FzdDxD
U1NTdHlsZVNoZWV0Kj4oc3R5bGVzaGVldHNbaV0uZ2V0KCkpLCAqbV9tZWRpdW0sIHRoaXMpOwor
ICAgICAgICBtX2F1dGhvclN0eWxlLT5hZGRSdWxlc0Zyb21TaGVldChzdGF0aWNfY2FzdDxDU1NT
dHlsZVNoZWV0Kj4oc2hlZXQpLCAqbV9tZWRpdW0sIHRoaXMpOwogICAgIH0KICAgICBtX2F1dGhv
clN0eWxlLT5zaHJpbmtUb0ZpdCgpOwogICAgIC8vIEZJWE1FOiBUaGlzIHJlYWxseSBvbmx5IG5l
ZWRzIHRvIGNvbGxlY3QgdGhlIGZlYXR1cmVzIGZyb20gdGhlIG5ld2x5IGFkZGVkIHNoZWV0cy4K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmggYi9Tb3Vy
Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5oCmluZGV4IGEyNjIyYWU4MDI4NDYzYjI4
YzM3N2I3YTE1ZjU4ZjRjZjY3ZDkyNzEuLjMxZWNhNDJhN2QxNzIyZmY3YjNlZjA1YzE3MDNmZGEw
ODBhM2U0MmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9y
LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuaApAQCAtMjcsNiAr
MjcsNyBAQAogI2luY2x1ZGUgIk1lZGlhUXVlcnlFeHAuaCIKICNpbmNsdWRlICJSZW5kZXJTdHls
ZS5oIgogI2luY2x1ZGUgIlNlbGVjdG9yQ2hlY2tlci5oIgorI2luY2x1ZGUgIlN0eWxlU2hlZXRM
aXN0LmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvSGFzaFNldC5o
PgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KQEAgLTcwLDcgKzcxLDYgQEAgY2xhc3MgU3R5bGVJ
bWFnZTsKIGNsYXNzIFN0eWxlUGVuZGluZ0ltYWdlOwogY2xhc3MgU3R5bGVTaGFkZXI7CiBjbGFz
cyBTdHlsZVNoZWV0OwotY2xhc3MgU3R5bGVTaGVldExpc3Q7CiBjbGFzcyBTdHlsZWRFbGVtZW50
OwogY2xhc3MgV2ViS2l0Q1NTS2V5ZnJhbWVSdWxlOwogY2xhc3MgV2ViS2l0Q1NTS2V5ZnJhbWVz
UnVsZTsKQEAgLTEyNyw3ICsxMjcsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRUZXh0U2l6ZUFk
anVzdChib29sIGIpIHsgbV9mb250RGlydHkgfD0gc3R5bGUoKS0+c2V0VGV4dFNpemVBZGp1c3Qo
Yik7IH0KICAgICBib29sIGhhc1BhcmVudE5vZGUoKSBjb25zdCB7IHJldHVybiBtX3BhcmVudE5v
ZGU7IH0KICAgICAKLSAgICB2b2lkIGFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKHVuc2lnbmVkIGZp
cnN0TmV3LCBjb25zdCBWZWN0b3I8UmVmUHRyPFN0eWxlU2hlZXQ+ID4mKTsKKyAgICB2b2lkIGFw
cGVuZEF1dGhvclN0eWxlc2hlZXRzKFN0eWxlU2hlZXRWZWN0b3I6OmNvbnN0X2l0ZXJhdG9yIGJl
Z2luLCBTdHlsZVNoZWV0VmVjdG9yOjpjb25zdF9pdGVyYXRvciBlbmQpOwogICAgIAogICAgIC8v
IEZpbmQgdGhlIGlkcyBvciBjbGFzc2VzIHRoZSBzZWxlY3RvcnMgb24gYSBzdHlsZXNoZWV0IGFy
ZSBzY29wZWQgdG8uIFRoZSBzZWxlY3RvcnMgb25seSBhcHBseSB0byBlbGVtZW50cyBpbiBzdWJ0
cmVlcyB3aGVyZSB0aGUgcm9vdCBlbGVtZW50IG1hdGNoZXMgdGhlIHNjb3BlLgogICAgIHN0YXRp
YyBib29sIGRldGVybWluZVN0eWxlc2hlZXRTZWxlY3RvclNjb3BlcyhDU1NTdHlsZVNoZWV0Kiwg
SGFzaFNldDxBdG9taWNTdHJpbmdJbXBsKj4mIGlkU2NvcGVzLCBIYXNoU2V0PEF0b21pY1N0cmlu
Z0ltcGwqPiYgY2xhc3NTY29wZXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0
eWxlU2hlZXRMaXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVTaGVldExpc3QuaAppbmRl
eCA0ZWI3ZDZhMjc4MWZhZjQ1MTE1MzhjMTQyMzg4YjhkYTRlMWVmNjc2Li4zMjc0MGUyNmJmZGFk
YTU4OTlhOWYxNjZkZTdhMmIxN2E4NjEyNzZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9j
c3MvU3R5bGVTaGVldExpc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVTaGVldExp
c3QuaApAQCAtNDMsNiArNDMsMTUgQEAgcHVibGljOgogCiAgICAgdW5zaWduZWQgbGVuZ3RoKCkg
Y29uc3Q7CiAgICAgU3R5bGVTaGVldCogaXRlbSh1bnNpZ25lZCBpbmRleCk7CisgICAgCisgICAg
U3R5bGVTaGVldFZlY3Rvcjo6Y29uc3RfaXRlcmF0b3IgYmVnaW4oKSBjb25zdAorICAgIHsKKyAg
ICAgICAgcmV0dXJuIG1fc2hlZXRzLmJlZ2luKCk7CisgICAgfQorICAgIFN0eWxlU2hlZXRWZWN0
b3I6OmNvbnN0X2l0ZXJhdG9yIGVuZCgpIGNvbnN0CisgICAgeworICAgICAgICByZXR1cm4gbV9z
aGVldHMuZW5kKCk7CisgICAgfQogCiAgICAgSFRNTFN0eWxlRWxlbWVudCogZ2V0TmFtZWRJdGVt
KGNvbnN0IFN0cmluZyYpIGNvbnN0OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20v
RG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCBkMmEw
MmM5NGY3OTFkNTRlYWU3MjYzNmQ2OTdkNDk5ZTFkNzU2YTg5Li4wYmQzZDVkMTRkN2M4ZDdlZGVj
NjQ3MDllMjU4YmNmNjNhNjZhODYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j
dW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTMyNjUs
NyArMzI2NSw5IEBAIGJvb2wgRG9jdW1lbnQ6OnVwZGF0ZUFjdGl2ZVN0eWxlc2hlZXRzKFN0eWxl
U2VsZWN0b3JVcGRhdGVGbGFnIHVwZGF0ZUZsYWcpCiAjZW5kaWYKICAgICAgICAgLy8gRGV0YWNo
IHRoZSBzdHlsZSBzZWxlY3RvciB0ZW1wb3JhcmlseSBzbyBpdCBjYW4ndCBnZXQgZGVsZXRlZCBk
dXJpbmcgYXBwZW5kQXV0aG9yU3R5bGVzaGVldHMKICAgICAgICAgT3duUHRyPENTU1N0eWxlU2Vs
ZWN0b3I+IGRldGFjaGVkU3R5bGVTZWxlY3RvciA9IG1fc3R5bGVTZWxlY3Rvci5yZWxlYXNlKCk7
Ci0gICAgICAgIGRldGFjaGVkU3R5bGVTZWxlY3Rvci0+YXBwZW5kQXV0aG9yU3R5bGVzaGVldHMo
bV9zdHlsZVNoZWV0cy0+bGVuZ3RoKCksIG5ld1N0eWxlc2hlZXRzKTsKKyAgICAgICAgU3R5bGVT
aGVldFZlY3Rvcjo6Y29uc3RfaXRlcmF0b3IgYmVnaW4gPSBuZXdTdHlsZXNoZWV0cy5iZWdpbigp
OworICAgICAgICBhZHZhbmNlKGJlZ2luLCBtX3N0eWxlU2hlZXRzLT5sZW5ndGgoKSk7CisgICAg
ICAgIGRldGFjaGVkU3R5bGVTZWxlY3Rvci0+YXBwZW5kQXV0aG9yU3R5bGVzaGVldHMoYmVnaW4s
IG5ld1N0eWxlc2hlZXRzLmVuZCgpKTsKICAgICAgICAgbV9zdHlsZVNlbGVjdG9yID0gZGV0YWNo
ZWRTdHlsZVNlbGVjdG9yLnJlbGVhc2UoKTsKICNpZm5kZWYgTkRFQlVHCiAgICAgICAgIG1fdXBk
YXRpbmdTdHlsZVNlbGVjdG9yID0gZmFsc2U7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>122579</attachid>
            <date>2012-01-15 18:19:54 -0800</date>
            <delta_ts>2012-01-15 19:38:21 -0800</delta_ts>
            <desc>new patch, smaller</desc>
            <filename>bug-76043-20120116111952.patch</filename>
            <type>text/plain</type>
            <size>2561</size>
            <attacher name="Roland Steiner">rolandsteiner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0ODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQxNGNlOTI3MjU3ZjM5
YWI2YmU3NGVlZTc4MzY5NmVlMDAwZjMxMi4uZWZiZWJmNWZiNmUzZTY3ODU3ZTEyYjQ5MDg3MjU4
MDI1OTJjNTYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE1ICBSb2xh
bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENTU1N0
eWxlU2VsZWN0b3IgY29uc3RydWN0b3IgYW5kIGFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKCkgY29u
dGFpbiBkdXBsaWNhdGVkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTc2MDQzCisKKyAgICAgICAgUmUtdXNlIGFwcGVuZEF1dGhvclN0eWxlc2hl
ZXRzKCkgZnJvbSB3aXRoaW4gQ1NTU3R5bGVTZWxlY3RvciBjb25zdHJ1Y3Rvci4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChy
ZWZhY3RvcmluZykKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OkNTU1N0eWxlU2VsZWN0b3IpOgorICAgICAg
ICAqIGNzcy9TdHlsZVNoZWV0TGlzdC5oOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVTaGVldExp
c3Q6OnZlY3Rvcik6CisKIDIwMTItMDEtMTIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2ds
ZS5jb20+CiAKICAgICAgICAgW0Nocm9taXVtXSBKU0V4cG9ydE1hY3Jvcy5oIHNob3VsZCBiZSB2
aXNpYmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3Iu
Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IDZiM2E2
OTE2ZjM0MmNhODIyY2Y5ZGZhODMyYjA2N2IzOWViZjAzOTUuLmNjZDI5NGM0Y2YzNDkxMTIzNTM0
MDUzODc3Y2M4OGY0MzRlZmVlZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT
dHlsZVNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rv
ci5jcHAKQEAgLTQxNCwxOCArNDE0LDcgQEAgQ1NTU3R5bGVTZWxlY3Rvcjo6Q1NTU3R5bGVTZWxl
Y3RvcihEb2N1bWVudCogZG9jdW1lbnQsIFN0eWxlU2hlZXRMaXN0KiBzdHlsZVNoZWUKICAgICAg
ICAgbV9hdXRob3JTdHlsZS0+YWRkUnVsZXNGcm9tU2hlZXQobWFwcGVkRWxlbWVudFNoZWV0LCAq
bV9tZWRpdW0sIHRoaXMpOwogCiAgICAgLy8gYWRkIHN0eWxlc2hlZXRzIGZyb20gZG9jdW1lbnQK
LSAgICB1bnNpZ25lZCBsZW5ndGggPSBzdHlsZVNoZWV0cy0+bGVuZ3RoKCk7Ci0gICAgZm9yICh1
bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgIFN0eWxlU2hlZXQqIHNo
ZWV0ID0gc3R5bGVTaGVldHMtPml0ZW0oaSk7Ci0gICAgICAgIGlmIChzaGVldC0+aXNDU1NTdHls
ZVNoZWV0KCkgJiYgIXNoZWV0LT5kaXNhYmxlZCgpKQotICAgICAgICAgICAgbV9hdXRob3JTdHls
ZS0+YWRkUnVsZXNGcm9tU2hlZXQoc3RhdGljX2Nhc3Q8Q1NTU3R5bGVTaGVldCo+KHNoZWV0KSwg
Km1fbWVkaXVtLCB0aGlzKTsKLSAgICB9Ci0gICAgbV9hdXRob3JTdHlsZS0+c2hyaW5rVG9GaXQo
KTsKLQotICAgIGNvbGxlY3RGZWF0dXJlcygpOwotICAgIAotICAgIGlmIChkb2N1bWVudC0+cmVu
ZGVyZXIoKSAmJiBkb2N1bWVudC0+cmVuZGVyZXIoKS0+c3R5bGUoKSkKLSAgICAgICAgZG9jdW1l
bnQtPnJlbmRlcmVyKCktPnN0eWxlKCktPmZvbnQoKS51cGRhdGUoZm9udFNlbGVjdG9yKCkpOwor
ICAgIGFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKDAsIHN0eWxlU2hlZXRzLnZlY3RvcigpKTsKIH0K
IAogdm9pZCBDU1NTdHlsZVNlbGVjdG9yOjpjb2xsZWN0RmVhdHVyZXMoKQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvY3NzL1N0eWxlU2hlZXRMaXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3Mv
U3R5bGVTaGVldExpc3QuaAppbmRleCA0ZWI3ZDZhMjc4MWZhZjQ1MTE1MzhjMTQyMzg4YjhkYTRl
MWVmNjc2Li4zZjgxMTYzZTYxNGUzMTI4YTljNjZiNDE1ODFlODZkNWZlZTgyMWQyIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVTaGVldExpc3QuaAorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9jc3MvU3R5bGVTaGVldExpc3QuaApAQCAtNDYsNiArNDYsMTEgQEAgcHVibGljOgogCiAg
ICAgSFRNTFN0eWxlRWxlbWVudCogZ2V0TmFtZWRJdGVtKGNvbnN0IFN0cmluZyYpIGNvbnN0Owog
CisgICAgY29uc3QgU3R5bGVTaGVldFZlY3RvciYgdmVjdG9yKCkgY29uc3QKKyAgICB7CisgICAg
ICAgIHJldHVybiBtX3NoZWV0czsKKyAgICB9CisKICAgICB2b2lkIHN3YXAoU3R5bGVTaGVldFZl
Y3RvciYgc2hlZXRzKQogICAgIHsKICAgICAgICAgbV9zaGVldHMuc3dhcChzaGVldHMpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>122583</attachid>
            <date>2012-01-15 19:38:27 -0800</date>
            <delta_ts>2012-01-16 04:05:21 -0800</delta_ts>
            <desc>new patch, fixed</desc>
            <filename>bug-76043-20120116123825.patch</filename>
            <type>text/plain</type>
            <size>2562</size>
            <attacher name="Roland Steiner">rolandsteiner</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0ODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQxNGNlOTI3MjU3ZjM5
YWI2YmU3NGVlZTc4MzY5NmVlMDAwZjMxMi4uZWZiZWJmNWZiNmUzZTY3ODU3ZTEyYjQ5MDg3MjU4
MDI1OTJjNTYzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE1ICBSb2xh
bmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENTU1N0
eWxlU2VsZWN0b3IgY29uc3RydWN0b3IgYW5kIGFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKCkgY29u
dGFpbiBkdXBsaWNhdGVkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTc2MDQzCisKKyAgICAgICAgUmUtdXNlIGFwcGVuZEF1dGhvclN0eWxlc2hl
ZXRzKCkgZnJvbSB3aXRoaW4gQ1NTU3R5bGVTZWxlY3RvciBjb25zdHJ1Y3Rvci4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChy
ZWZhY3RvcmluZykKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OkNTU1N0eWxlU2VsZWN0b3IpOgorICAgICAg
ICAqIGNzcy9TdHlsZVNoZWV0TGlzdC5oOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVTaGVldExp
c3Q6OnZlY3Rvcik6CisKIDIwMTItMDEtMTIgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2ds
ZS5jb20+CiAKICAgICAgICAgW0Nocm9taXVtXSBKU0V4cG9ydE1hY3Jvcy5oIHNob3VsZCBiZSB2
aXNpYmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3Iu
Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCmluZGV4IDZiM2E2
OTE2ZjM0MmNhODIyY2Y5ZGZhODMyYjA2N2IzOWViZjAzOTUuLjE5NDFlNTNkODgyZTZiM2Q5MGVk
ZjdkOGI4NGQ4ZWU1NDY2MjY5NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT
dHlsZVNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rv
ci5jcHAKQEAgLTQxNCwxOCArNDE0LDcgQEAgQ1NTU3R5bGVTZWxlY3Rvcjo6Q1NTU3R5bGVTZWxl
Y3RvcihEb2N1bWVudCogZG9jdW1lbnQsIFN0eWxlU2hlZXRMaXN0KiBzdHlsZVNoZWUKICAgICAg
ICAgbV9hdXRob3JTdHlsZS0+YWRkUnVsZXNGcm9tU2hlZXQobWFwcGVkRWxlbWVudFNoZWV0LCAq
bV9tZWRpdW0sIHRoaXMpOwogCiAgICAgLy8gYWRkIHN0eWxlc2hlZXRzIGZyb20gZG9jdW1lbnQK
LSAgICB1bnNpZ25lZCBsZW5ndGggPSBzdHlsZVNoZWV0cy0+bGVuZ3RoKCk7Ci0gICAgZm9yICh1
bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0gICAgICAgIFN0eWxlU2hlZXQqIHNo
ZWV0ID0gc3R5bGVTaGVldHMtPml0ZW0oaSk7Ci0gICAgICAgIGlmIChzaGVldC0+aXNDU1NTdHls
ZVNoZWV0KCkgJiYgIXNoZWV0LT5kaXNhYmxlZCgpKQotICAgICAgICAgICAgbV9hdXRob3JTdHls
ZS0+YWRkUnVsZXNGcm9tU2hlZXQoc3RhdGljX2Nhc3Q8Q1NTU3R5bGVTaGVldCo+KHNoZWV0KSwg
Km1fbWVkaXVtLCB0aGlzKTsKLSAgICB9Ci0gICAgbV9hdXRob3JTdHlsZS0+c2hyaW5rVG9GaXQo
KTsKLQotICAgIGNvbGxlY3RGZWF0dXJlcygpOwotICAgIAotICAgIGlmIChkb2N1bWVudC0+cmVu
ZGVyZXIoKSAmJiBkb2N1bWVudC0+cmVuZGVyZXIoKS0+c3R5bGUoKSkKLSAgICAgICAgZG9jdW1l
bnQtPnJlbmRlcmVyKCktPnN0eWxlKCktPmZvbnQoKS51cGRhdGUoZm9udFNlbGVjdG9yKCkpOwor
ICAgIGFwcGVuZEF1dGhvclN0eWxlc2hlZXRzKDAsIHN0eWxlU2hlZXRzLT52ZWN0b3IoKSk7CiB9
CiAKIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6Y29sbGVjdEZlYXR1cmVzKCkKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVNoZWV0TGlzdC5oIGIvU291cmNlL1dlYkNvcmUvY3Nz
L1N0eWxlU2hlZXRMaXN0LmgKaW5kZXggNGViN2Q2YTI3ODFmYWY0NTExNTM4YzE0MjM4OGI4ZGE0
ZTFlZjY3Ni4uM2Y4MTE2M2U2MTRlMzEyOGE5YzY2YjQxNTgxZTg2ZDVmZWU4MjFkMiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlU2hlZXRMaXN0LmgKKysrIGIvU291cmNlL1dl
YkNvcmUvY3NzL1N0eWxlU2hlZXRMaXN0LmgKQEAgLTQ2LDYgKzQ2LDExIEBAIHB1YmxpYzoKIAog
ICAgIEhUTUxTdHlsZUVsZW1lbnQqIGdldE5hbWVkSXRlbShjb25zdCBTdHJpbmcmKSBjb25zdDsK
IAorICAgIGNvbnN0IFN0eWxlU2hlZXRWZWN0b3ImIHZlY3RvcigpIGNvbnN0CisgICAgeworICAg
ICAgICByZXR1cm4gbV9zaGVldHM7CisgICAgfQorCiAgICAgdm9pZCBzd2FwKFN0eWxlU2hlZXRW
ZWN0b3ImIHNoZWV0cykKICAgICB7CiAgICAgICAgIG1fc2hlZXRzLnN3YXAoc2hlZXRzKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>