76040 2012-01-11 02:19:31 -0800 [v8] Int16Array.set(array, offset) fails on first execution 2012-01-11 13:07:00 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68890 1 ulan ulan abarth japhet kbr webkit.review.bot oldest_to_newest 533756 0 ulan 2012-01-11 02:19:31 -0800 The set() method of typed arrays ignores the offset argument on the first execution. For details see http://code.google.com/p/chromium/issues/detail?id=109785 533765 1 121997 ulan 2012-01-11 02:36:44 -0800 Created attachment 121997 Pass the offset argument to copyElements Ken, could you please take a look? The problem was that I missed the offset argument when calling copyElements. It passed the unit-tests because the fast set() method happened to be installed when calling set() with offset. I added a separate test which calls the set with a valid offset at the beginning. There is not need for testing invalid offset because in such case copyElements is not called at all. 534089 2 121997 kbr 2012-01-11 11:51:56 -0800 Comment on attachment 121997 Pass the offset argument to copyElements View in context: https://bugs.webkit.org/attachment.cgi?id=121997&action=review Fix looks good. Is it possible to also incorporate tests for this into the array-unit-tests.html test? If not (because it only happens the first time set() is called for each view type) then the separate test case is fine. Marking cq- until this question is answered. > ChangeLog:6 > + Reviewed by Kenneth Russell. Leave the "Reviewed by NOBODY" line alone when uploading patches. The commit process patches it up automatically. 534155 3 ulan 2012-01-11 12:46:06 -0800 > Is it possible to also incorporate tests for this into the array-unit-tests.html test? If not (because it only happens the first time set() is called for each view type) then the separate test case is fine. Yes, it happens only once on the first call, so I would prefer a separate test, otherwise this test could be accidentally disabled when changing array-unit-tests in future. > Leave the "Reviewed by NOBODY" line alone when uploading patches. The commit process patches it up automatically. I see, thanks. 534156 4 121997 kbr 2012-01-11 12:47:01 -0800 Comment on attachment 121997 Pass the offset argument to copyElements OK. Code and tests look good. Setting cq+. 534181 5 121997 webkit.review.bot 2012-01-11 13:06:48 -0800 Comment on attachment 121997 Pass the offset argument to copyElements Clearing flags on attachment: 121997 Committed r104736: <http://trac.webkit.org/changeset/104736> 534183 6 webkit.review.bot 2012-01-11 13:07:00 -0800 All reviewed patches have been landed. Closing bug. 121997 2012-01-11 02:36:44 -0800 2012-01-11 13:06:48 -0800 Pass the offset argument to copyElements b76040 text/plain 6936 ulan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwNDY4 OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAx LTExICBVbGFuIERlZ2VuYmFldiAgPHVsYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFt2OF0g SW50MTZBcnJheS5zZXQoYXJyYXksIG9mZnNldCkgZmFpbHMgb24gZmlyc3QgZXhlY3V0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NjA0MAorCisg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KKworICAgICAgICAqIExheW91dFRl c3RzL2Zhc3QvY2FudmFzL3dlYmdsL2FycmF5LXNldC13aXRoLW9mZnNldC1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2FycmF5LXNl dC13aXRoLW9mZnNldC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhBcnJheUJ1ZmZlclZpZXdDdXN0b20uY3BwOgorICAgICAgICAqIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFycmF5QnVmZmVyVmlld0N1c3RvbS5o OgorCiAyMDEyLTAxLTA5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBbQUNdIFNpbXBsaWZ5IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGJ1 aWxkIG9wdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFy cmF5QnVmZmVyVmlld0N1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmNwcAkocmV2aXNpb24gMTA0 NjgxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJW aWV3Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAsMTIgKzYwLDE4IEBAIHZvaWQgaW5z dGFsbEZhc3RTZXQodjg6OkhhbmRsZTx2ODo6T2JqZWMKIH0KIAogCi12b2lkIGNvcHlFbGVtZW50 cyh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGRlc3RBcnJheSwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0 PiBzcmNBcnJheSkKK3ZvaWQgY29weUVsZW1lbnRzKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZGVz dEFycmF5LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHNyY0FycmF5LCB1aW50MzJfdCBvZmZzZXQp CiB7CiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBrZXkgPSB2ODo6U3RyaW5nOjpOZXcoInNl dCIpOwogICAgIHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPiBzZXQgPSBkZXN0QXJyYXktPkdldChr ZXkpLkFzPHY4OjpGdW5jdGlvbj4oKTsKLSAgICB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gYXJndW1l bnQgPSBzcmNBcnJheTsKLSAgICBzZXQtPkNhbGwoZGVzdEFycmF5LCAxLCAmYXJndW1lbnQpOwor ICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBhcmd1bWVudHNbMl07CisgICAgaW50IG51bWJlck9m QXJndW1lbnRzID0gMTsKKyAgICBhcmd1bWVudHNbMF0gPSBzcmNBcnJheTsKKyAgICBpZiAob2Zm c2V0KSB7CisgICAgICAgIGFyZ3VtZW50c1sxXSA9IHY4OjpVaW50MzI6Ok5ldyhvZmZzZXQpOwor ICAgICAgICBudW1iZXJPZkFyZ3VtZW50cyA9IDI7CisgICAgfQorICAgIHNldC0+Q2FsbChkZXN0 QXJyYXksIG51bWJlck9mQXJndW1lbnRzLCBhcmd1bWVudHMpOwogfQogCiB9CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhBcnJheUJ1ZmZlclZpZXdDdXN0b20uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhBcnJheUJ1 ZmZlclZpZXdDdXN0b20uaAkocmV2aXNpb24gMTA0NjgxKQorKysgU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmgJKHdvcmtpbmcgY29weSkK QEAgLTUxLDcgKzUxLDcgQEAgdm9pZCBpbnN0YWxsRmFzdFNldCh2ODo6SGFuZGxlPHY4OjpPYmpl YwogCiAvLyBDb3B5IHRoZSBlbGVtZW50cyBmcm9tIHRoZSBzb3VyY2UgYXJyYXkgdG8gdGhlIHR5 cGVkIGRlc3RpbmF0aW9uIGFycmF5IGJ5CiAvLyBpbnZva2luZyB0aGUgJ3NldCcgbWV0aG9kIG9m IHRoZSBkZXN0aW5hdGlvbiBhcnJheSBpbiBKUy4KLXZvaWQgY29weUVsZW1lbnRzKHY4OjpIYW5k bGU8djg6Ok9iamVjdD4gZGVzdEFycmF5LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHNyY0FycmF5 KTsKK3ZvaWQgY29weUVsZW1lbnRzKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZGVzdEFycmF5LCB2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHNyY0FycmF5LCB1aW50MzJfdCBvZmZzZXQpOwogCiAKIC8v IFRlbXBsYXRlIGZ1bmN0aW9uIHVzZWQgYnkgdGhlIEFycmF5QnVmZmVyVmlldypDb25zdHJ1Y3Rv ciBjYWxsYmFja3MuCkBAIC0xNzEsNyArMTcxLDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNv bnN0cnVjdFdlYkdMQXJyYQogICAgIGFyZ3MuSG9sZGVyKCktPlNldEluZGV4ZWRQcm9wZXJ0aWVz VG9FeHRlcm5hbEFycmF5RGF0YShhcnJheS5nZXQoKS0+YmFzZUFkZHJlc3MoKSwgYXJyYXlUeXBl LCBhcnJheS5nZXQoKS0+bGVuZ3RoKCkpOwogCiAgICAgaWYgKCFzcmNBcnJheS5Jc0VtcHR5KCkp Ci0gICAgICAgIGNvcHlFbGVtZW50cyhhcmdzLkhvbGRlcigpLCBzcmNBcnJheSk7CisgICAgICAg IGNvcHlFbGVtZW50cyhhcmdzLkhvbGRlcigpLCBzcmNBcnJheSwgMCk7CiAKICAgICByZXR1cm4g dG9WOChhcnJheS5yZWxlYXNlKCksIGFyZ3MuSG9sZGVyKCksIE1hcmtJbmRlcGVuZGVudCk7CiB9 CkBAIC0yMTIsNyArMjEyLDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHNldFdlYkdMQXJyYXlI ZWxwZQogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIGlmICghZmFzdFNldEluc3RhbGxlZChh cmdzLkhvbGRlcigpKSkgewogICAgICAgICAgICAgICAgIGluc3RhbGxGYXN0U2V0KGFyZ3MuSG9s ZGVyKCkpOwotICAgICAgICAgICAgICAgIGNvcHlFbGVtZW50cyhhcmdzLkhvbGRlcigpLCBhcnJh eSk7CisgICAgICAgICAgICAgICAgY29weUVsZW1lbnRzKGFyZ3MuSG9sZGVyKCksIGFycmF5LCBv ZmZzZXQpOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICBmb3IgKHVpbnQz Ml90IGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspCiAgICAgICAgICAgICAgICAgICAgIGltcGwtPnNl dChvZmZzZXQgKyBpLCBhcnJheS0+R2V0KGkpLT5OdW1iZXJWYWx1ZSgpKTsKSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2FycmF5LXNldC13aXRoLW9mZnNldC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvYXJyYXktc2V0 LXdpdGgtb2Zmc2V0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvY2FudmFzL3dlYmdsL2FycmF5LXNldC13aXRoLW9mZnNldC1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsNTEgQEAKK1Rlc3Qgc2V0dGluZyBXZWJHTCBhcnJheSB3aXRoIG9m ZnNldAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3Nh Z2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKK1JlZ3Jlc3Npb24gdGVzdCBmb3Ig aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MDQwIDogSW50MTZBcnJh eS5zZXQoYXJyYXksIG9mZnNldCkgZmFpbHMgb24gZmlyc3QgZXhlY3V0aW9uCitUZXN0aW5nIElu dDhBcnJheQorUEFTUyB3ZWJHTEFycmF5WzBdIGlzIDAKK1BBU1Mgd2ViR0xBcnJheVsxXSBpcyAx CitQQVNTIHdlYkdMQXJyYXlbMl0gaXMgMgorUEFTUyB3ZWJHTEFycmF5WzNdIGlzIGJvdW5kc1sw XQorUEFTUyB3ZWJHTEFycmF5WzRdIGlzIGJvdW5kc1sxXQorVGVzdGluZyBVaW50OEFycmF5CitQ QVNTIHdlYkdMQXJyYXlbMF0gaXMgMAorUEFTUyB3ZWJHTEFycmF5WzFdIGlzIDEKK1BBU1Mgd2Vi R0xBcnJheVsyXSBpcyAyCitQQVNTIHdlYkdMQXJyYXlbM10gaXMgYm91bmRzWzBdCitQQVNTIHdl YkdMQXJyYXlbNF0gaXMgYm91bmRzWzFdCitUZXN0aW5nIEludDE2QXJyYXkKK1BBU1Mgd2ViR0xB cnJheVswXSBpcyAwCitQQVNTIHdlYkdMQXJyYXlbMV0gaXMgMQorUEFTUyB3ZWJHTEFycmF5WzJd IGlzIDIKK1BBU1Mgd2ViR0xBcnJheVszXSBpcyBib3VuZHNbMF0KK1BBU1Mgd2ViR0xBcnJheVs0 XSBpcyBib3VuZHNbMV0KK1Rlc3RpbmcgVWludDE2QXJyYXkKK1BBU1Mgd2ViR0xBcnJheVswXSBp cyAwCitQQVNTIHdlYkdMQXJyYXlbMV0gaXMgMQorUEFTUyB3ZWJHTEFycmF5WzJdIGlzIDIKK1BB U1Mgd2ViR0xBcnJheVszXSBpcyBib3VuZHNbMF0KK1BBU1Mgd2ViR0xBcnJheVs0XSBpcyBib3Vu ZHNbMV0KK1Rlc3RpbmcgSW50MzJBcnJheQorUEFTUyB3ZWJHTEFycmF5WzBdIGlzIDAKK1BBU1Mg d2ViR0xBcnJheVsxXSBpcyAxCitQQVNTIHdlYkdMQXJyYXlbMl0gaXMgMgorUEFTUyB3ZWJHTEFy cmF5WzNdIGlzIGJvdW5kc1swXQorUEFTUyB3ZWJHTEFycmF5WzRdIGlzIGJvdW5kc1sxXQorVGVz dGluZyBVaW50MzJBcnJheQorUEFTUyB3ZWJHTEFycmF5WzBdIGlzIDAKK1BBU1Mgd2ViR0xBcnJh eVsxXSBpcyAxCitQQVNTIHdlYkdMQXJyYXlbMl0gaXMgMgorUEFTUyB3ZWJHTEFycmF5WzNdIGlz IGJvdW5kc1swXQorUEFTUyB3ZWJHTEFycmF5WzRdIGlzIGJvdW5kc1sxXQorVGVzdGluZyBGbG9h dDMyQXJyYXkKK1BBU1Mgd2ViR0xBcnJheVswXSBpcyAwCitQQVNTIHdlYkdMQXJyYXlbMV0gaXMg MQorUEFTUyB3ZWJHTEFycmF5WzJdIGlzIDIKK1BBU1Mgd2ViR0xBcnJheVszXSBpcyBib3VuZHNb MF0KK1BBU1Mgd2ViR0xBcnJheVs0XSBpcyBib3VuZHNbMV0KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy93ZWJnbC9hcnJheS1zZXQtd2l0aC1vZmZzZXQuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9hcnJheS1zZXQtd2l0aC1vZmZzZXQuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2FycmF5LXNldC13aXRo LW9mZnNldC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ1IEBACis8aHRtbD4KKzxoZWFk PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3dlYmdsLXRlc3QuanMiPjwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHk+Cis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25z b2xlIj48L2Rpdj4KKworPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0IHNldHRpbmcgV2ViR0wg YXJyYXkgd2l0aCBvZmZzZXQiKTsKKworZGVidWcoJ1JlZ3Jlc3Npb24gdGVzdCBmb3IgPGEgaHJl Zj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc2MDQwIj5odHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYwNDA8L2E+IDogPGNvZGU+SW50MTZB cnJheS5zZXQoYXJyYXksIG9mZnNldCkgZmFpbHMgb24gZmlyc3QgZXhlY3V0aW9uPC9jb2RlPicp OworCit2YXIgd2ViR0xBcnJheSA9IG51bGw7Cit2YXIgYXJyYXkgPSBudWxsOwordmFyIGJvdW5k cyA9IG51bGw7CisKK2Z1bmN0aW9uIHRlc3RTZXR0ZXJzKHR5cGVOYW1lLCBsb3csIGhpZ2gpIHsK KyAgICBib3VuZHMgPSBbbG93LCBoaWdoXTsKKyAgICB2YXIgdHlwZSA9IHdpbmRvd1t0eXBlTmFt ZV07CisgICAgdmFyIGFycmF5X2J1ZmZlciA9IG5ldyBBcnJheUJ1ZmZlcigzMik7CisgICAgd2Vi R0xBcnJheSA9IG5ldyB0eXBlKGFycmF5X2J1ZmZlcik7CisgICAgZGVidWcoIlRlc3RpbmcgIiAr IHR5cGVOYW1lKTsKKyAgICBhcnJheSA9IFsxLCAyLCBsb3csIGhpZ2hdOworICAgIHdlYkdMQXJy YXkuc2V0KGFycmF5LCAxKTsKKyAgICBzaG91bGRCZSgid2ViR0xBcnJheVswXSIsICIwIik7Cisg ICAgc2hvdWxkQmUoIndlYkdMQXJyYXlbMV0iLCAiMSIpOworICAgIHNob3VsZEJlKCJ3ZWJHTEFy cmF5WzJdIiwgIjIiKTsKKyAgICBzaG91bGRCZSgid2ViR0xBcnJheVszXSIsICJib3VuZHNbMF0i KTsKKyAgICBzaG91bGRCZSgid2ViR0xBcnJheVs0XSIsICJib3VuZHNbMV0iKTsKK30KKwordGVz dFNldHRlcnMoIkludDhBcnJheSIsIC0xMjgsIDEyNyk7Cit0ZXN0U2V0dGVycygiVWludDhBcnJh eSIsIDAsIDI1NSk7Cit0ZXN0U2V0dGVycygiSW50MTZBcnJheSIsIC0zMjc2OCwgMzI3NjcpOwor dGVzdFNldHRlcnMoIlVpbnQxNkFycmF5IiwgMCwgNjU1MzUpOwordGVzdFNldHRlcnMoIkludDMy QXJyYXkiLCAtMjE0NzQ4MzY0OCwgMjE0NzQ4MzY0Nyk7Cit0ZXN0U2V0dGVycygiVWludDMyQXJy YXkiLCAwLCA0Mjk0OTY3Mjk1KTsKK3Rlc3RTZXR0ZXJzKCJGbG9hdDMyQXJyYXkiLCAtMi41LCAz LjUpOworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K